Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-04 Thread Cornelia Huck
On Fri, 1 Sep 2017 15:43:00 +0200 Cornelia Huck wrote: > On Thu, 31 Aug 2017 16:40:08 +0200 > Thomas Huth wrote: > > > We can use the drive_del test on s390x, too, to check that adding and > > deleting also works fine with the virtio-ccw bus. But we have to make > > sure that we use the devices

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-01 Thread Eric Blake
On 09/01/2017 05:39 AM, Thomas Huth wrote: /* Start with a drive used by a device that unplugs instantaneously */ -qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw" -" -device virtio-scsi-pci" -" -device scsi-hd,drive=driv

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-01 Thread Cornelia Huck
On Thu, 31 Aug 2017 16:40:08 +0200 Thomas Huth wrote: > We can use the drive_del test on s390x, too, to check that adding and > deleting also works fine with the virtio-ccw bus. But we have to make > sure that we use the devices with the "-ccw" suffix instead of the > "-pci" suffix for the virtio

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-01 Thread Cornelia Huck
On Fri, 1 Sep 2017 12:39:49 +0200 Thomas Huth wrote: > On 01.09.2017 11:10, Markus Armbruster wrote: > > David Hildenbrand writes: > > > >>> static void test_drive_del_device_del(void) > >>> { > >>> +char *args; > >>> + > >>> /* Start with a drive used by a device that unplugs inst

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-01 Thread Thomas Huth
On 01.09.2017 11:10, Markus Armbruster wrote: > David Hildenbrand writes: > >>> static void test_drive_del_device_del(void) >>> { >>> +char *args; >>> + >>> /* Start with a drive used by a device that unplugs instantaneously */ >>> -qtest_start("-drive if=none,id=drive0,file=null-c

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-09-01 Thread Markus Armbruster
David Hildenbrand writes: >> static void test_drive_del_device_del(void) >> { >> +char *args; >> + >> /* Start with a drive used by a device that unplugs instantaneously */ >> -qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw" >> -" -device virtio-sc

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-08-31 Thread David Hildenbrand
> static void test_drive_del_device_del(void) > { > +char *args; > + > /* Start with a drive used by a device that unplugs instantaneously */ > -qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw" > -" -device virtio-scsi-pci" > -" -devi

[Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-08-31 Thread Thomas Huth
We can use the drive_del test on s390x, too, to check that adding and deleting also works fine with the virtio-ccw bus. But we have to make sure that we use the devices with the "-ccw" suffix instead of the "-pci" suffix for the virtio-ccw transport on s390x. Introduce a helper function called qvir