Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Greg Kurz
On Fri, 14 Oct 2016 14:13:12 +0200 Laurent Vivier wrote: > On 14/10/2016 09:56, Greg Kurz wrote: > > On Thu, 13 Oct 2016 18:24:43 +0200 > > Laurent Vivier wrote: > > > >> Extract the realize part to cpu_exec_realize(), update all > >> calls to cpu_exec_init() to add cpu_exec_realize() to > >>

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Laurent Vivier
On 14/10/2016 16:13, Laurent Vivier wrote: > > > On 14/10/2016 16:11, Igor Mammedov wrote: >> On Thu, 13 Oct 2016 18:24:43 +0200 >> Laurent Vivier wrote: >> >>> Extract the realize part to cpu_exec_realize(), update all >>> calls to cpu_exec_init() to add cpu_exec_realize() to >>> have no func

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Laurent Vivier
On 14/10/2016 16:11, Igor Mammedov wrote: > On Thu, 13 Oct 2016 18:24:43 +0200 > Laurent Vivier wrote: > >> Extract the realize part to cpu_exec_realize(), update all >> calls to cpu_exec_init() to add cpu_exec_realize() to >> have no functionnal change. >> >> Put in cpu_exec_init() what initia

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Igor Mammedov
On Thu, 13 Oct 2016 18:24:43 +0200 Laurent Vivier wrote: > Extract the realize part to cpu_exec_realize(), update all > calls to cpu_exec_init() to add cpu_exec_realize() to > have no functionnal change. > > Put in cpu_exec_init() what initializes the CPU, > in cpu_exec_realize() what adds it to

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Laurent Vivier
On 14/10/2016 15:55, Igor Mammedov wrote: > On Thu, 13 Oct 2016 18:24:43 +0200 > Laurent Vivier wrote: > > [...] >> Rename cpu_exec_exit() with cpu_exec_unrealize(): >> cpu_exec_exit() is undoing what it has been done by cpu_exec_realize(), so >> call it cpu_exec_unrealize(). > a separate patch

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Igor Mammedov
On Thu, 13 Oct 2016 18:24:43 +0200 Laurent Vivier wrote: [...] > Rename cpu_exec_exit() with cpu_exec_unrealize(): > cpu_exec_exit() is undoing what it has been done by cpu_exec_realize(), so > call it cpu_exec_unrealize(). a separate patch??? [...] > diff --git a/exec.c b/exec.c > index 374c36

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Laurent Vivier
On 14/10/2016 09:56, Greg Kurz wrote: > On Thu, 13 Oct 2016 18:24:43 +0200 > Laurent Vivier wrote: > >> Extract the realize part to cpu_exec_realize(), update all >> calls to cpu_exec_init() to add cpu_exec_realize() to >> have no functionnal change. >> >> Put in cpu_exec_init() what initialize

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-14 Thread Greg Kurz
On Thu, 13 Oct 2016 18:24:43 +0200 Laurent Vivier wrote: > Extract the realize part to cpu_exec_realize(), update all > calls to cpu_exec_init() to add cpu_exec_realize() to > have no functionnal change. > > Put in cpu_exec_init() what initializes the CPU, > in cpu_exec_realize() what adds it to

Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-13 Thread David Gibson
On Thu, Oct 13, 2016 at 06:24:43PM +0200, Laurent Vivier wrote: > Extract the realize part to cpu_exec_realize(), update all > calls to cpu_exec_init() to add cpu_exec_realize() to > have no functionnal change. > > Put in cpu_exec_init() what initializes the CPU, > in cpu_exec_realize() what adds

[Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()

2016-10-13 Thread Laurent Vivier
Extract the realize part to cpu_exec_realize(), update all calls to cpu_exec_init() to add cpu_exec_realize() to have no functionnal change. Put in cpu_exec_init() what initializes the CPU, in cpu_exec_realize() what adds it to the environment. Remove error parameter from cpu_exec_init() as it ca