Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Mark Wu
On 03/06/2012 04:14 PM, Paolo Bonzini wrote: Il 06/03/2012 08:16, Mark Wu ha scritto: It seems we need a name for the union to reference its member. What version is your compiler? So I modified the scripts as the following patch. I also updated blockdev.c accordingly. After that I can compile

Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Mark Wu
On 03/06/2012 04:31 PM, Paolo Bonzini wrote: Il 06/03/2012 09:19, Mark Wu ha scritto: gcc -v Using built-in specs. Target: x86_64-redhat-linux Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-

Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Mark Wu
On 03/06/2012 01:33 AM, Paolo Bonzini wrote: Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini --- qapi-schema-test.json | 10 ++ scripts/qapi-types.py |5 + scripts/qapi-visit.py | 31 ++- test-qmp-input-visitor.c | 18 +

Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Paolo Bonzini
> I got the following error when I tried to compile it: > blockdev.c: In function ‘qmp_blockdev_snapshot_sync’: > blockdev.c:664: error: unknown field ‘blockdev_snapshot_sync’ > specified in initializer > cc1: warnings being treated as errors > blockdev.c:664: error: missing braces around initializ

Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Paolo Bonzini
Il 06/03/2012 09:19, Mark Wu ha scritto: > gcc -v > Using built-in specs. > Target: x86_64-redhat-linux > Configured with: ../configure --prefix=/usr --mandir=/usr/share/man > --infodir=/usr/share/info > --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap > --enable-shared --enable

Re: [Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-06 Thread Paolo Bonzini
Il 06/03/2012 08:16, Mark Wu ha scritto: > It seems we need a name for the union to reference its member. What version is your compiler? > So I > modified the scripts as the following patch. I also updated blockdev.c > accordingly. After that I can compile it without error. Actually, I > don't kn

[Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-05 Thread Paolo Bonzini
Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini --- qapi-schema-test.json | 10 ++ scripts/qapi-types.py |5 + scripts/qapi-visit.py | 31 ++- test-qmp-input-visitor.c | 18 ++ test-qmp-output-visitor.c |