Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michal Privoznik
On 28.02.2012 18:41, Luiz Capitulino wrote: Hmm, I know Michal already sent a new version with my suggestions, but you're right, splitting out the commands simplified both the responses, and makes it easier to discover whether or not that information is available, since you can look for the

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Luiz Capitulino
On Wed, 29 Feb 2012 14:17:52 +0100 Michal Privoznik mpriv...@redhat.com wrote: On 28.02.2012 18:41, Luiz Capitulino wrote: Hmm, I know Michal already sent a new version with my suggestions, but you're right, splitting out the commands simplified both the responses, and makes it easier to

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michael Roth
On Wed, Feb 29, 2012 at 12:01:16PM -0300, Luiz Capitulino wrote: On Wed, 29 Feb 2012 14:17:52 +0100 Michal Privoznik mpriv...@redhat.com wrote: On 28.02.2012 18:41, Luiz Capitulino wrote: Hmm, I know Michal already sent a new version with my suggestions, but you're right, splitting

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Luiz Capitulino
On Mon, 27 Feb 2012 20:07:28 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: What about something like this instead: { 'enum': 'GuestIpAddressType', 'data': [ 'ipv4', 'ipv6' ] } { 'type': 'GuestIpAddress', 'data': {'ip-address': 'str', 'ip-address-type':

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Michael Roth
On Tue, Feb 28, 2012 at 11:22:22AM -0300, Luiz Capitulino wrote: On Mon, 27 Feb 2012 20:07:28 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: What about something like this instead: { 'enum': 'GuestIpAddressType', 'data': [ 'ipv4', 'ipv6' ] } { 'type': 'GuestIpAddress',

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-28 Thread Luiz Capitulino
On Tue, 28 Feb 2012 11:09:38 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Tue, Feb 28, 2012 at 11:22:22AM -0300, Luiz Capitulino wrote: On Mon, 27 Feb 2012 20:07:28 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: What about something like this instead: { 'enum':

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-27 Thread Michal Privoznik
On 23.02.2012 15:20, Luiz Capitulino wrote: On Sun, 19 Feb 2012 12:15:43 +0100 Michal Privoznik mpriv...@redhat.com wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-27 Thread Michael Roth
On Mon, Feb 27, 2012 at 07:49:24PM +0100, Michal Privoznik wrote: On 23.02.2012 15:20, Luiz Capitulino wrote: On Sun, 19 Feb 2012 12:15:43 +0100 Michal Privoznik mpriv...@redhat.com wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-23 Thread Luiz Capitulino
On Sun, 19 Feb 2012 12:15:43 +0100 Michal Privoznik mpriv...@redhat.com wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-22 Thread Michal Privoznik
On 19.02.2012 12:15, Michal Privoznik wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com ---

[Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-19 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v3: -use ctpop32() instead of separate