Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2018 at 03:19:19AM -0300, Philippe Mathieu-Daudé wrote: > Le mer. 30 mai 2018 02:50, Philippe Mathieu-Daudé a écrit : > > On Wed, May 30, 2018 at 1:42 AM, Michael S. Tsirkin > wrote: > > On Wed, May 30, 2018 at 12:12:55AM -0300, Philippe Mathieu-Daudé wrote: > >> Hi

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:07 -0300 Philippe Mathieu-Daudé wrote: > Code change produced with: > $ git grep '#include "exec/exec-all.h"' | \ > cut -d: -f-1 | \ > xargs egrep -L > "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" > | \ > xargs

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 07:50, Philippe Mathieu-Daudé wrote: >>> No, not all :/ >>> I started with "(cpu_loop_|tlb_|tb_)" then kept brutebuilding until no >>> more errors appear. In 2 more steps I added "cpu_address_space_init|" >>> then "|GETPC|singlestep|TranslationBlock". Quick and dirty enough for my

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Philippe Mathieu-Daudé
Le mer. 30 mai 2018 02:50, Philippe Mathieu-Daudé a écrit : > On Wed, May 30, 2018 at 1:42 AM, Michael S. Tsirkin > wrote: > > On Wed, May 30, 2018 at 12:12:55AM -0300, Philippe Mathieu-Daudé wrote: > >> Hi Cornelia, > >> > >> On 05/29/2018 08:40 AM, Cornelia Huck wrote: > >> > On Mon, 28 May

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-29 Thread Philippe Mathieu-Daudé
On Wed, May 30, 2018 at 1:42 AM, Michael S. Tsirkin wrote: > On Wed, May 30, 2018 at 12:12:55AM -0300, Philippe Mathieu-Daudé wrote: >> Hi Cornelia, >> >> On 05/29/2018 08:40 AM, Cornelia Huck wrote: >> > On Mon, 28 May 2018 20:27:07 -0300 >> > Philippe Mathieu-Daudé wrote: >> > >> >> Code

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-29 Thread Michael S. Tsirkin
On Wed, May 30, 2018 at 12:12:55AM -0300, Philippe Mathieu-Daudé wrote: > Hi Cornelia, > > On 05/29/2018 08:40 AM, Cornelia Huck wrote: > > On Mon, 28 May 2018 20:27:07 -0300 > > Philippe Mathieu-Daudé wrote: > > > >> Code change produced with: > >> $ git grep '#include "exec/exec-all.h"' |

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-29 Thread Philippe Mathieu-Daudé
Hi Cornelia, On 05/29/2018 08:40 AM, Cornelia Huck wrote: > On Mon, 28 May 2018 20:27:07 -0300 > Philippe Mathieu-Daudé wrote: > >> Code change produced with: >> $ git grep '#include "exec/exec-all.h"' | \ >> cut -d: -f-1 | \ >> xargs egrep -L >>

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:07 -0300 Philippe Mathieu-Daudé wrote: > Code change produced with: > $ git grep '#include "exec/exec-all.h"' | \ > cut -d: -f-1 | \ > xargs egrep -L > "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" > | \ Hm, does this

[Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-28 Thread Philippe Mathieu-Daudé
Code change produced with: $ git grep '#include "exec/exec-all.h"' | \ cut -d: -f-1 | \ xargs egrep -L "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" | \ xargs sed -i.bak '/#include "exec\/exec-all.h"/d' Signed-off-by: Philippe