On Mon, Oct 10, 2016 at 05:11:19PM +0200, Radim Krčmář wrote:
[...]
> > But that's really a matter of taste. So:
>
> I'll currently go for an implicit else: (because 4 levels of indentation
> are getting helper-function worthy and it has less curly braces)
>
> if (!kvm_irqchip_in_kernel
2016-10-08 15:21+0800, Peter Xu:
> On Wed, Oct 05, 2016 at 03:06:55PM +0200, Radim Krčmář wrote:
>
> [...]
>
>> @@ -2472,10 +2473,22 @@ static bool vtd_decide_config(IntelIOMMUState *s,
>> Error **errp)
>> }
>>
>> if (s->intr_eim == ON_OFF_AUTO_AUTO) {
>> -s->intr_eim = x86_i
On Wed, Oct 05, 2016 at 03:06:55PM +0200, Radim Krčmář wrote:
[...]
> @@ -2472,10 +2473,22 @@ static bool vtd_decide_config(IntelIOMMUState *s,
> Error **errp)
> }
>
> if (s->intr_eim == ON_OFF_AUTO_AUTO) {
> -s->intr_eim = x86_iommu->intr_supported ?
> +s->intr_eim =
Cluster x2APIC cannot work without KVM's x2apic API when the maximal
APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we
forbid other APICs and also the old KVM case with less than 9, to
simplify the code.
There is no point in enabling EIM in forbidden APICs, so we keep it
ena
