Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-28 Thread Paolo Bonzini
Il 17/04/2014 15:44, Michael S. Tsirkin ha scritto: I'm fine with this. And I'm not against a runtime switch to get rid of per-target build of virtio. I am merely asking for separatable patchsets, e.g. structured like this: 1. implement bi-endian support with no data path overhead for fixed endi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-17 Thread Michael S. Tsirkin
On Thu, Apr 17, 2014 at 02:29:13PM +0200, Greg Kurz wrote: > On Thu, 17 Apr 2014 11:00:26 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Apr 17, 2014 at 08:54:12AM +0200, Greg Kurz wrote: > > > On Wed, 16 Apr 2014 20:32:07 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, Apr 16,

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-17 Thread Greg Kurz
On Thu, 17 Apr 2014 11:00:26 +0300 "Michael S. Tsirkin" wrote: > On Thu, Apr 17, 2014 at 08:54:12AM +0200, Greg Kurz wrote: > > On Wed, 16 Apr 2014 20:32:07 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote: > > > > On 16 April 2014 17

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-17 Thread Greg Kurz
On Wed, 16 Apr 2014 17:42:22 +0100 Peter Maydell wrote: > On 16 April 2014 17:34, Michael S. Tsirkin wrote: > > so it looks like virtio is currently compiled per-target. > > So why isn't it reasonable to keep it per-target for > > purpose of this enhancement? > > What am I missing? > > "virtio"

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-17 Thread Michael S. Tsirkin
On Thu, Apr 17, 2014 at 08:54:12AM +0200, Greg Kurz wrote: > On Wed, 16 Apr 2014 20:32:07 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote: > > > On 16 April 2014 17:34, Michael S. Tsirkin wrote: > > > > so it looks like virtio is currently

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-16 Thread Greg Kurz
On Wed, 16 Apr 2014 20:32:07 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote: > > On 16 April 2014 17:34, Michael S. Tsirkin wrote: > > > so it looks like virtio is currently compiled per-target. > > > So why isn't it reasonable to keep it per-ta

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-16 Thread Michael S. Tsirkin
On Wed, Apr 16, 2014 at 05:42:22PM +0100, Peter Maydell wrote: > On 16 April 2014 17:34, Michael S. Tsirkin wrote: > > so it looks like virtio is currently compiled per-target. > > So why isn't it reasonable to keep it per-target for > > purpose of this enhancement? > > What am I missing? > > "vi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-16 Thread Peter Maydell
On 16 April 2014 17:34, Michael S. Tsirkin wrote: > so it looks like virtio is currently compiled per-target. > So why isn't it reasonable to keep it per-target for > purpose of this enhancement? > What am I missing? "virtio" is more than one C file. Currently per-target: hw/virtio/virtio.c hw/vi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-16 Thread Michael S. Tsirkin
On Tue, Apr 15, 2014 at 03:22:56PM +0200, Greg Kurz wrote: > On Tue, 15 Apr 2014 13:35:03 +0200 > Alexander Graf wrote: > > > On 04/15/2014 10:40 AM, Greg Kurz wrote: > > > On Mon, 14 Apr 2014 15:08:23 +0200 > > > Alexander Graf wrote: > > > > > >> On 14.04.14 14:55, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Peter Maydell
On 15 April 2014 14:22, Greg Kurz wrote: > On Tue, 15 Apr 2014 13:35:03 +0200 > Alexander Graf wrote: >> That would defeat the purpose - the reason to have the helper inlined is >> to remove the conditional branch for x86. >> > > Sure but on the other hand, Peter does not like the idea of moving

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Greg Kurz
On Tue, 15 Apr 2014 13:35:03 +0200 Alexander Graf wrote: > On 04/15/2014 10:40 AM, Greg Kurz wrote: > > On Mon, 14 Apr 2014 15:08:23 +0200 > > Alexander Graf wrote: > > > >> On 14.04.14 14:55, Michael S. Tsirkin wrote: > >>> On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Alexander Graf
On 04/15/2014 10:40 AM, Greg Kurz wrote: On Mon, 14 Apr 2014 15:08:23 +0200 Alexander Graf wrote: On 14.04.14 14:55, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +020

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-15 Thread Greg Kurz
On Mon, 14 Apr 2014 15:08:23 +0200 Alexander Graf wrote: > > On 14.04.14 14:55, Michael S. Tsirkin wrote: > > On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > >> On 14.04.14 14:37, Michael S. Tsirkin wrote: > >>> On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:40:04 +0200 Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > > On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >> On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>> On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > >

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 15:12, Greg Kurz wrote: On Mon, 14 Apr 2014 14:53:03 +0200 Alexander Graf wrote: On 14.04.14 14:50, Greg Kurz wrote: On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:53:03 +0200 Alexander Graf wrote: > > On 14.04.14 14:50, Greg Kurz wrote: > > On Mon, 14 Apr 2014 14:22:36 +0200 > > Alexander Graf wrote: > > > >> On 14.04.14 13:58, Greg Kurz wrote: > >>> From: Rusty Russell > >>> > >>> virtio data structures are defined as "target endi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 03:08:23PM +0200, Alexander Graf wrote: > > On 14.04.14 14:55, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:37, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:55, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 15:46:34 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > > >>On 14.04.14 14:24, Michael S. Tsirkin w

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:56, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:49:31PM +0200, Alexander Graf wrote: On 14.04.14 14:46, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Cedric Le Goater
On 04/14/2014 02:49 PM, Alexander Graf wrote: > > On 14.04.14 14:46, Michael S. Tsirkin wrote: >> On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: >>> On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > On 14.04.14

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:49:31PM +0200, Alexander Graf wrote: > > On 14.04.14 14:46, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:37, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:50, Greg Kurz wrote: On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specif

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:22:36 +0200 Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > > From: Rusty Russell > > > > virtio data structures are defined as "target endian", which assumes > > that's a fixed value. In fact, that actually means it's platform-specific. > > The OASIS vir

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:46, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: This will have to be measure

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:40:04PM +0200, Alexander Graf wrote: > > On 14.04.14 14:37, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:24, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:38:14PM +0200, Alexander Graf wrote: > > On 14.04.14 14:34, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: > >>On 14.04.14 14:28, Michael S. Tsirkin wrote: > >>>On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote:

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:37, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data stru

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
On Mon, 14 Apr 2014 14:16:03 +0200 Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > > From: Rusty Russell > > > > virtio data structures are defined as "target endian", which assumes > > that's a fixed value. In fact, that actually means it's platform-specific. > > The OASIS vir

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:34, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: On 14.04.14 14:28, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: Could we try to poison any non-virtio, non-endian-specific memory accessors

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:29:20PM +0200, Alexander Graf wrote: > > On 14.04.14 14:24, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > >>On 14.04.14 13:58, Greg Kurz wrote: > >>>From: Rusty Russell > >>> > >>>virtio data structures are defined as "ta

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:31:06PM +0200, Alexander Graf wrote: > > On 14.04.14 14:28, Michael S. Tsirkin wrote: > >On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: > >>On 14.04.14 13:58, Greg Kurz wrote: > >>>From: Rusty Russell > >>> > >>>virtio data structures are defined as "ta

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:28, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's p

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 14:24, Michael S. Tsirkin wrote: On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's p

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:22:36PM +0200, Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > >From: Rusty Russell > > > >virtio data structures are defined as "target endian", which assumes > >that's a fixed value. In fact, that actually means it's platform-specific. > >The OASIS vi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Michael S. Tsirkin
On Mon, Apr 14, 2014 at 02:16:03PM +0200, Alexander Graf wrote: > > On 14.04.14 13:58, Greg Kurz wrote: > >From: Rusty Russell > > > >virtio data structures are defined as "target endian", which assumes > >that's a fixed value. In fact, that actually means it's platform-specific. > >The OASIS vi

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Alexander Graf
On 14.04.14 13:58, Greg Kurz wrote: From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory

[Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-14 Thread Greg Kurz
From: Rusty Russell virtio data structures are defined as "target endian", which assumes that's a fixed value. In fact, that actually means it's platform-specific. The OASIS virtio 1.0 spec will fix this, by making it all little endian. We introduce memory accessors to be used accross the virti