[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Michael S. Tsirkin
On Wed, Jan 05, 2011 at 11:41:02AM +0100, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail to create disk images = 2GB Signed-off-by: Jes Sorensen

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Jes Sorensen
On 01/05/11 13:34, Michael S. Tsirkin wrote: On Wed, Jan 05, 2011 at 11:41:02AM +0100, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail to create disk images = 2GB

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Michael S. Tsirkin
On Wed, Jan 05, 2011 at 01:36:35PM +0100, Jes Sorensen wrote: On 01/05/11 13:34, Michael S. Tsirkin wrote: On Wed, Jan 05, 2011 at 11:41:02AM +0100, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Anthony Liguori
On 01/05/2011 04:41 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail to create disk images= 2GB Signed-off-by: Jes Sorensenjes.soren...@redhat.com off_t would be

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Jes Sorensen
On 01/05/11 14:46, Anthony Liguori wrote: On 01/05/2011 04:41 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail to create disk images= 2GB Signed-off-by: Jes

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Anthony Liguori
On 01/05/2011 08:40 AM, Jes Sorensen wrote: On 01/05/11 14:46, Anthony Liguori wrote: On 01/05/2011 04:41 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com strtosz() needs to return a 64 bit type even on 32 bit architectures. Otherwise qemu-img will fail

[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t

2011-01-05 Thread Jes Sorensen
On 01/05/11 19:29, Anthony Liguori wrote: I wouldn't make such bold claims but I'll concede that one is not significantly better than the other and won't object to int64_t if you feel strongly. The more I think of it, the more I come to the conclusion that int64_t is the best solution. Since