Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-02 Thread Jan Kiszka
Anthony Liguori wrote: > On 06/01/2010 01:35 PM, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >> >>> On Tue, 01 Jun 2010 16:44:24 +0200 >>> Markus Armbruster wrote: >>> >>> Luiz Capitulino writes: > On Mon, 31 May 2010 16:13:12 +0200 > Markus Armbr

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Anthony Liguori
On 06/01/2010 01:35 PM, Markus Armbruster wrote: Luiz Capitulino writes: On Tue, 01 Jun 2010 16:44:24 +0200 Markus Armbruster wrote: Luiz Capitulino writes: On Mon, 31 May 2010 16:13:12 +0200 Markus Armbruster wrote: We need Device IDs to be unique and not

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 01 Jun 2010 16:44:24 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Mon, 31 May 2010 16:13:12 +0200 >> > Markus Armbruster wrote: >> > >> >> We need Device IDs to be unique and not contain '/' so device tree >> >> nodes can always be

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Luiz Capitulino
On Tue, 01 Jun 2010 16:44:24 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 31 May 2010 16:13:12 +0200 > > Markus Armbruster wrote: > > > >> We need Device IDs to be unique and not contain '/' so device tree > >> nodes can always be unambigously referenced by tree path.

Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 31 May 2010 16:13:12 +0200 > Markus Armbruster wrote: > >> We need Device IDs to be unique and not contain '/' so device tree >> nodes can always be unambigously referenced by tree path. >> >> We already have some protection against duplicate IDs, but it got >>

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Luiz Capitulino
On Tue, 01 Jun 2010 15:19:59 +0200 Jan Kiszka wrote: > Luiz Capitulino wrote: > > On Tue, 01 Jun 2010 15:09:34 +0200 > > Jan Kiszka wrote: > > > >> Luiz Capitulino wrote: > >>> Two bugs that might not be related to this thread: > >>> > >>> * "id" member is not mandatory for the device_add co

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Avi Kivity
On 06/01/2010 04:19 PM, Jan Kiszka wrote: Main point is whether "id" is required or not, I think it should be. And I think it might be recommended but should become mandatory (specifically not for HMP). I agree. Making id a mandatory argument will just result in clients being f

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Jan Kiszka
Luiz Capitulino wrote: > On Tue, 01 Jun 2010 15:09:34 +0200 > Jan Kiszka wrote: > >> Luiz Capitulino wrote: >>> Two bugs that might not be related to this thread: >>> >>> * "id" member is not mandatory for the device_add command: >>> >>> { "execute": "device_add", "arguments": { "driver":

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Luiz Capitulino
On Tue, 01 Jun 2010 15:09:34 +0200 Jan Kiszka wrote: > Luiz Capitulino wrote: > > Two bugs that might not be related to this thread: > > > > * "id" member is not mandatory for the device_add command: > > > > { "execute": "device_add", "arguments": { "driver": "e1000" } } > > {"return

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Jan Kiszka
Luiz Capitulino wrote: > Two bugs that might not be related to this thread: > > * "id" member is not mandatory for the device_add command: > > { "execute": "device_add", "arguments": { "driver": "e1000" } } > {"return": {}} Once we enable qtree paths for device_del, this is no longer

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-01 Thread Luiz Capitulino
On Mon, 31 May 2010 16:13:12 +0200 Markus Armbruster wrote: > We need Device IDs to be unique and not contain '/' so device tree > nodes can always be unambigously referenced by tree path. > > We already have some protection against duplicate IDs, but it got > holes: > > * We don't assign IDs t

[Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-05-31 Thread Gerd Hoffmann
On 05/31/10 16:13, Markus Armbruster wrote: We need Device IDs to be unique and not contain '/' so device tree nodes can always be unambigously referenced by tree path. We already have some protection against duplicate IDs, but it got holes: * We don't assign IDs to default devices. * -device