Re: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-07 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 04:45:20PM -0200, Marcelo Tosatti wrote: On Thu, Jan 06, 2011 at 04:34:38PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: Hi, Could you split the tested and untested parts to separate patches, noting the

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
diff --git a/hw/piix4.c b/hw/piix4.c index 5489386..1678898 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = { .qdev.desc= ISA bridge, .qdev.size= sizeof(PCIDevice), .qdev.no_user = 1, +.qdev.no_hotplug

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 09:40:52AM +0100, Gerd Hoffmann wrote: diff --git a/hw/piix4.c b/hw/piix4.c index 5489386..1678898 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = { .qdev.desc= ISA bridge, .qdev.size=

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Gerd Hoffmann
Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how simple the change is. Respin goes to the list shortly. cheers, Gerd

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how simple the change is. Yes but I don't know whether the untested devices this

Re: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-06 Thread Marcelo Tosatti
On Thu, Jan 06, 2011 at 04:34:38PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote: Hi, Could you split the tested and untested parts to separate patches, noting the status in the commit message? I think this is overkill given how

[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

2011-01-05 Thread Michael S. Tsirkin
On Tue, Nov 30, 2010 at 02:26:03PM +0100, Gerd Hoffmann wrote: This patch tags all pci devices which belong to the piix3/4 chipsets as not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c |2 ++