Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 12/08/21 13:09, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > ShellCheck points out that tr '[a-z]' actually replaces the []'s > > and only the a-z is needed. > > > > Remove the spurious [] - although in this use

Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Paolo Bonzini
On 12/08/21 15:05, Dr. David Alan Gilbert wrote: In configure line 4464: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. which hmm I've not quite got my head around yet; but

Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Paolo Bonzini
On 12/08/21 13:09, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" ShellCheck points out that tr '[a-z]' actually replaces the []'s and only the a-z is needed. Remove the spurious [] - although in this use it will make no difference. Fixes:

Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Eric Blake
On Thu, Aug 12, 2021 at 02:05:36PM +0100, Dr. David Alan Gilbert wrote: > Indeed it's not; there's LOTS of warnings; although most of them are > probably irrelevant; there are also two others at the error level: > > In configure line 4406: > if "$ld" -verbose 2>&1 | grep -q

Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 12 Aug 2021 at 12:11, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > ShellCheck points out that tr '[a-z]' actually replaces the []'s > > and only the a-z is needed. > > > > Remove the spurious [] -

Re: [PATCH] configure: Remove spurious [] from tr

2021-08-12 Thread Peter Maydell
On Thu, 12 Aug 2021 at 12:11, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > ShellCheck points out that tr '[a-z]' actually replaces the []'s > and only the a-z is needed. > > Remove the spurious [] - although in this use it will make no > difference. > > Fixes: