Re: [PATCH] vl, qemu-config: remove -set

2020-11-12 Thread Paolo Bonzini
On 12/11/20 12:26, Gerd Hoffmann wrote: Yes, that is quite useful for setting device properties which are not (yet) supported by libvirt, like this: Grepping through my libvirt domain config files I see 90% is indeed "-set device". But I've also found netdev (set

Re: [PATCH] vl, qemu-config: remove -set

2020-11-12 Thread Gerd Hoffmann
Hi, > IOW, it looks like it is valid to use -set, even if you're not using > -readconfig. Yes, that is quite useful for setting device properties which are not (yet) supported by libvirt, like this: Grepping through my libvirt domain config files I see 90% is indeed "-set

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Paolo Bonzini
Il gio 12 nov 2020, 07:55 Markus Armbruster ha scritto: > Immediate removal of -set / rejection of -set for some option groups > needs more justification than just "I think we can get away with it": > there has to be a tangible benefit. The benefit is being able to switch parsers (for

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/11/20 16:03, Daniel P. Berrangé wrote: >> On Wed, Nov 11, 2020 at 08:57:16AM -0500, Paolo Bonzini wrote: >>> -set as far as I can see has basically no use. It was intended as an >>> override >>> mechanism for configuration files, but even configuration files

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Paolo Bonzini
On 11/11/20 16:03, Daniel P. Berrangé wrote: iotest 068 uses -set and qtest vhost-user-text.c also does IOW, it looks like it is valid to use -set, even if you're not using -readconfig. Libvirt doesn't use -set, but we've had users who make use of libvirt command line passthrough for QEMU with

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Daniel P . Berrangé
On Wed, Nov 11, 2020 at 08:57:16AM -0500, Paolo Bonzini wrote: > -set as far as I can see has basically no use. It was intended as an override > mechanism for configuration files, but even configuration files themselves > are hardly used. Drop it with prejudice. > > Signed-off-by: Paolo Bonzini