Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Richard Henderson
On 5/13/21 8:33 AM, Alex Bennée wrote: Now add and mul columns are going down when the only change is to muladd? Is this just more noise? Running again more times I think it is a real effect: I don't believe it. If source code for a given function is not changing then the generated code

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Alex Bennée
Richard Henderson writes: > On 5/12/21 2:23 PM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Reorg everything using QEMU_GENERIC and multiple inclusion to >>> reduce the amount of code duplication between the formats. >>> >>> The use of QEMU_GENERIC means that we need to use

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-13 Thread Richard Henderson
On 5/12/21 2:23 PM, Alex Bennée wrote: Richard Henderson writes: Reorg everything using QEMU_GENERIC and multiple inclusion to reduce the amount of code duplication between the formats. The use of QEMU_GENERIC means that we need to use pointers instead of structures, which means that even

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Richard Henderson
On 5/12/21 6:22 AM, Alex Bennée wrote: I did note we are missing mulAdd tests but they seem to be missing from the underlying testfloat code as well. I guess we don't care that much for the 80bit code? Is it even used by any architectures? It's not used by any architecture, so no point in

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-12 Thread Alex Bennée
Richard Henderson writes: > On 5/10/21 8:36 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Reorg everything using QEMU_GENERIC and multiple inclusion to >>> reduce the amount of code duplication between the formats. >>> >>> The use of QEMU_GENERIC means that we need to use

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-11 Thread Richard Henderson
On 5/10/21 8:36 AM, Alex Bennée wrote: Richard Henderson writes: Reorg everything using QEMU_GENERIC and multiple inclusion to reduce the amount of code duplication between the formats. The use of QEMU_GENERIC means that we need to use pointers instead of structures, which means that even

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-10 Thread Alex Bennée
Richard Henderson writes: > Reorg everything using QEMU_GENERIC and multiple inclusion to > reduce the amount of code duplication between the formats. > > The use of QEMU_GENERIC means that we need to use pointers instead > of structures, which means that even the smaller float formats > need

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

2021-05-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210508014802.892561-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210508014802.892561-1-richard.hender...@linaro.org Subject: [PATCH 00/72]