Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-09 Thread Wu, Wentong
> >On Mon, 29 Jun 2020 at 09:17, Wentong Wu wrote: > > > > wrctl instruction on nios2 target will cause checking cpu > > interrupt but tcg_handle_interrupt() will call cpu_abort() > > if the CPU gets an interrupt while it's not in 'can do IO' > > state, so add gen_io_start around wrctl

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-06 Thread Wu, Wentong
; From: Peter Maydell > Sent: Monday, July 6, 2020 1:10 AM > To: Wu, Wentong > Cc: QEMU Developers ; QEMU Trivial > ; Chris Wulff ; Marek Vasut > > Subject: Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl > instruction > > On Mon, 29 Jun 2020 at 09:17,

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-06 Thread Peter Maydell
On Sun, 5 Jul 2020 at 21:54, Max Filippov wrote: > > On Sun, Jul 5, 2020 at 11:16 AM Max Filippov wrote: > > On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell > > wrote: > > > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > > > wrote: > > > > This isn't right. Not so much the gen_io_start

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
; ma...@denx.de; crwu...@gmail.com; peter.mayd...@linaro.org Subject: Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction On 6/29/20 9:05 AM, Wentong Wu wrote: > wrctl instruction on nios2 target will cause checking cpu interrupt > but tcg_handle_interrupt() will call cpu

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Thanks, I think we can get this series merged currently. -Original Message- From: Peter Maydell Sent: Monday, July 6, 2020 1:10 AM To: Wu, Wentong Cc: QEMU Developers ; QEMU Trivial ; Chris Wulff ; Marek Vasut Subject: Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Max Filippov
On Sun, Jul 5, 2020 at 11:16 AM Max Filippov wrote: > On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell > wrote: > > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > > wrote: > > > This isn't right. Not so much the gen_io_start portion, but the entire > > > existence of helper_check_interrupt. >

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Max Filippov
On Sun, Jul 5, 2020 at 10:09 AM Peter Maydell wrote: > On Thu, 2 Jul 2020 at 19:53, Richard Henderson > wrote: > > This isn't right. Not so much the gen_io_start portion, but the entire > > existence of helper_check_interrupt. > > I agree that it looks bogus (xtensa has a similar helper as

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Peter Maydell
On Mon, 29 Jun 2020 at 09:17, Wentong Wu wrote: > > wrctl instruction on nios2 target will cause checking cpu > interrupt but tcg_handle_interrupt() will call cpu_abort() > if the CPU gets an interrupt while it's not in 'can do IO' > state, so add gen_io_start around wrctl instruction. Also > at

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Peter Maydell
On Thu, 2 Jul 2020 at 19:53, Richard Henderson wrote: > This isn't right. Not so much the gen_io_start portion, but the entire > existence of helper_check_interrupt. I agree that it looks bogus (xtensa has a similar helper as well, incidentally), but fixing all that stuff up is more effort than

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Correct the format > -Original Message- > From: Richard Henderson > Sent: Friday, July 3, 2020 2:54 AM > To: Wu, Wentong ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; ma...@denx.de; crwu...@gmail.com; > peter.mayd...@linaro.org > Subject: Re: [PATCH 3

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-05 Thread Wu, Wentong
Correct the format > -Original Message- > From: Richard Henderson > Sent: Friday, July 3, 2020 2:54 AM > To: Wu, Wentong ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; ma...@denx.de; crwu...@gmail.com; > peter.mayd...@linaro.org > Subject: Re: [PATCH 3

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-03 Thread Wu, Wentong
HI Peter, Could you please take a look at this patch which is following your pervious suggestion? Thanks -Original Message- From: Wu, Wentong Sent: Tuesday, June 30, 2020 12:06 AM To: qemu-devel@nongnu.org Cc: qemu-triv...@nongnu.org; crwu...@gmail.com; ma...@denx.de;

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-03 Thread Wu, Wentong
-Original Message- From: Richard Henderson Sent: Friday, July 3, 2020 2:54 AM To: Wu, Wentong ; qemu-devel@nongnu.org Cc: qemu-triv...@nongnu.org; ma...@denx.de; crwu...@gmail.com; peter.mayd...@linaro.org Subject: Re: [PATCH 3/3] target/nios2: Use

Re: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-02 Thread Richard Henderson
On 6/29/20 9:05 AM, Wentong Wu wrote: > wrctl instruction on nios2 target will cause checking cpu > interrupt but tcg_handle_interrupt() will call cpu_abort() > if the CPU gets an interrupt while it's not in 'can do IO' > state, so add gen_io_start around wrctl instruction. Also > at the same

RE: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction

2020-07-01 Thread Wu, Wentong
Hi, Could you please take a look the new patch? Thanks > -Original Message- > Subject: [PATCH 3/3] target/nios2: Use gen_io_start around wrctl instruction > wrctl instruction on nios2 target will cause checking cpu interrupt but > tcg_handle_interrupt() will call cpu_abort() if the CPU