Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Eric Blake
On Wed, Sep 29, 2021 at 01:30:50AM -0400, ~farzon wrote: > From: Farzon Lotfi Food for thought: your git/mail configuration used one address for the envelope (name '~farzon' as user 'farzon@') and another as the patch author (name 'Farzon Lotfi' as user 'hi@'). Since you own your domain (with

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:55:16PM +0200, Kevin Wolf wrote: > > > When we're changing these lines anyway, let's make sure to have > > > consistent alignment with the surrounding code. So I would prefer > > > something like: > > > > > > +.bdrv_close = parallels_close, > > >

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Kevin Wolf
Am 30.09.2021 um 14:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > 9/30/21 12:46, Kevin Wolf wrote: > > Am 29.09.2021 um 07:30 hat ~farzon geschrieben: > > > From: Farzon Lotfi > > > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 > > > > > > Signed-off-by: Farzon Lotfi >

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Vladimir Sementsov-Ogievskiy
9/30/21 12:46, Kevin Wolf wrote: Am 29.09.2021 um 07:30 hat ~farzon geschrieben: From: Farzon Lotfi Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 Signed-off-by: Farzon Lotfi Just picking one example, but it applies to most hunks of the patch: diff --git a/block/parallels.c

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Kevin Wolf
Am 29.09.2021 um 07:30 hat ~farzon geschrieben: > From: Farzon Lotfi > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 > > Signed-off-by: Farzon Lotfi Just picking one example, but it applies to most hunks of the patch: > diff --git a/block/parallels.c b/block/parallels.c >