Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-10 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is deprecated

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Xu
On Mon, Apr 09, 2018 at 07:37:11PM +0200, Paolo Bonzini wrote: > On 09/04/2018 11:24, Peter Maydell wrote: > > On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: > >> Feels to me that since we've deprecated 2.0, we could just *never* auto > >> detect - just do test -z "$gtkabi" && gtkabi=3.0

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Paolo Bonzini
On 09/04/2018 11:24, Peter Maydell wrote: > On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: >> Feels to me that since we've deprecated 2.0, we could just *never* auto >> detect - just do test -z "$gtkabi" && gtkabi=3.0 >> >> Anyone who wants gtk2 should have to use an explicit --with-gtkab

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Peter Maydell
On 9 April 2018 at 09:31, Daniel P. Berrangé wrote: > Feels to me that since we've deprecated 2.0, we could just *never* auto > detect - just do test -z "$gtkabi" && gtkabi=3.0 > > Anyone who wants gtk2 should have to use an explicit --with-gtkabi=2.0 I think if we still work with gtk2 then w

Re: [Qemu-devel] [PATCH] configure: don't warn GTK if disabled

2018-04-09 Thread Daniel P . Berrangé
On Mon, Apr 09, 2018 at 04:23:23PM +0800, Peter Xu wrote: > We don't need to detect GTK ABI if GTK is disabled in general. > Otherwise we could get this warning (when host is installed with GTK ABI > version 2) even when configure with "--disable-gtk": > > WARNING: Use of GTK 2.0 is deprecated