Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 15:50:17 +0200 Paolo Bonzini wrote: > Il 19/10/2012 15:23, Luiz Capitulino ha scritto: > >> > > >> > With HMP yes, with QMP no. You just get "An incoming migration is > >> > expected before this command can be executed" and no clue that disks > >> > are encrypted. > > We cou

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 15:23, Luiz Capitulino ha scritto: >> > >> > With HMP yes, with QMP no. You just get "An incoming migration is >> > expected before this command can be executed" and no clue that disks >> > are encrypted. > We could move the bdrv_iterate() calls before the RUN_STATE_INMIGRATE check

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 05:27:29 -0400 (EDT) Paolo Bonzini wrote: > > What happens is that a stop command while in INMIGRATE state will just > > be ignored. Actually, any stops while in a state that pauses vCPUs > > are ignored. > > > > Also, I don't understand what you meant by "racy", care to elab

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Paolo Bonzini
> What happens is that a stop command while in INMIGRATE state will just > be ignored. Actually, any stops while in a state that pauses vCPUs > are ignored. > > Also, I don't understand what you meant by "racy", care to elaborate? Case 1: Case 2: user runs qe

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-18 Thread Luiz Capitulino
On Thu, 18 Oct 2012 11:14:22 +0200 Paolo Bonzini wrote: > Right now, stop followed by an incoming migration will let the > virtual machine start. cont before an incoming migration instead > will fail. > > This is bad because the actual behavior is not predictable; it is > racy with respect to t