Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-02-12 Thread Cornelia Huck
On Mon, 11 Feb 2019 12:57:36 -0500 "Jason J. Herne" wrote: > On 2/4/19 5:45 AM, Cornelia Huck wrote: > > On Tue, 29 Jan 2019 08:29:12 -0500 > > "Jason J. Herne" wrote: > >> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > >> index 7e3f65e..2457752 100644 > >> ---

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-02-11 Thread Jason J. Herne
On 2/4/19 5:45 AM, Cornelia Huck wrote: On Tue, 29 Jan 2019 08:29:12 -0500 "Jason J. Herne" wrote: Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. s/cases./cases,/ In one case no boot device is specified and a suitable boot device can not be

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-02-04 Thread Cornelia Huck
On Tue, 29 Jan 2019 08:29:12 -0500 "Jason J. Herne" wrote: > Make a new routine find_boot_device to locate the boot device for all > cases. not just virtio. s/cases./cases,/ > > In one case no boot device is specified and a suitable boot device can not > be auto detected. The error message

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-01-31 Thread Farhan Ali
On 01/29/2019 08:29 AM, Jason J. Herne wrote: Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. In one case no boot device is specified and a suitable boot device can not be auto detected. The error message for this case was specific to virtio

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. I don't think there should be a period after cases? In one case no boot device is specified and a suitable boot device can not be auto detected. The