Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Markus Armbruster
[cc: Anthony, please review the proposed incompatible change of the human monitor] jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- hmp-commands.hx |2 +- migration.c |4 ++-- 2 files changed, 3

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Paolo Bonzini
On 10/11/2010 11:03 AM, Markus Armbruster wrote: As noted before, this is an incompatible change of the human monitor command: unit now defaults to 'M'. This must be noted*prominently* in the commit message. Best in the subject. Incompatible changes can break tools. Quick grep of libvirt:

Re: [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-11 Thread Jes Sorensen
On 10/11/10 11:03, Markus Armbruster wrote: As noted before, this is an incompatible change of the human monitor command: unit now defaults to 'M'. This must be noted *prominently* in the commit message. Best in the subject. Incompatible changes can break tools. Quick grep of libvirt: