Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-26 Thread Paolo Bonzini
On 22/01/2018 11:36, Kang, Luwei wrote: >>> On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: On 18/01/2018 15:37, Eduardo Habkost wrote: > On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: >> On 18/01/2018 14:24, Eduardo Habkost wrote: >>> However, if

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-22 Thread Kang, Luwei
> > On 18/01/2018 14:24, Eduardo Habkost wrote: > > > However, if there's a simple way to make it possible to migrate > > > between hosts with different CPUID[14h] data, it would be even > > > better. With the current KVM intel-pt implementation, what happens > > > if the CPUID[14h] data seen by

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-22 Thread Kang, Luwei
> > On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: > >> On 18/01/2018 15:37, Eduardo Habkost wrote: > >>> On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > On 18/01/2018 14:24, Eduardo Habkost wrote: > > However, if there's a simple way to make it possible

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 17:52, Eduardo Habkost wrote: > On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: >> On 18/01/2018 15:37, Eduardo Habkost wrote: >>> On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: On 18/01/2018 14:24, Eduardo Habkost wrote: > However, if there's

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: > On 18/01/2018 15:37, Eduardo Habkost wrote: > > On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > >> On 18/01/2018 14:24, Eduardo Habkost wrote: > >>> However, if there's a simple way to make it possible to migrate >

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 15:37, Eduardo Habkost wrote: > On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: >> On 18/01/2018 14:24, Eduardo Habkost wrote: >>> However, if there's a simple way to make it possible to migrate >>> between hosts with different CPUID[14h] data, it would be even >>>

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > On 18/01/2018 14:24, Eduardo Habkost wrote: > > However, if there's a simple way to make it possible to migrate > > between hosts with different CPUID[14h] data, it would be even > > better. With the current KVM intel-pt

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 14:24, Eduardo Habkost wrote: > However, if there's a simple way to make it possible to migrate > between hosts with different CPUID[14h] data, it would be even > better. With the current KVM intel-pt implementation, what > happens if the CPUID[14h] data seen by the guest doesn't

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 05:33:53AM +, Kang, Luwei wrote: > > > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > > > CCing libvirt developers. > > > > > > > ... > > > > > > > > This case is slightly more problematic, however: the new > > > > > > > > feature is

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-17 Thread Kang, Luwei
> > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > > CCing libvirt developers. > > > > > > ... > > > > > > > This case is slightly more problematic, however: the new > > > > > > > feature is actually migratable (under very controlled > > > > > > > circumstances)

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-17 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 10:32:56AM +, Kang, Luwei wrote: > > > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > > CCing libvirt developers. > > > > > ... > > > > > > This case is slightly more problematic, however: the new feature > > > > > > is actually migratable

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-17 Thread Kang, Luwei
> > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > > CCing libvirt developers. > > > > ... > > > > > This case is slightly more problematic, however: the new feature > > > > > is actually migratable (under very controlled circumstances) > > > > > because of patch 2/2,

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-16 Thread Eduardo Habkost
On Tue, Jan 16, 2018 at 06:10:17AM +, Kang, Luwei wrote: > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > CCing libvirt developers. > > > ... > > > > This case is slightly more problematic, however: the new feature is > > > > actually migratable (under very

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Kang, Luwei
> > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > CCing libvirt developers. > > ... > > > This case is slightly more problematic, however: the new feature is > > > actually migratable (under very controlled circumstances) because of > > > patch 2/2, but it is not

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Eduardo Habkost
On Mon, Jan 15, 2018 at 03:25:18PM +0100, Jiri Denemark wrote: > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > CCing libvirt developers. > ... > > This case is slightly more problematic, however: the new feature > > is actually migratable (under very controlled circumstances)

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Jiri Denemark
On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > CCing libvirt developers. ... > This case is slightly more problematic, however: the new feature > is actually migratable (under very controlled circumstances) > because of patch 2/2, but it is not migration-safe[1]. This > means

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Eduardo Habkost
CCing libvirt developers. On Mon, Jan 15, 2018 at 10:33:35AM +0100, Paolo Bonzini wrote: > On 15/01/2018 08:19, Kang, Luwei wrote: > >> If you are forwarding host info directly to the guest, the feature > >> is not migration-safe. The new feature needs to be added to > >>

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Paolo Bonzini
On 15/01/2018 08:19, Kang, Luwei wrote: >> If you are forwarding host info directly to the guest, the feature >> is not migration-safe. The new feature needs to be added to >> feature_word_info[FEAT_7_0_EBX].unmigratable_flags. >> > Hi, Thanks for you review. I want to support Intel PT live

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-14 Thread Kang, Luwei
> > From: Chao Peng > > > > Expose Intel Processor Trace feature to guest. > > > > Signed-off-by: Chao Peng > > Signed-off-by: Luwei Kang > > --- > > target/i386/cpu.c | 19 ++- target/i386/cpu.h |

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-12 Thread Eduardo Habkost
On Tue, Jan 09, 2018 at 04:36:36AM +0800, Luwei Kang wrote: > From: Chao Peng > > Expose Intel Processor Trace feature to guest. > > Signed-off-by: Chao Peng > Signed-off-by: Luwei Kang > --- > target/i386/cpu.c