Re: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread KONRAD Frederic
On 06/29/2017 03:02 PM, Philippe Mathieu-Daudé wrote: On 06/29/2017 09:43 AM, Peter Maydell wrote: On 29 June 2017 at 13:35, Philippe Mathieu-Daudé wrote: This is true it is better to abort here than risking a deadlock. However it seems to me they are 3 issues here: - the

Re: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 09:43 AM, Peter Maydell wrote: On 29 June 2017 at 13:35, Philippe Mathieu-Daudé wrote: This is true it is better to abort here than risking a deadlock. However it seems to me they are 3 issues here: - the deadlock pattern is caused by using a global variable, -

Re: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread KONRAD Frederic
On 06/29/2017 02:43 PM, Peter Maydell wrote: On 29 June 2017 at 13:35, Philippe Mathieu-Daudé wrote: This is true it is better to abort here than risking a deadlock. However it seems to me they are 3 issues here: - the deadlock pattern is caused by using a global variable,

Re: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 13:35, Philippe Mathieu-Daudé wrote: > This is true it is better to abort here than risking a deadlock. > > However it seems to me they are 3 issues here: > - the deadlock pattern is caused by using a global variable, > - stellaris:ssys_calculate_system_clock()

Re: [Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread Philippe Mathieu-Daudé
Hi Frederic, On 06/29/2017 06:28 AM, KONRAD Frederic wrote: This helps the board developer by asserting that system_clock_rate is not null. Using systick with a zero rate will lead to a deadlock so better showing the error. Signed-off-by: KONRAD Frederic ---