Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

2018-03-04 Thread Peter Xu
On Fri, Mar 02, 2018 at 12:17:30PM +0100, Paolo Bonzini wrote: > On 02/03/2018 05:26, Peter Xu wrote: > > Frankly speaking I was a bit confused when I started to read > > chardev/qio codes with so many hooks, e.g., when I saw: > > > > qio_net_listener_set_client_func(s->listener,

Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

2018-03-02 Thread Paolo Bonzini
On 02/03/2018 05:26, Peter Xu wrote: > Frankly speaking I was a bit confused when I started to read > chardev/qio codes with so many hooks, e.g., when I saw: > > qio_net_listener_set_client_func(s->listener, tcp_chr_accept, > chr, NULL); > > I totally

Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

2018-03-01 Thread Peter Xu
On Thu, Mar 01, 2018 at 03:43:31PM +, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 04:44:30PM +0800, Peter Xu wrote: > > TCP chardevs can be using QIO network listeners working in the > > background when in listening mode. However the network listeners are > > always running in main

Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

2018-03-01 Thread Daniel P . Berrangé
On Thu, Mar 01, 2018 at 04:44:30PM +0800, Peter Xu wrote: > TCP chardevs can be using QIO network listeners working in the > background when in listening mode. However the network listeners are > always running in main context. This can race with chardevs that are > running in non-main contexts.