Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-16 Thread Gerd Hoffmann
Hi, How does this look like (incremental fixup attached, docs to be updated) ? Might be worth separate docs for the enums (we've done it elsewhere). Sure, as mentioned above docs where not done yet ... But the interface looks fine to me. ... as I wanted to check this first ;) So,

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-16 Thread Eric Blake
On 12/16/2014 03:18 AM, Gerd Hoffmann wrote: Hi, How does this look like (incremental fixup attached, docs to be updated) ? Might be worth separate docs for the enums (we've done it elsewhere). Sure, as mentioned above docs where not done yet ... But the interface looks fine to

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-15 Thread Gerd Hoffmann
Hi, So better add a 'vencrypt-subauth' enum with this list? Yeah probably a good idea How does this look like (incremental fixup attached, docs to be updated) ? cheers, Gerd From c2de144be939412f8923d20e22983e16ab418404 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann kra...@redhat.com

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-15 Thread Daniel P. Berrange
On Mon, Dec 15, 2014 at 10:16:39AM +0100, Gerd Hoffmann wrote: Hi, So better add a 'vencrypt-subauth' enum with this list? Yeah probably a good idea How does this look like (incremental fixup attached, docs to be updated) ? Looks fine to me. Regards, Daniel -- |:

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-15 Thread Eric Blake
On 12/15/2014 02:16 AM, Gerd Hoffmann wrote: Hi, So better add a 'vencrypt-subauth' enum with this list? Yeah probably a good idea How does this look like (incremental fixup attached, docs to be updated) ? +++ b/qapi-schema.json @@ -785,12 +785,22 @@ # # Since: 2.3 ##

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Gerd Hoffmann
Hi, +# @auth: The current authentication type used by the server +#'none' if no authentication is being used +#'vnc' if VNC authentication is being used +#'vencrypt+plain' if VEncrypt is used with plain text authentication +#'vencrypt+tls+none' if

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Wed, Dec 10, 2014 at 09:52:05AM -0700, Eric Blake wrote: On 12/10/2014 02:37 AM, Gerd Hoffmann wrote: Add new query vnc qmp command, for the lack of better ideas just name it query-vnc2. Changes over query-vnc: * It returns a list of vnc servers, so multiple vnc server instances

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 10:07:24AM +0100, Gerd Hoffmann wrote: Hi, +# @auth: The current authentication type used by the server +#'none' if no authentication is being used +#'vnc' if VNC authentication is being used +#'vencrypt+plain' if VEncrypt is used

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Gerd Hoffmann
Hi, That's not a correct interpretation of the auth values - tls and x509 are not separate auth codes. VNC has one set of primary auth codes really none, vnc, vencrypt Well, the source code also has (see vnc_auth_name in ui/vnc.c): ra2, ra2ne, tight, ultra, tls, sasl If using the

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 12:33:35PM +0100, Gerd Hoffmann wrote: Hi, That's not a correct interpretation of the auth values - tls and x509 are not separate auth codes. VNC has one set of primary auth codes really none, vnc, vencrypt Well, the source code also has (see

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-10 Thread Eric Blake
On 12/10/2014 02:37 AM, Gerd Hoffmann wrote: Add new query vnc qmp command, for the lack of better ideas just name it query-vnc2. Changes over query-vnc: * It returns a list of vnc servers, so multiple vnc server instances are covered. * Each vnc server returns a list of server