Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

Thomas Huth writes: > On 14/05/2019 20.41, Thomas Huth wrote: >> On 14/05/2019 20.03, Markus Armbruster wrote: >>> vubr_set_host() passes char values to isdigit(). Undefined behavior >>> when the value is negative. >>> >>> Fix by using qemu_isdigit() instead. >>> >>> Signed-off-by: Markus

Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

On 14/05/2019 20.41, Thomas Huth wrote: > On 14/05/2019 20.03, Markus Armbruster wrote: >> vubr_set_host() passes char values to isdigit(). Undefined behavior >> when the value is negative. >> >> Fix by using qemu_isdigit() instead. >> >> Signed-off-by: Markus Armbruster >> --- >>

Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

On 14/05/2019 20.03, Markus Armbruster wrote: > vubr_set_host() passes char values to isdigit(). Undefined behavior > when the value is negative. > > Fix by using qemu_isdigit() instead. > > Signed-off-by: Markus Armbruster > --- > tests/vhost-user-bridge.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

On 5/14/19 8:03 PM, Markus Armbruster wrote: > vubr_set_host() passes char values to isdigit(). Undefined behavior "happens"? > when the value is negative. > > Fix by using qemu_isdigit() instead. > > Signed-off-by: Markus Armbruster > --- > tests/vhost-user-bridge.c | 2 +- > 1 file