Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Gavin Shan
On 2/13/20 9:31 PM, Peter Maydell wrote: On Thu, 13 Feb 2020 at 03:49, Gavin Shan wrote: On 2/12/20 10:34 PM, Peter Maydell wrote: Yeah, this is on my list to look at; Richard Henderson also could have a look at it. From a quick scan I suspect you may be missing handling for AArch32. Yes,

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Gavin Shan
On 2/13/20 4:39 PM, Richard Henderson wrote: On 2/12/20 7:49 PM, Gavin Shan wrote: On 2/12/20 10:34 PM, Peter Maydell wrote: Yeah, this is on my list to look at; Richard Henderson also could have a look at it. From a quick scan I suspect you may be missing handling for AArch32. [Thanks for

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 03:49, Gavin Shan wrote: > On 2/12/20 10:34 PM, Peter Maydell wrote: > > Yeah, this is on my list to look at; Richard Henderson also could > > have a look at it. From a quick scan I suspect you may be missing > > handling for AArch32. > Yes, the functionality is only

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-12 Thread Richard Henderson
On 2/12/20 7:49 PM, Gavin Shan wrote: > On 2/12/20 10:34 PM, Peter Maydell wrote: >> Yeah, this is on my list to look at; Richard Henderson also could >> have a look at it. From a quick scan I suspect you may be missing >> handling for AArch32. >> > > [Thanks for copying Richard Henderson] > >

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-12 Thread Gavin Shan
On 2/12/20 10:34 PM, Peter Maydell wrote: On Wed, 12 Feb 2020 at 06:39, Gavin Shan wrote: On 2/5/20 10:05 PM, Gavin Shan wrote: This allows to inject SError interrupt, which will be used on receiving QMP/HMP "nmi" command in next patch. Signed-off-by: Gavin Shan --- target/arm/cpu.c|

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-12 Thread Peter Maydell
On Wed, 12 Feb 2020 at 06:39, Gavin Shan wrote: > > On 2/5/20 10:05 PM, Gavin Shan wrote: > > This allows to inject SError interrupt, which will be used on receiving > > QMP/HMP "nmi" command in next patch. > > > > Signed-off-by: Gavin Shan > > --- > > target/arm/cpu.c| 11 +++ > >

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-11 Thread Gavin Shan
On 2/5/20 10:05 PM, Gavin Shan wrote: This allows to inject SError interrupt, which will be used on receiving QMP/HMP "nmi" command in next patch. Signed-off-by: Gavin Shan --- target/arm/cpu.c| 11 +++ target/arm/cpu.h| 12 +--- target/arm/helper.c | 4 3