Re: [RFC PATCH 6/6] i386/sev: populate secrets and cpuid page and finalize the SNP launch

2021-07-19 Thread Brijesh Singh
Hi Dov, On 7/19/21 6:24 AM, Dov Murik wrote: s/LAUNCH_UPDATE/SNP_LAUNCH_UPDATE/ (to show it's the same command you refer to above) Noted. +static int +sev_snp_launch_update_gpa(uint32_t hwaddr, uint32_t size, uint8_t type) hwaddr is a confusing name here because it is also a typedef

Re: [RFC PATCH 6/6] i386/sev: populate secrets and cpuid page and finalize the SNP launch

2021-07-19 Thread Dov Murik
Hi Brijesh, On 10/07/2021 0:55, Brijesh Singh wrote: > During the SNP guest launch sequence, a special secrets and cpuid page > needs to be populated by the SEV-SNP firmware. The secrets page contains > the VM Platform Communication Key (VMPCKs) used by the guest to send and > receive secure

Re: [RFC PATCH 6/6] i386/sev: populate secrets and cpuid page and finalize the SNP launch

2021-07-14 Thread Brijesh Singh
On 7/14/21 12:29 PM, Dr. David Alan Gilbert wrote:>> +struct snp_pre_validated_range { +uint32_t start; +uint32_t end; +}; Just a thought, but maybe use a 'Range' from include/qemu/range.h ? I will look into it. thanks

Re: [RFC PATCH 6/6] i386/sev: populate secrets and cpuid page and finalize the SNP launch

2021-07-14 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > During the SNP guest launch sequence, a special secrets and cpuid page > needs to be populated by the SEV-SNP firmware. The secrets page contains > the VM Platform Communication Key (VMPCKs) used by the guest to send and > receive secure messages to