Re: virtiofsd: Where should it live?

2019-12-04 Thread Dr. David Alan Gilbert
We seem to be settling out to either fsdev/virtiofsd or tools/virtiofsd with tools picking up some speed as people seem to want to put a bunch of other stuff in there. Unless anyone shouts really loud, I'll work on making it tools/virtiofsd. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com /

Re: virtiofsd: Where should it live?

2019-12-04 Thread Eric Blake
On 12/4/19 7:28 AM, Kevin Wolf wrote: Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben: Hi, | ... +- qemu-edid Has its own MAINTAINERS section, together with hw/display/edit* and include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good idea. Gerd? Sort-o

Re: virtiofsd: Where should it live?

2019-12-04 Thread Eric Blake
On 12/4/19 1:43 AM, Markus Armbruster wrote: +- qemu-img | +- qemu-img.c Perhaps this one can all go into existing block/, similar to how pr-manager-helper.c is in scsi/, and virtfs-proxy-helper.c is in fsdev/. Up to the block maintainers, of course. +- qemu-nbd | +-

Re: virtiofsd: Where should it live?

2019-12-04 Thread Thomas Huth
On 04/12/2019 14.28, Kevin Wolf wrote: > Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben: >> Hi, >> | ... +- qemu-edid >>> >>> Has its own MAINTAINERS section, together with hw/display/edit* and >>> include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good

Re: virtiofsd: Where should it live?

2019-12-04 Thread Kevin Wolf
Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben: > Hi, > > > > | ... > > > +- qemu-edid > > > > Has its own MAINTAINERS section, together with hw/display/edit* and > > include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good > > idea. Gerd? > > Sort-of makes sen

Re: virtiofsd: Where should it live?

2019-12-04 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > So what do you think of Paolo's suggestion of putting virtiofsd in > fsdev (mkdir fsdev/9p && mv fsdev/* fsdev/9p && mkdir fsdev/virtiofsd ) No objections. Flatter: fsdev-9p/ and fsdev-virtio/. Matter of taste.

Re: virtiofsd: Where should it live?

2019-12-04 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Daniel P. Berrangé writes: > > > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > >> On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > >> wrote: > >> > > >> > We seem to be coming to the conclusion something that: > >> > > >>

Re: virtiofsd: Where should it live?

2019-12-04 Thread Gerd Hoffmann
Hi, > > | ... > > +- qemu-edid > > Has its own MAINTAINERS section, together with hw/display/edit* and > include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good > idea. Gerd? Sort-of makes sense. My personal preference would be a tools/ directory for all those smal

Re: virtiofsd: Where should it live?

2019-12-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: >> On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert >> wrote: >> > >> > We seem to be coming to the conclusion something that: >> > >> > a) It should live in the qemu tree >> > b) It shouldn't liv

Re: virtiofsd: Where should it live?

2019-12-03 Thread Greg Kurz
On Tue, 3 Dec 2019 13:10:46 + "Dr. David Alan Gilbert" wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 03/12/19 14:02, Dr. David Alan Gilbert wrote: > > >> It could be in fsdev/virtiofsd, > > > fsdev is currently all 9p stuff, so that would seem very confusing. > > > > Move it t

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > > wrote: > > > > > > We seem to be coming to the conclusion something that: > > > > > > a) It should live in the qemu tree

Re: virtiofsd: Where should it live?

2019-12-03 Thread Paolo Bonzini
On 03/12/19 14:02, Dr. David Alan Gilbert wrote: >> It could be in fsdev/virtiofsd, > fsdev is currently all 9p stuff, so that would seem very confusing. Move it to fsdev/9p? >> but I agree with Daniel that at this >> point the QEMU build system introduces baggage that you may not want for >> vir

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 03/12/19 14:02, Dr. David Alan Gilbert wrote: > >> It could be in fsdev/virtiofsd, > > fsdev is currently all 9p stuff, so that would seem very confusing. > > Move it to fsdev/9p? Greg: Are you OK with us doing that, and then having fsdev/virtiofs

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 26/11/19 13:14, Dr. David Alan Gilbert wrote: > >> IOW, if we did decide we want it in QEMU, then instead of > >> '$GIT/contrib/virtiofsd', I'd prefer to see '$GIT/virtiofsd'. > > > > I'm not sure it deserves a new top level for such a specific tool

Re: virtiofsd: Where should it live?

2019-12-03 Thread Paolo Bonzini
On 26/11/19 13:14, Dr. David Alan Gilbert wrote: >> IOW, if we did decide we want it in QEMU, then instead of >> '$GIT/contrib/virtiofsd', I'd prefer to see '$GIT/virtiofsd'. > > I'm not sure it deserves a new top level for such a specific tool. > It could be in fsdev/virtiofsd, but I agree with

Re: virtiofsd: Where should it live?

2019-12-03 Thread Daniel P . Berrangé
On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > wrote: > > > > We seem to be coming to the conclusion something that: > > > > a) It should live in the qemu tree > > b) It shouldn't live under contrib > > c) We'll create

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert > wrote: > > > > We seem to be coming to the conclusion something that: > > > > a) It should live in the qemu tree > > b) It shouldn't live under contrib > > c) We'll create a new top lev

Re: virtiofsd: Where should it live?

2019-12-03 Thread Peter Maydell
On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert wrote: > > We seem to be coming to the conclusion something that: > > a) It should live in the qemu tree > b) It shouldn't live under contrib > c) We'll create a new top level, i.e. 'daemons' > d) virtiofsd will be daemons/virtiofsd > > N

Re: virtiofsd: Where should it live?

2019-12-03 Thread Dr. David Alan Gilbert
We seem to be coming to the conclusion something that: a) It should live in the qemu tree b) It shouldn't live under contrib c) We'll create a new top level, i.e. 'daemons' d) virtiofsd will be daemons/virtiofsd Now, somethings I'm less clear on: e) What else would move into daemons? I

Re: virtiofsd: Where should it live?

2019-12-02 Thread Christophe de Dinechin
Dr. David Alan Gilbert writes: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > > For reference it's based on qemu's livh

Re: virtiofsd: Where should it live?

2019-12-02 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Mon, Dec 02, 2019 at 04:44:23PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > > > > Hi, > > > > There's been quite a bit of d

Re: virtiofsd: Where should it live?

2019-12-02 Thread Michael S. Tsirkin
On Mon, Dec 02, 2019 at 04:44:23PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > > > Hi, > > > There's been quite a bit of discussion about where virtiofsd, our > > > implemenation

Re: virtiofsd: Where should it live?

2019-12-02 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > > Hi, > > There's been quite a bit of discussion about where virtiofsd, our > > implemenation of a virtiofs daemon, should live. I'd like to get > > this settled now, because

Re: virtiofsd: Where should it live?

2019-12-02 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Thomas Huth writes: > > > On 02/12/2019 13.56, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert > >>> wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >>>

Re: virtiofsd: Where should it live?

2019-12-02 Thread Markus Armbruster
Thomas Huth writes: > On 02/12/2019 13.56, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert >>> wrote: * Daniel P. Berrangé (berra...@redhat.com) wrote: > My main objection to 'contrib/' is actually the perceived notion

Re: virtiofsd: Where should it live?

2019-12-02 Thread Thomas Huth
On 02/12/2019 13.56, Markus Armbruster wrote: > Peter Maydell writes: > >> On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert >> wrote: >>> >>> * Daniel P. Berrangé (berra...@redhat.com) wrote: My main objection to 'contrib/' is actually the perceived notions about what the contrib d

Re: virtiofsd: Where should it live?

2019-12-02 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert > wrote: >> >> * Daniel P. Berrangé (berra...@redhat.com) wrote: >> > My main objection to 'contrib/' is actually the perceived notions >> > about what the contrib directory is for. When I see 'contrib/' >> > code in ei

Re: virtiofsd: Where should it live?

2019-12-02 Thread Peter Maydell
On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > My main objection to 'contrib/' is actually the perceived notions > > about what the contrib directory is for. When I see 'contrib/' > > code in either QEMU, or other open source p

Re: virtiofsd: Where should it live?

2019-12-02 Thread Michael S. Tsirkin
On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > >

Re: virtiofsd: Where should it live?

2019-11-26 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > > Hi, > > There's been quite a bit of discussion about where virtiofsd, our > > implemenation of a virtiofs daemon, should live. I'd like to get > > this settled now, bec

Re: virtiofsd: Where should it live?

2019-11-26 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi David > > On Mon, Nov 25, 2019 at 10:50 PM Dr. David Alan Gilbert > wrote: > > > > Hi, > > There's been quite a bit of discussion about where virtiofsd, our > > implemenation of a virtiofs daemon, should live. I'd like to get > > thi

Re: virtiofsd: Where should it live?

2019-11-26 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > >

Re: virtiofsd: Where should it live?

2019-11-26 Thread Marc-André Lureau
Hi David On Mon, Nov 25, 2019 at 10:50 PM Dr. David Alan Gilbert wrote: > > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. >

virtiofsd: Where should it live?

2019-11-25 Thread Dr. David Alan Gilbert
Hi, There's been quite a bit of discussion about where virtiofsd, our implemenation of a virtiofs daemon, should live. I'd like to get this settled now, because I'd like to tidy it up for the next qemu cycle. For reference it's based on qemu's livhost-user+chunks of libfuse. It can't live in li