Re: [Qemu-devel] [PATCH v2] qxl: bump pci rev

2011-07-08 Thread Gerd Hoffmann
Hi, -DEFINE_PROP_UINT32(revision, PCIQXLDevice, revision, 2), +DEFINE_PROP_UINT32(revision, PCIQXLDevice, revision, 3), Can't be done unconditionally. With an older libspice we can't support the rev3 features. cheers, Gerd

Re: [Qemu-devel] [PATCH v2] qxl: async I/O

2011-07-08 Thread Gerd Hoffmann
+void qxl_spice_update_area_async(PCIQXLDevice *qxl, uint32_t surface_id, + struct QXLRect *area, struct QXLRect *dirty_rects, + uint32_t num_dirty_rects, uint32_t clear_dirty_region, + int async) +{ +if (async) {

Re: [Qemu-devel] Upstream Qemu With Xen configuration problem

2011-07-08 Thread Daniel Castro
Date: Thu, 07 Jul 2011 14:29:43 -0400 From: John Baboval john.babo...@virtualcomputer.com To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Upstream Qemu With Xen configuration problem Message-ID: 4e15fb17.3030...@virtualcomputer.com Content-Type: text/plain; charset=ISO-8859-1;

Re: [Qemu-devel] SeaBIOS error with Juniper FreeBSD kernel

2011-07-08 Thread Bjørn Mork
Kevin O'Connor ke...@koconnor.net writes: On Thu, Jul 07, 2011 at 05:45:02PM +0200, Bjørn Mork wrote: It's been a while with little work and little progress on my side... But I looked at this again today, and found that it may be related to the SMBIOS table being allocated with malloc_high().

Re: [Qemu-devel] [PATCH 1/3] qemu: Add strtosz_suffix_unit function

2011-07-08 Thread Markus Armbruster
Joerg Roedel joerg.roe...@amd.com writes: This function does the same as the strtosz_suffix function except that it allows to specify the unit to which the k/M/B/T suffixes apply. This function will be used later to parse the tsc-frequency from the command-line. Signed-off-by: Joerg Roedel

Re: [Qemu-devel] [PATCH v2] qxl: async I/O

2011-07-08 Thread Gerd Hoffmann
The above two lines change was a mistake. What about: qxl_spice_update_area_async(...) { #ifdef .. if (async) { qxl-ssd.worker-update_area_async(...) } else { qxl_spice_update_area(...) } #else qxl_spice_update_area(...) #endif } I would do if (async) { #if ...

Re: [Qemu-devel] [PATCH v2] qxl: async I/O

2011-07-08 Thread Gerd Hoffmann
btw, I'm looking at #if.*MINOR code like #if SPICE_INTERFACE_CORE_MINOR= 3 (ui/spice-core.c) Shouldn't that be checking the MAJOR as well? major changing means a incompatible change. I doubt we ever will do that. But if you feel better checking that it probably should just be a #if

Re: [Qemu-devel] [PATCH v2] qxl: async I/O

2011-07-08 Thread Alon Levy
On Fri, Jul 08, 2011 at 09:17:50AM +0200, Gerd Hoffmann wrote: +void qxl_spice_update_area_async(PCIQXLDevice *qxl, uint32_t surface_id, + struct QXLRect *area, struct QXLRect *dirty_rects, + uint32_t num_dirty_rects, uint32_t

Re: [Qemu-devel] [PATCH v2] qxl: async I/O

2011-07-08 Thread Alon Levy
On Fri, Jul 08, 2011 at 09:17:50AM +0200, Gerd Hoffmann wrote: +void qxl_spice_update_area_async(PCIQXLDevice *qxl, uint32_t surface_id, + struct QXLRect *area, struct QXLRect *dirty_rects, + uint32_t num_dirty_rects, uint32_t

Re: [Qemu-devel] [PATCH v2] qxl: bump pci rev

2011-07-08 Thread Alon Levy
On Fri, Jul 08, 2011 at 09:19:10AM +0200, Gerd Hoffmann wrote: Hi, -DEFINE_PROP_UINT32(revision, PCIQXLDevice, revision, 2), +DEFINE_PROP_UINT32(revision, PCIQXLDevice, revision, 3), Can't be done unconditionally. With an older libspice we can't support the rev3

Re: [Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

2011-07-08 Thread Kevin Wolf
Am 07.07.2011 18:04, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e6d7adc..5f16a78 100644 --- a/qemu-options.hx +++

[Qemu-devel] [PATCH 2/3] ahci doesn't support migration

2011-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/ide/ich.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 054e073..0f26603 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -72,6 +72,11 @@ #include hw/ide/pci.h #include

[Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/hw.h |1 + savevm.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 3/3] ehci doesn't support migration

2011-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 91fb7de..a0449be 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -2136,9 +2136,15 @@ static USBBusOps ehci_bus_ops =

[Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Gerd Hoffmann
Hi, This patch series adds an easy way to tag devices as non-migratable puts it into use for ahci and ehci. Gerd Hoffmann (3): vmstate: add no_migrate flag to VMStateDescription ahci doesn't support migration ehci doesn't support migration hw/hw.h |1 + hw/ide/ich.c |6

[Qemu-devel] [Discuss] is it good to add codes providing information to libvirt about the qemu's capabilities

2011-07-08 Thread Wayne Xia
Currently libvirt seems to invoke qemu by qemu -help onetime, and then analysis the output text to find whether one type of device the qemu could support. For example, if qemu -help prints a text with -sdl then libvirt thought the qemu could accept that. But here comes a problem: the output

[Qemu-devel] [PATCH 02/23] usb: Add a usb_fill_port helper function

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 2abce12..776974e 100644 ---

[Qemu-devel] [PULL] usb patch queue

2011-07-08 Thread Gerd Hoffmann
Hi, Here is the current usb patch queue. Most noteworthy is the usb companion controller support added. There are also a bunch of bug fixes, some from Hans which he found while doing the companion controller work and some have been found in patch review. please pull, Gerd The following

[Qemu-devel] [PATCH 03/23] usb: Move (initial) call of usb_port_location to usb_fill_port

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Cleanup / preparation patch for companion controller support. Note that as a side-effect this patch also fixes the milkymist-softusb controller not having a port_location set for its ports. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH 14/23] usb-ohci: Add support for being a companion controller

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com To use as a companion controller, use pci-ohci as device and set the masterbus and num-ports properties, ie: -device usb-ehci,addr=0b.1,multifunction=on,id=ehci0 -device pci-ohci,addr=0b.0,multifunction=on,masterbus=ehci0.0,num-ports=4 Signed-off-by: Hans

[Qemu-devel] [PATCH 10/23] usb: assert on calling usb_attach(port, NULL) on a port without a dev

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com with the usb-ehci: cleanup port reset handling patch in place no callers are calling usb_attach(port, NULL) for a port where port-dev is NULL. Doing that makes no sense as that causes the port detach op to get called for a port with nothing attached. Add

[Qemu-devel] [PATCH 08/23] usb-ehci: Connect Status bit is read only, don't allow changing it by the guest

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 87e1de3..ce1a432 100644 ---

[Qemu-devel] [PATCH 04/23] usb: Add a register_companion USB bus op.

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This is a preparation patch for adding support for USB companion controllers. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c | 31 +++ hw/usb.h |5

[Qemu-devel] [PATCH 17/23] ehci: fix port count.

2011-07-08 Thread Gerd Hoffmann
The ICH4 EHCI controller which we emulate has six ports not four. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index ec68c29..0b959ca 100644 --- a/hw/usb-ehci.c +++

[Qemu-devel] [PATCH 11/23] usb-ehci: Fix handling of PED and PEDC port status bits

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com The PED bit should only be set for highspeed devices and the PEDC bit should not be set on normal PED bit changes, only on io errors. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 24

[Qemu-devel] [PATCH 01/23] hw/usb-musb.c: Don't misuse usb_packet_complete()

2011-07-08 Thread Gerd Hoffmann
From: Peter Maydell peter.mayd...@linaro.org In musb_packet() handle final processing of non-asynchronous USB packets by directly calling musb_schedule_cb() rather than going through usb_packet_complete(). The latter will trigger an assertion because the packet doesn't belong to a device.

[Qemu-devel] [PATCH 09/23] usb-ehci: cleanup port reset handling

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Doing a usb_attach when dev is NULL will just result in the port detach op getting called even though nothing was connected in the first place. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 15/23] pci: add ich9 usb controller ids

2011-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pci_ids.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index d94578c..927f2b0 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -109,5 +109,13 @@ #define PCI_DEVICE_ID_INTEL_82371AB

[Qemu-devel] [PATCH 22/23] usb-hub: remove unused descriptor arrays

2011-07-08 Thread Gerd Hoffmann
Somehow they where left over when converting the hub to the new usb descriptor infrastructure ... Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c | 68 -- 1 files changed, 0 insertions(+), 68 deletions(-) diff --git

[Qemu-devel] [PATCH 05/23] usb: Make port wakeup and complete ops take a USBPort instead of a Device

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This makes them consistent with the attach and detach ops, and in general it makes sense to make portops take a port as argument. This also makes adding support for a companion controller easier / cleaner. [ kraxel: fix usb-musb.c build ] Signed-off-by:

[Qemu-devel] [PATCH 07/23] usb-ehci: drop unused num-ports state member

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 96451f3..87e1de3 100644 ---

[Qemu-devel] [PATCH 19/23] usb: update documentation

2011-07-08 Thread Gerd Hoffmann
Add a paragraph on companion controller mode and a configuration file which sets it all up for you. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/ich9-ehci-uhci.cfg | 37 + docs/usb2.txt | 33 - 2 files

Re: [Qemu-devel] Qemu performance

2011-07-08 Thread Alexander Graf
On 08.07.2011, at 04:55, Lê Đức Tài wrote: On 30.06.2011, at 15:24, Alexander Graf ag...@suse.de wrote: On 30.06.2011, at 04:11, Lê Đức Tài letai_d...@yahoo.com.vn wrote: Thank for your answer. Beside nbench, I'm also using Dhrystone to measure the guest cpu performance.

[Qemu-devel] [PATCH 06/23] usb: Replace device_destroy bus op with a child_detach port op

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Note this fixes 2 things in one go, first of all the device_destroy bus op should be a device_detach bus op, as pending async packets from the device should be cancelled on detach not on destroy. Secondly having this as a bus op won't work with companion

[Qemu-devel] [PATCH 13/23] usb-uhci: Add support for being a companion controller

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com To use as a companion controller set the masterbus property. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c | 41 - 1 files changed, 36

[Qemu-devel] [PATCH 23/23] usb-ohci: raise interrupt on attach

2011-07-08 Thread Gerd Hoffmann
Got lost in commit 618c169b577db64ac6589ad48825d2e11760d1a6, add it back in. Also fix codestyle while we are at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ohci.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c

[Qemu-devel] [PATCH 12/23] usb-ehci: Add support for registering companion controllers

2011-07-08 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 174 +++-- 1 files changed, 144 insertions(+), 30 deletions(-) diff --git

[Qemu-devel] [PATCH 16/23] uhci: add ich9 controllers

2011-07-08 Thread Gerd Hoffmann
Add ich9 controllers, Factor out properties to a separate struct and reference it to reduce duplication. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c | 54 +++--- 1 files changed, 39 insertions(+), 15 deletions(-) diff --git

[Qemu-devel] [PATCH 20/23] usb_register_port(): do not set port-opaque and port-index twice

2011-07-08 Thread Gerd Hoffmann
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index c8347e9..f1dd55e 100644 ---

[Qemu-devel] [PATCH 18/23] ehci: add ich9 controller.

2011-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 43 +-- 1 files changed, 29 insertions(+), 14 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 0b959ca..a4758f9 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -2244,19

[Qemu-devel] [PATCH 21/23] usb: fixup bluetooth descriptors

2011-07-08 Thread Gerd Hoffmann
Commit 4696425cd05c7baa0a4b469d43ba4b8488bcfc0f changes some endpoints from isocrounous to interrupt by mistake. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bt.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/usb-bt.c

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Gerd Hoffmann
Hi, For scsi-cd and other empty-but-generally-migratable devices we should probably add an empty vmstate, so that any further addition can be done as subsections. That will break migration to older versions which don't know about the new sections, even if they are empty ... cheers,

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Paolo Bonzini
On 07/08/2011 10:53 AM, Gerd Hoffmann wrote: Hi, This patch series adds an easy way to tag devices as non-migratable puts it into use for ahci and ehci. Gerd Hoffmann (3): vmstate: add no_migrate flag to VMStateDescription ahci doesn't support migration ehci doesn't support

Re: [Qemu-devel] VGA pass through and AHCI emulation status

2011-07-08 Thread Alexander Graf
On 08.07.2011, at 10:25, Piwko, Maciej wrote: Hi, We are currently working on passing primary VGA to GOS and checking AHCI emulation. Therefore we are facing problem with that tasks. My questions are: 1. What is the status of VGA pass-through? Are there any known issues with that? Are

Re: [Qemu-devel] [PATCH] Add tee option to qemu char device

2011-07-08 Thread Chun Yan Liu
On Thursday, July 07, 2011 09:51:45 PM you wrote: On 07/07/2011 10:24 AM, Chunyan Liu wrote: In previous thread Support logging xen-guest console, it's considered that adding a tee option to char layer is a more generic way and makes more sense.

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Paolo Bonzini
On 07/08/2011 11:59 AM, Gerd Hoffmann wrote: For scsi-cd and other empty-but-generally-migratable devices we should probably add an empty vmstate, so that any further addition can be done as subsections. That will break migration to older versions which don't know about the new sections,

Re: [Qemu-devel] [PATCH] Add tee option to qemu char device

2011-07-08 Thread Alexander Graf
On 08.07.2011, at 12:17, Chun Yan Liu wrote: On Thursday, July 07, 2011 09:51:45 PM you wrote: On 07/07/2011 10:24 AM, Chunyan Liu wrote: In previous thread Support logging xen-guest console, it's considered that adding a tee option to char layer is a more generic way and makes more sense.

[Qemu-devel] [PATCH 0/1] QMP command for snapshot_blkdev

2011-07-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, I discussed the issue of a QMP command for live snapshot with Anthony, and we have agreed that it is fine to have a QMP command that matches the current human monitor command. This doesn't preclude that in the future someone may want to add support

[Qemu-devel] [PATCH 1/1] QMP: add snapshot_blkdev command

2011-07-08 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands and or a break down of the functionality into multiple commands might be added. Signed-off-by:

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Hi, For scsi-cd and other empty-but-generally-migratable devices we should probably add an empty vmstate, so that any further addition can be done as subsections. That will break migration to older versions which don't know about the new sections,

Re: [Qemu-devel] [Sheepdog] [PATCH] sheepdog: add data preallocation support

2011-07-08 Thread MORITA Kazutaka
At Wed, 06 Jul 2011 09:53:32 +0200, Kevin Wolf wrote: Am 05.07.2011 20:21, schrieb MORITA Kazutaka: + +max_idx = (vdi_size + SD_DATA_OBJ_SIZE - 1) / SD_DATA_OBJ_SIZE; + +for (idx = 0; idx max_idx; idx++) { +uint64_t oid; +oid = vid_to_data_oid(vid, idx); +

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Paolo Bonzini
On 07/08/2011 01:47 PM, Gerd Hoffmann wrote: scsi-cd is new in 0.15, older versions have scsi-disk only. That's why we should take the occasion to add the empty vmstate at least to it. Ok, good opportunity in that specific case. For other devices, it's better to make the breakage in a

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Gerd Hoffmann
Hi, scsi-cd is new in 0.15, older versions have scsi-disk only. That's why we should take the occasion to add the empty vmstate at least to it. Ok, good opportunity in that specific case. For other devices, it's better to make the breakage in a single version. It also allows to make 0.15

Re: [Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

2011-07-08 Thread Luiz Capitulino
On Fri, 08 Jul 2011 10:18:17 +0200 Kevin Wolf kw...@redhat.com wrote: Am 07.07.2011 18:04, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Gerd Hoffmann
Hi, If desired, in the future we can revert this behavior for pc-0.14 and earlier machines. And I'm still looking for a sane way to handle *this*. One possibility is to add device name remapping to machine types, like ide is actually ide-0.14 when using pc-0.14 and put a different VMState

[Qemu-devel] [PATCH 1/6] mips: sigaltstack args

2011-07-08 Thread Wesley W. Terpstra
The syscall sigaltstack takes two parameters, not zero. This patch should have no impact as only values above 4 influence the runtime behaviour. Nevertheless, it is wrong. Signed-off-by: Wesley W. Terpstra terps...@debian.org --- diff --git a/linux-user/main.c b/linux-user/main.c index

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Paolo Bonzini
On 07/08/2011 02:47 PM, Gerd Hoffmann wrote: One possibility is to add device name remapping to machine types, like ide is actually ide-0.14 when using pc-0.14 and put a different VMState in ide-0.14. That isn't very different from subsections. Problem is that the old qemu version doesn't

Re: [Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image

2011-07-08 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng famc...@gmail.com wrote: +        ret = sscanf(p, %10s %lld %10s %512s, [...] +            ret = sscanf(p, %10s %lld %10s %511s %lld, %512s - %511s But instead of duplicating the format string and sscanf(3), I suggest doing sscanf(p, %10s %lld %10s

Re: [Qemu-devel] migration: new sections and backward compatibility.

2011-07-08 Thread Jes Sorensen
On 07/07/11 09:30, Avi Kivity wrote: On 07/07/2011 10:14 AM, Gerd Hoffmann wrote: Can't we just implicitly fail migration whenever there's a device in the tree that doesn't have VMSTATE? There are cases where the device doesn't need to save state, so that alone doesn't cut it. It should

[Qemu-devel] [PATCH 3/6] mips: null pointer deref should segfault

2011-07-08 Thread Wesley W. Terpstra
Dereferencing a null pointer causes an exception 0xC (EXCP_AdEL) instead of EXCP_TLBL. This should also trigger a segfault. Signed-off-by: Wesley W. Terpstra terps...@debian.org --- diff --git a/linux-user/main.c b/linux-user/main.c index 289054b..26ebc73 100644 --- a/linux-user/main.c +++

[Qemu-devel] [PATCH 2/6] mips: missing syscall returns wrong errno

2011-07-08 Thread Wesley W. Terpstra
Return -TARGET_ENOSYS instead of -ENOSYS from linux-user/main.c * Caused strange 'Level 2 synchronization messages' instead of correctly reporting the syscall was missing. * Made glibc simply fail instead of using older syscalls Signed-off-by: Wesley W. Terpstra terps...@debian.org ---

[Qemu-devel] [PATCH 6/6] mips: eabi syscall support for 64-bit args

2011-07-08 Thread Wesley W. Terpstra
mips uses the eabi calling convention. For 64-bit values this means some registers are skipped. This patch replicates the behaviour of arm/eabi for mips targets. This affects ftruncate64, creating insane sized fails (or just failing). Signed-off-by: Wesley W. Terpstra terps...@debian.org ---

[Qemu-devel] [PATCH 4/6] mips: rlimit incorrectly converts values

2011-07-08 Thread Wesley W. Terpstra
Byte swap was applied in the wrong order with testing for RLIM_INFINITY. On mips bigendian from an amd64 system this results in infinity being misinterpretted as 2^31-1. This is a serious bug because it causes setrlimit stack size to kill all child processes. This means (for example) that 'make'

[Qemu-devel] [PATCH 5/6] mips: rlimit codes are not the same

2011-07-08 Thread Wesley W. Terpstra
The codes for get/setrlimit differ between linux target platforms. This patch adds conversion. This is important else programs (rsyslog, python, ...) can go into a near infinite loop trying to close all the file descriptors from 0 to -1. Signed-off-by: Wesley W. Terpstra terps...@debian.org ---

Re: [Qemu-devel] [PATCH 0/3] non-migratable devices

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 14:59, Paolo Bonzini wrote: On 07/08/2011 02:47 PM, Gerd Hoffmann wrote: One possibility is to add device name remapping to machine types, like ide is actually ide-0.14 when using pc-0.14 and put a different VMState in ide-0.14. That isn't very different from subsections.

[Qemu-devel] [PATCH 4/3] vmstate: complain about devices without vmstate

2011-07-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/hw.h |2 ++ hw/qdev.c |7 ++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 1eb3486..6d6c493 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -336,6 +336,8 @@ struct VMStateDescription { const

Re: [Qemu-devel] [PATCH v6 1/4] guest agent: command state class

2011-07-08 Thread Luiz Capitulino
On Tue, 5 Jul 2011 08:21:37 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile|4 ++- configure |1 + qga/guest-agent-command-state.c | 73

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Anthony Liguori
On 07/08/2011 03:53 AM, Gerd Hoffmann wrote: This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmannkra...@redhat.com register_device_unmigratable()? Regards,

Re: [Qemu-devel] [PATCH v6 2/4] guest agent: qemu-ga daemon

2011-07-08 Thread Luiz Capitulino
On Tue, 5 Jul 2011 08:21:38 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes the results back to the channel in a manner

Re: [Qemu-devel] migration: new sections and backward compatibility.

2011-07-08 Thread Peter Maydell
On 8 July 2011 14:02, Jes Sorensen jes.soren...@redhat.com wrote: It seems reasonable to me to introduce a situation where devices have to explicitly marked as migration compatible and fail if there are devices in the system which are not. To ask a dumb question: does migration here mean only

Re: [Qemu-devel] [PATCH v6 3/4] guest agent: add guest agent commands schema file

2011-07-08 Thread Luiz Capitulino
On Tue, 5 Jul 2011 08:21:39 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qapi-schema-guest.json | 204 1 files changed, 204 insertions(+), 0 deletions(-) create mode

Re: [Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands

2011-07-08 Thread Luiz Capitulino
On Tue, 5 Jul 2011 08:21:40 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-sync guest-ping guest-info guest-shutdown guest-file-open guest-file-read guest-file-write guest-file-seek

Re: [Qemu-devel] migration: new sections and backward compatibility.

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 16:43, Peter Maydell wrote: On 8 July 2011 14:02, Jes Sorensenjes.soren...@redhat.com wrote: It seems reasonable to me to introduce a situation where devices have to explicitly marked as migration compatible and fail if there are devices in the system which are not. To ask a dumb

Re: [Qemu-devel] [PATCH v8 00/12] Adding VMDK monolithic flat support

2011-07-08 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng famc...@gmail.com wrote: Chnages from v7:    03/12: remove deadloop in probing descriptor file. Fam Zheng (12):  VMDK: introduce VmdkExtent  VMDK: bugfix, align offset to cluster in get_whole_cluster  VMDK: probe for monolithicFlat images  VMDK:

Re: [Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats

2011-07-08 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng famc...@gmail.com wrote: Add create option 'format', with enums: The -drive format=... option exists in QEMU today to specify the image format of a file. I think adding a format=... creation option may lead to confusion. How about subformat=... or

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 16:26, Anthony Liguori wrote: On 07/08/2011 03:53 AM, Gerd Hoffmann wrote: This allows to easily tag devices as non-migratable, so any attempt to migrate a virtual machine with the device in question active will make migration fail. Signed-off-by: Gerd Hoffmannkra...@redhat.com

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 17:44, Gerd Hoffmann wrote: On 07/08/11 16:26, Anthony Liguori wrote: register_device_unmigratable()? Wanna have a patch to zap it? Ah, no, we can't, for ivshmem this isn't fixed but depends on the configuration, so a static flag in the VMStateDescription doesn't cut it.

[Qemu-devel] [PATCH v2 3/4] hw/omap_clk: Add the clock for the OMAP2430-specific fifth GPIO module

2011-07-08 Thread Peter Maydell
The OMAP2430 has a fifth GPIO module which earlier OMAP2 models lack; add the clock definition for it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/omap_clk.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/omap_clk.c b/hw/omap_clk.c index

[Qemu-devel] [PATCH v2 0/4] omap_gpio: convert to qdev

2011-07-08 Thread Peter Maydell
These patches are changes from the meego omap3 tree which convert the omap GPIO module device to use qdev. Changes v1-v2: * renamed omap_l4_base() to omap_l4_region_base() * provide two qdev devices 'omap-gpio' and 'omap2-gpio' rather than trying to shoehorn two significantly different

[Qemu-devel] [PATCH v2 1/4] hw/omap_l4.c: Add helper function omap_l4_region_base

2011-07-08 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Add helper function omap_l4_region_base() to return the base address of a particular region of an L4 target agent. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH v2 4/4] hw/omap_gpio.c: Convert to qdev

2011-07-08 Thread Peter Maydell
From: Juha Riihimäki juha.riihim...@nokia.com Convert the OMAP GPIO module to qdev. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com [Riku Voipio: Fixes and restructuring patchset] Signed-off-by: Riku Voipio riku.voi...@iki.fi [Peter Maydell: More fixes and cleanups for upstream

Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription

2011-07-08 Thread Anthony Liguori
On 07/08/2011 11:04 AM, Gerd Hoffmann wrote: On 07/08/11 17:44, Gerd Hoffmann wrote: On 07/08/11 16:26, Anthony Liguori wrote: register_device_unmigratable()? Wanna have a patch to zap it? Ah, no, we can't, for ivshmem this isn't fixed but depends on the configuration, so a static flag in

[Qemu-devel] qemu minimum memory requirements

2011-07-08 Thread Darren Hart
I'm trying to boot a fairly minimal x86 kernel image (5M uncompressed) with a small (11M) busybox rootfs in qemu with a minimum amount of memory. I'm able to reduce the memory available to qemu down to 21M and boot successfully, but below that, I get the following: $

[Qemu-devel] [PATCH v4] hw/pc: Support system flash memory with -pflash parameter

2011-07-08 Thread Jordan Justen
If -pflash is specified and -bios is specified then pflash will be mapped just below the system rom using hw/pflash_cfi01.c. If -pflash is specified on the command line, but -bios is not specified, then 'bios.bin' will NOT be loaded, and instead the -pflash flash image will be mapped just below

[Qemu-devel] smp-parse: smp-opt-cores for simple -smp X

2011-07-08 Thread Adam Lackorzynski
Hi, When just using a simple '-smp X', both the smp_cores and smp_threads variables are set to 1, which on x86 leads to CPUid-0x8008-ecx returning 1 for the CPU count despite more CPUs are there. Docs say 'Missing values will be computed.', so my try on this is the following. Comments?

Re: [Qemu-devel] [PATCH v6 1/4] guest agent: command state class

2011-07-08 Thread Michael Roth
On 07/08/2011 09:25 AM, Luiz Capitulino wrote: On Tue, 5 Jul 2011 08:21:37 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: Signed-off-by: Michael Rothmdr...@linux.vnet.ibm.com --- Makefile|4 ++- configure |1 +

[Qemu-devel] Fixed bug [Bug 38672] - bugzilla.kernel.org

2011-07-08 Thread Stefan BOSAK
Hello. Bug is in (xen-mapcache.c): Reported-by: Steve stefan.bo...@gmail.com Signed-off-by: Steve stefan.bo...@gmail.com diff --git a/xen-mapcache.c b/xen-mapcache.c index 57fe24d..1c3b5bf 100644 --- a/xen-mapcache.c +++ b/xen-mapcache.c @@ -107,7 +107,7 @@ void qemu_map_cache_init(void)

Re: [Qemu-devel] [PATCH v6 2/4] guest agent: qemu-ga daemon

2011-07-08 Thread Michael Roth
On 07/08/2011 09:36 AM, Luiz Capitulino wrote: On Tue, 5 Jul 2011 08:21:38 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: This is the actual guest daemon, it listens for requests over a virtio-serial/isa-serial/unix socket channel and routes them through to dispatch routines, and writes

Re: [Qemu-devel] [PATCH v6 3/4] guest agent: add guest agent commands schema file

2011-07-08 Thread Michael Roth
On 07/08/2011 10:08 AM, Luiz Capitulino wrote: On Tue, 5 Jul 2011 08:21:39 -0500 Michael Rothmdr...@linux.vnet.ibm.com wrote: Signed-off-by: Michael Rothmdr...@linux.vnet.ibm.com --- qapi-schema-guest.json | 204 1 files changed, 204

[Qemu-devel] PPC version of Fedora 12 on qemu

2011-07-08 Thread David Ahern
Has anyone successfully installed the PPC version of Fedora-12 in a qemu VM? So far I have been unsuccessful - with the installs failing on the bootloader. Running yabootconfig manually is failing. Should this work? I am using qemu.git, pulled this morning. Thanks, David

[Qemu-devel] Taking live snapshots of running VMs

2011-07-08 Thread Ahmed M. Azab
Hi All, Is there a way to take a live memory snapshot of a running VM without freezing or stopping this VM? I explored the Qemu code and documentation and I found two ways to take a snapshot: 1-Using savevm Qemu monitor command, which freezes the VM for tens of seconds 2-Using migrate and

[Qemu-devel] Votre site Web pour 999 DT seulement !

2011-07-08 Thread Votre agence Web
PROMOTION SITE WEB Du 21 juin au 8 juillet 2011 Nous proposons aux entreprises/associations une solution Internet clé en main à 999 Dinars. Grande ou petite, votre entreprise/association ne peut plus se passer d’un site internet si elle désire grandir et se faire connaitre du plus grand

Re: [Qemu-devel] [PATCH v2] Fix signal handling when io-thread is disabled

2011-07-08 Thread Alexandre Raymond
ping? On Tue, Jun 14, 2011 at 12:47 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-06-14 16:05, Alexandre Raymond wrote: Changes since v1: - take pthread_sigmask() out of the ifdef as it is now common to both parts. This fix effectively blocks, in the main thread, the signals handled

Re: [Qemu-devel] [PATCH] Fix signal handling of SIG_IPI when io-thread is enabled

2011-07-08 Thread Alexandre Raymond
ping? On Wed, Jun 15, 2011 at 10:11 AM, Alexandre Raymond cerb...@gmail.com wrote: Hi Jan, Why? Ahh, because of qemu_cpu_kick_self: raise(SIG_IPI)! That should generate a per-process SIG_IPI. And that may not only affect Darwin. Looks good. Actually, with io-thread enabled, it goes through

Re: [Qemu-devel] Qemu performance

2011-07-08 Thread Lê Đức Tài
On 08.07.2011, at 16:55, Alexander Graf ag...@suse.de wrote: I see. Qemu always gives you best performance, as it can't throttle the guest :). Btw, I'd be happy to merge your custom board (or at least some components of it if they are reasonably mainstream) upstream, if you think it makes