[Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/21 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

[Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_6_0

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/21 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH 7/9] openpic: avoid a warning from clang analyzer

2011-09-05 Thread Paolo Bonzini
On 09/04/2011 05:52 PM, Blue Swirl wrote: Avoid this warning by clang analyzer by defining a default case: /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value returned to caller return retval; Signed-off-by: Blue Swirlblauwir...@gmail.com --- hw/openpic.c |1 + 1 files

Re: [Qemu-devel] [PATCH v6 3/4] block: add block timer and block throttling algorithm

2011-09-05 Thread Zhi Yong Wu
On Thu, Sep 01, 2011 at 02:36:41PM +0100, Stefan Hajnoczi wrote: Date: Thu, 1 Sep 2011 14:36:41 +0100 Message-ID: CAJSP0QU8GqWsA6jaYAfs0=hvabqayfrpszrnctgp6geggpt...@mail.gmail.com From: Stefan Hajnoczi stefa...@gmail.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Content-Type: text/plain;

Re: [Qemu-devel] [PATCH 1/4] Probe for libcheck by default.

2011-09-05 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On 09/01/11 21:37, Anthony Liguori wrote: On 09/01/2011 10:42 AM, Gerd Hoffmann wrote: Probe for libcheck and build checks (if found) by default. Can be explicitly disabled using --disable-check-utests. Signed-off-by: Gerd Hoffmannkra...@redhat.com

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread Paolo Bonzini
On 09/04/2011 11:16 AM, Michael S. Tsirkin wrote: I mean argue for a richer set of barriers, with per-arch minimal implementations instead of the large but portable hammer of sync_synchronize, if you will. That's what I'm saying really. On x86 the richer set of barriers need not insert

[Qemu-devel] buildbot failure in qemu on monitor_x86_64_debian_6_0

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder monitor_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_x86_64_debian_6_0/builds/21 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/21 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH] monitor: Protect outbuf from concurrent access

2011-09-05 Thread Gerd Hoffmann
On 09/02/11 17:31, Paolo Bonzini wrote: On 09/02/2011 05:18 PM, Gerd Hoffmann wrote: Can you just use a bottom half to defer this work to the I/O thread? Bottom half scheduling has to be signal safe which means it will also be thread safe. Not that straight forward as I would have to pass

Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA

2011-09-05 Thread Michael S. Tsirkin
On Fri, Sep 02, 2011 at 02:38:25PM +1000, David Gibson wrote: I'd prefer the stubs to be inline. Not just as an optimization: it also makes it easier to grok what goes on in the common no-iommu case. To elaborate on my earlier mail. The problem with making them inlines is that the

Re: [Qemu-devel] [PATCH 0/4] add make check

2011-09-05 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Hi, This patch series intends to make unit testing easier. It adds a new make check target which can be used to run all unit tests which are currently in the tree. It also enables the unit tests by default, so you don't have to re-run configure

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2011 at 09:41:19AM +0200, Paolo Bonzini wrote: On 09/04/2011 11:16 AM, Michael S. Tsirkin wrote: I mean argue for a richer set of barriers, with per-arch minimal implementations instead of the large but portable hammer of sync_synchronize, if you will. That's what I'm

[Qemu-devel] [PATCH] qemu_vmalloc: align properly for transparent hugepages and KVM

2011-09-05 Thread Avi Kivity
To make good use of transparent hugepages, KVM requires that guest-physical and host-virtual addresses share the low 21 bits (as opposed to just the low 12 bits normally required). Adjust qemu_vmalloc() to honor that requirement. Ignore it for small regions to avoid fragmentation.

Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support

2011-09-05 Thread Stefan Hajnoczi
On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote: Changes: 02/06: Free extents on fail in vmdk_open. Added: 07/08: VMDK: bugfix, open Haiku vmdk image 08/08: VMDK: bugfix, opening vSphere 4 exported image Fam Zheng (8): VMDK: enable twoGbMaxExtentFlat VMDK:

Re: [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment

2011-09-05 Thread Kevin Wolf
Am 04.09.2011 17:47, schrieb Blue Swirl: Remove an unnecessary assignment, spotted by clang analyzer: /src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read offset += reqs[i].qiov-size; Signed-off-by: Blue Swirl blauwir...@gmail.com Acked-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Mon, Jul 04, 2011 at 12:43:58PM +0300, Michael S. Tsirkin wrote: This adds support for a standard pci to pci bridge, enabling support for more than 32 PCI devices in the system. To use, specify the device id as a 'bus' option. Example:

Re: [Qemu-devel] [PATCH v6 2/4] block: add the block queue support

2011-09-05 Thread Zhi Yong Wu
On Thu, Sep 01, 2011 at 02:02:41PM +0100, Stefan Hajnoczi wrote: 01 Sep 2011 06:02:41 -0700 (PDT) Received: by 10.220.200.77 with HTTP; Thu, 1 Sep 2011 06:02:41 -0700 (PDT) In-Reply-To: 1314877456-19521-3-git-send-email-wu...@linux.vnet.ibm.com References:

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-05 Thread Gerd Hoffmann
On 09/03/11 17:22, Stefan Hajnoczi wrote: String arguments are not supported by all trace backends. This patch replaces existing string arguments in hw/usb-ehci.c either with individual trace events that remain human-friendly or by printing raw addresses when there is no alternative or downside

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Avi Kivity
On 09/05/2011 11:38 AM, Edgar E. Iglesias wrote: We shouldn't really use the term IRQ as it's confusing. I like the term pin better because that describes what we're really talking about. qemu_irq is designed oddly today because is represents something that is intrinsically state

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Peter Maydell
On 5 September 2011 09:51, Avi Kivity a...@redhat.com wrote: On 09/05/2011 11:38 AM, Edgar E. Iglesias wrote: I don't agree. That's not what qemu_irq represents. It represents a wire, a mechanism to drive changes through logic paths between state. It is intrinsically stateless. It may be the

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Gerd Hoffmann
Hi, Hi, RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that triggers red_disconnect_channel (and as a result, reds_stream_free(dispatcher-stream)). red_disconnect_channel is called also when there is an error upon receive/send and also when timeouts related to the client occur

[Qemu-devel] qemu segfaults at start

2011-09-05 Thread octane indice
Hello I tried to use qemu on x86-32 in order to emulate x86-32bits. I did a: wget http://wiki.qemu.org/download/qemu-0.15.0.tar.gz tar zxvf qemu-0.15.0.tar.gz cd qemu-0.15.0 ./configure --enable-system --target-list=i386-softmmu make sudo make install then: qemu disk.img Segmentation fault I

[Qemu-devel] [PATCH 0/5] Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The number of registers needed for the return value of TCG opcode INDEX_op_call is calculated in function tcg_gen_callN (nb_rets). It can be 0 or 1, for 32 bit hosts also 2 (return 64 bit value in two 32 bit registers). Some TCG implementations reserve 2 registers although only 1 is used. The

[Qemu-devel] [PATCH 4/5] tcg/sparc: Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The second register is only needed for 32 bit hosts. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/sparc/tcg-target.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index

[Qemu-devel] [PATCH 2/5] tcg/ia64: Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The second register is never used for ia64 hosts. Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/ia64/tcg-target.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index

[Qemu-devel] [PATCH 5/5] tcg/ppc64: Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The second register is only needed for 32 bit hosts. Cc: Vassili Karpov av1...@comtv.ru Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/ppc64/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index

[Qemu-devel] [PATCH 3/5] tcg/s390: Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The second register is only needed for 32 bit hosts. Cc: Alexander Graf ag...@suse.de Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/s390/tcg-target.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index

[Qemu-devel] [PATCH 1/5] tcg/i386: Only one call output register needed for 64 bit hosts

2011-09-05 Thread Stefan Weil
The second register is only needed for 32 bit hosts. Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/i386/tcg-target.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 7529677..281f87d 100644 ---

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Avi Kivity
On 09/05/2011 12:02 PM, Peter Maydell wrote: I agree that qemu_irq is inherently stateless. But I do think there should be a way for the sink to query the line level. Whether it is implemented as a cache of the last qemu_set() level, or with callbacks that query the underlying state is

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2011 at 02:43:16PM +1000, David Gibson wrote: On Sun, Sep 04, 2011 at 12:16:43PM +0300, Michael S. Tsirkin wrote: On Sun, Sep 04, 2011 at 12:46:35AM +1000, David Gibson wrote: On Fri, Sep 02, 2011 at 06:45:50PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Edgar E. Iglesias
On Mon, Sep 05, 2011 at 11:51:01AM +0300, Avi Kivity wrote: On 09/05/2011 11:38 AM, Edgar E. Iglesias wrote: We shouldn't really use the term IRQ as it's confusing. I like the term pin better because that describes what we're really talking about. qemu_irq is designed oddly

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Avi Kivity
On 09/05/2011 12:22 PM, Edgar E. Iglesias wrote: (real hardware can query a line at any time, yes?) IMO, the query is just an upside-down way of thinking of it. What happens is, you change some state, and the state drives changes through a logic path towards new state that picks up the

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-05 Thread Fabien Chouteau
On 03/09/2011 11:25, Blue Swirl wrote: On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau chout...@adacore.com wrote: Gdb expects all registers windows to be flushed in ram, which is not the case in Qemu. Therefore the back-trace generation doesn't work. This patch adds a function to handle

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2011 at 10:17:01AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Jul 04, 2011 at 12:43:58PM +0300, Michael S. Tsirkin wrote: This adds support for a standard pci to pci bridge, enabling support for more than 32 PCI devices in the

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-05 Thread Paolo Bonzini
No, rmb and wmb need to generate code. If they do we'll have to surround each their use with ifndef x86 as you suggest later. Which is just messy. [1 hour later] I see what you mean now. You assume there are no accesses to write-combining memory (of course) or non-temporal load/stores

Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch

2011-09-05 Thread Avi Kivity
On 09/04/2011 05:03 PM, Avi Kivity wrote: On 08/22/2011 04:12 PM, Anthony Liguori wrote: This patch changes qemu_set_fd_handler to be implemented in terms of g_io_add_watch(). The semantics are a bit different so some glue is required. qemu_set_fd_handler2 is much harder to convert because

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Gerd Hoffmann
Hi, Looking... qdev_device_help() shows only device properties, not bus properties. I'd call that a bug. Hmm, but is bus a bus property? It isn't. bus= is handled by qdev core (id= too). addr= actually is a (pci) bus property. cheers, Gerd

Re: [Qemu-devel] [PATCH] qemu_vmalloc: align properly for transparent hugepages and KVM

2011-09-05 Thread Jan Kiszka
On 2011-09-05 10:07, Avi Kivity wrote: To make good use of transparent hugepages, KVM requires that guest-physical and host-virtual addresses share the low 21 bits (as opposed to just the low 12 bits normally required). Adjust qemu_vmalloc() to honor that requirement. Ignore it for small

Re: [Qemu-devel] [PATCH] qemu_vmalloc: align properly for transparent hugepages and KVM

2011-09-05 Thread Avi Kivity
On 09/05/2011 01:10 PM, Jan Kiszka wrote: On 2011-09-05 10:07, Avi Kivity wrote: To make good use of transparent hugepages, KVM requires that guest-physical and host-virtual addresses share the low 21 bits (as opposed to just the low 12 bits normally required). Adjust qemu_vmalloc() to

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Edgar E. Iglesias
On Sun, Sep 04, 2011 at 08:57:31AM -0500, Anthony Liguori wrote: On 09/04/2011 08:49 AM, Jan Kiszka wrote: On 2011-09-04 15:41, Anthony Liguori wrote: On 09/04/2011 08:36 AM, Jan Kiszka wrote: On 2011-09-04 15:32, Anthony Liguori wrote: I prefer to not think of IRQs as special things.

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Edgar E. Iglesias
On Mon, Sep 05, 2011 at 12:28:50PM +0300, Avi Kivity wrote: ... Query is needed when a line is masked internally, or when a device is hot-plugged. We can work around masking by caching the level in the device even though the line is masked, and querying the cache when the line is

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 11:02:43AM +0200, Gerd Hoffmann wrote: Hi, Hi, RED_WORKER_MESSAGE_DISPLAY_DISCONNECT is not the only place that triggers red_disconnect_channel (and as a result, reds_stream_free(dispatcher-stream)). red_disconnect_channel is called also when there is an error

Re: [Qemu-devel] [PATCH v4 00/32] target-xtensa: new target architecture

2011-09-05 Thread Edgar E. Iglesias
On Sun, Sep 04, 2011 at 06:35:10PM +, Blue Swirl wrote: On Thu, Sep 1, 2011 at 8:45 PM, Max Filippov jcmvb...@gmail.com wrote: This series adds support for Tensilica Xtensa target. Port status: Linux for DC232B works in the qemu.  Not implemented xtensa options: MAC16, floating point

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2011 at 11:53:11AM +0200, Gerd Hoffmann wrote: Hi, Looking... qdev_device_help() shows only device properties, not bus properties. I'd call that a bug. Hmm, but is bus a bus property? It isn't. bus= is handled by qdev core (id= too). addr= actually is a (pci) bus

Re: [Qemu-devel] Where to log xen_platform_log data

2011-09-05 Thread Stefano Stabellini
On Sat, 3 Sep 2011, Stefan Hajnoczi wrote: Hi Steven, The Xen platform PCI device has a logging feature that is currently implemented using trace_xen_platform_log(s-log_buffer). String arguments may not be supported by all trace backends so they should be avoided. For example, the simple

Re: [Qemu-devel] [PATCH v3] rbd: fix leak in qemu_rbd_open failure paths

2011-09-05 Thread Kevin Wolf
Am 04.09.2011 18:19, schrieb Sage Weil: Fix leak of s-snap in failure path. Simplify error paths for the whole function. Reported-by: Stefan Hajnoczi stefa...@gmail.com Signed-off-by: Sage Weil s...@newdream.net This depends on [PATCH v2] rbd: allow client id to be specified in config

Re: [Qemu-devel] [PATCH v4 00/32] target-xtensa: new target architecture

2011-09-05 Thread Max Filippov
I just had a very quick look and it Looks good to me too. Would be awesome if Max could provide something to test with in binary form. Maybe we could put it on the wiki's download page. Tarball of my current kernel and rootfs is available at

Re: [Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output

2011-09-05 Thread Kevin Wolf
Am 02.09.2011 18:38, schrieb Daniel P. Berrange: From: Daniel P. Berrange d...@berrange.com To aid in knowing whether a 'block_resize' was succesful, display the logical disk size in bytes, in the 'info block' output In v2: - Replace sectors with bytes Signed-off-by: Daniel P.

[Qemu-devel] KVM call agenda for September 6

2011-09-05 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

Re: [Qemu-devel] qemu segfaults at start

2011-09-05 Thread Stefan Hajnoczi
On Mon, Sep 5, 2011 at 10:04 AM, octane indice oct...@alinto.com wrote: qemu disk.img Segmentation fault Please post the backtrace as well as your host operating system version (e.g. Fedora 15): gdb --args qemu disk.img (gdb) r ...runs and crashes... (gdb) bt Stefan

Re: [Qemu-devel] QEMU online guest disk resize wrt host block devices

2011-09-05 Thread Kevin Wolf
Am 01.09.2011 17:56, schrieb Christoph Hellwig: On Thu, Sep 01, 2011 at 03:27:35PM +0100, Daniel P. Berrange wrote: One other question too, when creating a qcow2 image via 'qemu-img create' you can specify a 'prealloc' option to require metadata to be allocated at time of creation. Should we

[Qemu-devel] [PATCH] ppc405: use RAM_ADDR_FMT instead of %08lx

2011-09-05 Thread Stefan Hajnoczi
The RAM_ADDR_FMT macro hides the type of ram_addr_t so that format strings can be safely used. Make sure to use RAM_ADDR_FMT so that the build works on 32-bit hosts with Xen enabled. Whether Xen should affect ppc TCG targets is questionable but a separate issue. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-05 Thread Stefan Hajnoczi
On Mon, Sep 5, 2011 at 9:38 AM, Gerd Hoffmann kra...@redhat.com wrote: On 09/03/11 17:22, Stefan Hajnoczi wrote: String arguments are not supported by all trace backends.  This patch replaces existing string arguments in hw/usb-ehci.c either with individual trace events that remain

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-05 Thread Gerd Hoffmann
Hi, Let's drop this patch. I will update the tracing documentation. Great. thanks, Gerd

Re: [Qemu-devel] [PATCH] qemu-coroutine: Add simple work queue support

2011-09-05 Thread Kevin Wolf
Am 24.08.2011 09:57, schrieb Peter A. G. Crosthwaite: Add a function co_queue_yield_to_next() which will immediately transfer control to the coroutine at the head of a co queue. This can be used for implementing simple work queues where the manager of a co-queue only needs to restart queued

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Gerd Hoffmann
Hi, I verified it still calls reds_stream_free from the worker thread, only now the call itself is done in red_channel.c (via red_channel_disconnect or something like that), which is called from red_worker.c Where the code in red_channel.c is now shared for all channel types? Hmm. That

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: Hi, I verified it still calls reds_stream_free from the worker thread, only now the call itself is done in red_channel.c (via red_channel_disconnect or something like that), which is called from red_worker.c Where the code

Re: [Qemu-devel] [Spice-devel] [PATCH] server: don't call reds_stream_free from worker thread context

2011-09-05 Thread Alon Levy
On Mon, Sep 05, 2011 at 03:29:39PM +0200, Gerd Hoffmann wrote: Hi, I verified it still calls reds_stream_free from the worker thread, only now the call itself is done in red_channel.c (via red_channel_disconnect or something like that), which is called from red_worker.c Where the code

[Qemu-devel] required glib version? Re: [PATCH 2/6] Add base64 encoder/decoder

2011-09-05 Thread Gerd Hoffmann
On 08/26/11 17:47, Jan Kiszka wrote: On 2011-08-26 17:23, Jan Kiszka wrote: [ using glib base64 decoder ] Requires glib= 2.12, we are currently at= 2.0, right? Would it be OK to raise the entry barrier? In master it currently is = 2.20 due to v9fs_init_worker_threads using

[Qemu-devel] [PATCH] spice: set qxl-ssd.running=true before telling spice to start, RHBZ #733993

2011-09-05 Thread Yonit Halperin
If qxl-ssd.running=true is set after telling spice to start, the spice server thread can call qxl_send_events while qxl-ssd.running is still false. This leads to assert(d-ssd.running). Signed-off-by: Yonit Halperin yhalp...@redhat.com --- Since it looks like the purpose of the assert in

Re: [Qemu-devel] [RFC PATCH 0/5] Add configure flag to disable TCG

2011-09-05 Thread Stefano Stabellini
On Fri, 2 Sep 2011, Anthony Liguori wrote: Hi, There have been a few attempts in the past to allow TCG to be disabled at build time. Recently, Alex made the suggestion that we could do it by using the same trick that we used to introduce kvm support. That involves introducing a

Re: [Qemu-devel] [PATCH 5/5] tcg/ppc64: Only one call output register needed for 64 bit hosts

2011-09-05 Thread malc
On Mon, 5 Sep 2011, Stefan Weil wrote: The second register is only needed for 32 bit hosts. Cc: Vassili Karpov av1...@comtv.ru Signed-off-by: Stefan Weil w...@mail.berlios.de --- tcg/ppc64/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Stefan Hajnoczi
String arguments are useful for producing human-readable traces without post-processing (e.g. stderr backend). Although the simple backend cannot handles strings all others can. Strings should be allowed and the simple backend can be extended to support them. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 2/2] MAINTAINERS: add tracing subsystem

2011-09-05 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 508ea1e..ce189a4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -446,6 +446,12 @@ S: Maintained F: slirp/ T:

[Qemu-devel] [PATCH] scsi: fix accounting of writes

2011-09-05 Thread Paolo Bonzini
Writes go through scsi_write_complete at least twice, the first time to get some data without having actually written anything. Because of this, the first time scsi_write_complete is called it will call bdrv_acct_done and account a read incorrectly. Fix this by looking at the aiocb. I am doing

[Qemu-devel] [PATCH] qemu-options: Improve help texts for options which depend on configure

2011-09-05 Thread Stefan Weil
* Replace available only by the more common only available. * Tracing options depend on the configuration of the QEMU executable, so clarify the help text for both options. Cc: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-options.hx |

[Qemu-devel] [PATCH V12 12/15] hw/9pfs: chown in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add support to do chown in chroot process Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |9 + 3 files changed, 24 insertions(+), 4

[Qemu-devel] [PATCH V12 10/15] hw/9pfs: Move file post creation changes to none security model

2011-09-05 Thread M. Mohan Kumar
After creating a file object, its permission and ownership details are updated as per 9p client's request for both passthrough and none security model. But with chrooted environment its not required for passthrough security model. Move all post file creation changes to none security model.

[Qemu-devel] [PATCH V12 13/15] hw/9pfs: stat in chroot environment

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 52 - hw/9pfs/virtio-9p-chroot.c| 59 - hw/9pfs/virtio-9p-chroot.h|3 ++ hw/9pfs/virtio-9p-local.c | 30

[Qemu-devel] [PATCH V12 11/15] hw/9pfs: chmod in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add support to do chmod operation in chroot process. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c |5 +++-- 3 files changed, 22 insertions(+), 2

[Qemu-devel] [PATCH V12 05/15] hw/9pfs: Support for opening a file in chroot environment

2011-09-05 Thread M. Mohan Kumar
This patch adds both chroot worker and qemu side support to open a file/ directory in the chroot environment Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot.c | 29 hw/9pfs/virtio-9p-chroot.h |2 +- hw/9pfs/virtio-9p-local.c | 79

[Qemu-devel] [PATCH V12 04/15] hw/9pfs: qemu interfaces for chroot environment

2011-09-05 Thread M. Mohan Kumar
QEMU side interfaces to communicate with chroot worker process. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com [mala...@us.ibm.com: Handle when qemu process can not receive fd because it already reached max fds] --- Makefile.objs |2 +- hw/9pfs/virtio-9p-chroot.c | 103

[Qemu-devel] [PATCH V12 02/15] hw/9pfs: Enable CONFIG_THREAD if CONFIG_VIRTFS is enabled

2011-09-05 Thread M. Mohan Kumar
9p Chroot environment needs APIs defined in qemu-thread.c, so enable CONFIG_THREAD if virtfs is enabled Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 1340c33..ad59fcc 100755 ---

[Qemu-devel] [PATCH V12 03/15] hw/9pfs: Provide chroot worker side interfaces

2011-09-05 Thread M. Mohan Kumar
Implement chroot worker side interfaces like sending the file descriptor to qemu process, reading the object request from socket etc. Also add chroot main function and other helper routines. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com [mala...@us.ibm.com: Do not send fd as part of data,

[Qemu-devel] [PATCH 1/2] ptimer: move declarations to ptimer.h

2011-09-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/arm_timer.c|1 + hw/etraxfs_timer.c|1 + hw/grlib_apbuart.c|1 + hw/grlib_gptimer.c|1 + hw/lan9118.c |1 + hw/leon3.c|1 + hw/lm32_timer.c |1 + hw/mcf5206.c

[Qemu-devel] [PATCH V12 06/15] hw/9pfs: Create support in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add both chroot worker qemu side interfaces to create regular files in chroot environment Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 36 hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c

[Qemu-devel] [PATCH V12 00/15] virtio-9p: chroot environment for passthrough security model

2011-09-05 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. (http://en.wikipedia.org/wiki/Time-of-check-to-time-of-use) This patchset resolves this issue by creating a dedicated process which chroots into the share path and all file object

[Qemu-devel] [PATCH V12 07/15] hw/9pfs: Creating special files in chroot environment

2011-09-05 Thread M. Mohan Kumar
Add both chroot worker and qemu side interfaces to create special files (directory, device nodes, links and symbolic links) Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 52 + hw/9pfs/virtio-9p-chroot.h|5

[Qemu-devel] [PATCH V12 08/15] hw/9pfs: Removing file or directory in chroot environment

2011-09-05 Thread M. Mohan Kumar
Support for removing file or directory in chroot environment. Add interfaces to remove file/directory in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 18 ++ hw/9pfs/virtio-9p-chroot.h|1 +

[Qemu-devel] [PATCH V12 01/15] Implement qemu_read_full

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- osdep.c | 32 qemu-common.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 56e6963..5a4d670 100644 --- a/osdep.c +++ b/osdep.c @@ -126,6 +126,38 @@

[Qemu-devel] [PATCH V12 09/15] hw/9pfs: Rename in chroot environment

2011-09-05 Thread M. Mohan Kumar
Support renaming a file or directory in chroot envirnoment. Add interfaces for renaming in chroot worker and qemu side. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 17 + hw/9pfs/virtio-9p-chroot.h|1 +

[Qemu-devel] [PATCH V12 15/15] hw/9pfs: Chroot environment for other functions

2011-09-05 Thread M. Mohan Kumar
Add chroot functionality for system calls that can operate on a file using relative directory file descriptor. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-local.c | 41 +++-- 1 files changed, 39 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH V12 14/15] hw/9pfs: readlink in chroot environment

2011-09-05 Thread M. Mohan Kumar
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtio-9p-chroot-worker.c | 17 ++--- hw/9pfs/virtio-9p-chroot.h|1 + hw/9pfs/virtio-9p-local.c | 14 -- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V12 01/15] Implement qemu_read_full

2011-09-05 Thread malc
On Mon, 5 Sep 2011, M. Mohan Kumar wrote: Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- osdep.c | 32 qemu-common.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c index 56e6963..5a4d670 100644

Re: [Qemu-devel] qemu segfaults at start

2011-09-05 Thread Mulyadi Santosa
On 05/09/2011, octane indice oct...@alinto.com wrote: then: qemu disk.img Segmentation fault how about invoking it as: qemu -hda disk.img ? does that make any difference? perhaps adding -S too so we could find out whether it reach the very initial point. -- regards, Mulyadi Santosa

Re: [Qemu-devel] [PATCH 7/9] openpic: avoid a warning from clang analyzer

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 6:48 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 09/04/2011 05:52 PM, Blue Swirl wrote: Avoid this warning by clang analyzer by defining a default case: /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value returned to caller     return retval;

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 9:33 AM, Fabien Chouteau chout...@adacore.com wrote: On 03/09/2011 11:25, Blue Swirl wrote: On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau chout...@adacore.com wrote: Gdb expects all registers windows to be flushed in ram, which is not the case in Qemu. Therefore the

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 8:38 AM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Sat, Sep 03, 2011 at 02:53:31PM -0500, Anthony Liguori wrote: On 08/31/2011 11:59 AM, Blue Swirl wrote: On Wed, Aug 31, 2011 at 8:28 AM, Avi Kivitya...@redhat.com  wrote: On 08/30/2011 10:19 PM, Blue Swirl

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Blue Swirl
On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: String arguments are useful for producing human-readable traces without post-processing (e.g. stderr backend).  Although the simple backend cannot handles strings all others can.  Strings should be allowed and

Re: [Qemu-devel] [PATCH] g364fb: compile in hwlib

2011-09-05 Thread Hervé Poussineau
Blue Swirl a écrit : Compile g364fb in hwlib. Two compilations less for the full build. Signed-off-by: Blue Swirl blauwir...@gmail.com --- Makefile.objs|1 + Makefile.target |2 +- default-configs/mips-softmmu.mak |1 +

Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments

2011-09-05 Thread Jan Kiszka
On 2011-09-05 21:45, Blue Swirl wrote: On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: String arguments are useful for producing human-readable traces without post-processing (e.g. stderr backend). Although the simple backend cannot handles strings all

Re: [Qemu-devel] Now, what's left to non-developers? (Qemu forum down again, No such list qemu-users)

2011-09-05 Thread Stefan Weil
Am 19.08.2011 21:49, schrieb Anthony Liguori: On 08/19/2011 11:28 AM, Stefan Hajnoczi wrote: On Fri, Aug 19, 2011 at 2:26 PM, Ottaviopr0f3ss0r1...@yahoo.com wrote: On 19 August 2011 11:08, 陳韋任che...@iis.sinica.edu.tw wrote: Hi, Ottavio 2) The qemu-user mailing list is not active:

[Qemu-devel] buildbot failure in qemu on default_x86_64_fedora16

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_fedora16 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_fedora16/builds/16 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel5 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/0 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel5 Build

[Qemu-devel] buildbot failure in qemu on default_ppc

2011-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/144 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-ppc.opensuse.org Build

[Qemu-devel] [PATCH v5 17/33] target-xtensa: implement exceptions

2011-09-05 Thread Max Filippov
- mark privileged opcodes with ring check; - make debug exception on exception handler entry. Signed-off-by: Max Filippov jcmvb...@gmail.com --- cpu-exec.c|6 +++ target-xtensa/cpu.h | 67 target-xtensa/helper.c| 37 +++-

[Qemu-devel] [PATCH v5 29/33] target-xtensa: implement memory protection options

2011-09-05 Thread Max Filippov
- TLB opcode group; - region protection option (ISA, 4.6.3); - region translation option (ISA, 4.6.4); - MMU option (ISA, 4.6.5). Cache control attribute bits are not used by this implementation. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/cpu.h | 56 -

[Qemu-devel] [PATCH v5 16/33] target-xtensa: add PS register and access control

2011-09-05 Thread Max Filippov
Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/cpu.h | 53 - target-xtensa/helper.c|1 + target-xtensa/translate.c | 29 3 files changed, 77 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v5 30/33] target-xtensa: implement boolean option

2011-09-05 Thread Max Filippov
See ISA, 4.3.9 Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/cpu.h |1 + target-xtensa/translate.c | 109 +++-- 2 files changed, 86 insertions(+), 24 deletions(-) diff --git a/target-xtensa/cpu.h b/target-xtensa/cpu.h index

[Qemu-devel] [PATCH v5 25/33] target-xtensa: implement accurate window check

2011-09-05 Thread Max Filippov
See ISA, 4.7.1.3 for details. Window check is inserted before commands that push used register watermark beyond its current level. Used register watermark is reset on instructions that change WINDOW_BASE/WINDOW_START SRs. Signed-off-by: Max Filippov jcmvb...@gmail.com ---

  1   2   >