[Qemu-devel] [PATCH] qcow2: Fix return value of alloc_refcount_block

2012-04-18 Thread Kevin Wolf
Someone forgot something in commit 29c1a730... Documenting the right return value is not enough, you also need to actually return it in the code. This bug sometimes causes error return values even when everything has succeeded: The new offset of the refcount block is truncated to 32 bits and inter

[Qemu-devel] [PATCH 3/9] tracetool: Add module for the 'h' format

2012-04-18 Thread Stefan Hajnoczi
From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/format/h.py | 45 + 1 file changed, 45 insertions(+) create mode 100644 scripts/tracetool/format/h.py diff --git a/scripts/tracetool/format/h.py b

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Add LRU page cache mechanism. > The page are accessed by their address. > > + > +typedef struct CacheItem { > +ram_addr_t it_addr; > +unsigned long it_age; > +uint8_t *it_data; > +} CacheItem; > + > +typedef struct CacheBucket { > +CacheItem bkt_item[CACHE_N

Re: [Qemu-devel] [PATCH] qcow2: Fix return value of alloc_refcount_block

2012-04-18 Thread Paolo Bonzini
Il 18/04/2012 16:35, Kevin Wolf ha scritto: > Someone forgot something in commit 29c1a730... Documenting the right > return value is not enough, you also need to actually return it in the > code. > > This bug sometimes causes error return values even when everything has > succeeded: The new offset

Re: [Qemu-devel] [PATCH v9 02/10] Add uleb encoding/decoding functions

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Implement Unsigned Little Endian Base 128. > > Signed-off-by: Orit Wasserman > + > +/* ULEB128 */ Can we add at least an url to what ULEB128 is? https://en.wikipedia.org/wiki/LEB128 Rest is ok. Thanks, Juan.

Re: [Qemu-devel] [PATCH v6 1/5] sockets: change inet_connect() to support nonblock socket

2012-04-18 Thread Michael Roth
On Wed, Apr 18, 2012 at 10:49:02AM +0800, Amos Kong wrote: > On 18/04/12 10:10, Michael Roth wrote: > >On Tue, Apr 17, 2012 at 10:54:01PM +0800, Amos Kong wrote: > >>Add a bool argument to inet_connect() to assign if set socket > >>to block/nonblock, and delete original argument 'socktype' > >>that

Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman Review-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 0/2] ide: convert pio code path to asynchronous I/O

2012-04-18 Thread Kevin Wolf
Am 29.03.2012 11:31, schrieb Stefan Hajnoczi: > IDE PIO mode is currently implemented using synchronous I/O functions. > There's > no need to do this because the IDE interface is actually designed with polling > and interrupts in mind - we can do asynchronous I/O and let the guest know > when >

Re: [Qemu-devel] [PATCH v9 04/10] Add host_from_stream_offset_versioned function

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > --- > arch_init.c | 26 +++--- > 1 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/arch_init.c b/arch_ini

Re: [Qemu-devel] [PATCH v9 05/10] Add MigrationParams structure

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Isaku Yamahata Reviewed-by: Juan Quintela Thought about doing something like that several times. Thanks.

[Qemu-devel] [PATCH 4/9] tracetool: Add support for the 'stderr' backend

2012-04-18 Thread Stefan Hajnoczi
From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/stderr.py | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 scripts/tracetool/backend/stderr.py diff --git a/scripts/tracetool/backend

Re: [Qemu-devel] [PATCH 2/2] [trivial] Simpler handling of tracetool-generated files in makefiles

2012-04-18 Thread Stefan Hajnoczi
On Wed, Apr 18, 2012 at 2:45 PM, Lluís Vilanova wrote: > If not, I'll just drop it and instead simply replace calls to tracetool with > "$(TRACETOOL)". If you're willing to do this I would prefer it. Thanks, Stefan

Re: [Qemu-devel] [PATCH 1/2] [trivial] Generic elimination of auto-generated files

2012-04-18 Thread Andreas Färber
Am 18.04.2012 16:11, schrieb Stefan Hajnoczi: > On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >>> On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote: -rm -f $(GENERATED_HEADERS) -rm -f $(GENERATED_SOURCES) +rm -f $(forea

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3] PPC: Fix interrupt MSR value for classic exception models.

2012-04-18 Thread Alexander Graf
On 04/13/2012 06:53 PM, Mark Cave-Ayland wrote: On 11/04/12 02:08, David Gibson wrote: Hi David, Commit 41557447d30eeb944e42069513df13585f5e6c7f introduced a new method of calculating the MSR for the interrupt context. However this doesn't quite agree with the PowerISA 2.06B specification (pp

Re: [Qemu-devel] [PATCH 1/2] [trivial] Generic elimination of auto-generated files

2012-04-18 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >>> On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote: -    rm -f $(GENERATED_HEADERS) -    rm -f $(GENERATED_SOURCES) +    rm -f $(foreach f,$(GENERATED_HEA

Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

2012-04-18 Thread Eric Blake
On 04/18/2012 03:37 AM, Wen Congyang wrote: >>> 2. This command doesn't support the fd that is is associated with a pipe, >>> socket, or FIFO(lseek will fail with such fd). >> >> How hard would it be to lift that restriction ? When libvirt does save to >> file, or core dump these days, we te

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-18 Thread Alexander Graf
On 04/15/2012 06:14 PM, Andreas Färber wrote: Am 13.04.2012 14:00, schrieb Meador Inge: On 04/13/2012 06:40 AM, Andreas Färber wrote: Am 12.04.2012 19:24, schrieb Scott Wood: On 04/12/2012 11:59 AM, Andreas Färber wrote: Am 10.04.2012 22:04, schrieb Meador Inge: commit f7aa558396dd0f6b7a2b2

Re: [Qemu-devel] [PATCH 1/2] [trivial] Generic elimination of auto-generated files

2012-04-18 Thread Lluís Vilanova
Andreas Färber writes: > Am 18.04.2012 16:11, schrieb Stefan Hajnoczi: >> On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova wrote: >>> Stefan Hajnoczi writes: >>> On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote: > -rm -f $(GENERATED_HEADERS) > -rm -f $(GENERATED

Re: [Qemu-devel] [PATCH RFC 4/6] target-i386: convert cpu to 2-stage initialization

2012-04-18 Thread Igor Mammedov
On 04/17/2012 01:37 AM, Igor Mammedov wrote: From: Igor Mammedov Use realize to start a cpu prepared by x86_cpu_initfn. v2: Create apic for cpu only once. Signed-off-by: Igor Mammedov --- hw/pc.c | 35 - target-i386/cpu.c| 69

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Orit Wasserman
On 04/18/2012 05:34 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> Add LRU page cache mechanism. >> The page are accessed by their address. >> >> + >> +typedef struct CacheItem { >> +ram_addr_t it_addr; >> +unsigned long it_age; >> +uint8_t *it_data; >> +} CacheItem; >> + >> +type

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-18 Thread Scott Wood
On 04/18/2012 10:40 AM, Alexander Graf wrote: > On 04/15/2012 06:14 PM, Andreas Färber wrote: >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >> index 86a915c..ba4b84d 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -4462,36 +4462,32

Re: [Qemu-devel] [PATCH v9 06/10] Add XBZRLE to ram_save_block and ram_save_live

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > @@ -104,6 +104,7 @@ const uint32_t arch_type = QEMU_ARCH; > #define RAM_SAVE_FLAG_PAGE 0x08 > #define RAM_SAVE_FLAG_EOS 0x10 > #define RAM_SAVE_FLAG_CONTINUE 0x20 > +#define RAM_SAVE_FLAG_XBZRLE 0x40 missing space for alignment? > > #ifdef __ALTIVEC__ >

Re: [Qemu-devel] [PATCH v9 07/10] Add XBZRLE option to migrate command

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > --- > hmp-commands.hx | 20 > hmp.c|4 +++- > migration.c |9 + > qapi-schema.json |

Re: [Qemu-devel] [PATCH v9 08/10] Add migration capabilites

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Add migration capabiltes that can be queried by the management. > The managment can query to source and the destination in order to > verify both support some maigration capability (currently only XBZRLE). s/maigration/migration. ok with me. > diff --git a/savevm.c b/sav

[Qemu-devel] how to use the s390 emulation?

2012-04-18 Thread Anonymous
Hello All, Can anyone please explain how I can use the s390 emulation of qemu on a Intel Linux host? TIA

[Qemu-devel] [Bug 984953] [NEW] qemu-img alters (breaks) disk image content when converting to VDI

2012-04-18 Thread Volker Grabsch
Public bug reported: When using "qemu-img convert" to create a VDI image, the VDI image is valid, but may contain an altered disk image. When such an image is run under VirtualBox, subtle bugs such as spontaneous segmentation faults happen because of broken system libraries. The following set of

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2012-04-18 Thread Michael Tokarev
Oh. The fix is part of 0.12.5 stable series, also debian #580649 . Well, it fixed the issue for me and for original reporter of #580649, and it was a real bug and fix. So I don't think it is the same issue. And again, please verify if this issue is still present in latest release. I'm not sure

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2012-04-18 Thread Michael Tokarev
And the original issue is indeed very different: without that fix you'd never see your guest UNstucking when you migrate it back. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/585113 Title: e1000 i

Re: [Qemu-devel] [PATCH v9 09/10] Add set_cachesize command

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > +.name = "migrate_set_cachesize", > +.args_type = "value:o", This mean that we can assign values like 256M, rig

Re: [Qemu-devel] [PATCH v9 10/10] Add XBZRLE statistics

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v9 00/10] XBZRLE delta for live migration of large memory app

2012-04-18 Thread Anthony Liguori
Hi, Just to avoid any 1.1 migration "surprises", I view this series as 1.2 material. I'm reluctant to make any protocol changes this late in the release process (assuming this series got all the necessary review/ack in the next 1.5 weeks). If anyone has a strong feeling differently, now's th

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- arch_init.c | 220 ++

Re: [Qemu-devel] [PATCH v9 02/10] Add uleb encoding/decoding functions

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- migration.h |4 savevm.c| 28 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/migration.h b/migration.h index

Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- arch_init.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/a

Re: [Qemu-devel] [PATCH v9 04/10] Add host_from_stream_offset_versioned function

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman ENOEXPLANATION The indentation is wrong in this patch and the commit message needs to explain what's going on here. BTW, SoB is

Re: [Qemu-devel] [PATCH v9 05/10] Add MigrationParams structure

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Isaku Yamahata If you're not going to SoB this patch, please make sure you set the GIT_AUTHOR appropriately so that there's a From line for Isaku. Otherwise it will mess up git history (you will be the author but will not have a So

Re: [Qemu-devel] [PATCH v9 06/10] Add XBZRLE to ram_save_block and ram_save_live

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Add migration state to store XBRLE params (enablement and cache size). In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_

Re: [Qemu-devel] [PATCH v9 07/10] Add XBZRLE option to migrate command

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- hmp-commands.hx | 20 hmp.c|4 +++- migration.c |9 + qapi-schema.js

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2012-04-18 Thread Michael Tokarev
Which fix you're talking about? I don't remember seeing any backporting to 0.12 or even identifcation of the commit which fixed this issue, and don't remember adding it to debian qemu-kvm package. Was there a fix? Thanks, /mjt -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH v9 08/10] Add migration capabilites

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Add migration capabiltes that can be queried by the management. The managment can query to source and the destination in order to verify both support some maigration capability (currently only XBZRLE). Signed-off-by: Orit Wasserman Ah, excellent.

Re: [Qemu-devel] [PATCH v9 09/10] Add set_cachesize command

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman

Re: [Qemu-devel] [PATCH v9 10/10] Add XBZRLE statistics

2012-04-18 Thread Anthony Liguori
On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- arch_init.c | 68 +++

Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function

2012-04-18 Thread Juan Quintela
Anthony Liguori wrote: > On 04/11/2012 01:49 PM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> --- >> arch_init.c | 26 ++ >> 1 files changed, 14 insertions(+),

Re: [Qemu-devel] [PATCH v9 01/10] Add cache handling functions

2012-04-18 Thread Juan Quintela
Orit Wasserman wrote: > On 04/18/2012 05:34 PM, Juan Quintela wrote: >>> +assert(cache_num_buckets); >>> +DPRINTF("Setting cache buckets to %lu\n", cache_num_buckets); >>> + >>> +assert(!page_cache); >> >> Only user of this function make page_cache = NULL before calling. >> Returning

Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function

2012-04-18 Thread Anthony Liguori
On 04/18/2012 12:40 PM, Juan Quintela wrote: Anthony Liguori wrote: On 04/11/2012 01:49 PM, Orit Wasserman wrote: Signed-off-by: Orit Wasserman Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman --- arch_init.c | 26 ++ 1 files

Re: [Qemu-devel] [PATCH 00/12 v13] introducing a new, dedicated guest memory dump mechanism

2012-04-18 Thread Wen Congyang
On 04/18/2012 09:03 PM, Wen Congyang wrote: At 04/18/2012 08:49 PM, Wen Congyang Wrote: Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html The last version is here: ht

Re: [Qemu-devel] [PATCH 12/12 v12] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

2012-04-18 Thread Wen Congyang
On 04/18/2012 11:35 PM, Eric Blake wrote: On 04/18/2012 03:37 AM, Wen Congyang wrote: 2. This command doesn't support the fd that is is associated with a pipe, socket, or FIFO(lseek will fail with such fd). How hard would it be to lift that restriction ? When libvirt does save to file

[Qemu-devel] [Bug 984953] Re: qemu-img alters (breaks) disk image content when converting to VDI

2012-04-18 Thread Volker Grabsch
** Description changed: When using "qemu-img convert" to create a VDI image, the VDI image is valid, but may contain an altered disk image. When such an image is run under VirtualBox, subtle bugs such as spontaneous segmentation faults happen because of broken system libraries. The fo

[Qemu-devel] [Bug 585113] Re: e1000 irq problems after live migration with qemu-kvm 0.12.4

2012-04-18 Thread Angelo Pantano
Unfortunately I cannot confirm the fix, as in version: ii qemu-kvm0.12.5+dfsg-5+squeeze8 the guest is a karmic 9.10 when I live migrate it from serverA (dell poweredge r210) to serverB (dual core intel 3.20GHz) my guest gets always stuck, oddly enough this does not

[Qemu-devel] [Bug 984953] Re: qemu-img alters (breaks) disk image content when converting to VDI

2012-04-18 Thread Volker Grabsch
** Attachment added: "Example disk image that triggers the bug" https://bugs.launchpad.net/bugs/984953/+attachment/3089614/+files/test-2M-2.raw.bz2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/98

[Qemu-devel] [PATCH v2 0/2] [trivial] More concise handling of tracetool-generated files

2012-04-18 Thread Lluís Vilanova
Some trivial changes to handle tracetool-generated files more concisely. Signed-off-by: Lluís Vilanova --- NOTE: Applies on top of the tracetool rewrite. Changes in v2: * Only remove tracetool-generated files that were actually produced by the top-level makefile. * Dropped tracetool-gen and t

[Qemu-devel] [PATCH v2 1/2] [trivial] Generic elimination of auto-generated files

2012-04-18 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 135cb72..5dd2a8c 100644 --- a/Makefile +++ b/Makefile @@ -23,7 +23,7 @@ ifeq ($(TRACE_BACKEND),dtrace) GENERATED_HEADERS += trace-dtrace.h endif G

[Qemu-devel] [PATCH v2 2/2] [trivial] Beautify makefile commands for generation of files with tracetool

2012-04-18 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs | 22 +++--- Makefile.target |4 ++-- rules.mak |3 +++ 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 6d6f24d..70c5c79 100644 --- a/Makefile.objs +++ b/Makefile.

[Qemu-devel] [Bug 984953] Re: qemu-img alters (breaks) disk image content when converting to VDI

2012-04-18 Thread Stefan Weil
Which version of QEMU did you use? I think your report is a duplicate of bug report #919242. It was fixed by this commit: commit 641543b76b82a8b361482b727e08de0c8ec093b0 Author: Stefan Weil Date: Sat Jan 21 13:54:24 2012 +0100 block/vdi: Zero unused parts when allocating a new block (fix #

Re: [Qemu-devel] [PATCH v2 0/5] tcg-mips: Use TCG registers for the FPU

2012-04-18 Thread Richard Henderson
On 03/30/2012 12:05 PM, Richard Henderson wrote: > This is a re-base of a patch set sent in December. The only > real changes are CPUState -> CPUMIPSState. The commit message > for patch 4 describe the real intent. > > This patch set is also available at > > git://repo.or.cz/qemu/rth.git rth/

Re: [Qemu-devel] [PATCH v2] target-mips: Implement Loongson Multimedia Instructions

2012-04-18 Thread Richard Henderson
On 03/30/2012 12:13 PM, Richard Henderson wrote: > Implements all of the COP2 instructions except for the S > family of comparisons. The documentation is unclear for those. > > Signed-off-by: Richard Henderson Ping. r~

Re: [Qemu-devel] [PATCH v2 0/2] QOM'ify MIPS CPU

2012-04-18 Thread Richard Henderson
On 04/15/2012 08:41 PM, Andreas Färber wrote: > Hello, > > This series strips down my MIPS QOM'ification patch from the qom-cpu-others > RFC series. Subclasses are postponed. > > I've also left out code movement from cpu_state_reset() into the CPU reset > function since the reset code accesses mi

Re: [Qemu-devel] [PATCH v2 0/2] misc MIPS improvments

2012-04-18 Thread Richard Henderson
On 03/30/2012 12:16 PM, Richard Henderson wrote: > Extracted and rebased from a larger patch set from December. > > Available as > >git://repo.or.cz/qemu/rth.git rth/mips/next Ping. r~

Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-18 Thread malc
On Wed, 18 Apr 2012, Gerd Hoffmann wrote: > Hi, > > [ adding seabios list to Cc:, topic is the missing vesa 2.0 protected > mode interface in seavgabios ] > > >> Pointer? > >> I'd like to have a test case which breaks with the new vgabios. > > > > We talked with malc briefly on irc yesterda

[Qemu-devel] [PATCH 2/2] qemu-ga: suspend: handle EINTR

2012-04-18 Thread Luiz Capitulino
The read() call in bios_supports_mode() can fail with EINTR if a child terminates during the call. Handle it. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c ind

[Qemu-devel] [PATCH 0/2]: qemu-ga: fix possible SIGCHLD related bugs

2012-04-18 Thread Luiz Capitulino
Please, check individual patches for details. qga/commands-posix.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function

2012-04-18 Thread Eric Blake
On 04/18/2012 11:45 AM, Anthony Liguori wrote: >> >>> I thought I had previously asked for a monitor command to negotiate >>> extensions for migration? >> >> I think it is in another patch. > > So I think we also need: > > { 'command': 'set-migration-capabilities', > 'data': { 'enable': ['Mig

[Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir

2012-04-18 Thread Eduardo Habkost
The variable is used for the qemu-specific directory and has a different meaning of the autoconf "datadir" variable (that's used for the $prefix/share directory, not for $prefix/share/PACKAGE). This doesn't change behavior or interfaces, it's just an internal variable rename. Signed-off-by: Eduar

[Qemu-devel] [PATCH 03/14] configure: rename $confdir to $qemu_confdir

2012-04-18 Thread Eduardo Habkost
There's no "confdir" variable on Autoconf, but it's good to make it clear that it's a variable for the Qemu-specific subdirectory inside $sysconfdir. Signed-off-by: Eduardo Habkost --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure ind

[Qemu-devel] [PATCH 07/14] Makefile: use $(qemu_confdir) instead of $(sysconfdir)/qemu

2012-04-18 Thread Eduardo Habkost
Instead of hardcoding the directory suffix, use the qemu-specific directory variable. Signed-off-by: Eduardo Habkost --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c8e4b53..a9bc796 100644 --- a/Makefile +++ b/Makefile @@ -281,8

Re: [Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir

2012-04-18 Thread Eric Blake
On 04/18/2012 01:55 PM, Eduardo Habkost wrote: > The variable is used for the qemu-specific directory and has a different > meaning of the autoconf "datadir" variable (that's used for the > $prefix/share directory, not for $prefix/share/PACKAGE). Automake uses the name $pkgdatadir for $prefix/shar

[Qemu-devel] [PATCH 2/5] eliminate arch_config_name variable

2012-04-18 Thread Eduardo Habkost
Not needed anymore, as the code that uses the variable is already inside arch_init.c. Signed-off-by: Eduardo Habkost --- arch_init.c |3 +-- arch_init.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 4008115..152cbbb 100644 --- a/arc

[Qemu-devel] [PATCH 1/5] move code to read default config files to a separate function

2012-04-18 Thread Eduardo Habkost
Function added to arch_init.c because it depends on arch-specific settings. Signed-off-by: Eduardo Habkost --- arch_init.c | 18 ++ arch_init.h |4 vl.c| 10 ++ 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCH 0/5] -no-user-config option, move CPU models to /usr/share

2012-04-18 Thread Eduardo Habkost
This is the first try of the new -no-user-config option. Patches 1 to 3 just move some code around, patch 4 just adds the new option without adding any new config file. Patch 5 finally creates a /usr/share/qemu /cpus-x86_64.conf file, with the CPU models we currently have on Qemu. Reference to pr

Re: [Qemu-devel] [RFC PATCH 1/3] iommu: Introduce iommu_group

2012-04-18 Thread Alex Williamson
On Wed, 2012-04-18 at 19:58 +1000, David Gibson wrote: > On Mon, Apr 02, 2012 at 03:14:40PM -0600, Alex Williamson wrote: > > IOMMUs often do not have visibility of individual devices in the > > system. Due to IOMMU design, bus topology, or device quirks, we > > can often only identify groups of d

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: suspend: handle EINTR

2012-04-18 Thread Peter Maydell
On 18 April 2012 20:30, Luiz Capitulino wrote: > The read() call in bios_supports_mode() can fail with EINTR if a child > terminates during the call. Handle it. > > Signed-off-by: Luiz Capitulino > --- >  qga/commands-posix.c |   12 >  1 file changed, 8 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 01/14] configure: rename $datadir to $qemu_datadir

2012-04-18 Thread Eduardo Habkost
On Wed, Apr 18, 2012 at 01:57:51PM -0600, Eric Blake wrote: > On 04/18/2012 01:55 PM, Eduardo Habkost wrote: > > The variable is used for the qemu-specific directory and has a different > > meaning of the autoconf "datadir" variable (that's used for the > > $prefix/share directory, not for $prefix/

[Qemu-devel] [PATCH 1/2] qemu-ga: suspend: fix possible SIGCHLD during close() and g_free()

2012-04-18 Thread Luiz Capitulino
A child created by bios_supports_mode() could terminate during the call to close() or g_free(). This could cause the SIGCHLD signal to be deliveried in the midle of their execution. Possible problems range from resource leak to segfault. Fix that by blocking SIGCHLD during those calls. Also, tries

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-18 Thread Andreas Färber
Am 18.04.2012 17:40, schrieb Alexander Graf: > On 04/15/2012 06:14 PM, Andreas Färber wrote: >> Am 13.04.2012 14:00, schrieb Meador Inge: >>> On 04/13/2012 06:40 AM, Andreas Färber wrote: >>> Am 12.04.2012 19:24, schrieb Scott Wood: > On 04/12/2012 11:59 AM, Andreas Färber wrote: >> Am

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-04-18 Thread Blue Swirl
On Wed, Apr 18, 2012 at 02:49, 陳韋任 wrote: > On Tue, Apr 17, 2012 at 08:17:09PM +, Blue Swirl wrote: >> On Tue, Apr 17, 2012 at 05:40, Xin Tong wrote: >> > that is possible. but if that is the case, why not split the tlb >> > walking and the tlb fill ? can anyone please confirm ? >> >> I sent

[Qemu-devel] [PATCH 09/14] config-host.mak: remove CONFIG_QEMU_SHAREDIR

2012-04-18 Thread Eduardo Habkost
There is no code using that variable according to 'git grep', so kill it. Signed-off-by: Eduardo Habkost --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 33b7a25..3a38d28 100755 --- a/configure +++ b/configure @@ -3002,7 +3002,6 @

[Qemu-devel] [PATCH 06/14] config-host.mak: rename confdir to qemu_confdir

2012-04-18 Thread Eduardo Habkost
$confdir is a confusing name, as it's not clear if it's "the system config dir" or "the Qemus-specific directory inside the config dir". $qemu_confdir makes it more clear. The current C code that uses CONFIG_QEMU_CONFDIR should be safe, as now create_config generates the same #define name (CONFIG_

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Blue Swirl
On Tue, Apr 17, 2012 at 21:33, Anthony Liguori wrote: > On 04/17/2012 03:59 PM, Peter Maydell wrote: >> >> On 17 April 2012 21:43, Blue Swirl  wrote: >>> >>> On Tue, Apr 17, 2012 at 20:31, Peter Maydell >>>  wrote: Well, it could. But we should make that decision based on whether it

Re: [Qemu-devel] [RFC PATCH 2/3] iommu: Create basic group infrastructure and update AMD-Vi & Intel VT-d

2012-04-18 Thread Alex Williamson
On Wed, 2012-04-18 at 21:55 +1000, David Gibson wrote: > On Mon, Apr 02, 2012 at 03:14:46PM -0600, Alex Williamson wrote: > > IOMMU groups define the minimum granularity of the IOMMU. We therefore > > create groups using a dma_dev which is the effective requestor ID for > > the entire group. Addi

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3] PPC: Fix interrupt MSR value for classic exception models.

2012-04-18 Thread Jakub Jermar
On 04/18/2012 05:30 PM, Alexander Graf wrote: > On 04/13/2012 06:53 PM, Mark Cave-Ayland wrote: >> On 11/04/12 02:08, David Gibson wrote: >> >> Hi David, >> Commit 41557447d30eeb944e42069513df13585f5e6c7f introduced a new method of calculating the MSR for the interrupt context. Howev

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3] PPC: Fix interrupt MSR value for classic exception models.

2012-04-18 Thread Jakub Jermar
On 04/18/2012 05:30 PM, Alexander Graf wrote: > On 04/13/2012 06:53 PM, Mark Cave-Ayland wrote: >> On 11/04/12 02:08, David Gibson wrote: >> >> Hi David, >> Commit 41557447d30eeb944e42069513df13585f5e6c7f introduced a new method of calculating the MSR for the interrupt context. Howev

[Qemu-devel] [PATCH 02/14] configure: rename $docdir to $qemu_docdir

2012-04-18 Thread Eduardo Habkost
The autoconf "docdir" variable is used for the program-specific subdirectory, but anyway it's better to make it clear that the variable is used for the qemu-specific subdirectory path. Signed-off-by: Eduardo Habkost --- configure |8 1 files changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Anthony Liguori
On 04/18/2012 03:28 PM, Blue Swirl wrote: On Tue, Apr 17, 2012 at 21:33, Anthony Liguori wrote: On 04/17/2012 03:59 PM, Peter Maydell wrote: On 17 April 2012 21:43, Blue Swirlwrote: On Tue, Apr 17, 2012 at 20:31, Peter Maydell wrote: Well, it could. But we should make that decision

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Blue Swirl
On Tue, Apr 17, 2012 at 20:59, Peter Maydell wrote: > On 17 April 2012 21:43, Blue Swirl wrote: >> On Tue, Apr 17, 2012 at 20:31, Peter Maydell >> wrote: >>> Well, it could. But we should make that decision based on whether it >>> makes sense and has a use case for actual users of the board, no

[Qemu-devel] [PATCH 5/5] move CPU definitions to /usr/share/qemu/cpus-x86_64.conf

2012-04-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile | 12 +++- arch_init.c |1 + sysconfigs/target/cpus-x86_64.conf | 128 ++ sysconfigs/target/target-x86_64.conf | 128 -- 4 fil

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Blue Swirl
On Wed, Apr 18, 2012 at 20:35, Anthony Liguori wrote: > On 04/18/2012 03:28 PM, Blue Swirl wrote: >> >> On Tue, Apr 17, 2012 at 21:33, Anthony Liguori >>  wrote: >>> >>> On 04/17/2012 03:59 PM, Peter Maydell wrote: On 17 April 2012 21:43, Blue Swirl    wrote: > > > On Tu

[Qemu-devel] [PATCH 05/14] config-host.mak: rename datadir to qemu_datadir

2012-04-18 Thread Eduardo Habkost
Autoconf concept of "datadir" is supposed to be "$prefix/share", not "$prefix/share/PACKAGE", so using datadir for the Qemu-specific directory is confusing. The current C code that uses CONFIG_QEMU_DATADIR should be safe, as now create_config generates the same #define name (CONFIG_QEMU_DATADIR) f

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: suspend: handle EINTR

2012-04-18 Thread Luiz Capitulino
On Wed, 18 Apr 2012 21:08:28 +0100 Peter Maydell wrote: > On 18 April 2012 20:30, Luiz Capitulino wrote: > > The read() call in bios_supports_mode() can fail with EINTR if a child > > terminates during the call. Handle it. > > > > Signed-off-by: Luiz Capitulino > > --- > >  qga/commands-posix.c

[Qemu-devel] [PATCH 04/14] create_config: separate section for qemu_*dir variables (v2)

2012-04-18 Thread Eduardo Habkost
The generic *dir section will eventually go away and be replaced with qemu_* section. By now, both sections will be kept, while the variables get renamed on config-host.mak. With this patch, a XXXdir variable will become a CONFIG_QEMU_XXXDIR define, and a qemu_XXXdir variable will become CONFIG_QE

[Qemu-devel] [PATCH 12/14] create_config: simplify prefix=* block, remove CONFIG_QEMU_PREFIX

2012-04-18 Thread Eduardo Habkost
As now that block handles only the prefix variable, the code can be much simpler. This also removes the CONFIG_QEMU_PREFIX define as it is not used by any C code. Signed-off-by: Eduardo Habkost --- scripts/create_config |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] qemu physical address

2012-04-18 Thread Blue Swirl
On Wed, Apr 18, 2012 at 01:28, Xin Tong wrote: > I am reading how qemu refill TLB working. > > target-i386/helper.c > >    pte = pte & env->a20_mask; > >    /* Even if 4MB pages, we map only one 4KB page in the cache to >       avoid filling it too fast */ >    page_offset = (addr & TARGET_PAGE_MA

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Andreas Färber
Am 18.04.2012 22:35, schrieb Anthony Liguori: > On 04/18/2012 03:28 PM, Blue Swirl wrote: >> On Tue, Apr 17, 2012 at 21:33, Anthony Liguori >> wrote: >>> >>> >>> Kernel loading is a hack. I'll go out on a limb and say that most >>> non-x86 >>> boards are doing it completely wrong. Messing aroun

[Qemu-devel] [PATCH 4/5] implement -no-user-config command-line option

2012-04-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- arch_init.c | 10 +++--- arch_init.h |2 +- qemu-options.hx | 16 +--- vl.c|6 +- 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index 62332e9..c5fc00f 100644 --- a/ar

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-18 Thread Blue Swirl
On Wed, Apr 18, 2012 at 20:51, Andreas Färber wrote: > Am 18.04.2012 22:35, schrieb Anthony Liguori: >> On 04/18/2012 03:28 PM, Blue Swirl wrote: >>> On Tue, Apr 17, 2012 at 21:33, Anthony Liguori >>> wrote: Kernel loading is a hack.  I'll go out on a limb and say that most no

[Qemu-devel] [PATCH 00/14] qom: convert busses to QOM

2012-04-18 Thread Anthony Liguori
This is the last of the core QOM series. This series converts busses to QOM using a model where busses are proper objects that inherit from Object directly. Devices have a has-a relationship with any bus they implement. This series also creates link associated with the device/bus relationships.

[Qemu-devel] [PATCH 01/14] qdev: fix adding of ptr properties

2012-04-18 Thread Anthony Liguori
ptr properties have neither a get/set or a print/parse which means that when they're added they aren't treated as static or legacy properties. Just assume properties like this are legacy properties and treat them as such. Signed-off-by: Anthony Liguori --- hw/qdev.c |5 - 1 files change

[Qemu-devel] [PATCH 02/14] object: add object_property_foreach

2012-04-18 Thread Anthony Liguori
Provide a mechanism to walk through each property for an object. Signed-off-by: Anthony Liguori --- include/qemu/object.h | 26 ++ qom/object.c | 10 ++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/include/qe

[Qemu-devel] [PATCH 12/14] qbus: move print_dev to DeviceClass

2012-04-18 Thread Anthony Liguori
It should have never been a bus method. Signed-off-by: Anthony Liguori --- hw/isa-bus.c | 37 -- hw/pci.c | 79 +++ hw/qdev-monitor.c | 10 +++--- hw/qdev.h |3 +- hw/sysbus.c

Re: [Qemu-devel] [PATCH] mips: Fix BC1ANY[24]F instructions

2012-04-18 Thread Andreas Färber
Am 26.11.2011 14:37, schrieb Richard Sandiford: > There's some dodgy application of De Morgan's law in the emulation > of the MIPS BC1ANY[24]F instructions: they end up branching only > if all CCs are false, rather than if one CC is. > > Tested on mips64-linux-gnu, where it fixes the GCC MIPS3D te

[Qemu-devel] [PATCH 3/5] move list of default config files to an array

2012-04-18 Thread Eduardo Habkost
More files will be added to the list, with additional attributes, later. Signed-off-by: Eduardo Habkost --- arch_init.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 152cbbb..62332e9 100644 --- a/arch_init.c +++

<    1   2   3   >