[Qemu-devel] buildbot failure in qemu on ppc-next_x86_64_debian_6_0

2012-05-04 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_x86_64_debian_6_0/builds/263 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

Re: [Qemu-devel] [PATCH 1.1] scsi: Add assertion for use-after-free errors

2012-05-04 Thread Paolo Bonzini
Il 03/05/2012 22:58, Stefan Weil ha scritto: Am 03.05.2012 19:36, schrieb Stefan Weil: The QEMU emulation which is currently used with Raspberry PI images (qemu-system-arm -M versatilepb ...) accesses memory which was freed. Valgrind output (extract): ==17857== Invalid write of size 4

Re: [Qemu-devel] [Bug 990364] Re: virtio_ioport_write: unexpected address 0x13 value 0x1

2012-05-04 Thread Alon Levy
On Thu, May 03, 2012 at 12:16:57PM -, vrozenfe wrote: On Monday, April 30, 2012 07:17:09 PM Vadim Rozenfeld wrote: On Monday, April 30, 2012 03:31:03 PM Stefan Hajnoczi wrote: Hi Vadim, Here is a recent bug report with virtio-win-0.1-22.iso. Wanted to bring it to your attention,

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-05-04 Thread Paolo Bonzini
Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: +itask-bs-total_sectors= rc16-returned_lba * + rc16-block_length / BDRV_SECTOR_SIZE ; Ronnie, does this need to be (rc16-returned_lba + 1) * ...? READ CAPACITY returns the highest valid LBA, not the size.

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-05-04 Thread ronnie sahlberg
On Fri, May 4, 2012 at 6:06 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: +    itask-bs-total_sectors    = rc16-returned_lba * +                               rc16-block_length / BDRV_SECTOR_SIZE ; Ronnie, does this need to be (rc16-returned_lba

[Qemu-devel] [PATCH] Fix incorrect calculation of iscsi number of blocks

2012-05-04 Thread Ronnie Sahlberg
List, READCAPACITY16 returns the LBA of the last accessible block. Number of blocks is one greater than this. This patch fixes the incorrect calculation of total sectors that Paolo spotted and reported. Sorry, regards ronnie sahlberg

[Qemu-devel] [PATCH] ISCSI: Readcapacity retruned the lba of the last sector. Total number of sectors is one more.

2012-05-04 Thread Ronnie Sahlberg
Thanks to Paolo for spotting. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index eb49093..7c1970d 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -482,7 +482,7

[Qemu-devel] [seabios patch 2/5] acpi: add qemu fwcfg driver

2012-05-04 Thread Gerd Hoffmann
Add a acpi driver for the qemu firmware config interface. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/acpi-dsdt.dsl | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl index

[Qemu-devel] [seabios patch 3/5] acpi: update pci io windows according to fw_cfg info

2012-05-04 Thread Gerd Hoffmann
This patch makes the pci ressources runtime configurable. The patch fetches the pci window information from the qemu firmware config interface and in case valid data is found there the ressource entries are updated accordingly. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [seabios patch 5/5] update src/acpi-dsdt.hex

2012-05-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/acpi-dsdt.hex | 420 +++-- 1 files changed, 410 insertions(+), 10 deletions(-) diff --git a/src/acpi-dsdt.hex b/src/acpi-dsdt.hex index 07f0e18..16b3e37 100644 --- a/src/acpi-dsdt.hex +++

[Qemu-devel] [seabios patch 4/5] pciinit: make pci ressources configurable

2012-05-04 Thread Gerd Hoffmann
Try to get the pci window information from the qemu firmware config interface and use them if available, otherwise fall back to the compile time defaults. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/paravirt.c |8 src/paravirt.h |2 ++ src/pciinit.c | 29

[Qemu-devel] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Gerd Hoffmann
Hi, This patch series makes the PCI I/O windows runtime-configurable via qemu firmware config interface. Main advantage is that we can size and shuffle around the PCI i/O windows according to the amount of memory the virtual machine has. We don't need a hole for 64bit PCI bars, we can just

Re: [Qemu-devel] [PATCH] ISCSI: Readcapacity retruned the lba of the last sector. Total number of sectors is one more.

2012-05-04 Thread Paolo Bonzini
Il 04/05/2012 10:15, Ronnie Sahlberg ha scritto: itask-iscsilun-num_blocks = rc16-returned_lba; -itask-bs-total_sectors= rc16-returned_lba * +itask-bs-total_sectors= (rc16-returned_lba + 1) * What about itask-iscsilun-num_blocks? :) No need to resend, I fixed this

[Qemu-devel] [PULL 00/14] SCSI changes for 1.1

2012-05-04 Thread Paolo Bonzini
Anthony, the following changes since commit f05ae5379e40f81a6c8526d891693af8bf6e62da: Bail out if CONFIG_TCG_PASS_AREG0 is defined (2012-05-03 15:48:49 +0400) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Gerd Hoffmann
Hi, However, I've ran into a different issue today: migrating while suspended doesn't work. The target VM seems to be locked into S3, it just doesn't resume. Haven't investigated yet, but this is expected to work, right? Well, that one is still on the todo list. There is the temporary

Re: [Qemu-devel] [PATCH v3] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 05:00:45PM -0400, Paul Moore wrote: FIPS 140-2 requires disabling certain ciphers, including DES, which is used by VNC to obscure passwords when they are sent over the network. The solution for FIPS users is to disable the use of VNC password auth when the host system

[Qemu-devel] [PATCH 04/14] scsi: fix WRITE SAME transfer length and direction

2012-05-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 14 -- hw/scsi-disk.c |5 - 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index c29a4ae..5640aae 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -791,7

Re: [Qemu-devel] [SeaBIOS] [seabios patch 5/5] update src/acpi-dsdt.hex

2012-05-04 Thread Gerd Hoffmann
On 05/04/12 10:21, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Topic just came up on irc (#qemu): Any reason to keep the iasl generated files in the git repository? I think pretty much every linux distro has iasl packaged these days, so it shouldn't be a major hassle to

[Qemu-devel] [PATCH 10/14] scsi: do not require a minimum allocation length for INQUIRY

2012-05-04 Thread Paolo Bonzini
The requirements on the INQUIRY buffer size are not in my copy of SPC (SPC-4 r27) and not observed by LIO. Rip them out. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |8 hw/scsi-disk.c | 11 --- 2 files changed, 19 deletions(-) diff --git

[Qemu-devel] [PATCH 14/14] scsi: Add assertion for use-after-free errors

2012-05-04 Thread Paolo Bonzini
From: Stefan Weil s...@weilnetz.de The QEMU emulation which is currently used with Raspberry PI images (qemu-system-arm -M versatilepb ...) accesses memory which was freed. Valgrind output (extract): ==17857== Invalid write of size 4 ==17857==at 0x24EB06: scsi_req_unref (scsi-bus.c:1273)

[Qemu-devel] [PATCH 13/14] scsi: remove useless debug messages

2012-05-04 Thread Paolo Bonzini
Optional inquiry information is declared obsolete in the latest versions of the standard; invalid CDBs or unsupported VPD pages are supported can be diagnosed with trace_scsi_inquiry. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 13 - 1 file changed, 13

[Qemu-devel] [PATCH 05/14] scsi: Specify the xfer direction for UNMAP and ATA_PASSTHROUGH commands

2012-05-04 Thread Paolo Bonzini
From: Ronnie Sahlberg ronniesahlb...@gmail.com scsi_cmd_xfer_mode() is used to specify the xfer direction for SCSI commands that come in from the guest. If the direction is set incorrectly this will eventually cause QEMU to kernel-panic the guest. Add UNMAP and ATAPASSTHROUGH as commands that

Re: [Qemu-devel] [SeaBIOS] [seabios patch 5/5] update src/acpi-dsdt.hex

2012-05-04 Thread Michael Tokarev
On 04.05.2012 13:04, Gerd Hoffmann wrote: On 05/04/12 10:21, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Topic just came up on irc (#qemu): Any reason to keep the iasl generated files in the git repository? I think pretty much every linux distro has iasl packaged

[Qemu-devel] [PATCH 08/14] scsi: do not report bogus overruns for commands in the 0x00-0x1F range

2012-05-04 Thread Paolo Bonzini
Interpreting cdb[4] == 0 as a request to transfer 256 blocks is only needed for READ_6 and WRITE_6. No other command in that range needs that special-casing, and the resulting overrun breaks scsi-testsuite's attempt to use command 2 as a known-invalid command. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow

2012-05-04 Thread Paolo Bonzini
Avoid sending more than 2GB of data, as that can cause overflows in int32_t variables. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c

[Qemu-devel] [qemu patch] pci: pass i/o windows via fwcfg

2012-05-04 Thread Gerd Hoffmann
This patch adds a fw_cfg entry for the PCI I/O windows. It holds four values, 64bit each. The first two specify the 32bit PCI I/O window below 4G, the second two the 64bit PCI I/O window above 4G. The 32bit PCI I/O window used to start at the fixed address 0xe000. Now it starts at the end

[Qemu-devel] [PATCH 06/14] scsi: change removable field to host many features

2012-05-04 Thread Paolo Bonzini
It is pointless to add a uint32_t field for every new feature. Since we will need a new feature soon, convert accesses to removable to look at bit 0 only. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 23 +++ 1 file changed, 15 insertions(+), 8

[Qemu-devel] [PATCH 11/14] scsi: do not require a minimum allocation length for REQUEST SENSE

2012-05-04 Thread Paolo Bonzini
The requirements on the REQUEST SENSE buffer size are not in my copy of SPC (SPC-4 r27) and not observed by LIO. Rip them out. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/scsi-bus.c

[Qemu-devel] [PATCH 01/14] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-05-04 Thread Paolo Bonzini
From: Ronnie Sahlberg ronniesahlb...@gmail.com Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update the iscsi block layer to use READCAPACITY16 to detect the size of the LUN instead

[Qemu-devel] [PATCH 09/14] scsi: parse 16-byte tape CDBs

2012-05-04 Thread Paolo Bonzini
The transfer length for these commands is different from the transfer length of the corresponding disk commands, so parse it specially. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- READ REVERSE(16) seems to be for people who stream manga from tape. hw/scsi-bus.c | 10

[Qemu-devel] [PATCH 07/14] scsi-disk: add dpofua property

2012-05-04 Thread Paolo Bonzini
Linux expects REQ_FUA to be advertised only if WRITE+FUA is faster than WRITE+SYNCHRONIZE CACHE, so we should not set the DPOFUA bit. However, it is useful to have it for testing purposes, so add a qdev property to set it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c |

[Qemu-devel] [PATCH 03/14] scsi: fix refcounting for reads

2012-05-04 Thread Paolo Bonzini
Recently introduced FUA support also gave us a use-after-free of the BlockAcctCookie within a SCSIDiskReq, due to unbalanced reference counting. The patch fixes this by making scsi_do_read look like a combination of scsi_*_complete + scsi_*_data. It does both a ref (like scsi_read_data) and an

[Qemu-devel] [PATCH 12/14] scsi: set VALID bit to 0 in fixed format sense data

2012-05-04 Thread Paolo Bonzini
The INFORMATION field (bytes 3..6) is never set by QEMU, so the VALID bit must be 0. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 925c3ae..add1d4f 100644 ---

[Qemu-devel] [seabios patch 1/5] pci: init all devices

2012-05-04 Thread Gerd Hoffmann
seabios used to initialize root bus devices only, with this patch devices behind pci bridges are initialized too. This allows to boot from virtio devices behind pci bridges. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/pciinit.c |3 --- 1 files changed, 0 insertions(+), 3

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-04 Thread Peter Maydell
On 4 May 2012 01:41, Anthony Liguori anth...@codemonkey.ws wrote: On 05/03/2012 02:58 PM, Peter Maydell wrote: No unreviewed patches should go double when we're in hardfreeze! These patches are admittedly trivial but it is important to stress the point that all patches need to go on the

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-04 Thread Alexander Graf
On 04.05.2012, at 04:37, malc wrote: On Fri, 4 May 2012, Andreas F?rber wrote: Am 04.05.2012 02:41, schrieb Anthony Liguori: On 05/03/2012 02:58 PM, Peter Maydell wrote: On 9 February 2012 13:46, Anthony Liguorianth...@codemonkey.ws wrote: On 02/09/2012 03:48 AM, Markus Armbruster wrote:

[Qemu-devel] [PATCH 03/35] vmstate: unicore32 don't support cpu migration

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-unicore32/cpu.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index 81c14ff..65f389c 100644 --- a/target-unicore32/cpu.h +++ b/target-unicore32/cpu.h @@ -135,8

[Qemu-devel] [PATCH 34/35] vmstate: Add copyright info for ppc processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c v3: change copyright dates v4: add Fabrice QEMU contributors Signed-off-by: Juan Quintela quint...@redhat.com --- target-ppc/vmstate-cpu.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 [v5] - rebase on top - sparc psr change behaviour: old behaviour was unintended, thanks Blu - alexander agreed with ppc changes - patch missing

[Qemu-devel] [PATCH 29/35] vmstate: Add copyright info for lm32 processor

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Acked-By: Michael Walle mich...@walle.cc --- target-lm32/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c index 132259d..3867189 100644 ---

[Qemu-devel] [PATCH 15/35] vmstate: port sparc cpu

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/sun4u.c | 20 -- target-sparc/cpu.h |9 +- target-sparc/machine.c | 474 3 files changed, 283 insertions(+), 220 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index

Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Juan Quintela
Andreas Färber afaer...@suse.de wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 [v5] - rebase on top - sparc psr change behaviour: old behaviour was unintended, thanks Blu - alexander

[Qemu-devel] [PATCH 25/35] vmstate: fix vmstate formating for i386

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-i386/machine.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-i386/machine.c b/target-i386/machine.c index 127c44f..c2a8872 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@

Re: [Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: With this change, we sent arrays as arrays, making state description send? much simpler. The change is incompatible, but as far as I know, sparc don't care about migration compatibility beteween versions. the SPARC targets don't (or sparc doesn't)

Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Andreas Färber afaer...@suse.de wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 Oops, you meaned here. s/v4/v5/ :-( I have to put in one script how

[Qemu-devel] [PATCH 01/35] vmstate: Simplify test for CPU_SAVE_VERSION

2012-05-04 Thread Juan Quintela
Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have defined cpu_save/load. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 0607c9b..cba333f 100644 --- a/exec.c

Re: [Qemu-devel] [PATCH 01/35] vmstate: Simplify test for CPU_SAVE_VERSION

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have CPUs' definitions? defined cpu_save/load. This commit message sounds wrong. Use of cpu_save/load is still coupled to CPU_SAVE_VERSION AFAICS. What really changes is that

[Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Juan Quintela
This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 [v5] - rebase on top - sparc psr change behaviour: old behaviour was unintended, thanks Blu - alexander agreed with ppc changes - patch missing already included for ppc Anthony, please pull. [v4] -

[Qemu-devel] [PATCH 20/35] mips: bump migration version to 4

2012-05-04 Thread Juan Quintela
bcond state was stored as int32, but it is target_ulong. Change migration state to reflect that. Signed-off-by: Juan Quintela quint...@redhat.com --- target-mips/cpu.h |2 +- target-mips/machine.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 12/35] vmstate: port ppc cpu

2012-05-04 Thread Juan Quintela
Added sdr1_vmstate because storing the value requires calling ppc_store_sdr1(). The position when the function is called also changes (I think it is save). Signed-off-by: Juan Quintela quint...@redhat.com --- target-ppc/cpu.h |5 +- target-ppc/machine.c | 245

Re: [Qemu-devel] [RFC 0/9] Virtio-mmio refactoring.

2012-05-04 Thread Evgeny Voevodin
On 04.05.2012 07:41, Evgeny Voevodin wrote: On 03.05.2012 16:14, Peter Maydell wrote: On 25 April 2012 06:54, Evgeny Voevodine.voevo...@samsung.com wrote: In this patchset refactoring of virtio-mmio layer is made. Instead of creating virtio-blk-mmio, virtio-net-mmio, etc on the system bus we

Re: [Qemu-devel] [PATCH 01/35] vmstate: Simplify test for CPU_SAVE_VERSION

2012-05-04 Thread Juan Quintela
Andreas Färber afaer...@suse.de wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have CPUs' definitions? defined cpu_save/load. This commit message sounds wrong. Use of cpu_save/load is still coupled to

Re: [Qemu-devel] [PATCH 08/35] vmstate: introduce float32 arrays

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 25 + vmstate.h |5 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 2d18bab..a22278e 100644 ---

[Qemu-devel] [PATCH 30/35] vmstate: Add copyright info for cris processor

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Acked-by: Edgar E. Iglesias edgar.igles...@gmail.com --- target-cris/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c index 1dbf8b5..47ac170

Re: [Qemu-devel] [PATCH 01/35] vmstate: Simplify test for CPU_SAVE_VERSION

2012-05-04 Thread Andreas Färber
Am 04.05.2012 13:59, schrieb Juan Quintela: Andreas Färber afaer...@suse.de wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have CPUs' definitions? defined cpu_save/load. This commit message sounds wrong. Use of

[Qemu-devel] [PATCH 32/35] vmstate: Add copyright info for i386 processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Add Fabrice copyright from vl.c Signed-off-by: Juan Quintela quint...@redhat.com --- target-i386/vmstate-cpu.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/target-i386/vmstate-cpu.c

[Qemu-devel] [PATCH 31/35] vmstate: Add copyright info for arm processor

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Acked-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- target-arm/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c index f8ccdd7..65ed6eb

[Qemu-devel] [PATCH 07/35] vmstate: port cris cpu to vmstate

2012-05-04 Thread Juan Quintela
Have to define TLBSet struct. Multidimensional arrays in C are a mess, just unroll them. Signed-off-by: Juan Quintela quint...@redhat.com --- target-cris/cpu.h | 13 ++--- target-cris/machine.c | 138 +++-- 2 files changed, 60 insertions(+), 91

[Qemu-devel] [PATCH 05/35] vmstate: use new style for lm32 cpus

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-lm32/cpu.h |2 -- target-lm32/machine.c | 14 ++ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32/cpu.h index 422a55b..049936a 100644 --- a/target-lm32/cpu.h +++

[Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Juan Quintela
Use one subsection for each feature. This means that we don't need to bump the version field each time that a new feature gets introduced. Introduce cpsr_vmstate field, as I am not sure if I can use uncached_cpsr for saving state. Signed-off-by: Juan Quintela quint...@redhat.com ---

[Qemu-devel] [PATCH 24/35] vmstate: all cpus converted

2012-05-04 Thread Juan Quintela
We don't have any more CPU_SAVEVM_VERSION users, neither cpu_save/load() ones. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c|5 - qemu-common.h |4 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/exec.c b/exec.c index 85f0d61..1deb943 100644

[Qemu-devel] [PATCH 18/35] mips: make mvp an embedded struct instead of a pointer

2012-05-04 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela quint...@redhat.com --- hw/mips_malta.c |4 ++-- target-mips/cpu.h|4 ++-- target-mips/machine.c| 12 ++-- target-mips/op_helper.c | 30 +-

[Qemu-devel] [PATCH 21/35] vmstate: port mips cpu

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-mips/cpu.h |5 +- target-mips/machine.c | 465 +++-- 2 files changed, 182 insertions(+), 288 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index c77d270..8eb6173

[Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 25 + vmstate.h |4 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index a22278e..da8f234 100644 --- a/savevm.c +++ b/savevm.c @@ -1107,6 +1107,31 @@ const

[Qemu-devel] [PATCH 17/35] mips_fulong2e: cpu vmstate already registered in cpu_exec_init

2012-05-04 Thread Juan Quintela
This is the second place that register cpu migration code, it is done in general in cpu_exec_init(), just remove this call. Signed-off-by: Juan Quintela quint...@redhat.com --- hw/mips_fulong2e.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/mips_fulong2e.c

[Qemu-devel] [PATCH 13/35] vmstate: introduce VMSTATE_VARRAY_MULTIPLY

2012-05-04 Thread Juan Quintela
This allows to sent a partial array where the size is another structure field multiplied by a constant. Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c |6 ++ vmstate.h | 35 +++ 2 files changed, 29 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH 35/35] vmstate: Add copyright info for sparc processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c v3: Change copyright dates v4: add QEMU contributors Signed-off-by: Juan Quintela quint...@redhat.com --- target-sparc/vmstate-cpu.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 11/35] vmstate: Introduce VMSTATE_STRUCT_VARRAY_INT32_TEST

2012-05-04 Thread Juan Quintela
We have an array of structs whose size is an int32 in the same struct that depends on a test value to know if it is there or not. Signed-off-by: Juan Quintela quint...@redhat.com --- vmstate.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/vmstate.h

[Qemu-devel] [PATCH 08/35] vmstate: introduce float32 arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 25 + vmstate.h |5 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 2d18bab..a22278e 100644 --- a/savevm.c +++ b/savevm.c @@ -1082,6 +1082,31 @@ const

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Paul Moore
On Friday, May 04, 2012 04:01:09 AM Roman Drahtmueller wrote: FIPS 140-2 requires disabling certain ciphers, including DES, which is used by VNC to obscure passwords when they are sent over the network. The solution for FIPS users is to disable the use of VNC password auth

[Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Juan Quintela
With this change, we sent arrays as arrays, making state description much simpler. The change is incompatible, but as far as I know, sparc don't care about migration compatibility beteween versions. Signed-off-by: Juan Quintela quint...@redhat.com --- target-sparc/machine.c | 172

Re: [Qemu-devel] [PATCH v3] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Paul Moore
On Friday, May 04, 2012 09:54:17 AM Daniel P. Berrange wrote: On Thu, May 03, 2012 at 05:00:45PM -0400, Paul Moore wrote: FIPS 140-2 requires disabling certain ciphers, including DES, which is used by VNC to obscure passwords when they are sent over the network. The solution for FIPS

Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password authentication (security type 2) when in FIPS mode

2012-05-04 Thread Daniel P. Berrange
On Fri, May 04, 2012 at 08:39:04AM -0400, Paul Moore wrote: On Friday, May 04, 2012 04:01:09 AM Roman Drahtmueller wrote: Two problems: 1) openssl may not come with FIPS support. proc file is ignored. 2) openssl may run in FIPS mode for reasons other than fips=1 on the kernel cmdline

[Qemu-devel] [PATCH 19/35] mips: make tlb an embedded struct instead of a pointer

2012-05-04 Thread Juan Quintela
Adjust all callers. Signed-off-by: Juan Quintela quint...@redhat.com --- hw/mips_timer.c |2 +- target-mips/cpu.h|2 +- target-mips/helper.c | 30 +- target-mips/machine.c| 56 +-

Re: [Qemu-devel] [PATCH 22/35] arm: save always 32 fpu registers

2012-05-04 Thread Peter Maydell
On 4 May 2012 11:54, Juan Quintela quint...@redhat.com wrote: This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATURE_VPF3, we always send the 32 registers. As I pointed out last time around, this bug is already fixed in master

[Qemu-devel] [PATCH 04/35] vmstate: use new cpu style for x86

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-i386/cpu.h |2 -- target-i386/machine.c | 12 +--- 2 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index b5b9a50..73b71ec 100644 --- a/target-i386/cpu.h +++

[Qemu-devel] [PATCH 33/35] vmstate: Add copyright info for mips processor

2012-05-04 Thread Juan Quintela
v2: Move license to BSD-like as in vl.c Signed-off-by: Juan Quintela quint...@redhat.com --- target-mips/vmstate-cpu.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c index

[Qemu-devel] [PATCH 26/35] vmstate: remove unneeded includes from target-*/machine.c

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-alpha/machine.c |1 - target-arm/machine.c |1 - target-cris/machine.c |1 - target-i386/machine.c |6 -- target-lm32/machine.c |1 - target-mips/machine.c |3 --- target-ppc/machine.c |2 --

[Qemu-devel] [PATCH 06/35] vmstate: make microblaze cpus not migrateable

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-microblaze/cpu.h |2 -- target-microblaze/machine.c | 26 ++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 718d5bb..866623d

[Qemu-devel] [PATCH 28/35] vmstate: Add copyright info for alpha processor

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Acked-by: Richard Henderson r...@twiddle.net --- target-alpha/vmstate-cpu.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c index 22c70f3..b94b1e5

[Qemu-devel] [PATCH 10/35] vmstate: introduce CPU_DoubleU arrays

2012-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 24 vmstate.h |4 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index da8f234..0a00dec 100644 --- a/savevm.c +++ b/savevm.c @@ -1132,6 +1132,30 @@ const

Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus

2012-05-04 Thread Anthony Liguori
On 05/04/2012 06:35 AM, Juan Quintela wrote: Juan Quintelaquint...@redhat.com wrote: Andreas Färberafaer...@suse.de wrote: Am 04.05.2012 12:54, schrieb Juan Quintela: This repository contains all the changes: git://repo.or.cz/qemu/quintela.git vmstate-cpus-v4 Oops, you meaned here.

[Qemu-devel] [PATCH 22/35] arm: save always 32 fpu registers

2012-05-04 Thread Juan Quintela
This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATURE_VPF3, we always send the 32 registers. Signed-off-by: Juan Quintela quint...@redhat.com --- target-arm/cpu.h |2 +- target-arm/machine.c | 22 ++

[Qemu-devel] [PATCH 14/35] vmstate: define vmstate_info_uinttls

2012-05-04 Thread Juan Quintela
We are going to define arrays of this type, so we need the integer type. Signed-off-by: Juan Quintela quint...@redhat.com --- hw/hw.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index e5cb9bf..9dbac88 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -52,11

Re: [Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Peter Maydell
On 4 May 2012 12:35, Andreas Färber afaer...@suse.de wrote: It appears once again none of these patches are actually cc'ing the proper maintainers. Not even Acked-by (or is git-send-email case-sensitive? it's spelled Acked-By in lm32 patch). FWIW, git-send-email is not case-sensitive when

[Qemu-devel] [PATCH 02/35] vmstate: make all architectures export a way to migrate cpu's

2012-05-04 Thread Juan Quintela
This makes several changes: - exports VMStateDescription vmstate_cpu non-static. - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined - for the architecture that had nothing, it just register the cpu as unmigratable. - Depending on CPU_SAVE_VERSION we register old/new migration

Re: [Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays

2012-05-04 Thread Andreas Färber
Am 04.05.2012 12:54, schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 25 + vmstate.h |4 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index a22278e..da8f234 100644 ---

Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu

2012-05-04 Thread Peter Maydell
On 4 May 2012 11:54, Juan Quintela quint...@redhat.com wrote: Use one subsection for each feature.  This means that we don't need to bump the version field each time that a new feature gets introduced. Introduce cpsr_vmstate field, as I am not sure if I can use uncached_cpsr for saving state.

[Qemu-devel] [PATCH 27/35] vmstate: rename machine.c to vmstate-cpu.c

2012-05-04 Thread Juan Quintela
They only contain vmstate cpu sections nowadays. Change name to reflect the case. Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile.target|3 ++- target-alpha/{machine.c = vmstate-cpu.c} |0 target-arm/{machine.c = vmstate-cpu.c}

Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: seabios used to initialize root bus devices only, with this patch devices behind pci bridges are initialized too. This allows to boot from virtio devices behind pci bridges. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-05-04 Thread Kevin O'Connor
On Wed, May 02, 2012 at 03:42:51PM +0200, Gerd Hoffmann wrote: Hi, Is this just a matter of removing the if (pci_bdf_to_bus(pci-bdf) != 0) break from pci_bios_init_devices()? Seems to do the trick, at least the disks connected appear in the boot menu now and the seabios log file looks

Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows

2012-05-04 Thread Kevin O'Connor
On Fri, May 04, 2012 at 10:21:22AM +0200, Gerd Hoffmann wrote: Hi, This patch series makes the PCI I/O windows runtime-configurable via qemu firmware config interface. Main advantage is that we can size and shuffle around the PCI i/O windows according to the amount of memory the virtual

Re: [Qemu-devel] [RFC 0/9] Virtio-mmio refactoring.

2012-05-04 Thread Anthony Liguori
On 05/03/2012 07:14 AM, Peter Maydell wrote: On 25 April 2012 06:54, Evgeny Voevodine.voevo...@samsung.com wrote: In this patchset refactoring of virtio-mmio layer is made. Instead of creating virtio-blk-mmio, virtio-net-mmio, etc on the system bus we create virtio-blk, virtio-net, etc devices

Re: [Qemu-devel] [PATCH 16/35] vmstate: make incompatible change for sparc

2012-05-04 Thread Andreas Färber
Am 04.05.2012 15:00, schrieb Peter Maydell: On 4 May 2012 12:35, Andreas Färber afaer...@suse.de wrote: Not even [cc'ing] Acked-by (or is git-send-email case-sensitive? it's spelled Acked-By in lm32 patch). FWIW, git-send-email is not case-sensitive when looking for things indicating it

[Qemu-devel] [PATCH 0/1] RFC: ipl device for s390

2012-05-04 Thread Christian Borntraeger
Alex, while Einar is reworking the block size/geometry patches, here is the current state of the external loader. While the real firmware loader only supports fcp, this patch also allows to ipl dasd disks (the differences in terms of on-disk format are pretty small). This has the advantage of

[Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Christian Borntraeger
An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this scheme as an qemu device that also allows to configure the IPL like the HMC. We have a parameter iplid that refers to a disk device and a load parm that specifies the entry on the disk to be ipled. We also

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Alexander Graf
On 04.05.2012, at 15:44, Christian Borntraeger wrote: An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this scheme as an qemu device that also allows to configure the IPL like the HMC. We have a parameter iplid that refers to a disk device and a load

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Gerd Hoffmann
Hi, There's a quite simple and stupid way to do it. When we migrate an stopped VM, it's automatically resumed on the target. We could do the same for a suspended VM: we could automatically resume it before migrating, as you said above. That's not the behavior I'd expect, I mean I would

Re: [Qemu-devel] [PATCH 2/3] runstate: introduce suspended state

2012-05-04 Thread Luiz Capitulino
On Fri, 04 May 2012 15:54:26 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, There's a quite simple and stupid way to do it. When we migrate an stopped VM, it's automatically resumed on the target. We could do the same for a suspended VM: we could automatically resume it before

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-04 Thread Christian Borntraeger
On 04/05/12 15:53, Alexander Graf wrote: On 04.05.2012, at 15:44, Christian Borntraeger wrote: An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this scheme as an qemu device that also allows to configure the IPL like the HMC. We have a parameter iplid

  1   2   >