Re: [Qemu-devel] [PATCH 1/2] exec.c: Fix off-by-one error in register_subpage

2012-08-01 Thread Avi Kivity
On 07/26/2012 01:45 AM, Tyler Hall wrote: subpage_register() expects end to be the last byte in the mapping. Registering a non-page-aligned memory region that extends up to or beyond a page boundary causes subpage_register() to silently fail through the (end = PAGE_SIZE) check. This bug

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 14:30, schrieb Paolo Bonzini: Il 01/08/2012 14:23, Kevin Wolf ha scritto: Am 01.08.2012 14:09, schrieb Paolo Bonzini: Il 01/08/2012 13:49, Kevin Wolf ha scritto: The real question is: if I remove the possibility to inspect the (so far anonymous) target device with

[Qemu-devel] [PATCH 08/19] net: Remove vlan code from net.c

2012-08-01 Thread Stefan Hajnoczi
The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- hw/xen_nic.c |1 - net.c| 108

[Qemu-devel] [PATCH 10/19] net: Rename non_vlan_clients to net_clients

2012-08-01 Thread Stefan Hajnoczi
There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Eric Blake
On 08/01/2012 04:03 AM, Miroslav Rezanina wrote: This patch adds compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 15:09, Kevin Wolf ha scritto: It's not about source vs. target, it's about what block device the _job_ is attached too. The source is always going to be special because you must do block-job-resume source. This whole concept of a block job being attached to a single bs is

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 15:21, Eric Blake ha scritto: +++ b/qemu-img.c @@ -96,7 +96,9 @@ static void help(void) '-a' applies a snapshot (revert disk to saved state)\n '-c' creates a snapshot\n '-d' deletes a snapshot\n - '-l' lists all

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-01 Thread Eric Blake
On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors.

[Qemu-devel] [PATCH 07/19] net: Convert qdev_prop_vlan to peer with hub

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Instead of using VLANState use net/hub.h to support the vlan qdev property. The vlan qdev property becomes an alias for the peer qdev property but is represented as a VLAN ID number. When a VLAN ID is selected the device will really peer with a hub

Re: [Qemu-devel] [RFC 00/27]: add new error format

2012-08-01 Thread Luiz Capitulino
On Wed, 01 Aug 2012 19:33:27 +0800 Amos Kong ak...@redhat.com wrote: On 31/07/12 22:44, Luiz Capitulino wrote: On Fri, 27 Jul 2012 18:31:41 -0300 Luiz Capitulinolcapitul...@redhat.com wrote: [Please, read below why this is an RFC] This series implements the 'Plan for error handling

Re: [Qemu-devel] [PATCH 26/27] error, qerror: pass desc string to error calls

2012-08-01 Thread Luiz Capitulino
On Wed, 01 Aug 2012 19:37:29 +0800 Amos Kong ak...@redhat.com wrote: On 28/07/12 05:32, Luiz Capitulino wrote: FIXME: broke error_is_type() and qemu-ga. Signed-off-by: Luiz Capitulinolcapitul...@redhat.com --- error.c | 5 ++- qerror.c | 44 ++-- qerror.h |

Re: [Qemu-devel] [PATCH] fix Xen compilation

2012-08-01 Thread Andreas Färber
Am 01.08.2012 12:19, schrieb Stefano Stabellini: xen_pt_unregister_device is used as PCIUnregisterFunc, so it should match the type. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Tested-by: Andreas Färber afaer...@suse.de /-F diff --git a/hw/xen_pt.c b/hw/xen_pt.c

[Qemu-devel] [PATCH] exec.c: Remove out of date comment

2012-08-01 Thread Peter Maydell
Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the comment and its function. It is in any case obsolete since (a) the function arguments it refers to have been

Re: [Qemu-devel] [PATCH v2] megasas: static SAS addresses

2012-08-01 Thread Andreas Färber
Am 01.08.2012 12:46, schrieb Hannes Reinecke: This patch introduces a new property 'sas_address' which allows the user to specify the SAS address for the HBA. The default address is following the NAA locally assigned identifier format with the locally assigned address 0x525400 as used eg for

[Qemu-devel] [PATCH 15/19] net: cleanup deliver/deliver_iov func pointers

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- net.c | 35

[Qemu-devel] [PATCH 16/19] net: determine if packets can be sent before net queue deliver packets

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- net/queue.c |9 + net/slirp.c

Re: [Qemu-devel] [PATCH] fix Xen compilation

2012-08-01 Thread Stefano Stabellini
On Wed, 1 Aug 2012, Andreas Färber wrote: Am 01.08.2012 12:19, schrieb Stefano Stabellini: xen_pt_unregister_device is used as PCIUnregisterFunc, so it should match the type. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Tested-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH 13/19] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-08-01 Thread Stefan Hajnoczi
Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Reviewed-by:

[Qemu-devel] [PATCH 06/19] net: Drop vlan argument to qemu_new_net_client()

2012-08-01 Thread Stefan Hajnoczi
Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com

Re: [Qemu-devel] [libvirt-users] Using virsh to load scripts for the guest machine

2012-08-01 Thread Anthony Liguori
Eric Blake ebl...@redhat.com writes: On 07/30/2012 12:00 PM, Mauricio Tavares wrote: On Mon, Jul 30, 2012 at 1:50 PM, Eric Blake ebl...@redhat.com wrote: On 07/15/2012 07:52 PM, Mauricio Tavares wrote: Right on the top of

[Qemu-devel] [PULL 00/19] Net patches for QEMU 1.2

2012-08-01 Thread Stefan Hajnoczi
The following changes since commit 0b22ef0f57a8910d849602bef0940edcd0553d2c: configure: -I\$(SRC_PATH) goes in QEMU_INCLUDES not QEMU_CFLAGS (2012-07-31 20:06:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to

Re: [Qemu-devel] [PATCH 12/27] hmp: hmp_change(): don't use error_get_field()

2012-08-01 Thread Luiz Capitulino
On Wed, 01 Aug 2012 14:39:04 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Use the 'device' passed by the user and call qmp_query_block() to get the 'filename' info. error_get_field() is going to be dropped by a future commit.

Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-01 Thread Eric Blake
On 07/31/2012 10:51 AM, Dong Xu Wang wrote: Introduce a new file format:add-cow. The usage can be found at this patch. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- Now add-cow is still using QEMUOptionParameter, not QemuOpts, I will send a seperate patch series to convert.

[Qemu-devel] [PULL] Xen fixes

2012-08-01 Thread Stefano Stabellini
Hi Anthony, please pull a couple of simple Xen compilation fixes from: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-fixes-20120801 Anthony PERARD (1): configure: Fix xen probe with Xen 4.2 and later Stefano Stabellini (1): fix Xen compilation configure |1 - hw

Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

2012-08-01 Thread Eric Blake
On 07/31/2012 10:51 AM, Dong Xu Wang wrote: In add-cow file format, we will use path_has_protocol and we will read a NUL-terminated string from image , qed_read_string has done the samething, s/image ,/image,/ s/samething/same thing/ so make the two functions public, then we will reuse them

Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-01 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: Introduce a new file format:add-cow. The usage can be found at this patch. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- Now add-cow is still using QEMUOptionParameter, not QemuOpts, I will send a

Re: [Qemu-devel] [PATCH 15/27] block: block_int: include qerror.h

2012-08-01 Thread Luiz Capitulino
On Wed, 01 Aug 2012 14:42:02 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Several block/ files are relying on qerror.h being provided by qapi-types.h. However, qapi-types.h won't provide it anymore. Squash it into commit that makes

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-01 Thread Eric Blake
On 07/31/2012 10:51 AM, Dong Xu Wang wrote: This is the implementation code for add-cow file format. Because image_file might be very huge, then we can't read entire bitmap into memory, we must use a cache. Since qcow-cache.c has implemted cache code, we can create our cache

[Qemu-devel] [PATCH 01/19] net: Add interface to bridge when SIOCBRADDIF isn't available

2012-08-01 Thread Stefan Hajnoczi
From: Corey Bryant cor...@linux.vnet.ibm.com The bridge helper uses the SIOCBRADDIF ioctl to add an inteface to a bridge. SIOCBRADDIF is not available on old Linux versions. This patch adds support to use the SIOCDEVPRIVATE ioctl with BRCTL_ADD_IF if SIOCBRADDIF is not available. Reported-by:

[Qemu-devel] [PATCH 05/19] hub: Check that hubs are configured correctly

2012-08-01 Thread Stefan Hajnoczi
Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks performed by net core on

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-08-01 Thread Andreas Färber
Am 23.07.2012 15:22, schrieb Igor Mammedov: MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu.

Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

2012-08-01 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: diff --git a/block.h b/block.h index c89590d..b523076 100644 --- a/block.h +++ b/block.h @@ -152,6 +152,8 @@ int bdrv_pwrite(BlockDriverState *bs, int64_t offset, const void *buf, int count);

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 15:21, schrieb Paolo Bonzini: Il 01/08/2012 15:09, Kevin Wolf ha scritto: It's not about source vs. target, it's about what block device the _job_ is attached too. The source is always going to be special because you must do block-job-resume source. This whole concept of a

[Qemu-devel] [PATCH 19/19] net: add the support for -netdev socket, listen

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will

Re: [Qemu-devel] [PATCH] exec.c: Remove out of date comment

2012-08-01 Thread Avi Kivity
On 08/01/2012 04:35 PM, Peter Maydell wrote: Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the comment and its function. It is in any case obsolete since

[Qemu-devel] [PATCH 18/19] net: fix the coding style

2012-08-01 Thread Stefan Hajnoczi
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- net/socket.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 2/2] target-i386: move cpu_reset and reset callback to cpu.c

2012-08-01 Thread Andreas Färber
Am 23.07.2012 15:22, schrieb Igor Mammedov: Moving reset callback into cpu object from board level and resetting cpu at the end of x86_cpu_realize() will allow properly create cpu object during run-time (hotplug) without calling reset externaly. When reset over QOM hierarchy is implemented,

Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-08-01 Thread Anthony Liguori
On 07/06/2012 04:53 PM, Hervé Poussineau wrote: Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: -chardev stdio,id=debugcon,mux=on -device isa-debugcon,iobase=0x402,chardev=debugcon -device isa-debugcon,iobase=0x403,chardev=debugcon -device

[Qemu-devel] [PATCH v4 0/2] GlusterFS support in QEMU - v4

2012-08-01 Thread Bharata B Rao
Hi, This is the v4 of the patchset to support GlusterFS backend from QEMU. Due to difficulties in supporting ipv6 address format in the ealier specification, I switched over to the URI based specification which looks like this: file=gluster://server:[port]/volname/image[?transport=socket] I

[Qemu-devel] [PATCH v4 1/2] qemu: Add a config option for GlusterFS as block backend

2012-08-01 Thread Bharata B Rao
qemu: Add a config option for GlusterFS as block backend From: Bharata B Rao bhar...@linux.vnet.ibm.com GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- configure | 34

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-01 Thread Stefan Hajnoczi
On Wed, Aug 1, 2012 at 2:57 PM, Eric Blake ebl...@redhat.com wrote: On 07/31/2012 10:51 AM, Dong Xu Wang wrote: This is the implementation code for add-cow file format. Because image_file might be very huge, then we can't read entire bitmap into memory, we must use a cache. Since qcow-cache.c

[Qemu-devel] [PATCH v4 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-01 Thread Bharata B Rao
block: Support GlusterFS as a QEMU block backend. From: Bharata B Rao bhar...@linux.vnet.ibm.com This patch adds gluster as the new block backend in QEMU. This gives QEMU the ability to boot VM images from gluster volumes. Its already possible to boot from VM images on gluster volumes, but this

Re: [Qemu-devel] [PATCH 11/27] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-01 Thread Luiz Capitulino
On Wed, 01 Aug 2012 13:37:44 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Today, hmp_cont() checks for QERR_DEVICE_ENCRYPTED in order to know if qmp_cont() failed due to an encrypted device. If it did, hmp_cont() accesses

Re: [Qemu-devel] [PATCH] exec.c: Remove out of date comment

2012-08-01 Thread Peter Maydell
On 1 August 2012 15:05, Avi Kivity a...@redhat.com wrote: On 08/01/2012 04:35 PM, Peter Maydell wrote: Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the

Re: [Qemu-devel] [PATCH] exec.c: Remove out of date comment

2012-08-01 Thread Avi Kivity
On 08/01/2012 05:17 PM, Peter Maydell wrote: On 1 August 2012 15:05, Avi Kivity a...@redhat.com wrote: On 08/01/2012 04:35 PM, Peter Maydell wrote: Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 16:14, schrieb Stefan Hajnoczi: On Wed, Aug 1, 2012 at 2:57 PM, Eric Blake ebl...@redhat.com wrote: On 07/31/2012 10:51 AM, Dong Xu Wang wrote: This is the implementation code for add-cow file format. Because image_file might be very huge, then we can't read entire bitmap into

Re: [Qemu-devel] [PATCHv2] unicore32-softmmu: Add a minimal curses screen support

2012-08-01 Thread Andreas Färber
Am 01.08.2012 05:09, schrieb g...@mprc.pku.edu.cn: From: Guan Xuetao g...@mprc.pku.edu.cn This patch adds a minimal curses screen support for unicore32-softmmu. We assume 80*30 screen size to minimize the implementation. Two problems are not solved, but they are innocuous. 1. curses windows

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (e.g LGPL'ed VGA BIOS port 0x501)

2012-08-01 Thread Andreas Färber
Am 06.07.2012 23:53, schrieb Hervé Poussineau: Add generic support for simple I/O port which, when written to, cause QEMU to exit with the given written value. There is no vmstate associated with the debugging port, simply because the entire interface is a single, stateless, write-only port.

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 16:01, Kevin Wolf ha scritto: Well, the thing that disturbs me is having a BlockJob attached to a single block device. Jobs can and do operate on multiple images and should probably affect both BDSs the same. For example, bs-in_use should probably be set for both (Haven't checked

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-01 Thread Avi Kivity
On 07/31/2012 01:24 AM, Benjamin Herrenschmidt wrote: So Anthony listed a few, the transport being inconsistent with all our other paravirt model is also part of the problem, and the spice code base just hurts my eyes. The fact that it's essentially GDI centric makes it a non starter for me

Re: [Qemu-devel] [PATCH v2 0/7] split out uses of kvm_irqchip_in_kernel()

2012-08-01 Thread Peter Maydell
ping? thanks -- PMM On 26 July 2012 15:35, Peter Maydell peter.mayd...@linaro.org wrote: This patch series removes all uses of kvm_irqchip_in_kernel() from architecture-independent code, by creating a set of more specific functions instead to test for the particular aspects of behaviour that

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 16:34, schrieb Paolo Bonzini: Il 01/08/2012 16:01, Kevin Wolf ha scritto: Well, the thing that disturbs me is having a BlockJob attached to a single block device. Jobs can and do operate on multiple images and should probably affect both BDSs the same. For example, bs-in_use

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (e.g LGPL'ed VGA BIOS port 0x501)

2012-08-01 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 06.07.2012 23:53, schrieb Hervé Poussineau: Add generic support for simple I/O port which, when written to, cause QEMU to exit with the given written value. There is no vmstate associated with the debugging port, simply because the entire

Re: [Qemu-devel] [PATCH 13/47] block: introduce block job error

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 16:59, Kevin Wolf ha scritto: Am 01.08.2012 16:34, schrieb Paolo Bonzini: Il 01/08/2012 16:01, Kevin Wolf ha scritto: Well, the thing that disturbs me is having a BlockJob attached to a single block device. Jobs can and do operate on multiple images and should probably affect

Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-08-01 Thread Hervé Poussineau
Anthony Liguori a écrit : On 07/06/2012 04:53 PM, Hervé Poussineau wrote: Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: -chardev stdio,id=debugcon,mux=on -device isa-debugcon,iobase=0x402,chardev=debugcon -device isa-debugcon,iobase=0x403,chardev=debugcon -device

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-01 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: +if (backing_filename) { +header.features |= ADD_COW_F_BACKING_FILE; +header.backing_filename_offset = sizeof(header) + 16 * 2; It's not obvious what 16 * 2 is. +ret = bdrv_pwrite(bs,

Re: [Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde

2012-08-01 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: add-cow will let raw file support snapshot_blkdev indirectly. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- blockdev.c | 45 +

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-01 Thread Andreas Färber
Am 30.07.2012 18:19, schrieb Alon Levy: On Mon, Jul 30, 2012 at 09:54:27PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:25 +0300, Avi Kivity wrote: [...] why not go all the way to qxl? That will give you better graphics performance with no need to hack. Well, qxl is pretty

Re: [Qemu-devel] [PATCH] fix Xen compilation

2012-08-01 Thread Anthony Liguori
Stefano Stabellini stefano.stabell...@eu.citrix.com writes: xen_pt_unregister_device is used as PCIUnregisterFunc, so it should match the type. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Applied. Thanks. Regards, Anthony Liguori diff --git a/hw/xen_pt.c

Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-08-01 Thread Anthony Liguori
Hervé Poussineau hpous...@reactos.org writes: Anthony Liguori a écrit : On 07/06/2012 04:53 PM, Hervé Poussineau wrote: Debug output ports (enabled by DEBUG_BIOS define) can be replaced by: -chardev stdio,id=debugcon,mux=on -device isa-debugcon,iobase=0x402,chardev=debugcon -device

Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

2012-08-01 Thread Anthony Liguori
Igor Mammedov imamm...@redhat.com writes: v2: ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), to keep cpu_init implementation in -softmmu and -user targets the same in single place and maintanable. v3: reuse cpu_is_bsp() rather than open code check if

Re: [Qemu-devel] [PATCH 2/2] pc: remove DEBUG_BIOS define and QEMU exit I/O ports

2012-08-01 Thread Hervé Poussineau
Anthony Liguori a écrit : Hervé Poussineau hpous...@reactos.org writes: Anthony Liguori a écrit : On 07/06/2012 04:53 PM, Hervé Poussineau wrote: QEMU exit (which can be guest triggered) can be replaced by: -device isa-debugexit,iobase=0x501 -device isa-debugexit,iobase=0x501,access-size=2

Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

2012-08-01 Thread Andreas Färber
Am 01.08.2012 17:43, schrieb Anthony Liguori: Igor Mammedov imamm...@redhat.com writes: v2: ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), to keep cpu_init implementation in -softmmu and -user targets the same in single place and maintanable. v3: reuse

Re: [Qemu-devel] [RFC PATCH 3/4] qmp: Introduce memchar_write QMP command

2012-08-01 Thread Eric Blake
On 08/01/2012 03:48 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json | 20 qemu-char.c | 19 +++ qmp-commands.hx | 29 + 3 files changed, 68 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [RFC PATCH 4/4] qmp: Introduce memchar_read QMP command

2012-08-01 Thread Eric Blake
On 08/01/2012 03:48 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qapi-schema.json | 20 qemu-char.c | 16 qmp-commands.hx | 28 3 files changed, 64 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [v2 Patch 1/9]block: Framework for reopening image files safely

2012-08-01 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 10:34 PM, Supriya Kannery supri...@linux.vnet.ibm.com wrote: +void bdrv_reopen(BlockDriverState *bs, int bdrv_flags, Error **errp) +{ +BlockDriver *drv = bs-drv; +int ret = 0; +BDRVReopenState *reopen_state = NULL; + +/* Quiesce IO for the given block

Re: [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements

2012-08-01 Thread Paolo Bonzini
Il 23/07/2012 18:32, Paolo Bonzini ha scritto: Il 03/07/2012 15:20, Paolo Bonzini ha scritto: These patches let virtio-blk use the new support for toggling the cache mode between writethrough and writeback. The first patch introduces a new feature bit and configuration field to do

[Qemu-devel] [PATCH v2] Support 'help' as a synonym for '?' in command line options

2012-08-01 Thread Peter Maydell
For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. Update the documentation to use 'help' rather than '?', since '?' is a shell metacharacter and thus prone to fail

[Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump

2012-08-01 Thread Jason Baron
Add a new '[,dump_guest_core=on|off]' option to the '-machine' option. When 'dump_guest_core=off' is specified, guest memory is omitted from the core dump. The default behavior continues to be to include guest memory when a core dump is triggered. In my testing, this brought the core dump size

Re: [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements

2012-08-01 Thread Kevin Wolf
Am 01.08.2012 17:52, schrieb Paolo Bonzini: Il 23/07/2012 18:32, Paolo Bonzini ha scritto: Il 03/07/2012 15:20, Paolo Bonzini ha scritto: These patches let virtio-blk use the new support for toggling the cache mode between writethrough and writeback. The first patch introduces a new feature

[Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer

2012-08-01 Thread Paolo Bonzini
The current RTC emulation has two timers firing every second, one on each edge of the UIP bit. This will prevent CPUs from staying at deep C-states. Intel's measurements from previous submissions show the C6 residency reduced by 6% when running 64 idle guests. The following patches remove the

[Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is used for those registers. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PATCH 02/10] RTC: Rename rtc_timer_update

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index

[Qemu-devel] [PATCH 08/10] RTC: Get and set time without going through s-current_tm

2012-08-01 Thread Paolo Bonzini
This patch makes rtc_set_time and rtc_set_cmos work without reading s-current_tm. In the case of rtc_set_time I introduce a new function that retrieves the time and stores into a given struct tm (not hard-coded to s-current_tm). In the case of rtc_set_cmos, the current time is similarly taken

[Qemu-devel] [PATCH] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-01 Thread Hervé Poussineau
Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using DC390 driver) - MS Windows NT 3.1 (using DC390 driver) - MS Windows NT 4.0

[Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V

2012-08-01 Thread Paolo Bonzini
Also, for consistency with other occurrences, implement VMSTATE_TIMER as a special case of VMSTATE_TIMER_V rather than VMSTATE_TIMER_TEST. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vmstate.h |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vmstate.h

[Qemu-devel] [PATCH 07/10] RTC: Do not fire timer periodically to catch next alarm

2012-08-01 Thread Paolo Bonzini
This patch limits further the usage of a periodic timer. It computes the time of the next alarm, and uses it to skip all intermediate occurrences of the timer. Cc: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 117

Re: [Qemu-devel] [v2 Patch 0/9]block: Image file reopen and dynamic host pagecache change

2012-08-01 Thread Supriya Kannery
On 08/01/2012 02:03 AM, Jeff Cody wrote: On 07/30/2012 05:34 PM, Supriya Kannery wrote: For changing host pagecache setting of a running VM, it is important to have a safe way of reopening its image file. Hi Supriya, I never received patches 6 or 8, either through the list or at my direct

[Qemu-devel] [PATCH 09/10] RTC: Remove the current_tm field

2012-08-01 Thread Paolo Bonzini
This is not used anymore and only written to. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index a69ddc3..57a481a 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@

[Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com If an interrupt flag is already set when the interrupt becomes enabled, raise an interrupt immediately, and vice versa if interrupts become disabled. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PATCH 06/10] RTC: Add divider reset support

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com The first update cycle begins one-half seconds after divider reset is removed. This feature is useful for testing. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 50

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-01 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777; qemu-devel qemu-devel; KVM list Subject: Re: [PATCH 4/4] Enable kvm

[Qemu-devel] [PATCH 10/10] RTC: Allow to migrate from old QEMU

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com The new logic is compatible with old, and it should not block migration from old QEMU. However, the new version cannot migrate to the old one. Cc: Juan Quintela quint...@redhat.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo

[Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it

2012-08-01 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Calculate guest RTC based on the time of the last update, instead of using timers. The formula is (base_rtc + guest_time_now - guest_time_last_update + offset) Base_rtc is the RTC value when the RTC was last updated. Guest_time_now is the guest time

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-08-01 Thread Blue Swirl
On Wed, Aug 1, 2012 at 6:45 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/07/2012 22:38, Blue Swirl ha scritto: It's a whole lot of churn though, and clobbers the history for most QMP functions. It also seems like a strange thing for clang to complain about... Not really, it's just

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-01 Thread Scott Wood
On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777; qemu-devel

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-01 Thread Blue Swirl
On Wed, Aug 1, 2012 at 9:09 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors. Make libqblock-test could build the code. For

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-01 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777; qemu-devel qemu-devel; KVM list Subject: Re: [PATCH 4/4] Enable kvm

Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-08-01 Thread Alex Williamson
On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: On 2012-08-01 07:18, Alex Williamson wrote: +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE + 14) + +#endif /* VFIO_H */ Please patch update-linux-headers.sh and let it do its work instead (separate patches). Unfortunately

[Qemu-devel] [PULL 00/11] Migration next

2012-08-01 Thread Juan Quintela
://repo.or.cz/r/qemu/quintela.git migration-next-20120801 for you to fetch changes up to 7bff472b8fba64b7417c243d2132422afc0c2137: Restart optimization on stage3 update version (2012-08-01 19:56:57 +0200) Juan Quintela (1): Restart optimization on stage3 update version Orit Wasserman (10): Add

[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-08-01 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- docs/xbzrle.txt | 136 1 file changed, 136 insertions(+) create mode 100644 docs/xbzrle.txt

[Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-08-01 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info migrate-cache-size'

Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported

2012-08-01 Thread Alex Williamson
On Wed, 2012-08-01 at 09:15 +0200, Jan Kiszka wrote: On 2012-08-01 07:18, Alex Williamson wrote: Signed-off-by: Alex Williamson alex.william...@redhat.com --- MAINTAINERS |5 + configure | 12 hw/i386/Makefile.objs |1 + 3 files

[Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions

2012-08-01 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- cutils.c | 33 + qemu-common.h | 8 2 files changed, 41

[Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-08-01 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com ---

[Qemu-devel] [PATCH v2 0/6] Clang patches

2012-08-01 Thread Blue Swirl
With this patch set, I'm able to compile AREG0 free softmmu targets. v1-v2: redo QAPI change (#3), new patches 5 and 6. Blue Swirl (6): sparc: fix floppy TC line setup sparc: fix expression with uninitialized initial value qapi: avoid reserved keywords user: fix accidental AREG0 use

Re: [Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump

2012-08-01 Thread Anthony Liguori
Jason Baron jba...@redhat.com writes: Add a new '[,dump_guest_core=on|off]' option to the '-machine' option. When 'dump_guest_core=off' is specified, guest memory is omitted from the core dump. The default behavior continues to be to include guest memory when a core dump is triggered. In

[Qemu-devel] [PATCH v2 1/6] sparc: fix floppy TC line setup

2012-08-01 Thread Blue Swirl
The qemu_irq for Terminal Count (TC) line between FDC and Slavio misc device was created only after use, spotted by Clang compiler. Also, it was not created if the FDC didn't exist. Rearrange code to fix order. Always create the TC line. Signed-off-by: Blue Swirl blauwir...@gmail.com ---

[Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value

2012-08-01 Thread Blue Swirl
err was uninitialized, it's not OK to use |=. Spotted by Clang compiler. Fix by implementing the earlier statement which initializes the variable. Signed-off-by: Blue Swirl blauwir...@gmail.com --- linux-user/signal.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords

2012-08-01 Thread Blue Swirl
Clang compiler complained about use of reserved word 'restrict' in SLIRP and QAPI. Prefix C keywords with q_, adjust SLIRP accordingly. Signed-off-by: Blue Swirl blauwir...@gmail.com --- net/slirp.c |6 +++--- scripts/qapi.py | 16 2 files changed, 19 insertions(+), 3

<    1   2   3   4   >