[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-08-02 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index

Re: [Qemu-devel] [PATCH v1 00/34]: add new error format

2012-08-02 Thread Luiz Capitulino
On Wed, 1 Aug 2012 22:02:20 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: Quick summary first, long introduction afterwards. From the rfc: o rebased on top of master o dropped patch qapi: qapi.py: allow the ' character be escaped o split patch qerror: drop qerror_abort() into

Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno

2012-08-02 Thread Luiz Capitulino
On Wed, 1 Aug 2012 22:02:35 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: Next commit wants to use this. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- This patch is an interesting case, because one of the goal of the error format that's being replaced was that callers

Re: [Qemu-devel] [PATCH 06/34] qerror: avoid passing qerr pointer

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 13:23:58 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Helps dropping/modifying qerror functions. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c | 24 1 file changed,

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 15:27, Markus Armbruster ha scritto: +bdev_list = qmp_query_block(NULL); +for (bdev = bdev_list; bdev; bdev = bdev-next) { +if (!strcmp(bdev-value-device, device) +blockinfo_is_encrypted(bdev-value) +

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-02 Thread Peter Maydell
On 2 August 2012 02:16, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- Hello Peter, here's my current draft for subjecting more arm devices to the stricter device checks in libhwX. Please review desired granularity (here: fine-grained) and naming

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 13:35:54 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c | 1 + qapi-schema.json | 7 +-- 2 files changed, 6 insertions(+), 2

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 02/08/2012 15:27, Markus Armbruster ha scritto: +bdev_list = qmp_query_block(NULL); +for (bdev = bdev_list; bdev; bdev = bdev-next) { +if (!strcmp(bdev-value-device, device) +

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 15:53, Markus Armbruster ha scritto: Is this anything that an external application can reproduce? Perhaps we need to keep QERR_DEVICE_ENCRYPTED even if libvirt does not use it, or at least provide an alternative mechanism (e.g. an event) to realize its effect. Not sure I

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-08-02 Thread Eric Blake
On 08/02/2012 06:44 AM, Orit Wasserman wrote: Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-02 Thread Eric Blake
On 08/02/2012 06:44 AM, Orit Wasserman wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela

Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

2012-08-02 Thread Eric Blake
On 08/02/2012 04:16 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qorum.c | 15 +++ s/qorum/quorum/ for the file name. 1 file changed, 15 insertions(+) create mode 100644 block/qorum.c diff --git a/block/qorum.c b/block/qorum.c new file

Re: [Qemu-devel] [PATCH 01/10] alpha-linux-user: Fix signal handling

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: Proper signal numbers were not defined, and EXCP_INTERRUPT was unhandled, leading to all sorts of subtle confusion. Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 03/10] alpha-linux-user: Handle TARGET_SSI_IEEE_RAISE_EXCEPTION properly

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: We weren't aggregating the exceptions, nor raising signals properly. Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org No idea about the alpha details, but looks plausible and

Re: [Qemu-devel] [PATCH 12/34] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 13:53:08 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit changes hmp_cont() to loop through all block devices and proactively set an encryption key for any encrypted device without a valid one. This

Re: [Qemu-devel] [PULL 00/11] Migration next

2012-08-02 Thread Anthony Liguori
On 08/01/2012 01:01 PM, Juan Quintela wrote: Hi Here is the xbzrle pull request. All comments about QMP names addressed. Please, pull The following changes since commit 02d2bd5d57812154cfb978bc2098cf49d551583d: Replace 'struct siginfo' with 'siginfo_t'. (2012-08-01 08:54:07 -0500) are

Re: [Qemu-devel] [PATCH 04/10] linux-user: Sync fcntl.h bits with the kernel

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: For each target, only define the bits that appear in arch/target/include/asm/fcntl.h. Mirror the kernel's asm-generic layout by handling anything undefined afterward. Signed-off-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH 05/10] linux-user: Handle O_SYNC, O_NOATIME, O_CLOEXEC, O_PATH

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 07/10] linux-user: Translate pipe2 flags; add to strace

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH 09/10] alpha-linux-user: Properly handle the non-rt sigprocmask syscall.

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: Name the syscall properly for QEMU, kernel source notwithstanding. Fix syntax errors in the code thus enabled within do_syscall. Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 15:27:33 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit changes the way hmp_change() checks if an encryption key is required for the device to be inserted. Instead of checking for QERR_DEVICE_ENCRYPTED,

Re: [Qemu-devel] [PATCH 10/10] alpha-linux-user: Fix the getpriority syscall

2012-08-02 Thread Peter Maydell
On 25 July 2012 23:10, Richard Henderson r...@twiddle.net wrote: Alpha uses unbiased priority values in the syscall, with the a3 return value signaling error conditions. Therefore, properly interpret the libc getpriority as needed for the guest rather than passing the host value through

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 15:46:48 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 02/08/2012 15:27, Markus Armbruster ha scritto: +bdev_list = qmp_query_block(NULL); +for (bdev = bdev_list; bdev; bdev = bdev-next) { +if (!strcmp(bdev-value-device, device) +

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 15:57:24 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 02/08/2012 15:53, Markus Armbruster ha scritto: Is this anything that an external application can reproduce? Perhaps we need to keep QERR_DEVICE_ENCRYPTED even if libvirt does not use it, or at least

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-02 Thread Andreas Färber
Am 02.08.2012 15:48, schrieb Peter Maydell: On 2 August 2012 02:16, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- Hello Peter, here's my current draft for subjecting more arm devices to the stricter device checks in libhwX. Please review desired

Re: [Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 10:37, Hervé Poussineau ha scritto: Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using DC390 driver) - MS

Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

2012-08-02 Thread Benoît Canet
Le Thursday 02 Aug 2012 à 08:04:46 (-0600), Eric Blake a écrit : On 08/02/2012 04:16 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qorum.c | 15 +++ s/qorum/quorum/ for the file name. ack 1 file changed, 15 insertions(+) create

Re: [Qemu-devel] [PATCH 1/2] Allow QEMUMachine to override reset sequencing

2012-08-02 Thread Lluís Vilanova
David Gibson writes: [...] diff --git a/vl.c b/vl.c index 9fea320..ac47a7c 100644 --- a/vl.c +++ b/vl.c @@ -1410,6 +1410,14 @@ void qemu_system_reset(bool report) cpu_synchronize_all_post_reset(); } +void qemu_system_reset(bool report) +{ +if (current_machine-reset) +

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-02 Thread Peter Maydell
On 2 August 2012 15:53, Andreas Färber afaer...@suse.de wrote: Am 02.08.2012 15:48, schrieb Peter Maydell: On 2 August 2012 02:16, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- Hello Peter, here's my current draft for subjecting more arm devices to

Re: [Qemu-devel] [PATCH v3] Support 'help' as a synonym for '?' in command line options

2012-08-02 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. This change means that in some cases where we were being lazy in our

Re: [Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 02/08/2012 10:37, Hervé Poussineau ha scritto: Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using

Re: [Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 02/08/2012 10:37, Hervé Poussineau ha scritto: Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using

Re: [Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 17:09, Hervé Poussineau ha scritto: Paolo Bonzini a écrit : Il 02/08/2012 10:37, Hervé Poussineau ha scritto: Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22

Re: [Qemu-devel] [PATCH 14/34] net: inet_connect(), inet_connect_opts(): add in_progress argument

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: It's used to indicate the special case where a valid file-descriptor is returned (ie. success) but the connection can't be completed w/o blocking. Why callers need that isn't obvious from this patch. I assume it becomes obvious later in this

Re: [Qemu-devel] [PATCH 04/10] linux-user: Sync fcntl.h bits with the kernel

2012-08-02 Thread Richard Henderson
On 2012-08-02 07:34, Peter Maydell wrote: No entries for TARGET_M68K? I checked and I think that's the only supported arch which isn't listed here and isn't only using the asm-generic values. (It's the same 4 defines as TARGET_ARM.) I didn't notice because it was missing beforehand. The

Re: [Qemu-devel] [PATCH 1/2] Allow QEMUMachine to override reset sequencing

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 05:50, Benjamin Herrenschmidt ha scritto: This sort of stuff is either (1) hard coded in a firmware/flashrom or (2) built dynamically in firmware. Let's not pretend like we're doing this because it's needed for real hardware. Doesn't matter, we do things like -kernel

Re: [Qemu-devel] [PATCH 1/2] qom: add missing 'const' in documentation sample

2012-08-02 Thread Andreas Färber
Am 02.08.2012 10:40, schrieb Hervé Poussineau: Signed-off-by: Hervé Poussineau hpous...@reactos.org Acked-by: Andreas Färber afaer...@suse.de /-F --- include/qemu/object.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/object.h

Re: [Qemu-devel] [PATCH 10/10] alpha-linux-user: Fix the getpriority syscall

2012-08-02 Thread Richard Henderson
On 2012-08-02 07:48, Peter Maydell wrote: Sanity check -- it is only getpriority that has the biasing, not setpriority? Correct. r~

Re: [Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 10:40, schrieb Hervé Poussineau: Signed-off-by: Hervé Poussineau hpous...@reactos.org Reviewed-by: Andreas Färber afaer...@suse.de Thanks, Andreas --- hw/esp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index

[Qemu-devel] [Bug 1032048] Re: qemu-kvm 1.1.x can't 'make', guest: 'arm', host: x86_64

2012-08-02 Thread Andreas Färber
qemu-kvm does not support arm guests. Use qemu-1.1.1 instead. ** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1032048 Title: qemu-kvm 1.1.x can't

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
Ping? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-02 Thread Andreas Färber
Am 02.08.2012 04:10, schrieb David Gibson: A number of things need to occur during reset of the PAPR paravirtualized platform in a specific order. For example, the hash table needs to be cleared before the CPUs are reset, so that they initialize their register state correctly, and the CPUs

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 17:41, schrieb Peter Maydell: Ping? Alex? Christian? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a

Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno

2012-08-02 Thread Markus Armbruster
[cc: Juan Amos] Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 1 Aug 2012 22:02:35 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: Next commit wants to use this. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- This patch is an interesting case, because one of

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Alexander Graf
On 02.08.2012, at 17:46, Andreas Färber wrote: Am 02.08.2012 17:41, schrieb Peter Maydell: Ping? Alex? Christian? Looks good to me, and should probably go in through the kvm queue. Avi, Marcelo? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code

Re: [Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 10:40, Hervé Poussineau ha scritto: Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index c6422ad..4b00889 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -816,7

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-02 Thread Alexander Graf
On 01.08.2012, at 19:27, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777; qemu-devel

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-02 Thread Alexander Graf
On 01.08.2012, at 19:36, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List; kvm-...@vger.kernel.org; Bhushan Bharat-R65777; qemu-devel

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-02 Thread Andreas Färber
Am 02.08.2012 17:01, schrieb Peter Maydell: On 2 August 2012 15:53, Andreas Färber afaer...@suse.de wrote: In practice, it seemed that usage of these devices is rather fragmented (not all boards use all PLxxx devices) so that per-device config names as in master allow for fine-grained control

Re: [Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

2012-08-02 Thread Markus Armbruster
[cc: Amos] Luiz Capitulino lcapitul...@redhat.com writes: This error is currently returned by inet_connect_opts(), however it causes the follow spurious message on HMP: (qemu) migrate tcp:0: migrate: Connection can not be completed immediately (qemu) But migration

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-02 Thread Alexander Graf
On 01.08.2012, at 20:00, Scott Wood wrote: On 08/01/2012 12:27 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, August 01, 2012 7:57 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org List;

Re: [Qemu-devel] [PATCH 15/27] block: block_int: include qerror.h

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 01 Aug 2012 14:42:02 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Several block/ files are relying on qerror.h being provided by qapi-types.h. However, qapi-types.h won't provide it

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 18.07.2012 13:10, schrieb Peter Maydell: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the common Linux architecture name and QEMU

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-02 Thread Corey Bryant
On 07/25/2012 11:57 PM, Corey Bryant wrote: On 07/25/2012 03:43 PM, Eric Blake wrote: On 07/23/2012 07:08 AM, Corey Bryant wrote: When qemu_open is passed a filename of the /dev/fdset/nnn format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within

[Qemu-devel] [PATCH v3 06/10] RTC: Update the RTC clock only when reading it

2012-08-02 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Calculate guest RTC based on the time of the last update, instead of using timers. The formula is (base_rtc + guest_time_now - guest_time_last_update + offset) Base_rtc is the RTC value when the RTC was last updated. Guest_time_now is the guest time

[Qemu-devel] [PATCH v3 07/10] RTC: Add divider reset support

2012-08-02 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com The first update cycle begins one-half seconds after divider reset is removed. This feature is useful for testing. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 50

Re: [Qemu-devel] [RFC 12/12] qorum: build feature into QEMU.

2012-08-02 Thread Andreas Färber
Am 02.08.2012 12:16, schrieb Benoît Canet: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs |1 + 1 file changed, 1 insertion(+) diff --git a/block/Makefile.objs b/block/Makefile.objs index b5754d3..6ff9ba7 100644 --- a/block/Makefile.objs +++

Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

2012-08-02 Thread Andreas Färber
Am 02.08.2012 12:16, schrieb Benoît Canet: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qorum.c | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 block/qorum.c Did you forget to add the header file, or did you mean source file? :) Andreas -- SUSE

[Qemu-devel] [PATCH v3 05/10] vmstate: add VMSTATE_TIMER_V

2012-08-02 Thread Paolo Bonzini
Also, for consistency with other occurrences, implement VMSTATE_TIMER as a special case of VMSTATE_TIMER_V rather than VMSTATE_TIMER_TEST. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vmstate.h |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vmstate.h

[Qemu-devel] [PATCH v3 10/10] RTC: Remove the current_tm field

2012-08-02 Thread Paolo Bonzini
This is not used anymore and only written to. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index a609f72..d63554f 100644 --- a/hw/mc146818rtc.c +++

Re: [Qemu-devel] [PATCH for-1.2 1/4] qemu-thread: Let qemu_thread_is_self() return bool

2012-08-02 Thread Andreas Färber
Am 02.08.2012 08:27, schrieb Stefan Weil: Am 02.08.2012 02:48, schrieb Andreas Färber: qemu_cpu_is_self(), passing the return value through, will later be adapted to return bool as well. Signed-off-by: Andreas Färber afaer...@suse.de --- qemu-thread-posix.c |2 +-

[Qemu-devel] [PATCH v3 01/10] RTC: Remove the logic to update time format when DM bit changed

2012-08-02 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is used for those registers. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
On 2 August 2012 17:01, Andreas Färber afaer...@suse.de wrote: One minor nit: The indentation seems off here - esac 2 spaces, if 4. configure's indentation is pretty inconsistent generally between 2 or 4 spaces. I usually go for 4 for new code but don't reindent old code. (There's a lot more

Re: [Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 17:12, Paolo Bonzini ha scritto: I can take this patch in the SCSI tree, but... do we really need two models, considering that the PCI id is the same and that (for the coolness factor of installing NT 3.1 onto an empty VM) we can just add ESP support to SeaBIOS? Does the

Re: [Qemu-devel] [PATCH 4/4] Enable kvm emulated watchdog

2012-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Wednesday, August 01, 2012 11:31 PM To: Bhushan Bharat-R65777 Cc: Alexander Graf; qemu-...@nongnu.org List; kvm-...@vger.kernel.org; qemu- devel qemu-devel; KVM list Subject: Re: [PATCH 4/4] Enable kvm emulated watchdog On

[Qemu-devel] [PATCH v3 02/10] RTC: Rename rtc_timer_update

2012-08-02 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 18:22, schrieb Peter Maydell: On 2 August 2012 17:01, Andreas Färber afaer...@suse.de wrote: One minor nit: The indentation seems off here - esac 2 spaces, if 4. configure's indentation is pretty inconsistent generally between 2 or 4 spaces. I usually go for 4 for new code but

Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-08-02 Thread Alex Williamson
On Thu, 2012-08-02 at 11:02 +0200, Jan Kiszka wrote: On 2012-08-01 20:09, Alex Williamson wrote: On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: On 2012-08-01 07:18, Alex Williamson wrote: +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE + 14) + +#endif /* VFIO_H */

[Qemu-devel] [PATCH v3 03/10] RTC: introduce RTC_CLOCK_RATE

2012-08-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index b99f4d3..175ddac 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -46,6 +46,7 @@ #endif

[Qemu-devel] [PATCH v3 04/10] RTC: Update interrupt state when interrupts are masked/unmasked

2012-08-02 Thread Paolo Bonzini
From: Yang Zhang yang.z.zh...@intel.com If an interrupt flag is already set when the interrupt becomes enabled, raise an interrupt immediately, and vice versa if interrupts become disabled. Signed-off-by: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-08-02 Thread Jan Kiszka
On 2012-08-02 18:37, Alex Williamson wrote: On Thu, 2012-08-02 at 11:02 +0200, Jan Kiszka wrote: On 2012-08-01 20:09, Alex Williamson wrote: On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: On 2012-08-01 07:18, Alex Williamson wrote: +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE

Re: [Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

2012-08-02 Thread Benoît Canet
Did you forget to add the header file, or did you mean source file? :) I was thinking GPL header when typing this line :) Benoît

Re: [Qemu-devel] [PATCH 25/34] qerror: qerror_table: don't use C99 struct initializers

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This allows for changing QERR_ macros to initialize two struct members at the same time. See next commit for more details. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c | 276

Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 17:50:30 +0200 Markus Armbruster arm...@redhat.com wrote: [cc: Juan Amos] Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 1 Aug 2012 22:02:35 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: Next commit wants to use this. Signed-off-by: Luiz

[Qemu-devel] [PATCH v3 09/10] RTC: Get and set time without going through s-current_tm

2012-08-02 Thread Paolo Bonzini
This patch makes rtc_set_time and rtc_set_cmos work without reading s-current_tm. In the case of rtc_set_time I introduce a new function that retrieves the time and stores into a given struct tm (not hard-coded to s-current_tm). In the case of rtc_set_cmos, the current time is similarly taken

[Qemu-devel] [PATCH v3 08/10] RTC: Do not fire timer periodically to catch next alarm

2012-08-02 Thread Paolo Bonzini
This patch limits further the usage of a periodic timer. It computes the time of the next alarm, and uses it to skip all intermediate occurrences of the timer. Cc: Yang Zhang yang.z.zh...@intel.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 117

Re: [Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

2012-08-02 Thread Michael Roth
On Wed, Aug 01, 2012 at 10:02:37PM -0300, Luiz Capitulino wrote: This error is currently returned by inet_connect_opts(), however it causes the follow spurious message on HMP: (qemu) migrate tcp:0: migrate: Connection can not be completed immediately (qemu) But migration

Re: [Qemu-devel] [PATCH 26/34] error, qerror: add ErrorClass argument to error functions

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: The new argument is added to functions qerror_report() and error_set(). It's stored in Error and QError. qerror_report_err() is also updated to take care of it. The QERR_ macros are changed to contain a place holder value for the new argument,

[Qemu-devel] [PATCH v3 00/10] Remove periodic wakeup from RTC timer

2012-08-02 Thread Paolo Bonzini
The current RTC emulation has two timers firing every second, one on each edge of the UIP bit. This will prevent CPUs from staying at deep C-states. Intel's measurements from previous submissions show the C6 residency reduced by 6% when running 64 idle guests. The following patches remove the

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-08-02 Thread Orit Wasserman
On 08/02/2012 04:58 PM, Eric Blake wrote: On 08/02/2012 06:44 AM, Orit Wasserman wrote: Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-02 Thread Orit Wasserman
On 08/02/2012 05:01 PM, Eric Blake wrote: On 08/02/2012 06:44 AM, Orit Wasserman wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This commit replaces the place holder value for the ErrorClass argument with a proper ErrorClass value for all QERR_ macros. All current errors are mapped to GenericError, except for errors CommandNotFound, DeviceNotActive, DeviceNotFound,

Re: [Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS

2012-08-02 Thread Luiz Capitulino
On Thu, 2 Aug 2012 11:54:11 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Wed, Aug 01, 2012 at 10:02:37PM -0300, Luiz Capitulino wrote: This error is currently returned by inet_connect_opts(), however it causes the follow spurious message on HMP: (qemu) migrate tcp:0:

Re: [Qemu-devel] [PATCH 29/34] qmp: switch to the new error format on the wire

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: IMPORTANT: this BREAKS QMP's compatibility for the error response. This commit changes QMP's wire protocol to make use of the simpler error format introduced by previous commits. There are two important (and mostly incompatible) changes: 1.

Re: [Qemu-devel] [PATCH 29/34] qmp: switch to the new error format on the wire

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 19:12:03 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: IMPORTANT: this BREAKS QMP's compatibility for the error response. This commit changes QMP's wire protocol to make use of the simpler error format introduced by

Re: [Qemu-devel] [PATCH 31/34] error, qerror: pass desc string to error calls

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This commit changes all QERR_ macros to contain a human message (ie. the desc string found in qerr_table[]) instead of a json dictionary in string format. Before this commit, error_set() and qerror_report() would receive a json dictionary in

Re: [Qemu-devel] [PATCH 33/34] error: drop error_get_qobject()/error_set_qobject()

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: They are not used anymore. Also drops error_int.h. Squash into PATCH 32?

Re: [Qemu-devel] [PATCH v1 00/34]: add new error format

2012-08-02 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Quick summary first, long introduction afterwards. From the rfc: o rebased on top of master o dropped patch qapi: qapi.py: allow the ' character be escaped o split patch qerror: drop qerror_abort() into two patches o fixed

[Qemu-devel] [PATCH 1/2] configure: Don't run Xen compile checks in subshells

2012-08-02 Thread Peter Maydell
The Xen compile checks are currently run inside subshells. This is unnecessary and has the effect that if do_cc() exits with an error message then this only causes the subshell to exit, not the whole of configure, which is confusing. Remove the subshells, changing: if ( cat ; compile_prog ) ;

[Qemu-devel] [PATCH 0/2] configure: fix minor issues in Xen checks

2012-08-02 Thread Peter Maydell
These patches fix some minor issues in the Xen checks: * the use of subshells meant that the (not yet committed) bail out on -Werror failure check in do_cc didn't actually cause the configure run to stop * the 4.1 probe code had a set-but-unused-variable warning Blue: with these two I'm

[Qemu-devel] [PATCH 2/2] configure: Fix set-but-not-used warning in Xen 4.1 probe

2012-08-02 Thread Peter Maydell
The Xen 4.1 probe never uses the return value from xc_interface_open(), so was provoking a compiler warning on newer gcc. Fix by not bothering to put the return value anywhere. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- configure |3 +-- 1 file changed, 1 insertion(+), 2

Re: [Qemu-devel] [PATCH v2] memory: add cmd line option, to omit guest memory from qemu core dump

2012-08-02 Thread Luiz Capitulino
On Wed, 01 Aug 2012 13:21:57 -0500 Anthony Liguori anth...@codemonkey.ws wrote: diff --git a/qemu-config.c b/qemu-config.c index 5c3296b..5c2c9a9 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -595,6 +595,10 @@ static QemuOptsList qemu_machine_opts = { .name =

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-02 Thread Anthony Liguori
Benoît Canet benoit.ca...@gmail.com writes: This patchset create a block driver implementing a qorum using three qemu disk images. Writes are mirrored on the three files. For the reading part the three files are read at the same time and a vote is done to determine which is the majoritary

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-02 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 02.08.2012 04:10, schrieb David Gibson: A number of things need to occur during reset of the PAPR paravirtualized platform in a specific order. For example, the hash table needs to be cleared before the CPUs are reset, so that they initialize their

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-02 Thread Anthony Liguori
Corey Minyard tcminy...@gmail.com writes: On 08/01/2012 09:40 PM, Anthony Liguori wrote: Corey Minyard cminy...@mvista.com writes: On 08/01/2012 08:15 PM, Kevin O'Connor wrote: Well, I should also probably add the ACPI name space definition for this information, too, and the SMBIOS

Re: [Qemu-devel] [PATCH 2/2] pseries: Use new hook to correct reset sequence

2012-08-02 Thread Andreas Färber
Am 02.08.2012 20:29, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: Anthony was favoring moving reset code out of machines and expressed dislike for looping through CPUs, which my above patch took into account. The ordering issue between CPU and devices is still unsolved

[Qemu-devel] [PATCH v2 0/4] VFIO-based PCI device assignment for QEMU 1.2

2012-08-02 Thread Alex Williamson
v2: - Update kernel header update script - Pull in all changes as a result of that - Note that vfio.h is non yet and installed header, but I'll fix that on my next kernel vfio pull request. - New tag for v2 as noted below. Thanks, Alex VFIO kernel support was just merged into Linux, so

[Qemu-devel] [PATCH v2 1/4] Update kernel header script to include vfio

2012-08-02 Thread Alex Williamson
Signed-off-by: Alex Williamson alex.william...@redhat.com --- scripts/update-linux-headers.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 9d2a4bc..270d32b 100755 ---

[Qemu-devel] [PATCH v2 2/4] Update Linux kernel headers

2012-08-02 Thread Alex Williamson
Based on Linux as of 1a9b4993. Note that vfio.h isn't yet an installed header at this commit, but will be fixed soon. Signed-off-by: Alex Williamson alex.william...@redhat.com --- linux-headers/asm-s390/kvm.h |2 linux-headers/asm-s390/kvm_para.h |2 linux-headers/asm-x86/kvm.h

[Qemu-devel] [PATCH v2 4/4] vfio: Enable vfio-pci and mark supported

2012-08-02 Thread Alex Williamson
Signed-off-by: Alex Williamson alex.william...@redhat.com --- MAINTAINERS |5 + configure | 12 hw/i386/Makefile.objs |1 + 3 files changed, 18 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d219d2..9680d69 100644 --- a/MAINTAINERS

<    1   2   3   >