[Qemu-devel] [PATCH v5 0/4] timers thread-safe stuff

2013-09-25 Thread Liu Ping Fan
v5: fine rename some variable in patch24. fix commit log for patch12 v4: fix commit log for protect timers_state's clock with seqlock (Thanks for Alex) v3: 1. rename seqlock_read_check as seqlock_read_retry 2. Document timerlist were protected by BQL, and discard private lock around

[Qemu-devel] [PATCH v5 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-25 Thread Liu Ping Fan
After disabling the QemuClock, we should make sure that no QemuTimers are still in flight. To implement that with light overhead, we resort to QemuEvent. The caller of disabling will wait on QemuEvent of each timerlist. Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb. And

[Qemu-devel] [PATCH v5 1/4] seqlock: introduce read-write seqlock

2013-09-25 Thread Liu Ping Fan
From: Paolo Bonzini pbonz...@redhat.com Seqlock implementation for QEMU. Usage idiom reader: do{ start = seqlock_read_begin() }while(seqlock_read_try(start)) writer: seqlock_write_lock() ... seqlock_write_unlock() initialization: seqlock_init(QemuSeqLock *sl, QemuMutex *mutex)

[Qemu-devel] [PATCH v5 3/4] qemu-thread: add QemuEvent

2013-09-25 Thread Liu Ping Fan
From: Paolo Bonzini pbonz...@redhat.com This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) {

Re: [Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init()

2013-09-25 Thread Fam Zheng
On Fri, 09/20 13:54, Kevin Wolf wrote: Working on a QDict instead of a QemuOpts that accepts anything is more in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has anyway, so this saves additional conversions. And last, but not least, it allows later patches to easily

Re: [Qemu-devel] [PATCH 05/10] xhci: emulate intr endpoint intervals correctly

2013-09-25 Thread Gerd Hoffmann
On Di, 2013-09-24 at 19:55 -0500, Michael Roth wrote: Quoting Gerd Hoffmann (2013-08-28 07:43:01) Respect the interval for interrupt endpoints, so we don't finish transfers as fast as possible but at the rate configured by the guest. Fixes guest deadlocks triggered by interrupt storms.

Re: [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet

2013-09-25 Thread liu ping fan
Hi, is hpet orphan? Or who can help me to merge this patch-set if my patch is fine. Thanks. On Thu, Sep 12, 2013 at 11:25 AM, Liu Ping Fan qemul...@gmail.com wrote: v5: use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, hard code intcap as IRQ2 v4: use stand

[Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-09-25 Thread Klaus Hochlehnert
I had a chance to test it again. I used qemu 1.6.0 now for this. And the installation works now for virtio and ide. Thanks for fixing this, Klaus -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH v5 2/4] timer: protect timers_state's clock with seqlock

2013-09-25 Thread Liu Ping Fan
QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its foundation, i.e. cpu_clock_offset exposed to race condition. Using private lock to protect it. After this patch, reading QEMU_CLOCK_VIRTUAL is thread safe unless use_icount is true, in which case the existing callers still rely on the

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: When I added support for the Q35-based machinetypes to libvirt, I specifically prohibited attaching any PCI devices (with the exception of graphics controllers) to the PCIe root complex, That's wrong I think. Anything attached to RC

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

2013-09-25 Thread Stefan Hajnoczi
On Wed, Sep 25, 2013 at 08:58:10AM +0800, Fam Zheng wrote: On Tue, 09/24 14:49, Stefan Hajnoczi wrote: On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote: Since commit block: Error parameter for open functions, error output is more verbose. Update test case output file to follow

Re: [Qemu-devel] [PATCH v5 1/4] seqlock: introduce read-write seqlock

2013-09-25 Thread Paolo Bonzini
Il 25/09/2013 08:20, Liu Ping Fan ha scritto: From: Paolo Bonzini pbonz...@redhat.com Seqlock implementation for QEMU. Usage idiom reader: do{ start = seqlock_read_begin() }while(seqlock_read_try(start)) writer: seqlock_write_lock() ... seqlock_write_unlock()

[Qemu-devel] [PATCH] pseries: Fix loading of little endian kernels

2013-09-25 Thread Anton Blanchard
From: Benjamin Herrenschmidt b...@kernel.crashing.org Try loading the kernel as little endian if it fails big endian. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Reviewed-by: Anton Blanchard an...@samba.org --- Index: b/hw/ppc/spapr.c

[Qemu-devel] [PATCH] ppc: Add CFAR, DAR and DSISR to the dictionary of printable registers

2013-09-25 Thread Anton Blanchard
From: Tom Musta tommu...@gmail.com The CFAR, DAR and DSISR registers are currently missing from the dictionary of registers that may be printed in the QEMU console. These are interesting registers when debugging. With this patch, the following commands work properly: (qemu) print $cfar

[Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-09-25 Thread Paolo Bonzini
** Changed in: qemu Status: In Progress = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1191606 Title: qemu crashes with iscsi initiator (libiscsi) when using virtio Status in

[Qemu-devel] [PATCH] target-ppc: Little Endian Correction to Load/Store Vector Element

2013-09-25 Thread Anton Blanchard
From: Tom Musta tommu...@gmail.com The Load Vector Element (lve*x) and Store Vector Element (stve*x) instructions not only byte-swap in Little Endian mode, they also invert the element that is accessed. For example, the RTL for lvehx contains this: eb -- EA[60:63] if Big-Endian byte

[Qemu-devel] [PATCH 1/2] roms: enable parallel seabios / seavgabios builds

2013-09-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 29 ++- roms/{config.vga.cirrus = config.vga-cirrus} | 0 roms/{config.vga.isavga = config.vga-isavga} | 0 roms/{config.vga.qxl = config.vga-qxl} | 0

[Qemu-devel] [PATCH 2/2] roms: add support for building sgabios

2013-09-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/Makefile | 9 + 1 file changed, 9 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 6994873..10d5a65 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -50,6 +50,7 @@ default: @echo bios -- update

Re: [Qemu-devel] [PATCH] rbd: avoid qemu_rbd_snap_list() memory leak when no snapshots

2013-09-25 Thread Kevin Wolf
Am 25.09.2013 um 02:28 hat Michael Roth geschrieben: Quoting Stefan Hajnoczi (2013-08-14 07:13:52) When there are no snapshots qemu_rbd_snap_list() returns 0 and the snapshot table pointer is NULL. Don't forget to free the snaps buffer we allocated for librbd rbd_snap_list(). Cc:

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-25 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:55:04PM -0400, Tim Epkes wrote: I just tested the most recent version of qemu (1.4). I have 2 virtual images back to back via a tcp socket. They can ping eachother, but when I down the listener and bring it back up (meaning killing the kvm and relaunching) it

Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup

2013-09-25 Thread Stefan Hajnoczi
On Fri, Sep 20, 2013 at 01:12:37PM -0400, Jeff Cody wrote: Changes in v3: Patch 1: MANIFEST file dropped. Instead of bunzip2, use bzcat. Check error return of bzcat. Don't attempt to remove $SAMPLE_IMG_FILE if the variable is blank. Patch 2: MANIFEST file dropped.

Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-25 Thread Kevin Wolf
Am 25.09.2013 um 03:14 hat Fam Zheng geschrieben: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-25 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:19:29PM +0100, Alex Bennée wrote: stefa...@redhat.com writes: On Mon, Sep 23, 2013 at 05:07:27PM +0100, alex.ben...@linaro.org wrote: Given I found a couple of issues while doing this I think this is useful alongside the existing buildbot efforts. It allows

Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-25 Thread Fam Zheng
On Wed, 09/25 10:27, Kevin Wolf wrote: Am 25.09.2013 um 03:14 hat Fam Zheng geschrieben: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059

Re: [Qemu-devel] [PATCH 3/3] block/stream.c: ensure copy always set

2013-09-25 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:27:49PM +0100, Alex Bennée wrote: stefa...@redhat.com writes: On Mon, Sep 23, 2013 at 05:07:30PM +0100, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This only showed up when compiling with --enable-trace-backend=stderr|ftrace at which

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Marcel Apfelbaum
On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: When I added support for the Q35-based machinetypes to libvirt, I specifically prohibited attaching any PCI devices (with the exception of graphics controllers) to the

Re: [Qemu-devel] qemu-1.6.0 under Cygwin64 ./configure failed

2013-09-25 Thread Alexander Voropay
Trying to buld qemu 1.6.0 with MinGW64 unger Cygwin64. Basically it works with current `configure` script but linker requres alot of libraries built for MinGW64 $ export CC=x86_64-w64-mingw32-gcc $ ./configure --target-list=arm-softmmu --disable-strip --disable-xen --disable-kvm --disable-user

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 11:48:28AM +0300, Marcel Apfelbaum wrote: On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: When I added support for the Q35-based machinetypes to libvirt, I specifically prohibited attaching

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-09-25 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 01:48:12PM -0500, Anthony Liguori wrote: On Sep 23, 2013 8:46 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Sep 10, 2013 at 08:08:22PM -0400, Joey Carlini wrote: I managed to get QEMU running on a Crouton install, virtual box not being possible with the

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-09-25 Thread Alexey Kardashevskiy
On 09/17/2013 12:16 AM, Alexey Kardashevskiy wrote: On 09/10/2013 02:15 PM, Alexey Kardashevskiy wrote: On 08/16/2013 08:35 AM, Andreas Färber wrote: Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the lack

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Zhanghaoyu (A)
Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen. Good catch. I want to do below works to resolve this problem, 1. change NICConf's

[Qemu-devel] [PATCH v3 0/2] Fix and add test into 059.

2013-09-25 Thread Fam Zheng
The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. v3: filter test dir in script and output file. v2: Drop space changes Fam Zheng (2): qemu-iotests: fix test case 059 qemu-iotests: add monolithicFlat creation test to

[Qemu-devel] [PATCH v3 1/2] qemu-iotests: fix test case 059

2013-09-25 Thread Fam Zheng
Since commit block: Error parameter for open functions, error output is more verbose. Update test case output file to follow the change. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v3 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-25 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index b03429d..b6f9703 100755 --- a/tests/qemu-iotests/059 +++

Re: [Qemu-devel] [PATCH v5 1/4] seqlock: introduce read-write seqlock

2013-09-25 Thread liu ping fan
On Wed, Sep 25, 2013 at 2:20 PM, Liu Ping Fan qemul...@gmail.com wrote: From: Paolo Bonzini pbonz...@redhat.com Seqlock implementation for QEMU. Usage idiom reader: do{ start = seqlock_read_begin() }while(seqlock_read_try(start)) writer: seqlock_write_lock() ...

[Qemu-devel] [PATCH] trace: drop LTTng Userspace Tracer backend

2013-09-25 Thread Stefan Hajnoczi
The current LTTng Userspace Tracer backend does not build against modern libraries. LTTng has changed the library ABI several times, making it difficult to support this backend. Due to lack of users, remove this trace backend until someone turns up who is willing to actively maintain it.

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 09:02:54AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen. Good catch. I

Re: [Qemu-devel] [PATCH v5 3/4] qemu-thread: add QemuEvent

2013-09-25 Thread liu ping fan
On Wed, Sep 25, 2013 at 2:20 PM, Liu Ping Fan qemul...@gmail.com wrote: From: Paolo Bonzini pbonz...@redhat.com This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Laine Stump
On 09/25/2013 04:48 AM, Marcel Apfelbaum wrote: On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: When I added support for the Q35-based machinetypes to libvirt, I specifically prohibited attaching any PCI devices (with

[Qemu-devel] [PATCH v4 1/2] qemu-iotests: fix test case 059

2013-09-25 Thread Fam Zheng
Since commit block: Error parameter for open functions, error output is more verbose. Update test case output file to follow the change. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v4 0/2] Fix and add test into 059.

2013-09-25 Thread Fam Zheng
The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. v4: Bigger image size to catch the cluster size checking issue. v3: filter test dir in script and output file. v2: Drop space changes Fam Zheng (2): qemu-iotests: fix test

[Qemu-devel] [PATCH v4 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-25 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index b03429d..d2b3f9e 100755 --- a/tests/qemu-iotests/059 +++

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Zhanghaoyu (A)
Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen. Good catch. I want to do below works to resolve this problem, 1. change

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 05:39:37AM -0400, Laine Stump wrote: On 09/25/2013 04:48 AM, Marcel Apfelbaum wrote: On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: When I added support for the Q35-based machinetypes to

Re: [Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-25 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 25 September 2013 01:31, alex.ben...@linaro.org wrote: +# Debug related options +- env: TARGETS=i386-softmmu,x86_64-softmmu + EXTRA_CONFIG=--enable-debug --enable-debug-tcg --enable-tcg-interpreter --enable-debug implies

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 09:55:02AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen. Good

[Qemu-devel] [PATCH 0/2] Correct bitmap size in zero cluster expansion

2013-09-25 Thread Max Reitz
The current version of the zero cluster expansion uses the guest disk size for determining the size of the expanded_clusters bitmap, however, it is addressed using host offsets. This leads to an assertion failing if the host image size exceeds the guest disk size. This is fixed by using the host

[Qemu-devel] [PATCH 2/2] qemu-iotests: Preallocated zero clusters in 061

2013-09-25 Thread Max Reitz
Add a test case for zero cluster expansion on an image completely filled with preallocated zero clusters to test 061. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/061 | 9 + tests/qemu-iotests/061.out | 11 +++ 2 files changed, 20 insertions(+) diff

[Qemu-devel] [PATCH 1/2] qcow2: Correct bitmap size in zero expansion

2013-09-25 Thread Max Reitz
Since the expanded_clusters bitmap is addressed using host offsets in the underlying image file, the correct size to use for allocating the bitmap is not determined by the guest disk image but by the underlying host image file. Furthermore, this size may change during the expansion due to cluster

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Laine Stump
On 09/25/2013 06:00 AM, Michael S. Tsirkin wrote: On Wed, Sep 25, 2013 at 05:39:37AM -0400, Laine Stump wrote: However it is done, each controller will need to have two sets of flags - one for what it can plug into, and one for what can be plugged into it. Not just into it - what can be

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Zhanghaoyu (A)
Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen. Good catch. I want to do below works to resolve this problem, 1.

Re: [Qemu-devel] [PATCH v4 0/2] Fix and add test into 059.

2013-09-25 Thread Kevin Wolf
Am 25.09.2013 um 11:45 hat Fam Zheng geschrieben: The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. v4: Bigger image size to catch the cluster size checking issue. v3: filter test dir in script and output file. v2:

Re: [Qemu-devel] [PATCH] memory: fix 128 arithmetic in info mtree

2013-09-25 Thread Alexey Kardashevskiy
On 09/10/2013 02:19 PM, Alexey Kardashevskiy wrote: On 08/30/2013 06:10 PM, Alexey Kardashevskiy wrote: mtree_print_mr() calls int128_get64() in 3 places but only 2 places handle 2^64 correctly. This fixes the third call of int128_get64(). Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 10:14:49AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time network disconnection probably happen.

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 06:14:27AM -0400, Laine Stump wrote: On 09/25/2013 06:00 AM, Michael S. Tsirkin wrote: On Wed, Sep 25, 2013 at 05:39:37AM -0400, Laine Stump wrote: However it is done, each controller will need to have two sets of flags - one for what it can plug into, and one for

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 01:56:20PM +0300, Michael S. Tsirkin wrote: On Wed, Sep 25, 2013 at 06:14:27AM -0400, Laine Stump wrote: On 09/25/2013 06:00 AM, Michael S. Tsirkin wrote: On Wed, Sep 25, 2013 at 05:39:37AM -0400, Laine Stump wrote: However it is done, each controller will need to

[Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest

2013-09-25 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects

[Qemu-devel] [PATCH v5 03/23] qom: cleanup struct Error references

2013-09-25 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 51 +-- 1 file

[Qemu-devel] [PATCH v5 05/23] fw_cfg: interface to trigger callback on read

2013-09-25 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h index f60dd67..2ab0fc2

[Qemu-devel] [PATCH v5 10/23] q35: expose mmcfg size as a property

2013-09-25 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h

[Qemu-devel] [PATCH v5 12/23] acpi: add rules to compile ASL source

2013-09-25 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure

[Qemu-devel] [PATCH v5 01/23] qemu: add Error to typedefs

2013-09-25 Thread Michael S. Tsirkin
This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/typedefs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h

[Qemu-devel] [PATCH v5 06/23] loader: support for unmapped ROM blobs

2013-09-25 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support incoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH v5 02/23] qom: pull in qemu/typedefs

2013-09-25 Thread Michael S. Tsirkin
As usual so we can use typedefs without header dependencies. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qom/object.h b/include/qom/object.h index

[Qemu-devel] [PATCH v5 09/23] q35: use macro for MCFG property name

2013-09-25 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h index

[Qemu-devel] [PATCH v5 15/23] i386: add bios linker/loader

2013-09-25 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH v5 04/23] qom: add pointer to int property helpers

2013-09-25 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 21 ++ qom/object.c | 60

[Qemu-devel] [PATCH v5 16/23] loader: allow adding ROMs in done callbacks

2013-09-25 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/hw/loader.h b/include/hw/loader.h

[Qemu-devel] [PATCH v5 17/23] i386: define pc guest info

2013-09-25 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/i386/pc.c | 35

[Qemu-devel] [PATCH v5 07/23] pcie_host: expose UNMAPPED macro

2013-09-25 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/pcie_host.h

[Qemu-devel] [PATCH v5 19/23] piix: APIs for pc guest info

2013-09-25 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/piix4.h | 8 include/hw/i386/pc.h

[Qemu-devel] [PATCH v5 22/23] hpet: add API to find it

2013-09-25 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 757f79f..ab44bd3 100644 ---

Re: [Qemu-devel] [PATCH v2] block: Fix compiler warning (-Werror=uninitialized)

2013-09-25 Thread Kevin Wolf
Am 22.09.2013 um 08:19 hat Stefan Weil geschrieben: The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3: block/stream.c:141:22: error: ‘copy’ may be used uninitialized in this function [-Werror=uninitialized] This is not a real bug - a better compiler would not complain. Now

[Qemu-devel] [PATCH v5 08/23] pcie_host: expose address format

2013-09-25 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed, 21 insertions(+), 21 deletions(-)

[Qemu-devel] [PATCH v5 20/23] ich9: APIs for pc guest info

2013-09-25 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/ich9.h| 2 ++

[Qemu-devel] [PATCH v5 14/23] loader: use file path size from fw_cfg.h

2013-09-25 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH] qdict: Extract qdict_extract_subqdict.

2013-09-25 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 23 ++- include/qapi/qmp/qdict.h | 2 ++ qobject/qdict.c | 21 + 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v5 21/23] pvpanic: add API to access io port

2013-09-25 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v5 18/23] acpi/piix: add macros for acpi property names

2013-09-25 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 7a343f8..f966cef 100644 --- a/include/hw/i386/pc.h +++

Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-25 Thread Kevin Wolf
Am 24.09.2013 um 17:21 hat Eric Blake geschrieben: On 09/24/2013 09:07 AM, Benoît Canet wrote: Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The .bdrv_needs_filename is set in drivers not having

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-25 Thread Tim Epkes
Well its been a long time since I have coded anything in c and time is a factor (as I just don't have any to spare). I'll have to figure something else out for it. The modifications would be more than net/socket.c, as the client connects to the tcp server/listener and when it goes away, there is

Re: [Qemu-devel] [PATCH] memory: fix 128 arithmetic in info mtree

2013-09-25 Thread Paolo Bonzini
Il 30/08/2013 10:10, Alexey Kardashevskiy ha scritto: mtree_print_mr() calls int128_get64() in 3 places but only 2 places handle 2^64 correctly. This fixes the third call of int128_get64(). Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- memory.c | 4 +++- 1 file changed, 3

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Sep 25, 2013 at 10:14:49AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address will broadcast via qemu_announce_self in destination, so, long time

Re: [Qemu-devel] [PATCH] qdict: Extract qdict_extract_subqdict.

2013-09-25 Thread Kevin Wolf
Am 25.09.2013 um 13:30 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net Thanks, applied to the block branch. (And I like how the subject line sounds :-)) Kevin

[Qemu-devel] [PATCH v3 0/3] qemu-iotests with sample images, vhdx test, cleanup

2013-09-25 Thread Jeff Cody
Changes in v3: One line in patch 3, for test 043: $TEST_IMG.[123].base instead of $TEST_IMG.[123].base. Thanks Stefan. Added Stefan's Reviewed-by to the patches. Changes in v2: Patch 1: MANIFEST file dropped. Instead of bunzip2, use bzcat. Check error return of bzcat.

[Qemu-devel] [PATCH v3 2/3] block: qemu-iotests for vhdx, read sample dynamic image

2013-09-25 Thread Jeff Cody
This adds the VHDX format to the qemu-iotests format, and adds a read test. The test reads from an existing sample image, that was created with Hyper-V under Windwos Server 2012. The image file is a 1GB dynamic image, with 32MB blocks. The pattern 0xa5 exists from 0MB-33MB (past a block size

[Qemu-devel] [PATCH v3 1/3] block: qemu-iotests - add basic ability to use binary sample images

2013-09-25 Thread Jeff Cody
For image formats that are not QEMU native, but supported for compatibility, it is useful to verify that an image created with the 'gold standard' native tool can be read / written to successfully by QEMU. In addition to testing non-native images, this could also be useful to test against image

[Qemu-devel] [PATCH 0/2] block: make aio_poll(ctx, true) block with no fds

2013-09-25 Thread Stefan Hajnoczi
Jan and Alex have expressed that aio_poll(ctx, blocking=true) should block even when there are no file descriptors registered. This can be handy since other threads may still kick the AioContext using aio_notify(ctx). A concrete example is a thread that has only a timer in its AioContext.

[Qemu-devel] [PATCH 2/2] aio: make aio_poll(ctx, true) block with no fds

2013-09-25 Thread Stefan Hajnoczi
This patch drops a special case where aio_poll(ctx, true) returns false instead of blocking if no file descriptors are waiting on I/O. Now it is possible to block in aio_poll() to wait for aio_notify(). This change eliminates busy waiting. bdrv_drain_all() used to rely on busy waiting to

[Qemu-devel] [PATCH 1/2] block: clean up bdrv_drain_all() throttling comments

2013-09-25 Thread Stefan Hajnoczi
Since cc0681c45430a1f1a4c2d06e9499b7775afc9a18 (block: Enable the new throttling code in the block layer.) bdrv_drain_all() no longer spins. The code used to look as follows: do { busy = qemu_aio_wait(); /* FIXME: We do not have timer support here, so this is effectively * a

Re: [Qemu-devel] [RFC] sync NIC's MAC maintained in NICConf as soon as emualted NIC's MAC changed in guest

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 01:39:48PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Sep 25, 2013 at 10:14:49AM +, Zhanghaoyu (A) wrote: Hi, all Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC address

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-25 Thread Mark Wu
Hi guys, Thanks a lot for all your insightful comments. I will post a patch to resolve the O(n2) problem according to Michael's comments soon and rebase the 'success-response' on it. Mark. On 09/25/2013 08:34 AM, Luiz Capitulino wrote: On Tue, 24 Sep 2013 16:07:29 -0500 Michael Roth

Re: [Qemu-devel] [PATCH] ppc: Add CFAR, DAR and DSISR to the dictionary of printable registers

2013-09-25 Thread Alexander Graf
On 25.09.2013, at 09:41, Anton Blanchard wrote: From: Tom Musta tommu...@gmail.com The CFAR, DAR and DSISR registers are currently missing from the dictionary of registers that may be printed in the QEMU console. These are interesting registers when debugging. With this patch, the

Re: [Qemu-devel] [PATCH] target-ppc: Little Endian Correction to Load/Store Vector Element

2013-09-25 Thread Alexander Graf
On 25.09.2013, at 09:42, Anton Blanchard wrote: From: Tom Musta tommu...@gmail.com The Load Vector Element (lve*x) and Store Vector Element (stve*x) instructions not only byte-swap in Little Endian mode, they also invert the element that is accessed. For example, the RTL for lvehx

Re: [Qemu-devel] [PATCH] pseries: Fix loading of little endian kernels

2013-09-25 Thread Alexander Graf
On 25.09.2013, at 09:40, Anton Blanchard wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Try loading the kernel as little endian if it fails big endian. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Reviewed-by: Anton Blanchard an...@samba.org Thanks,

Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest

2013-09-25 Thread Gerd Hoffmann
On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more

Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest

2013-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 02:48:52PM +0200, Gerd Hoffmann wrote: On Mi, 2013-09-25 at 14:22 +0300, Michael S. Tsirkin wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's

[Qemu-devel] qemu-img create: set nocow flag to solve performance issue on btrfs

2013-09-25 Thread Chunyan Liu
Hi, List, Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad performance would be to turn off COW attributes on VM files (since having copy on write for this kind of data is not useful). We

[Qemu-devel] [PATCH] kvm/apic: use QOM style

2013-09-25 Thread xiaoqiang.zhao
Change apic and kvm/apic to use QOM interface. Includes: 1. APICCommonState now use QOM realizefn 2. Remove DO_UPCAST() for APICCommonState 3. Use type constant 4. Change DeviceState pointers from 'd' to 'dev', sounds better? this is my first qemu patch, if there is a problem, please let me konw

[Qemu-devel] [PATCH 03/38] target-ppc: fix bit extraction for FPBF and FPL

2013-09-25 Thread Michael Roth
From: Aurelien Jarno aurel...@aurel32.net Bit extraction for the FP BF and L field of the MTFSFI and MTFSF instructions is wrong and doesn't match the reference manual (which explain the bit number in big endian format). It has been broken in commit 7d08d85645def18eac2a9d672c1868a35e0bcf79. This

  1   2   3   4   >