qemu_chr_fe_write() may return EAGAIN. Therefore, use
qemu_chr_fe_write_all().
Signed-off-by: Michael Walle mich...@walle.cc
---
hw/char/lm32_juart.c |2 +-
hw/char/lm32_uart.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/char/lm32_juart.c
The new MMU tests use longer names.
Signed-off-by: Michael Walle mich...@walle.cc
---
hw/misc/lm32_sys.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
index 9bdb781..8176cdb 100644
--- a/hw/misc/lm32_sys.c
+++
Instead of killing QEMU, translate instructions which are not available on
the CPU model as a noop and issue a log message at translation time.
On the real hardware CPU unknown opcodes results in undefined behaviour.
These changes prepare the removal of CPULM32State from DisasContext.
Cc:
This allows us to completely remove CPULM32State from DisasContext.
Instead, copy the fields we need to DisasContext.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Walle mich...@walle.cc
---
target-lm32/cpu-qom.h |1 +
target-lm32/cpu.h | 12 +---
Instead of translating the instruction to a no-op, pause the VM and display
a message to the user.
As a side effect, this also works for instructions where the operands are
only known at runtime.
Signed-off-by: Michael Walle mich...@walle.cc
---
target-lm32/helper.h|1 +
Introduce new target check_% to run indiviudal test caes, eg.
make check_mmu
Signed-off-by: Michael Walle mich...@walle.cc
---
tests/tcg/lm32/Makefile |3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile
index 9a00ef7..19e0664 100644
---
This will ease debugging the test cases.
Signed-off-by: Michael Walle mich...@walle.cc
---
hw/misc/lm32_sys.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
index 6af0cca..1fd69ff 100644
--- a/hw/misc/lm32_sys.c
+++ b/hw/misc/lm32_sys.c
@@ -81,6
On 14 October 2013 16:36, Peter Maydell peter.mayd...@linaro.org wrote:
Are you sure the logic in this function is right? (ie that we
should only clear the sgi_source[][] bit for this source, and
not completely? If nothing else, I think the interrupt should
stay pending if some other source
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was
eliminated. But we are reading from the target buffer a 16-bit value, which
is in big-endian format. Therefore, swap the bytes if we are building for a
little-endian host.
Cc: Paolo Bonzini pbonz...@redhat.com
On Mon, Oct 14, 2013 at 06:15:25PM +0200, Igor Mammedov wrote:
On Mon, 14 Oct 2013 17:00:47 +0300
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Oct 14, 2013 at 03:04:45PM +0200, Gerd Hoffmann wrote:
Hi,
To me it makes more sense to just go the direct route and say
This patch adds in-target breakpoint and watchpoint support.
Signed-off-by: Michael Walle mich...@walle.cc
---
target-lm32/TODO|2 --
target-lm32/cpu.c |1 +
target-lm32/cpu.h | 27 --
target-lm32/helper.c| 89
Do not use qemu_log().
Signed-off-by: Michael Walle mich...@walle.cc
---
hw/misc/lm32_sys.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
index 8176cdb..6af0cca 100644
--- a/hw/misc/lm32_sys.c
+++ b/hw/misc/lm32_sys.c
@@ -80,7
Il 11/10/2013 03:16, Fam Zheng ha scritto:
This patch adds loading, stamp checking and initialization of modules.
The init function of dynamic module is no longer directly called as
__attribute__((constructor)) in static linked version, it is called
only after passed the checking of presense
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 2f631d4..208e7c2 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1729,7 +1729,8 @@ int vmstate_load_state(QEMUFile *f, const
VMStateDescription
This series cleans up the vmstate save/load code a little, and adds a
max_version_id field to VMStateDescription.
This will be useful in case we need to revert vmstate changes but keep
compatibility with QEMU versions that had a higher version_id. No existing
behavior will be changed by code that
This will allow us to load data that has a high version_id, while using
a lower version_id when saving.
Useful in case we need to revert vmstate changes but keep compatibility
with QEMU versions that had a higher version_id.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
This makes the code more readable, making each condition that makes a
field be skipped much more visible, and reduces one level of indentation
in the code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 156 ---
1
This will make it easier to add code that skips some fields, by simply
using continue.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
savevm.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/savevm.c b/savevm.c
index 208e7c2..9562669 100644
--- a/savevm.c
This will allow fields to have version_id vmsd-version_id, to allow
us to support loading data with higher version_id.
This patch alone is not useful by itself, but it will be useful when
introducing the max_version_id field to VMStateDescription.
Signed-off-by: Eduardo Habkost
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca
---
docs/tracing.txt | 31 +++
1 file changed, 31 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index bfc261b..cbb3aaf 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -214,6 +214,37 @@
Sorry for the delay, just submitted the updated documentation.
Thanks,
Mohamad
On 13-10-07 08:36 AM, Alex Bennée wrote:
mohamad.ge...@gmail.com writes:
Version 2
* Fix tracepoint generation error in first version.
* Avoid warnings and errors specific to LTTng ust 2.0.
* If using LTTng ust
On 10/14/2013 09:29 AM, Michael Walle wrote:
+#ifndef HOST_WORDS_BIGENDIAN
+rgb565 = bswap16(rgb565);
+#endif
be16_to_cpu, no ifdef needed.
r~
Hi,
Am 14.10.2013 18:29, schrieb Michael Walle:
This allows us to completely remove CPULM32State from DisasContext.
Instead, copy the fields we need to DisasContext.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Walle mich...@walle.cc
Sorry for not getting to review this
Am Montag, 14. Oktober 2013, 18:29:24 schrieb Michael Walle:
This is a pull for various updates and fixes for the LatticeMico32 target.
Please pull.
changes since v1:
- rebased
- dropped patch target-lm32: register helper functions. This is
no longer needed.
- added patch
Am Montag, 14. Oktober 2013, 19:05:25 schrieb Richard Henderson:
On 10/14/2013 09:29 AM, Michael Walle wrote:
+#ifndef HOST_WORDS_BIGENDIAN
+rgb565 = bswap16(rgb565);
+#endif
be16_to_cpu, no ifdef needed.
r~
Thanks. I'll update the patch.
--
michael
Am 14.10.2013 18:29, schrieb Michael Walle:
Instead of killing QEMU, translate instructions which are not available on
the CPU model as a noop and issue a log message at translation time.
On the real hardware CPU unknown opcodes results in undefined behaviour.
These changes prepare the
Am 14.10.2013 14:09, schrieb Igor Mammedov:
On Tue, 16 Jul 2013 00:25:53 +0200
Igor Mammedov imamm...@redhat.com wrote:
It's reordered and rebased v8 plus CPUID feature bits conversion to
properties
and cleanups that are removing unused anymore *_feature_name arrays.
dynamic = static
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca
---
configure |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 23dbaaf..627054c 100755
--- a/configure
+++ b/configure
@@ -3287,15 +3287,14 @@ fi
# For 'ust' backend, test if ust
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca
---
docs/tracing.txt | 31 +++
1 file changed, 31 insertions(+)
diff --git a/docs/tracing.txt b/docs/tracing.txt
index bfc261b..64683db 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -214,6 +214,37 @@
Version 3
* Change component name to avoid potential namespace collision with another
project.
* Update ust documentation in docs/tracing.txt.
* Add ust generated files to .gitignore.
Mohamad Gebai (5):
Fix configure script for LTTng 2.x
Modified the tracetool framework for LTTng 2.x.
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca
---
.gitignore |2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..e024a76 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,8 @@ trace/generated-tracers-dtrace.h
trace/generated-tracers.dtrace
* A new format is required to generate definitions for ust tracepoints.
Files ust_events_h.py and ust_events_c.py define common macros, while
new function ust_events_h in events.py does the actual definition of
each tracepoint.
* ust.py generates the new interface for calling userspace
Add generation of new files for LTTng ust.
Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca
---
Makefile|5 +
trace/Makefile.objs | 29 +++--
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index
On Fri, Oct 11, 2013 at 11:38 AM, Eric Blake ebl...@redhat.com wrote:
On 10/11/2013 09:18 AM, Wolfgang Richter wrote:
Idea: Introduce a mode for drive-backup that duplicates writes to
another target, not CoW. It is useful for introspecting (my use
case), and for keeping a remote block device
On Sat, Oct 12, 2013 at 1:47 AM, Fam Zheng f...@redhat.com wrote:
While mirroring write is a good idea, doing it with drive-backup is probably
not. The function of this command is to 'backup' the image with existing data,
instead of new data. With your 'stream' mode, this semantic is changed.
On 10/14/2013 02:10 PM, Wolfgang Richter wrote:
Add the designation '(since 1.7)' to make it obvious when this mode was
introduced.
Done. Is it better to place the updated patch in this thread or start
a new one?
http://wiki.qemu.org/Contribute/SubmitAPatch suggests submitting a new
Michael S. Tsirkin m...@redhat.com writes:
update generated file, not sure what changed
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Tested-by: Gerd Hoffmann kra...@redhat.com
Reviewed-by: Igor Mammedov imamm...@redhat.com
Tested-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Michael
Michael S. Tsirkin m...@redhat.com writes:
Add ACPI based PCI hotplug library with bridge hotplug
support.
Design
- each bus gets assigned bsel property.
- ACPI code writes this number
to a new BNUM register, then uses existing
UP/DOWN registers to probe slot status;
Michael S. Tsirkin m...@redhat.com writes:
Anthony, I know you wanted to review some of the patches,
since you didn't respond either all's well or you
could not find the time.
I think we are better off merging them for 1.7 and then - worst case,
if major issues surface - disabling the
This allows us to completely remove CPULM32State from DisasContext.
Instead, copy the fields we need to DisasContext.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Walle mich...@walle.cc
---
changes since v1:
- instead of storing a pointer to the cpu definitions, register
Dear qemu developers,
I've noticed about 3 days ago a bug, apparently introduced by the last massive
modifications in blockdev.c, that prevents the use of a cdrom ISO without write
permission, like in qemu-system-i386 -cdrom /some.iso ..., giving the message
could not open disk image
On Mon, 10/14 17:28, Edivaldo de Araujo Pereira wrote:
Dear qemu developers,
I've noticed about 3 days ago a bug, apparently introduced by the last
massive modifications in blockdev.c, that prevents the use of a cdrom ISO
without write permission, like in qemu-system-i386 -cdrom
On 10/10/2013 09:06 PM, Zhanghaoyu (A) wrote:
When several VMs migrate with RDMA at the same time, the increased pressure
cause packet loss probabilistically and make source and destination wait for
each other. There might be some of VMs blocked during the migration.
Fix the bug by using two
Since 0ebd24e0, cdrom doesn't have read-only on by default, which will
error out when using an read only image. Fix it by setting the default
value when parsing opts.
Reported-by: Edivaldo de Araujo Pereira edivaldoapere...@yahoo.com.br
Signed-off-by: Fam Zheng f...@redhat.com
---
blockdev.c | 7
On Mon, 10/14 07:52, Eric Blake wrote:
On 10/12/2013 12:33 AM, Fam Zheng wrote:
There is errp passed in, so no need for local_err and error_propagate.
s/compelte/complete/ in the subject
Signed-off-by: Fam Zheng f...@redhat.com
---
block/mirror.c | 4 +---
1 file changed, 1
There is errp passed in, so no need for local_err and error_propagate.
Also drop the backing_filename which is set but unused since 34b5d2c.
Signed-off-by: Fam Zheng f...@redhat.com
--
v2: fix typo in subject line.
drop backing_filename.
(Thanks Eric)
Signed-off-by: Fam Zheng
If the block job completes too fast, the test can fail. Change the
numbers so the qmp events are more stably captured by the script.
A sleep is removed for the same reason.
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/030 | 11 +--
1 file changed, 5 insertions(+), 6
This file is moved out from QMP/ to BUILD dir, change the ignore file
too.
Signed-off-by: Fam Zheng f...@redhat.com
---
.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 8e1b73f..5584b5f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,7
On 10/14/2013 08:23 PM, Fam Zheng wrote:
There is errp passed in, so no need for local_err and error_propagate.
Also drop the backing_filename which is set but unused since 34b5d2c.
Signed-off-by: Fam Zheng f...@redhat.com
--
Three dashes instead of two before 'git am' will notice that
On Mon, 10/14 21:05, Eric Blake wrote:
On 10/14/2013 08:23 PM, Fam Zheng wrote:
There is errp passed in, so no need for local_err and error_propagate.
Also drop the backing_filename which is set but unused since 34b5d2c.
Signed-off-by: Fam Zheng f...@redhat.com
--
Three dashes
On 10/14/2013 10:36 PM, Markus Armbruster wrote:
Mike Qiu qiud...@linux.vnet.ibm.com writes:
Without this, output of 'info block'
scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2)
[not inserted]
scsi0-cd2: [not inserted]
Removable device: not locked, tray closed
floppy0: [not inserted]
Changelog to v1:
Find remainder of macaddr-a[5] by modulo 256,
otherwise it may be overflow by add index++.
The default mac address is 52:54:00:12:34:56 + index, this will
cause problem that when we boot up more than one guest with all
mac addresses unset by default, assume that
Am 15.10.2013 06:17, schrieb Mike Qiu:
Changelog to v1:
Find remainder of macaddr-a[5] by modulo 256,
otherwise it may be overflow by add index++.
The default mac address is 52:54:00:12:34:56 + index, this will
cause problem that when we boot up more than one guest with all
mac
On Mon, Oct 14, 2013 at 03:36:13PM -0700, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
Add ACPI based PCI hotplug library with bridge hotplug
support.
Design
- each bus gets assigned bsel property.
- ACPI code writes this number
to a new BNUM
On Mon, Oct 14, 2013 at 03:32:43PM -0700, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
update generated file, not sure what changed
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Tested-by: Gerd Hoffmann kra...@redhat.com
Reviewed-by: Igor Mammedov
On Mon, Oct 14, 2013 at 10:18 PM, Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Oct 11, 2013 at 10:59:40AM +0800, liu ping fan wrote:
On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote:
On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote:
Il 10/10/2013
On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
Anthony, I know you wanted to review some of the patches,
since you didn't respond either all's well or you
could not find the time.
I think we are better off merging them for 1.7
On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote:
This is a huge series and I still am not convinced this is the right
path forward.
Also, this kind of response is quite unexpected after this direction was
discussed multiple times and largely agreed upon on the phone meeting,
and
V2:
1: all fail case will goto fail section.
2: add the goto code.
v3:
Address Stefan's comments:
2: don't goto fail after allocation failure.
3: use sn-l1size correctly in qcow2_free_cluster().
4-7: add test case to verify the error paths.
Other:
1: new patch fix a existing bug,
The return value is only used for error report before this patch,
so change the function protype to return void.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block/qcow2-snapshot.c| 27 +++
block/qcow2.h |4 +++-
block/rbd.c
This test will focus on the low level procedure of qcow2 snapshot
operations, now it covers only the create operation. Overlap error
paths are not checked since no good way to trigger those errors.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
tests/qemu-iotests/068 | 214
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block/qcow2-snapshot.c | 25 +
1 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index c933b7f..6d0ffd4 100644
--- a/block/qcow2-snapshot.c
+++
The function still returns int since qcow2_snapshot_delete() will
return the number.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block/qcow2-snapshot.c | 48 ++--
1 files changed, 42 insertions(+), 6 deletions(-)
diff --git
Some code in qcow2-snapshot.c directly access bs-file, so in those
points error can't be injected by other events. Since the code in
qcow2-snapshot.c is qcow2's internal detail similar as L1 table,
so add some debug events.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block/qcow2-snapshot.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 4bd494b..c933b7f 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
On 10/15/2013 01:07 PM, Stefan Weil wrote:
Am 15.10.2013 06:17, schrieb Mike Qiu:
Changelog to v1:
Find remainder of macaddr-a[5] by modulo 256,
otherwise it may be overflow by add index++.
The default mac address is 52:54:00:12:34:56 + index, this will
cause problem that when
101 - 166 of 166 matches
Mail list logo
