Re: [Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote: Michael Tsirkin doesn't trust us to keep values of QEMUMachine member product stable in the future. Use copies instead, and in a way that makes it obvious that they're guest ABI. Note that we can be trusted to keep values of

Re: [Qemu-devel] [PATCH v3 1/2] hw: Pass QEMUMachine to its init() method

2013-10-31 Thread Michael S. Tsirkin
On Wed, Oct 30, 2013 at 01:56:39PM +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Put it in QEMUMachineInitArgs, so I don't have to touch every board. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product version by default

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 06:54:37AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 01:56:40PM +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Currently, we get SeaBIOS defaults: manufacturer Bochs, product

[Qemu-devel] [PATCH] uas: Fix response iu struct definition

2013-10-31 Thread Hans de Goede
This patch mirrors a patch to the Linux uas kernel driver which I've just submitted. It looks like the qemu uas struct definitions were taken from the Linux kernel driver, and have inherited the same mistake. Besides fixing the response iu struct, the patch also drops the add_info parameter from

Re: [Qemu-devel] [PATCH v3 0/7] qdev and blockdev refcount leak fixes

2013-10-31 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 04:44:18PM +0100, Andreas Färber wrote: Am 30.10.2013 14:54, schrieb Stefan Hajnoczi: v3: * I lost track of this patch, now I'm pushing it again Part of this series is in a pending qom-next pull of mine (on a different base), which Anthony didn't merge due to some

Re: [Qemu-devel] [PATCH v3 2/2] smbios: Set system manufacturer, product version by default

2013-10-31 Thread Eduardo Habkost
On Wed, Oct 30, 2013 at 09:22:38PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 04:18:37PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote:

Re: [Qemu-devel] [libvirt] QEMU 1.6 and drive discard parameter

2013-10-31 Thread Amos Kong
On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote: CC to Amos. On 30/10/13 16:19, whitearchey wrote: In QEMU 1.6 parameters of 'drive' option were removed: QemuOptsList qemu_drive_opts = { .name = drive, .head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.head), .desc

Re: [Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-31 Thread Eduardo Habkost
On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote: Michael Tsirkin doesn't trust us to keep values of QEMUMachine member product stable in the future. Use copies instead, and in a way that makes it obvious that they're guest ABI. Note that we can be trusted to keep values of

Re: [Qemu-devel] [PATCH v3 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-31 Thread Marcel Apfelbaum
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com A PIIX3/PIIX4 southbridge has multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in pc_init1() or mips_malta_init() to work: the ISA

Re: [Qemu-devel] [PATCH v3 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-31 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com A PIIX3/PIIX4 southbridge has multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in

Re: [Qemu-devel] [PATCH] import kvm-unittest in QEMU source tree

2013-10-31 Thread Gleb Natapov
On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote: On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote: This simply imports kvm-unittest git into qemu source tree. We can next work on making make check run it automatically. Squashed 'kvm-unittest/' content

[Qemu-devel] [PATCH] RFC: spapr: introduce smt_cpu_index

2013-10-31 Thread Alexey Kardashevskiy
This is not really a patch to accept or review, this is a conversation starter. Cc: Badari Pulavarty pbad...@linux.vnet.ibm.com Cc: Paul Mackerras pau...@samba.org Cc: David Gibson da...@gibson.dropbear.id.au Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] virtio-net performance on mach-virt.

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 04:32, Giridhar Maruthy ha scritto: On 30 October 2013 22:12, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/10/2013 15:40, Giridhar Maruthy ha scritto: Hi All, I tried to measure the network performance of guest (mach-virt) with virtio-net on an ARM host platform (Samsung

Re: [Qemu-devel] [libvirt] QEMU 1.6 and drive discard parameter

2013-10-31 Thread Amos Kong
CC Kevin, Paolo On Thu, Oct 31, 2013 at 04:35:43PM +0800, Amos Kong wrote: On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote: CC to Amos. On 30/10/13 16:19, whitearchey wrote: In QEMU 1.6 parameters of 'drive' option were removed: QemuOptsList qemu_drive_opts = {

Re: [Qemu-devel] [PATCH repost] ahci: fix win7 hang on boot

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 12:32:12PM +0100, Paolo Bonzini wrote: Il 28/10/2013 20:01, Michael S. Tsirkin ha scritto: From: Alexander Graf ag...@suse.de When AHCI executes an asynchronous IDE command, it checked DRDY without checking either DRQ or BSY. This sometimes caused interrupt to be

Re: [Qemu-devel] [PATCH repost] ahci: fix win7 hang on boot

2013-10-31 Thread Paolo Bonzini
Il 28/10/2013 20:01, Michael S. Tsirkin ha scritto: From: Alexander Graf ag...@suse.de When AHCI executes an asynchronous IDE command, it checked DRDY without checking either DRQ or BSY. This sometimes caused interrupt to be sent before command is actually completed. This resulted in a

Re: [Qemu-devel] [PATCH 00/13] target-openrisc: More optimizations and corrections

2013-10-31 Thread Jia Liu
Hi Sebastian, On Wed, Oct 30, 2013 at 5:22 AM, Sebastian Macke sebast...@macke.de wrote: On 29/10/2013 2:15 PM, Max Filippov wrote: On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke sebast...@macke.de wrote: Hi, This is the second part of the patches to make the openrisc target faster

Re: [Qemu-devel] How to add qemu-system-$(target) as a dependency for qtests

2013-10-31 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 05:09:26PM +0100, Paolo Bonzini wrote: Il 30/10/2013 16:07, Stefan Hajnoczi ha scritto: I came across this little tests/Makefile annoyance: If you modify QEMU code and then run make check it will not rebuild QEMU. This can be confusing during development when you

Re: [Qemu-devel] [PATCH v3 10/10] qdev: Do not let the user try to device_add when it cannot work

2013-10-31 Thread Marcel Apfelbaum
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Such devices have always been unavailable and omitted from the list of available devices shown by device_add help. Until commit 18b6dad silently broke the former, setting up nasty traps for

Re: [Qemu-devel] [PATCH v3 09/10] isa: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-31 Thread Marcel Apfelbaum
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Drop it when there's no obvious reason why device_add could not work. Else keep and document why. * isa-fdc: drop * i8042: drop, even though its I/O base is hardcoded (because you

Re: [Qemu-devel] [PATCH] RFC: spapr: introduce smt_cpu_index

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 10:28, Alexey Kardashevskiy ha scritto: This is not really a patch to accept or review, this is a conversation starter. Cc: Badari Pulavarty pbad...@linux.vnet.ibm.com Cc: Paul Mackerras pau...@samba.org Cc: David Gibson da...@gibson.dropbear.id.au Cc: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH v8 00/19] VHDX log replay and write support, .bdrv_create()

2013-10-31 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 10:44:37AM -0400, Jeff Cody wrote: This patch series contains the initial VHDX log parsing, replay, write support, and image creation. === v8 changes === https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v7-upstream Rebased to latest qemu/master Patch

Re: [Qemu-devel] [PATCH v3 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-31 Thread Marcel Apfelbaum
On Thu, 2013-10-31 at 11:29 +0100, Markus Armbruster wrote: Marcel Apfelbaum marce...@redhat.com writes: On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com A PIIX3/PIIX4 southbridge has multiple functions. We model each function as

Re: [Qemu-devel] [PATCH v8 16/19] block: vhdx - add .bdrv_create() support

2013-10-31 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 10:44:53AM -0400, Jeff Cody wrote: +if (image_size VHDX_MAX_IMAGE_SIZE) { +error_setg_errno(errp, EINVAL, Image size too large; max of 64TB\n); Error messages should not include '\n'. Perhaps this can be fixed when merging the patch.

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Edgar E. Iglesias
On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote: The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700) are available in the git repository at:

Re: [Qemu-devel] [PATCH] import kvm-unittest in QEMU source tree

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 8:48 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote: On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote: This simply imports kvm-unittest git into qemu source tree. We can next work on making make

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Andreas Färber
Hi, Am 31.10.2013 15:02, schrieb Edgar E. Iglesias: On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote: The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700) are

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 3:18 PM, Andreas Färber afaer...@suse.de wrote: Hi, Am 31.10.2013 15:02, schrieb Edgar E. Iglesias: On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote: The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking

Re: [Qemu-devel] [PATCH] import kvm-unittest in QEMU source tree

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 03:17:57PM +0100, Anthony Liguori wrote: On Thu, Oct 31, 2013 at 8:48 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote: On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote: This simply imports

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this? Thanks. I think the biggest issue is the new PANICKED state. Guests already have simple ways to halt the CPU, and

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Peter Maydell
On 31 October 2013 14:18, Andreas Färber afaer...@suse.de wrote: Peter, since I had picked up the first two patches into my still pending qom-next pull, as per the QEMU Summit discussion those patches should've gotten an Acked-by. Hmm? I don't recall this part of the discussion. If you want

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Eric Blake
On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this? Thanks. I think the biggest issue is the new PANICKED state.

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 3:32 PM, Eric Blake ebl...@redhat.com wrote: On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this?

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Andreas Färber
Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de wrote: Peter, since I had picked up the first two patches into my still pending qom-next pull, as per the QEMU Summit discussion those patches should've gotten an Acked-by. Hmm? I don't

[Qemu-devel] [PULL v2 00/56] QOM devices patch queue 2013-10-31

2013-10-31 Thread Andreas Färber
Hello Anthony, This is my updated QOM devices patch queue. Please pull or provide more details of what is not working in your build environment. v2 is rebased, dropping two ARM patches, and the observed SD segfault had been fixed in 794cbc26eb94ce13c75d105eea9ff0afff56e2c2. Patches are not

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 31/10/2013 15:32, Eric Blake ha scritto: On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de wrote: Peter, since I had picked up the first two patches into my still pending qom-next pull, as per the QEMU Summit

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 08:32:43AM -0600, Eric Blake wrote: On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's been a long time since this thread. But qemu 1.7 is releasing, do you have any consensus on this?

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Andreas Färber
Am 31.10.2013 15:39, schrieb Anthony Liguori: On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de wrote: Peter, since I had picked up the first two patches into my still

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Eric Blake
On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote: if (event PVPANIC_PANICKED) { panicked_mon_event(pause); -vm_stop(RUN_STATE_GUEST_PANICKED); Don't you still need to halt the guest on a panic event, for management to have a chance to choose what to do about the

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 03:39:17PM +0100, Paolo Bonzini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 31/10/2013 15:32, Eric Blake ha scritto: On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: Hi All, I know it's

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 3:45 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:39, schrieb Anthony Liguori: On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto: Yes, it does. What does it break exactly? The point of a panicked event is to examine the guest at a particular moment in time (e.g. host-initiated crash dump). If you let the guest run, it may reboot and prevent you from getting a

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Anthony Liguori
On Thu, Oct 31, 2013 at 3:45 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:39, schrieb Anthony Liguori: On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de

Re: [Qemu-devel] e1000 patch for osx

2013-10-31 Thread Gabriel L. Somlo
On Wed, Oct 30, 2013 at 6:31 PM, jacek burghardt wrote: I got this error hw/net/e1000.c: In function 'set_phy_ctrl': hw/net/e1000.c:209:10: warning: implicit declaration of function 'set_ics' [-Wimplicit-function-declaration] That's because set_ics needs to be declared before being used in

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote: Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto: Yes, it does. What does it break exactly? The point of a panicked event is to examine the guest at a particular moment in time (e.g. host-initiated crash dump). If you let

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 08:49:08AM -0600, Eric Blake wrote: On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote: if (event PVPANIC_PANICKED) { panicked_mon_event(pause); -vm_stop(RUN_STATE_GUEST_PANICKED); Don't you still need to halt the guest on a panic event,

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2013-10-31 Thread Peter Maydell
On 31 October 2013 14:36, Andreas Färber afaer...@suse.de wrote: Am 31.10.2013 15:31, schrieb Peter Maydell: On 31 October 2013 14:18, Andreas Färber afaer...@suse.de wrote: Peter, since I had picked up the first two patches into my still pending qom-next pull, as per the QEMU Summit

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote: Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto: Yes, it does. What does it break exactly? The point of a panicked event is to examine the guest at a particular moment in

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote: Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote: Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto: Yes, it does. What does it break exactly? The point of

[Qemu-devel] [PULL 04/30] qemu-img: add special exit code if bdrv_check is not supported

2013-10-31 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de currently it is not possible to distinguish by exitcode if there has been an error or if bdrv_check is not supported by the image format. Change the exitcode from 1 to 63 for the latter case. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Eric Blake

[Qemu-devel] [PULL v2 00/30] Block patches

2013-10-31 Thread Kevin Wolf
The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-anthony for you to fetch changes up to

[Qemu-devel] [PULL 02/30] qcow2: Restore total_sectors value in save_vmstate

2013-10-31 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Since df2a6f29a5, bdrv_co_do_writev increases the total_sectors value of a growable block devices on writes after the current end. This leads to the virtual disk apparently growing in qcow2_save_vmstate, which in turn affects the disk size captured by the

[Qemu-devel] [PULL 01/30] qapi: fix documentation example

2013-10-31 Thread Kevin Wolf
From: Eric Blake ebl...@redhat.com The QMP wire format uses , not '', around strings. * docs/qapi-code-gen.txt: Fix typo. Signed-off-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- docs/qapi-code-gen.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 05/30] block/vpc: check that the image has not been truncated

2013-10-31 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de this adds a check that a dynamic VHD file has not been accidently truncated (e.g. during transfer or upload). Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vpc.c | 7 +++

[Qemu-devel] [PULL 03/30] qcow2: Unset zero_beyond_eof in save_vmstate

2013-10-31 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Saving the VM state is done using bdrv_pwrite. This function may perform a read-modify-write, which in this case results in data being read from beyond the end of the virtual disk. Since we are actually trying to access an area which is not a part of the virtual

[Qemu-devel] [PULL 07/30] qcow2: Flush image after creation

2013-10-31 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Opening the qcow2 image with BDRV_O_NO_FLUSH prevents any flushes during the image creation. This means that the image has not yet been flushed to disk when qemu-img create exits. This flush is delayed until the next operation on the image involving opening it

[Qemu-devel] [PULL 21/30] sheepdog: handle vdi objects in resend_aio_req

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp The current resend_aio_req() doesn't work when the request is against vdi objects. This fixes the problem. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Tested-by: Liu Yuan namei.u...@gmail.com Reviewed-by: Liu Yuan

[Qemu-devel] [PULL 24/30] sheepdog: try to reconnect to sheepdog after network error

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This introduces a failed request queue and links all the inflight requests to the list after network error happens. After QEMU reconnects to the sheepdog server successfully, the sheepdog block driver will retry all the requests in the failed

[Qemu-devel] [PULL 20/30] sheepdog: check return values of qemu_co_recv/send correctly

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp If qemu_co_recv/send doesn't return the specified length, it means that an error happened. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Tested-by: Liu Yuan namei.u...@gmail.com Reviewed-by: Liu Yuan namei.u...@gmail.com

[Qemu-devel] [PULL 08/30] exec: Fix bounce buffer allocation in address_space_map()

2013-10-31 Thread Kevin Wolf
This fixes a regression introduced by commit e3127ae0c, which kept the allocation size of the bounce buffer limited to one page in order to avoid unbounded allocations (as explained in the commit message of 6d16c2f88), but broke the reporting of the shortened bounce buffer to the caller. The

[Qemu-devel] [PULL 10/30] tests: Multiboot mmap test case

2013-10-31 Thread Kevin Wolf
This adds a test case for Multiboot memory map in the tests/multiboot directory, where future i386 test kernels can be dropped. Because this requires an x86 build host and an installed 32 bit libgcc, the test is not part of a regular 'make check'. The reference output for the test is verified

[Qemu-devel] [PULL 25/30] sheepdog: make add_aio_request and send_aioreq void functions

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp These functions no longer return errors. We can make them void functions and simplify the codes. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Tested-by: Liu Yuan namei.u...@gmail.com Reviewed-by: Liu Yuan namei.u...@gmail.com

[Qemu-devel] [PULL 30/30] vmdk: Implment bdrv_get_specific_info

2013-10-31 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c | 68 +- qapi-schema.json

[Qemu-devel] [PULL 15/30] block: Disable BDRV_O_COPY_ON_READ for the backing file

2013-10-31 Thread Kevin Wolf
From: Thibaut LAURENT thibaut.laur...@gmail.com Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c, bdrv_open_common will throw an error when trying to open a file read-only with the BDRV_O_COPY_ON_READ flag set. Although BDRV_O_RDWR is unset for the backing files, BDRV_O_COPY_ON_READ is still

[Qemu-devel] [PULL 11/30] block: Don't copy backing file name on error

2013-10-31 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com bdrv_open_backing_file() tries to copy the backing file name using pstrcpy directly after calling bdrv_open() to open the backing file without checking whether that was actually successful. If it was not, ps-backing_hd-file will probably be NULL and qemu will

[Qemu-devel] [PULL 16/30] block: Avoid unecessary drv-bdrv_getlength() calls

2013-10-31 Thread Kevin Wolf
The block layer generally keeps the size of an image cached in bs-total_sectors so that it doesn't have to perform expensive operations to get the size whenever it needs it. This doesn't work however when using a backend that can change its size without qemu being aware of it, i.e. passthrough of

[Qemu-devel] [PULL 12/30] sheepdog: explicitly set copies as type uint8_t

2013-10-31 Thread Kevin Wolf
From: Liu Yuan namei.u...@gmail.com 'copies' is actually uint8_t since day one, but request headers and some helper functions parameterize it as uint32_t for unknown reasons and effectively reserve 24 bytes for possible future use. This patch explicitly set the correct for copies and reserve the

[Qemu-devel] [PATCH 0/7] block: qemu-iotests, more quoting fixes

2013-10-31 Thread Jeff Cody
There are still problems with the qemu-iotests, if the pathname of the working directory contains spaces. This series fixes most of them. To verify, ./check -qcow2 was run from a pathname with spaces (e.g., renamed ~/qemu-kvm to ~/qemu-kvm test/). The following tests still fail due to

[Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019

2013-10-31 Thread Jeff Cody
There were still instances of $TEST_IMG not being properly quoted. This was in the usage of a string built up for a 'for' loop; modify the loop so we can quote $TEST_IMG properly. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/019 | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PATCH 2/7] block: qemu-iotests, fix _make_test_img() to work with spaced pathnames

2013-10-31 Thread Jeff Cody
_make_test_img() currently works with spaced pathnames only when not specifying a backing file. This fixes it so that the backing file argument is properly quoted. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/common.rc | 13 +++-- 1 file changed, 11 insertions(+), 2

[Qemu-devel] [PULL 17/30] qemu-iotests: Fix 051 reference output

2013-10-31 Thread Kevin Wolf
Commit 684b254 forgot to update it. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/051.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index 2839e32..15deef6 100644 --- a/tests/qemu-iotests/051.out

[Qemu-devel] [PULL 13/30] sheepdog: pass copy_policy in the request

2013-10-31 Thread Kevin Wolf
From: Liu Yuan namei.u...@gmail.com Currently copy_policy isn't used. Recent sheepdog supports erasure coding, which make use of copy_policy internally, but require client explicitly passing copy_policy from base inode to newly creately inode for snapshot related operations. If connected sheep

[Qemu-devel] [PATCH 3/7] block: qemu-iotests, add quotes to $TEST_IMG.base usage in 017

2013-10-31 Thread Jeff Cody
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with spaces are supported. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/017 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017 index 45f2c0b..aba3faf

[Qemu-devel] [PATCH 5/7] block: qemu-iotests, removes duplicate double quotes in 039

2013-10-31 Thread Jeff Cody
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 index f85b4ce..8bade92 100755 ---

[Qemu-devel] [PULL 18/30] qemu-iotests: drop duplicated create_image

2013-10-31 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com There's a same common function in iotests.py Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/040 | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/040

[Qemu-devel] [PATCH 6/7] block: qemu-iotests, add quotes to $TEST_IMG usage for 051

2013-10-31 Thread Jeff Cody
There were still a couple of instances of unquoted usage of $TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail on pathnames with spaces in them. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/051 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PULL 19/30] qemu-iotests: Test case for backing file deletion

2013-10-31 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Add a test case for trying to open an image file where it is impossible to open its backing file (in this case, because it was deleted). When doing this, qemu (or qemu-io in this case) should not crash but rather print an appropriate error message.

[Qemu-devel] [PATCH 7/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 061

2013-10-31 Thread Jeff Cody
When creating images with backing files in the test, the backing file argument was not quoted properly. This caused the test to fail when run from a pathname with a space. Pass the backing argument in with the -b option to _make_test_img, so it can be properly quoted. Signed-off-by: Jeff Cody

[Qemu-devel] [PULL 22/30] sheepdog: reload inode outside of resend_aioreq

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This prepares for using resend_aioreq() after reconnecting to the sheepdog server. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Tested-by: Liu Yuan namei.u...@gmail.com Reviewed-by: Liu Yuan namei.u...@gmail.com Signed-off-by:

[Qemu-devel] [PULL 28/30] qemu-iotests: prefill some data to test image

2013-10-31 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Case 030 occasionally fails because of block job compltes too fast to be captured by script, and 'unexpected qmp event' of job completion causes the test failure. Simply fill in some data to the test image to make this false alarm less likely to happen. (For

[Qemu-devel] [PULL 29/30] qapi: Add optional field 'compressed' to ImageInfo

2013-10-31 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qapi-schema.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 04:56:07PM +0100, Paolo Bonzini wrote: Il 31/10/2013 16:45, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote: Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini

Re: [Qemu-devel] [PATCH v5 2/2] vmdk: Implment bdrv_get_specific_info

2013-10-31 Thread Eric Blake
On 10/30/2013 08:06 PM, Fam Zheng wrote: Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com --- v5: Changed 3 lines: - Save cid in vmdk_open. (Kevin) - Report parent_cid in vmdk_get_specific_info. - Rename create_type

Re: [Qemu-devel] [PULL 30/30] vmdk: Implment bdrv_get_specific_info

2013-10-31 Thread Eric Blake
On 10/31/2013 09:48 AM, Kevin Wolf wrote: From: Fam Zheng f...@redhat.com Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- +++ b/qapi-schema.json @@ -225,6 +225,27 @@ } }

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto: PANICKED-DEBUG was added by commit bc7d0e667. That commit can be reverted if the panicked state is removed from runstate_needs_reset. Okay so let's drop the code duplication and explicitly make them the same? Signed-off-by: Michael S.

Re: [Qemu-devel] [PULL 30/30] vmdk: Implment bdrv_get_specific_info

2013-10-31 Thread Kevin Wolf
Am 31.10.2013 um 17:13 hat Eric Blake geschrieben: On 10/31/2013 09:48 AM, Kevin Wolf wrote: From: Fam Zheng f...@redhat.com Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH 2/7] block: qemu-iotests, fix _make_test_img() to work with spaced pathnames

2013-10-31 Thread Eric Blake
On 10/31/2013 09:57 AM, Jeff Cody wrote: _make_test_img() currently works with spaced pathnames only when not specifying a backing file. This fixes it so that the backing file argument is properly quoted. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/common.rc | 13

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote: Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto: PANICKED-DEBUG was added by commit bc7d0e667. That commit can be reverted if the panicked state is removed from runstate_needs_reset. Okay so let's drop the code

Re: [Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests

2013-10-31 Thread Eric Blake
On 10/31/2013 09:57 AM, Jeff Cody wrote: The usage of $TEST_IMG was not properly quoted everywhere in common.pattern. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/common.pattern | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 3/7] block: qemu-iotests, add quotes to $TEST_IMG.base usage in 017

2013-10-31 Thread Eric Blake
On 10/31/2013 09:57 AM, Jeff Cody wrote: $TEST_IMG.base is used unquoted. Add quotes so that pathnames with spaces are supported. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/017 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote: Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto: PANICKED-DEBUG was added by commit bc7d0e667. That commit can be reverted if the panicked state is removed from runstate_needs_reset. Okay so let's drop the code

Re: [Qemu-devel] [PATCH 5/7] block: qemu-iotests, removes duplicate double quotes in 039

2013-10-31 Thread Eric Blake
On 10/31/2013 09:57 AM, Jeff Cody wrote: Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric

[Qemu-devel] [PULL 23/30] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This helper function behaves similarly to co_sleep_ns(), but the sleeping coroutine will be resumed when using qemu_aio_wait(). Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Tested-by: Liu Yuan namei.u...@gmail.com Reviewed-by:

Re: [Qemu-devel] [PATCH 7/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 061

2013-10-31 Thread Eric Blake
On 10/31/2013 09:57 AM, Jeff Cody wrote: When creating images with backing files in the test, the backing file argument was not quoted properly. This caused the test to fail when run from a pathname with a space. Pass the backing argument in with the -b option to _make_test_img, so it can be

[Qemu-devel] [PULL 27/30] sheepdog: check simultaneous create in resend_aioreq

2013-10-31 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp After reconnection happens, all the inflight requests are moved to the failed request list. As a result, sd_co_rw_vector() can send another create request before resend_aioreq() resends a create request from the failed list. This patch adds a

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Paolo Bonzini
Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote: Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto: PANICKED-DEBUG was added by commit bc7d0e667. That commit can be reverted if the panicked state is removed from

[Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests

2013-10-31 Thread Jeff Cody
The usage of $TEST_IMG was not properly quoted everywhere in common.pattern. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/common.pattern | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/common.pattern

Re: [Qemu-devel] pvpanic plans?

2013-10-31 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 05:38:40PM +0100, Paolo Bonzini wrote: Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto: On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote: Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto: PANICKED-DEBUG was added by commit bc7d0e667. That commit

[Qemu-devel] [PULL 14/30] ahci: fix win7 hang on boot

2013-10-31 Thread Kevin Wolf
From: Alexander Graf ag...@suse.de When AHCI executes an asynchronous IDE command, it checked DRDY without checking either DRQ or BSY. This sometimes caused interrupt to be sent before command is actually completed. This resulted in a race condition: if guest then managed to access the device

  1   2   >