Il 07/11/2013 22:51, Peter Maydell ha scritto:
>> > 1. Not all architectures have the behavior: "Address space that is not
>> > RAM(and friends)
>> > is for sure PCI". Only x86 behaves like this (I think).
>
> More specifically, the x86 pc behaves like this. Other
> x86 based systems could in
On Thu, 11/07 16:01, Benoît Canet wrote:
> Add the minimum of code to prepare the followings patches.
>
> If no node_name is provided to bdrv_new the bs->node_name is set to
> "undefined".
> This will allow to have some default string to communicate in QMP and HMP.
> This also make "undefined" a
To be able to boot on newer hardware that the software support,
PowerISA defines a logical PVR, one per every PowerISA specification
version from 2.04.
This adds the "compat" option which takes values 205 or 206 and forces
QEMU to boot the guest with a logical PVR (CPU_POWERPC_LOGICAL_2_05 or
CPU_
On 11/08/2013 12:36 AM, Igor Mammedov wrote:
> On Thu, 7 Nov 2013 20:11:51 +1100
> Alexey Kardashevskiy wrote:
>
>> On 11/06/2013 12:53 AM, Andreas Färber wrote:> Am 05.11.2013 10:52, schrieb
>> Paolo Bonzini:
Il 05/11/2013 10:16, Alexander Graf ha scritto:
>
> On 05.11.2013, at 10
On 11/08/2013 01:01 AM, Andreas Färber wrote:> Am 07.11.2013 10:11, schrieb
Alexey Kardashevskiy:
>> On 11/06/2013 12:53 AM, Andreas Färber wrote:> Am 05.11.2013 10:52, schrieb
>> Paolo Bonzini:
Il 05/11/2013 10:16, Alexander Graf ha scritto:
>
> On 05.11.2013, at 10:06, Paolo Bonzin
This adds suboptions support for -cpu.
Cc: Igor Mammedov
Cc: Andreas Färber
Signed-off-by: Alexey Kardashevskiy
---
include/qom/cpu.h | 29 +
include/sysemu/sysemu.h | 1 +
qom/cpu.c | 27 +++
vl.c| 42
On Fri, 8 Nov 2013 14:27:40 +1100
Alexey Kardashevskiy wrote:
> The SPAPR specification says that the RMA starts at the LPAR's logical
> address 0 and is the first logical memory block reported in
> the LPAR’s device tree.
>
> So SLOF only maps the first block and that block needs to span
> the
Looks good to me. Two small comments below.
On Wed, 11/06 13:16, Amos Kong wrote:
> Currently we have three QemuOptsList (qemu_common_drive_opts,
> qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts
> is added to vm_config_groups[].
>
> This patch changes query-command-line-option
Am 07.11.2013 um 21:23 hat Eric Blake geschrieben:
> On 11/07/2013 08:01 AM, Benoît Canet wrote:
> > Add the minimum of code to prepare the followings patches.
> >
> > If no node_name is provided to bdrv_new the bs->node_name is set to
> > "undefined".
> > This will allow to have some default str
Am 07.11.2013 um 16:01 hat Benoît Canet geschrieben:
> As node-name is a separate name space as device-name we can enable it's
> definition right now: nobody will use it so no harm involved.
>
> Signed-off-by: Benoit Canet
As Eric already said, we need to update the QAPI schema for the new
field
v2:
* Add Fam's total_sectors patch which fixes <512 byte VMDK files
All bug fixes with one exception: Jeff Cody's VHDX write support. The patches
have been on the list and reviewed for a long time. They are self-contained
and do not touch anything outside VHDX. They missed the soft freeze onl
From: Jeff Cody
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/common.pattern | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/
From: Jeff Cody
_make_test_img() currently works with spaced pathnames only when not
specifying a backing file. This fixes it so that the backing file
argument is properly quoted.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/common.r
From: Jeff Cody
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with
spaces are supported.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/017 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-i
From: Jeff Cody
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail
on pathnames with spaces in them.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/051 | 8 -
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 81a375b..76c98a7 100644
--- a/qapi-schema.json
+++ b/qapi-schema.j
Add a qtest qmp() function that returns the response object. This
allows test cases to verify the result or to check for error responses.
It also allows waiting for QMP events.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Andreas Färber
---
tests/libqtest.c | 66 +++
From: Max Reitz
error_setg_errno() may overwrite errno; therefore, its value should be
read before calling that function and not afterwards.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoit Canet
Signed-off-by: Stefan Hajnoczi
---
block.c | 2 +-
1 file changed, 1 insert
From: Jeff Cody
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx-endian.c | 75 +
block/vhdx.c| 20 +++---
b
From: Jeff Cody
This adds support for VHDX v0 logs, as specified in Microsoft's
VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
The following support is added:
* Log parsing, and validation - validate that an existing log
is correct.
* Log sear
From: Jeff Cody
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vh
From: Jeff Cody
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.c | 52
block/vhdx.h | 48
2 f
From: Jeff Cody
Bit shifting can be fun, but in this case it was unnecessary. The
upper 44 bits of the 64-bit BAT entry is specifies the File Offset,
so we shifted the bits to get access to the value.
However, per the spec the value is in MB. So we dutifully shifted back
to the left by 20 bits
From: Jeff Cody
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff C
From: Andreas Tobler
The below patch is needed to compile qemu trunk on FreeBSD with gcc48,
clang will fail ;). Host x84_64-freebsd.
Signed-off-by: Andreas Tobler
Signed-off-by: Stefan Hajnoczi
---
block/raw-posix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/blo
From: Jeff Cody
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/039 b/test
From: Jeff Cody
This adds support for writing to the VHDX log.
For spec details, see VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
There are a few limitations to this log support:
1.) There is no caching yet
2.) The log is flushed after each ent
From: Fam Zheng
Since b94a2610, bdrv_getlength() is omitted when probing image. VMDK
monolithicFlat is broken by that because a file < 512 bytes can't be
read with its total_sectors truncated to 0. This patch round up the size
to BDRV_SECTOR_SIZE, when a image size is not sector aligned.
Signed-
From: Jeff Cody
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.
From: Jeff Cody
There were still instances of $TEST_IMG not being properly quoted.
This was in the usage of a string built up for a 'for' loop; modify
the loop so we can quote $TEST_IMG properly.
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-i
Ensure that the device_add error code path deletes device objects.
Failure to do so not only leaks the objects but can also keep other
objects (like drive or netdev) alive due to qdev properties holding
references.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
tests/Makefile
From: Jeff Cody
This tests the replay of a data sector in a VHDX image file.
The image file is a 10G dynamic image, with 4MB block size. The
image was created with qemu-img, and the log left unplayed by
modification of the vhdx image format driver.
It was verified under both QEMU and Hyper-V t
On Tue, 11/05 22:09, Xu Wang wrote:
> If there is a loop in the backing file chain, it could cause problems
> such as no response or a segfault during system boot. Hence detecting a
> backing file loop is necessary. This patch extracts the loop check from
> collect_image_info_list() in block.c into
From: Jeff Cody
This adds support for VHDX image creation, for images of type "Fixed"
and "Dynamic". "Differencing" types (i.e., VHDX images with backing
files) are currently not supported.
Options for image creation include:
* log size:
The size of the journaling log for VHDX. Min
From: Jeff Cody
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnocz
From: Jeff Cody
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
tests/q
Hi,
On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote:
> On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis Liaskovitis wrote:
> > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The
> > _PXM
> > value is derived from the passed in guest info, same way as CPU
From: Jeff Cody
Regions in the image file cannot overlap - the log, region tables,
and metdata must all be unique and non-overlapping.
This adds region checking by means of a QLIST; there can be a variable
number of regions and metadata (there may be metadata or region tables
that we do not reco
From: Jeff Cody
When creating images with backing files in the test, the backing
file argument was not quoted properly. This caused the test to fail
when run from a pathname with a space. Pass the backing argument in
with the -b option to _make_test_img, so it can be properly quoted.
Signed-of
From: Jeff Cody
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.c | 30 --
block/vhdx.h |
From: Jeff Cody
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnocz
From: Jeff Cody
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write it as well.
Signe
On Tue, 11/05 22:09, Xu Wang wrote:
> Every image should be checked if there is infinite loop in backing
> file chain before open it. So infinite loop check was added into
> bdrv_new_open(). If @filename is opened without the flag
> BDRV_O_NO_BACKING, the infinite loop check should be called.
>
>
On Tue, 11/05 22:09, Xu Wang wrote:
> Backing file loop should be checked before qemu-img create command
> execution. If loop is found, qemu-img create should be stopped and
> an error printed.
>
> Signed-off-by: Xu Wang
> ---
> block.c | 8
> 1 file changed, 4 insertions(+), 4 deletion
On Tue, 11/05 22:09, Xu Wang wrote:
> Check the backing file for a loop during image boot, to avoid a lack or
> response or segfault.
>
> Signed-off-by: Xu Wang
> ---
> blockdev.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index b260477..7c0927f 100
On 8 November 2013 08:05, Paolo Bonzini wrote:
> Il 07/11/2013 22:51, Peter Maydell ha scritto:
>>> > 1. Not all architectures have the behavior: "Address space that is not
>>> > RAM(and friends)
>>> > is for sure PCI". Only x86 behaves like this (I think).
>>
>> More specifically, the x86 pc
From: Jeff Cody
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -778,6 +778,1
From: Jeff Cody
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their
MSGUID fields set as arrays of 16. This is incorrect (it stems from
an early version where those fields were uint_8 arrays). Those fields
were, up to this patch, unused.
Also, there were a couple of typos and
From: Max Reitz
The actual size of the image file may differ depending on the Linux
kernel currently running on the host. Filtering out this value makes
this test pass in such cases.
Signed-off-by: Max Reitz
Reviewed-by: Benoit Canet
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/067
Il 08/11/2013 11:44, Peter Maydell ha scritto:
> On 8 November 2013 08:05, Paolo Bonzini wrote:
>> Il 07/11/2013 22:51, Peter Maydell ha scritto:
> 1. Not all architectures have the behavior: "Address space that is not
> RAM(and friends)
> is for sure PCI". Only x86 behaves like t
Il 07/11/2013 23:23, Laszlo Ersek ha scritto:
> On 11/07/13 22:24, Marcel Apfelbaum wrote:
>> Why pci-hole and system.flash collide? IMHO we should not play with
>> priorities here, better solve the collision.
>
> What about this "beautiful" series? It produces
>
> memory
> -000ff
On Tue, Nov 05, 2013 at 06:46:27PM -0500, Cole Robinson wrote:
> The following commit introduced a migration incompatibility:
>
> commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe
> Author: David Gibson
> Date: Thu Jun 6 18:48:49 2013 +1000
>
> pci: Replace pci_find_domain() with more genera
From: Peter Lieven
Signed-off-by: Peter Lieven
Signed-off-by: Stefan Hajnoczi
---
block/vpc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index 627d11c..577cc45 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -211,6 +211,15 @@ static int vpc_open(BlockD
From: Jeff Cody
This adds the ability to update the headers in a VHDX image, including
generating a new MS-compatible GUID.
As VHDX depends on uuid.h, VHDX is now a configurable build option. If
VHDX support is enabled, that will also enable uuid as well. The
default is to have VHDX enabled.
Hi Paolo,
Many apologies to you, I did not reply to you earlier. I somehow
missed your email.
The command I used was
sudo qemu-system-arm -enable-kvm -kernel zImage -machine type=virt
-display none -cpu cortex-a15 -m 512 -append 'console=ttyAMA0
root=/dev/vda ip=192.168.42.24:192.168.42.1:192.16
These memory leaks also make drive_add if=none,id=drive0 without a file=
option leak the options list. This keeps ID "drive0" around forever.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
blockdev.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-
The following should work:
(qemu) drive_add if=none,id=drive0
(qemu) drive_del drive0
(qemu) drive_add if=none,id=drive0
Previous versions of QEMU produced a duplicate ID error because
drive_add leaked the options.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
tests/Makefil
Existing qmp() callers do not expect a response object. In order to
implement real QMP test cases it will be necessary to inspect the
response object.
Rename qmp() to qmp_discard_response(). Later patches will introduce a
qmp() function that returns the response object and tests that use it.
Si
Am 08.11.2013 09:22, schrieb Alexey Kardashevskiy:
> On 11/08/2013 12:36 AM, Igor Mammedov wrote:
>> On Thu, 7 Nov 2013 20:11:51 +1100
>> Alexey Kardashevskiy wrote:
>>
>>> On 11/06/2013 12:53 AM, Andreas Färber wrote:> Am 05.11.2013 10:52, schrieb
>>> Paolo Bonzini:
> Il 05/11/2013 10:16, A
Am 08.11.2013 09:22, schrieb Alexey Kardashevskiy:
> On 11/08/2013 01:01 AM, Andreas Färber wrote:
>> Please do separate these global preparations from the actual new ppc
>> property. Elsewhere it was discussed whether to use a readable string
>> value, which might hint at a dynamic property of typ
On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote:
> Am 07.11.2013 um 21:28 schrieb "Gabriel L. Somlo" :
>
> > Some guest operating systems' drivers (particularly Mac OS X)
> > expect the link state to be pre-initialized by an earlier
> > component such as a proprietary BIOS. This pat
Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy:
> So far POWER7+ was a part of POWER7 family. However it has a different
> PVR base value so in order to support PVR masks, it needs a separate
> family class.
>
Alexey,
> Another reason to make a POWER7+ family is that its name in the device
>
On 11/07/2013 08:26 PM, Fam Zheng wrote:
> If backing file doesn't exist, the error message is confusing and
> misleading:
>
> $ qemu /tmp/a.qcow2
> qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
> such file or directory
>
> This is not intuitive. It's better t
On 11/08/2013 03:19 AM, Fam Zheng wrote:
>
>> +BlockDriverState *bs;
>> +BlockDriver *drv;
>> +char fbuf[1024];
>
> Could use PATH_MAX.
PATH_MAX is undefined on some platforms, and could also be defined to
something larger than a page which could lead to nastiness if you end up
overf
On 2013-10-09 13:42, Gerd Hoffmann wrote:
> Hi,
>
Only very recent distros fulfill the need of >= 1.0.13, so you naturally
fall back to this code. I just realized that even the factory build of
OpenSUSE is still on libusb-1.0.9. Current Ubuntu versions are on 1.0.12
at best.
On Wed, Nov 06, 2013 at 06:34:55PM +0100, Vincenzo Maffione wrote:
> Signed-off-by: Vincenzo Maffione
> ---
> MAINTAINERS | 8
> 1 file changed, 8 insertions(+)
Thanks, applied to my net-next tree:
https://github.com/stefanha/qemu/commits/net-next
Stefan
On Thu, Nov 07, 2013 at 08:10:29PM +0100, Max Reitz wrote:
> There may be calls to error_setg() and especially error_setg_errno()
> which blindly (and until now wrongly) assume these functions not to
> clobber errno (e.g., they pass errno to error_setg_errno() and return
> -errno afterwards). Inste
On 11/09/2013 12:44 AM, Andreas Färber wrote:
> Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy:
>> So far POWER7+ was a part of POWER7 family. However it has a different
>> PVR base value so in order to support PVR masks, it needs a separate
>> family class.
>>
>
> Alexey,
>
>> Another reason
On 11/09/2013 12:20 AM, Andreas Färber wrote:
> When I am finally through with review of Igor's patches then he can
> implement that for x86 and we/you can copy or adapt it for ppc. No need
> to do big experiments for a concretely needed ppc feature.
Does it mean I better stop wasting your time a
On 11/08/13 07:09, Jordan Justen wrote:
> On Thu, Nov 7, 2013 at 2:23 PM, Laszlo Ersek wrote:
>> ... upwards through the following call chain:
>>
>> pc_init1() | pc_q35_init()
>> pc_memory_init()
>> pc_system_firmware_init()
>> pc_system_flash_init()
>>
>> Signed-off-by: Laszlo
Am 08.11.2013 15:57, schrieb Alexey Kardashevskiy:
> On 11/09/2013 12:20 AM, Andreas Färber wrote:
>
>> When I am finally through with review of Igor's patches then he can
>> implement that for x86 and we/you can copy or adapt it for ppc. No need
>> to do big experiments for a concretely needed pp
On Thu, Nov 07, 2013 at 11:06:06AM -0800, akepner wrote:
> First cut at emulating 82571. I'm sure there are lots of rough
> edges, but it's working for me.
>
> Pretty obviously I started with a copy of the e1000 code, and
> modified just what was necessary to get it working. I'd like
> to also do
On 11/7/2013 6:23 PM, Richard Henderson wrote:
> On 11/07/2013 06:31 AM, Tom Musta wrote:
>> The single-precision scalar arithmetic instructions all interpret the most
>> significant 64 bits of a VSR as a single precision floating point number
>> stored in double precision format (similar to the st
On Fri, 2013-11-08 at 09:05 +0100, Paolo Bonzini wrote:
> Il 07/11/2013 22:51, Peter Maydell ha scritto:
> >> > 1. Not all architectures have the behavior: "Address space that is not
> >> > RAM(and friends)
> >> > is for sure PCI". Only x86 behaves like this (I think).
> >
> > More specifical
On 11/6/2013 5:04 AM, Juan Quintela wrote:
Hi
[v2]
In this version:
- fixed all the comments from last versions (thanks Eric)
- kvm migration bitmap is synchronized using bitmap operations
- qemu bitmap -> migration bitmap is synchronized using bitmap operations
If bitmaps are not properly align
On Fri, 2013-11-08 at 10:44 +, Peter Maydell wrote:
> On 8 November 2013 08:05, Paolo Bonzini wrote:
> > Il 07/11/2013 22:51, Peter Maydell ha scritto:
> >>> > 1. Not all architectures have the behavior: "Address space that is not
> >>> > RAM(and friends)
> >>> > is for sure PCI". Only x8
On 8 November 2013 15:07, Laszlo Ersek wrote:
> On 11/08/13 07:09, Jordan Justen wrote:
>> int64_t? :)
>
> Heh, yes, I did cringe when I wrote that, but if you check the
> bottom-most function, where the assignment happens,
> pc_system_flash_init(), it declares the local "size" variable as
> int64
On 11/06/2013 06:44 PM, Dave Airlie wrote:
On Wed, Nov 6, 2013 at 8:57 PM, Gerd Hoffmann wrote:
Hi,
It currently just adds multiple DisplaySurfaces to the QemuConsole,
now Gerd said he thought I should be using multiple QemuConsoles but I
really didn't think this was a good idea,
Why?
It
On Fri, Nov 08, 2013 at 06:53:27AM -0700, Eric Blake wrote:
> On 11/08/2013 03:19 AM, Fam Zheng wrote:
> >
> >> +BlockDriverState *bs;
> >> +BlockDriver *drv;
> >> +char fbuf[1024];
> >
> > Could use PATH_MAX.
>
> PATH_MAX is undefined on some platforms, and could also be defined to
On 11/08/13 16:16, Peter Maydell wrote:
> On 8 November 2013 15:07, Laszlo Ersek wrote:
>> On 11/08/13 07:09, Jordan Justen wrote:
>>> int64_t? :)
>>
>> Heh, yes, I did cringe when I wrote that, but if you check the
>> bottom-most function, where the assignment happens,
>> pc_system_flash_init(),
On 8 November 2013 15:27, Laszlo Ersek wrote:
> On 11/08/13 16:16, Peter Maydell wrote:
>> That said, having to pass the size of a sub-sub-region
>> all the way back up the call stack is very odd and makes
>> me wonder if it's really the right way to do it...
>> The top level shouldn't have to car
Hi,
> OK, then here is the first issue I ran into while trying libusbx (git
> head, i.e. 1.0.17+: The new stack causes significant latency issues that
> makes it almost unusable for pass-through of USB audio devices (some
> headset in my case). Reverting usb-linux and disabling libusb over QEMU
Am 07.11.2013 21:27, schrieb Jordan Justen:
> On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum wrote:
>> The commit:
>>
>> Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6
>> Author: Marcel Apfelbaum
>> Date: Mon Sep 16 11:21:16 2013 +0300
>>
>> hw/pci: partially handle pci master abort
>>
On Fri, Nov 08, 2013 at 02:39:25PM +0100, Stefan Hajnoczi wrote:
> On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote:
>> We can easily modify SeaBIOS to just loop through all PCI devices,
>> look for an e1000 and initialize it far enough for XNU, no?
>> After all, it sounds like that's
Hi,
Am 06.11.2013 21:31, schrieb Tom Musta:
> This is the fourth and final series of patches that add emulation support
> to QEMU for the PowerPC Vector Scalar Extension (VSX).
[...]
> target-ppc/cpu.h|4 +-
> target-ppc/fpu_helper.c | 191
>
Commit 921ac5d0f3a0df869db5ce4edf752f51d8b1596a
virtio-net: remove layout assumptions for ctrl vq
introduced a regression where the multicast address filter
entries are written to the beginning of the mac table array,
thus overwriting any unicast addresses that may have been
programmed in
Il 08/11/2013 16:08, Marcel Apfelbaum ha scritto:
> Actually, as I see, the default behavior of "system" memory region
> is to use unassigned_mem_ops that has valid.accepts method returning
> false (no read/write methods). I don't see that read all-ones/ignore
> writes is implemented.
Right, it's
On 11/08/13 16:42, Andreas Färber wrote:
> Am 07.11.2013 21:27, schrieb Jordan Justen:
>> On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum
>> wrote:
>>> The commit:
>>>
>>> Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6
>>> Author: Marcel Apfelbaum
>>> Date: Mon Sep 16 11:21:16 2013 +0300
>
On Tue, Nov 05, 2013 at 10:09:18PM -0500, Xu Wang wrote:
> Every image should be checked if there is infinite loop in backing
> file chain before open it. So infinite loop check was added into
> bdrv_new_open(). If @filename is opened without the flag
> BDRV_O_NO_BACKING, the infinite loop check sh
On Fri, 2013-11-08 at 17:12 +0100, Paolo Bonzini wrote:
> Il 08/11/2013 16:08, Marcel Apfelbaum ha scritto:
> > Actually, as I see, the default behavior of "system" memory region
> > is to use unassigned_mem_ops that has valid.accepts method returning
> > false (no read/write methods). I don't see
Il 08/11/2013 17:19, Laszlo Ersek ha scritto:
> I'm not very familiar with external files in tests though. Can I model
> it on "qdict-test-data.txt"?
>
> "qdict-test-data.txt" is located in the root source directory. When
> configure runs outside the root source directory (= separate build dir),
>
See more suggestions below.
Am 08.11.2013 17:19, schrieb Jeff Cody:
> On Tue, Nov 05, 2013 at 10:09:18PM -0500, Xu Wang wrote:
>> Every image should be checked if there is infinite loop in backing
>> file chain before open it. So infinite loop check was added into.
... if there is an infinite loo
From: Sergey Fedorov
Do not return after net_hub_flush(). Always flush callee network client
incoming queue.
Signed-off-by: Sergey Fedorov
Signed-off-by: Stefan Hajnoczi
---
net/net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 870d3bb..0a88e68 100644
--- a/
On Thu, 7 Nov 2013 23:23:57 +0100
Laszlo Ersek wrote:
> On 11/07/13 22:24, Marcel Apfelbaum wrote:
>
> > Why pci-hole and system.flash collide? IMHO we should not play with
> > priorities here, better solve the collision.
>
> What about this "beautiful" series? It produces
Laszlo,
there is pa
From: Dmitry Fleytman
Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command
multicast list overwrites unicast list in mac_table.
This leads to broken logic for both unicast and multicast RX filtering.
Signed-off-by: Dmitry Fleytman
Signed-off-by: Stefan Hajnoczi
---
hw/net/virtio-net.c | 3
Bug fixes for QEMU 1.7.
The following changes since commit 964668b03d26f0b5baa5e5aff0c966f4fcb76e9e:
Update version for 1.7.0-rc0 release (2013-11-06 21:49:39 -0800)
are available in the git repository at:
git://github.com/stefanha/qemu.git net
for you to fetch changes up to cc386e96727442
From: Dmitry Krivenok
[Assigning a multicast MAC address to a NIC leads to confusing behavior.
Reject multicast MAC addresses so users are alerted to their error
straight away.
The "net/eth.h" in6_addr rename prevents a name collision with
on Linux.
-- Stefan]
Signed-off-by: Dmitry V. Krivenok
On 2013-11-08 16:39, Gerd Hoffmann wrote:
> Hi,
>
>> OK, then here is the first issue I ran into while trying libusbx (git
>> head, i.e. 1.0.17+: The new stack causes significant latency issues that
>> makes it almost unusable for pass-through of USB audio devices (some
>> headset in my case). R
Am 08.11.2013 15:54, schrieb Alexey Kardashevskiy:
> On 11/09/2013 12:44 AM, Andreas Färber wrote:
>> Am 08.11.2013 03:37, schrieb Alexey Kardashevskiy:
>>> So far POWER7+ was a part of POWER7 family. However it has a different
>>> PVR base value so in order to support PVR masks, it needs a separat
Am 08.11.2013 17:19, schrieb Laszlo Ersek:
> On 11/08/13 16:42, Andreas Färber wrote:
>> Jordan or Laszlo,
>>
>> Can either of you please add a small test case to i440fx-test using
>> -pflash and doing a read in the PCI hole (or wherever exactly) so that
>> we can avoid regressing yet again? :)
>
1 - 100 of 128 matches
Mail list logo
