Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-17 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: > Am 03.02.2014 20:01, schrieb Eduardo Habkost: > > On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: > >> Il 21/01/2014 16:51, Andreas Färber ha scritto: > > We already do that for other bits (e.g. XSAVE/OSXSAVE), > >

Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union

2014-02-17 Thread Luiz Capitulino
On Mon, 17 Feb 2014 09:50:10 +0800 Wenchao Xia wrote: > 于 2014/2/14 17:23, Markus Armbruster 写道: > > Wenchao Xia writes: > > > >> 于 2014/2/13 23:14, Markus Armbruster 写道: > >>> Wenchao Xia writes: > >>> > It will check whether the values specified are written correctly, > and whether

[Qemu-devel] [PATCH] PCIE: fix regression with coldplugged multifunction device

2014-02-17 Thread Igor Mammedov
QEMU abort is caused by misplaced assertion, which should be checked only when device is hotplugged. Refernce to regression report: http://www.mail-archive.com/qemu-devel@nongnu.org/msg216226.html Reported-By: Nigel Kukard Signed-off-by: Igor Mammedov --- hw/pci/pcie.c | 16

Re: [Qemu-devel] Hotplug vs. multifunction regression

2014-02-17 Thread Alex Williamson
[cc +igor, +mst] Appears that it's no longer possible to use multifunction devices at PCIe at all due to hotplug being an integral part of device realization now. Thanks, Alex On Sun, 2014-02-16 at 15:57 +, Nigel Kukard wrote: > Hi guys, > > Starting from the patch series in 9f117d41 the b

Re: [Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open()

2014-02-17 Thread Benoît Canet
The Monday 17 Feb 2014 à 13:42:43 (+0100), Kevin Wolf wrote : > Am 15.02.2014 um 04:30 hat Max Reitz geschrieben: > > bdrv_file_open() is now nearly a subset of bdrv_open(), except for the > > fact that bdrv_file_open() is for protocols and bdrv_open() for block > > drivers. It is possible to use b

[Qemu-devel] KVM call agenda for 2014-02-17 (was Re: KVM call agenda for 2014-02-04)

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 03, 2014 at 01:57:02PM +0100, Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > * Should we change anything to get more people to sign for the call? > There hasn't been a call in quite a long time. Ideas? > > Thanks, Juan. > > Call det

Re: [Qemu-devel] [PATCH] PCIE: fix regression with coldplugged multifunction device

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 03:00:06PM +0100, Igor Mammedov wrote: > QEMU abort is caused by misplaced assertion, which should > be checked only when device is hotplugged. > > Refernce to regression report: > http://www.mail-archive.com/qemu-devel@nongnu.org/msg216226.html > > Reported-By: Nigel Kuk

Re: [Qemu-devel] Hotplug vs. multifunction regression

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 07:10:51AM -0700, Alex Williamson wrote: > [cc +igor, +mst] > > Appears that it's no longer possible to use multifunction devices at > PCIe at all due to hotplug being an integral part of device realization > now. Thanks, > > Alex Yes, Igor just fixed it. > On Sun, 2014

Re: [Qemu-devel] KVM call agenda for 2014-02-17 (was Re: KVM call agenda for 2014-02-04)

2014-02-17 Thread Peter Maydell
On 17 February 2014 14:19, Michael S. Tsirkin wrote: > > On Mon, Feb 03, 2014 at 01:57:02PM +0100, Juan Quintela wrote: >> Hi >> >> Please, send any topic that you are interested in covering. >> >> * Should we change anything to get more people to sign for the call? >> There hasn't been a call i

[Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Michael S. Tsirkin
As reported in http://article.gmane.org/gmane.comp.emulators.qemu/253987 Mac OSX actually requires describing all occupied slots in ACPI - even if hotplug isn't enabled. I didn't expect this so I dropped description of all non hotpluggable slots from ACPI. As a result: before commit 99fd437dee4686

[Qemu-devel] [PULL 0/5] acpi,pc,pci,virtio,memory bug fixes

2014-02-17 Thread Michael S. Tsirkin
The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 4/5] memory_region_present: return false if address is not found in child MemoryRegion

2014-02-17 Thread Michael S. Tsirkin
From: Igor Mammedov Windows XP shows COM2 port as non functional in "Device Manager" although no COM2 port backing device is present in QEMU. This regression is really due to 3bb28b7208b349e7a1b326e3c6ef9efac1d462bf? memory: Provide separate handling of unassigned io ports accesses That is

[Qemu-devel] [PULL 2/5] acpi-test-data: update expected files

2014-02-17 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 4582 -> 4461 bytes tests/acpi-test-data/pc/SSDT | Bin 2200 -> 2299 bytes tests/acpi-test-data/q35/DSDT | Bin 7438 -> 7370 bytes tests/acpi-test-data/q35/SSDT | Bin 475 -> 588 bytes 4 files changed, 0 insertions(+), 0 d

[Qemu-devel] [PULL 3/5] virtio-net: remove function calls from assert

2014-02-17 Thread Michael S. Tsirkin
From: Joel Stanley peer_{de,at}tach were called from inside assert(). We don't support building without NDEBUG but it's not tidy. Rearrange to attach peer outside assert calls. Signed-off-by: Joel Stanley Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net

Re: [Qemu-devel] KVM call agenda for 2014-02-17 (was Re: KVM call agenda for 2014-02-04)

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 02:17:21PM +, Peter Maydell wrote: > On 17 February 2014 14:19, Michael S. Tsirkin wrote: > > > > On Mon, Feb 03, 2014 at 01:57:02PM +0100, Juan Quintela wrote: > >> Hi > >> > >> Please, send any topic that you are interested in covering. > >> > >> * Should we change an

[Qemu-devel] [PULL 5/5] PCIE: fix regression with coldplugged multifunction device

2014-02-17 Thread Michael S. Tsirkin
From: Igor Mammedov PCIE is causing asserts each time a multifunction device is added on command line (coldplug). This is caused by commit a66e657e18cd9b70e9f57ae5512c07faf2bc508f pci/pcie: convert PCIE hotplug to use hotplug-handler API QEMU abort is caused by misplaced assertion, which sho

Re: [Qemu-devel] [PATCH v13 10/14] qmp: Add command 'blockdev-backup'

2014-02-17 Thread Benoît Canet
The Monday 17 Feb 2014 à 21:32:51 (+0800), Fam Zheng wrote : > On Thu, 02/13 14:48, Benoît Canet wrote: > > The Wednesday 29 Jan 2014 à 13:07:37 (+0800), Fam Zheng wrote : > > > Similar to drive-backup, but this command uses a device id as target > > > instead of creating/opening an image file. > >

Re: [Qemu-devel] Fwd: Trying to write a new device / virtio-i2c ?

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 14:32, Alex David ha scritto: But that leaves me with another problem as I now understand how I2C works on linux... I, in fact, need at least 3 busses (for my at least 3 devices) - so i2c-0, i2c-1, i2c-2 So you cannot configure the three devices on the same bus, with three diffe

[Qemu-devel] [PATCH 2/3] hw/net/stellaris_enet: Avoid unintended sign extension

2014-02-17 Thread Peter Maydell
Add a cast to avoid an unintended sign extension that would mean we returned 0x in the high 32 bits for an IA0 read if bit 31 in the MAC address was 1. (This is harmless since we'll only be doing 4 byte reads, but it could be confusing, so best avoided.) Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 3/3] hw/timer/arm_timer: Avoid array overrun for bad addresses

2014-02-17 Thread Peter Maydell
The integrator's timer read/write functions log an error for bad addresses in guest accesses, but were falling through and using an out of bounds array index rather than returning early. Fix this. Signed-off-by: Peter Maydell --- hw/timer/arm_timer.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-devel] [PATCH v3 13/20] vhdx: correctly propagate errors

2014-02-17 Thread Jeff Cody
On Mon, Feb 17, 2014 at 02:44:00PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/vhdx.c | 21 + > 1 file changed, 9 insertions(+), 12 deletions(-) > > diff --git a/block/vhdx.c b/block/vhdx.c > index 55689cf..bd3081b 100644 > --- a/block/vhdx.c > ++

[Qemu-devel] [Bug 1280961] [NEW] editing the file when mount the file system using 9pfs. it will report fsync failed.

2014-02-17 Thread chchen
Public bug reported: I have get a fsync error when I use the 9pfs on the kvm guest. it appears when I use vi editor and sysbench. I have not found the reason yet. can you tell something about it? the attache is the picture. and there is no any log which I can provide. My qemu version is qemu-

[Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-17 Thread Kevin Wolf
Instead of making the backing file contents visible again after a discard request, set the zero flag if possible (i.e. on version >= 3). Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 22 -- tests/qemu-iotests/046 | 18 ++ 2 files changed, 34 insertion

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-17 Thread Eduardo Habkost
On Mon, Feb 17, 2014 at 03:58:13PM +0200, Michael S. Tsirkin wrote: > On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: > > Am 03.02.2014 20:01, schrieb Eduardo Habkost: > > > On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: > > >> Il 21/01/2014 16:51, Andreas Färber ha

[Qemu-devel] Cortex-M3: reading NVIC registers causes segfaults

2014-02-17 Thread Andreas Galauner
Hi qemu developers, I'm currently trying to emulate an ARM Cortex-M3 and I need to debug the system using GDB and IDA Pro. The platform is an STM32 and I'm using a port from github [1] based on qemu 1.5.1 for that. I ported the custom STM32 code to qemu 1.7.0 to have a more recent version to work

[Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-17 Thread Peter Maydell
Three random easy patches fixing issues reported by Coverity Scan. Peter Maydell (3): hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses hw/net/stellaris_enet: Avoid unintended sign extension hw/timer/arm_timer: Avoid array overrun for bad addresses hw/misc/arm_sysctl.c| 4

[Qemu-devel] [PATCH 1/3] hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses

2014-02-17 Thread Peter Maydell
Fix incorrect use of sizeof() rather than ARRAY_SIZE() to guard accesses into the mb_clock[] array, which was allowing a malicious guest to overwrite the end of the array. Signed-off-by: Peter Maydell --- hw/misc/arm_sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN

2014-02-17 Thread Eric Blake
On 02/16/2014 03:33 AM, Michael S. Tsirkin wrote: > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote: >> If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out all >> VLAN-tagged packets but send them to the guest. >> >> Signed-off-by: Stefan Fritsch > > Thanks for the patch

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Gabriel L. Somlo
Michael, On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > As reported in > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > Mac OSX actually requires describing all occupied slots > in ACPI - even if hotplug isn't enabled. > > I didn't expect this so I dropped desc

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-17 Thread Markus Armbruster
Fam Zheng writes: > On Sat, 02/15 11:01, Markus Armbruster wrote: >> Jeff Cody writes: >> >> > On Fri, Feb 14, 2014 at 05:45:40PM +0100, Kevin Wolf wrote: >> >> Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben: >> >> > Signed-off-by: Paolo Bonzini >> >> > --- >> >> > block/cow.c | 12 +++-

Re: [Qemu-devel] Cortex-M3: reading NVIC registers causes segfaults

2014-02-17 Thread Peter Maydell
On 17 February 2014 14:52, Andreas Galauner wrote: > I'm currently trying to emulate an ARM Cortex-M3 and I need to debug the > system using GDB and IDA Pro. The platform is an STM32 and I'm using a > port from github [1] based on qemu 1.5.1 for that. I ported the custom > STM32 code to qemu 1.7.0

Re: [Qemu-devel] [PATCH v2] trace backend: introduce multi tracing backend

2014-02-17 Thread Lluís Vilanova
Kazuya Saito writes: > This patch implements "multi tracing backend" which enables several > tracing backend simultaneously. This series raises some conflicts with the one I'm preparing for TCG tracing. In order to make it simpler to eventually integrate both, I've been preparing a cleanup of so

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

2014-02-17 Thread Vlad Yasevich
On 02/16/2014 09:27 PM, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. > > We should also not send the vlan table to management, this patch makes > the vlan-talbe optional.

Re: [Qemu-devel] Fwd: Trying to write a new device / virtio-i2c ?

2014-02-17 Thread Alex David
2014-02-17 15:30 GMT+01:00 Paolo Bonzini : > So you cannot configure the three devices on the same bus, with three > different addresses? Each sensor is different on the original hardware, they are connected on different busses. As my guest apps are calling i2c-1, i2c-2, ,i2c-N (and I can't

[Qemu-devel] device_del id missing after blockdev-add

2014-02-17 Thread William Dauchy
Hello, I'm starting qemu with the following config in order to test drive hotremove and hotadd: [drive "disk1"] if = "none" id = "disk1" cache = "none" aio = "native" format = "raw" file = "/dev/sda" [device "disk1"] driver = "scsi-hd" drive = "disk1" scsi-id = "1" removable

Re: [Qemu-devel] Delegating tasks for the GitHub mirror

2014-02-17 Thread Markus Armbruster
Peter Maydell writes: > On 17 February 2014 12:09, Alex Bennée wrote: >> I would like to get the Travis tests up and running on the "official" >> QEMU GitHub mirror to try and shorten the loop between the build >> breaking and people being notified. I'm quite happy to set this up if >> you add m

[Qemu-devel] [PATCH 1/3] qtest: drop unused child_pid field

2014-02-17 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index c9a4f89..2876ce4 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -43,7 +43,6 @@ struct QTestState int qmp_fd; bool irq_level[MAX_IRQ

[Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-17 Thread Stefan Hajnoczi
The QEMU process stays running if the test case fails. This patch fixes the leak by installing a SIGABRT signal handler which invokes qtest_end(). In order to make that work for assertion failures during qtest_init(), we need to initialize QTestState fields including file descriptors and pids car

[Qemu-devel] [PATCH 0/3] qtest: avoid pidfile and QEMU process leaks

2014-02-17 Thread Stefan Hajnoczi
This series prevents the following qtest issues: 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber. 2. Leaking the QEMU process when a test case aborts. Applying this series should make buildbots and manual "make check" users have a more pleasant and less leaky experie

[Qemu-devel] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor

2014-02-17 Thread Igor Mammedov
From: Wanlong Gao Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov --- include/sysemu/sysemu.h |3 +- numa.c | 147 +++ qapi-schema.json| 32 ++ vl.c|

[Qemu-devel] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor

2014-02-17 Thread Igor Mammedov
... while at it move most of numa related code to a dedicated file so that it won't to clatter vl.c. git tree for testing: https://github.com/imammedo/qemu/commits/numa_prep_v1 Igor Mammedov (1): vl.c: fix style issue Wanlong Gao (5): NUMA: move numa related code to new file numa.c NUMA: c

[Qemu-devel] [PATCH 6/6] NUMA: expand MAX_NODES from 64 to 128

2014-02-17 Thread Igor Mammedov
From: Wanlong Gao libnuma choosed 128 for MAX_NODES, so we follow libnuma here. Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov --- include/sysemu/sysemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/sysemu/sysemu.h b

[Qemu-devel] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size

2014-02-17 Thread Igor Mammedov
From: Wanlong Gao If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it to ensure that we write t

[Qemu-devel] [PATCH 1/6] vl.c: fix style issue

2014-02-17 Thread Igor Mammedov
add missing curly brackets to 'if' statement Signed-off-by: Igor Mammedov --- vl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 316de54..9e60e5c 100644 --- a/vl.c +++ b/vl.c @@ -4150,8 +4150,9 @@ int main(int argc, char **argv, char **envp)

[Qemu-devel] [PATCH 4/6] NUMA: Add numa_info structure to contain numa nodes info

2014-02-17 Thread Igor Mammedov
From: Wanlong Gao Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mamme

[Qemu-devel] [PATCH 2/6] NUMA: move numa related code to new file numa.c

2014-02-17 Thread Igor Mammedov
From: Wanlong Gao Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov --- Makefile.target |2 +- cpus.c | 14 include/sysemu/cpus.h |1 - include/sysemu/sysemu.h |3 + numa.c | 183 +++

Re: [Qemu-devel] Fwd: Trying to write a new device / virtio-i2c ?

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 16:33, Alex David ha scritto: If you need more than one bus, you need a new device exposing the I2C bus, besides the new sensor devices. USB-I2C could be one such device. So let me see if I understood well. USB-I2C (host QEMU device) seems a good idea, I could normally

[Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-17 Thread Gabriel L. Somlo
Add v2.3 fields to Type 17 (Memory Device) structure. Add Type 2 (Baseboard) structure. "About This Mac" on OS X guests will crash and restart the GUI if Type 17 structures are not compliant with at least v2.3 of the SMBIOS/DMI spec. OS X 10.7 and 10.8 will panic during boot if a Type 2 (Baseboar

[Qemu-devel] [PATCH v2 0/2] block: add suppoort for gluster reopen

2014-02-17 Thread Jeff Cody
Changes v1->v2: Patch 1: Removed unneeded state variables 'filename' and 'open_flags' (Stefan) Patch 2: Removed unneeded reopen state variable 'open_flags' (Stefan) This series provides support for bdrv_reopen() with gluster protocol drivers, and thereby also ena

[Qemu-devel] [PATCH v2 2/2] block: gluster - add reopen support.

2014-02-17 Thread Jeff Cody
Gluster does parse open flags in its .bdrv_open() implementation, and the .bdrv_reopen_* implementations need to do the same. A new gluster connection to the image file to be created is established in the .bdrv_reopen_prepare(), and the image file opened with the new flags. If this is successful,

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-17 Thread Mike Day
> 1. You seem to be removing the use of the active_timers_lock and replacing it > by >rcu (fine). However, you seem to have left the qemu_mutex_destroy in >timerlist_free, and left the mutex in QEMUTimerList. Any reason why we > need both? > I responded incorrectly to this yesterday. We

[Qemu-devel] [PATCH v2 1/2] block: gluster - code movements, state storage changes

2014-02-17 Thread Jeff Cody
In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, store open_flags and filename in the gluster state storage struct, and add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody --- block/gluster.c | 41 ++---

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 16:44, Stefan Hajnoczi ha scritto: } +static void sigabrt_handler(int signo) +{ +qtest_end(); +} + void qtest_quit(QTestState *s) { int status; if (s->qemu_pid != -1) { kill(s->qemu_pid, SIGTERM); waitpid(s->qemu_pid, &status, 0); } close(s-

Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

2014-02-17 Thread Paolo Bonzini
Il 13/02/2014 17:13, Igor Mammedov ha scritto: Adds option to -m "mem" - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in MiB. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov Sign

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-17 Thread Bob Breuer
On 2/17/2014 6:50 AM, Mark Cave-Ayland wrote: > On 14/02/14 14:54, Peter Crosthwaite wrote: > >>> The short answer is "we don't know" because we don't have any >>> documentation. >> >> Sigh This has happened quite a lot lately. >> >> If the kernel driver has macros, re-use them as much as poss

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-17 Thread Andreas Färber
Am 17.02.2014 14:58, schrieb Michael S. Tsirkin: > On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: >> Am 03.02.2014 20:01, schrieb Eduardo Habkost: >>> On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: Il 21/01/2014 16:51, Andreas Färber ha scritto: >>> We alre

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2014-02-17 Thread Peter Maydell
On 16 February 2014 22:00, Brad Smith wrote: > On 26/01/14 1:06 PM, Paolo Bonzini wrote: >> >> Il 26/01/2014 02:37, Brad Smith ha scritto: > > Reviewed-by: Stefan Hajnoczi >>> >>> >>> Is there some sort of process I am missing to have build fixes >>> commited so that QEMU actual

[Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-17 Thread Stefan Hajnoczi
qtest_init() cannot use exec*p() to launch QEMU since the exec*p() functions take an argument array while qtest_init() takes char *extra_args. Therefore we execute /bin/sh -c and let the shell parse the argument string. This left /bin/sh as our child process and our child's child was QEMU. We st

Re: [Qemu-devel] [PATCH 5/6] NUMA: convert -numa option to use OptsVisitor

2014-02-17 Thread Eric Blake
On 02/17/2014 08:49 AM, Igor Mammedov wrote: > From: Wanlong Gao > > Signed-off-by: Wanlong Gao > Signed-off-by: Paolo Bonzini > Signed-off-by: Igor Mammedov > --- > +++ b/qapi-schema.json > @@ -4420,3 +4420,35 @@ > +## > +# @NumaNodeOptions > +# > +# Create a guest NUMA node. (for OptsVisito

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-17 Thread Alex Bligh
On 17 Feb 2014, at 16:13, Mike Day wrote: >> 1. You seem to be removing the use of the active_timers_lock and replacing >> it by >> rcu (fine). However, you seem to have left the qemu_mutex_destroy in >> timerlist_free, and left the mutex in QEMUTimerList. Any reason why we >> need both? >

Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

2014-02-17 Thread Luiz Capitulino
On Mon, 17 Feb 2014 17:18:25 +0100 Paolo Bonzini wrote: > Il 13/02/2014 17:13, Igor Mammedov ha scritto: > > Adds option to -m > > "mem" - startup memory amount > > > > For compatibility with legacy CLI if suffix-less number is passed, > > it assumes amount in MiB. > > > > Otherwise user is free

Re: [Qemu-devel] [PATCH v2] memory: fix limiting of translation at a page boundary

2014-02-17 Thread Anthony PERARD
On Fri, Feb 07, 2014 at 02:56:48PM +, Stefano Stabellini wrote: > On Fri, 7 Feb 2014, Paolo Bonzini wrote: > > Commit 360e607 (address_space_translate: do not cross page boundaries, > > 2014-01-30) broke MMIO accesses in cases where the section is shorter > > than the full register width. This

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > qtest_init() cannot use exec*p() to launch QEMU since the exec*p() > functions take an argument array while qtest_init() takes char > *extra_args. Therefore we execute /bin/sh -c and let the > shell parse the argument string. > > This left /bin/sh as our child process

Re: [Qemu-devel] [PATCH] qemu-options.hx: improve -numa doc

2014-02-17 Thread Paolo Bonzini
Il 14/02/2014 20:34, Luiz Capitulino ha scritto: The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text. Signed-off-by: Luiz Capitulino --- qemu-options.hx | 9 +

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > The QEMU process stays running if the test case fails. This patch fixes > the leak by installing a SIGABRT signal handler which invokes > qtest_end(). > > In order to make that work for assertion failures during qtest_init(), > we need to initialize QTestState fields in

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

2014-02-17 Thread Eric Blake
On 02/16/2014 07:27 PM, Amos Kong wrote: > Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't > filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. > > We should also not send the vlan table to management, this patch makes > the vlan-talbe optional. s/t

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

2014-02-17 Thread Eric Blake
On 02/17/2014 09:52 AM, Eric Blake wrote: > On 02/16/2014 07:27 PM, Amos Kong wrote: >> Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't >> filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. >> >> We should also not send the vlan table to management, t

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 17:49, Markus Armbruster ha scritto: Assumes zero-initialization has the same effect as sigemptyset(&sigact.sa_mask). Quoting POSIX: The implementation of the sigemptyset() (or sigfillset()) function could quite trivially clear (or set) all the bits in the signal set.

Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug

2014-02-17 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > Michael, > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > As reported in > > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > > Mac OSX actually requires describing all occupied slots > > in A

Re: [Qemu-devel] [PATCH] virtio-net: only output the vlan table when VIRTIO_NET_F_CTRL_VLAN is negotiated

2014-02-17 Thread Vlad Yasevich
On 02/17/2014 11:56 AM, Eric Blake wrote: > On 02/17/2014 09:52 AM, Eric Blake wrote: >> On 02/16/2014 07:27 PM, Amos Kong wrote: >>> Stefan Fritsch just fixed a virtio-net driver bug [1], virtio-net won't >>> filter out VLAN-tagged packets if VIRTIO_NET_F_CTRL_VLAN isn't negotiated. >>> >>> We sho

Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure

2014-02-17 Thread Markus Armbruster
Paolo Bonzini writes: > Il 17/02/2014 16:44, Stefan Hajnoczi ha scritto: >> } >> >> +static void sigabrt_handler(int signo) >> +{ >> +qtest_end(); >> +} >> + > > void qtest_quit(QTestState *s) > { > int status; > > if (s->qemu_pid != -1) { > kill(s->qemu_pid, SIGTERM); >

Re: [Qemu-devel] [PATCH] block/iscsi: query for supported VPD pages

2014-02-17 Thread Peter Lieven
ping ;-) Am 29.01.2014 12:56, schrieb Peter Lieven: > this patch ensures that we only query for block provisioning and > block limits vpd pages if they are advertised. It also cleans > up the inquiry code and eliminates some redundant code. > > Signed-off-by: Peter Lieven > --- > block/iscsi.c |

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-17 Thread Eric Blake
On 02/17/2014 07:45 AM, Kevin Wolf wrote: > Instead of making the backing file contents visible again after a discard > request, set the zero flag if possible (i.e. on version >= 3). > > Signed-off-by: Kevin Wolf > --- > block/qcow2-cluster.c | 22 -- > tests/qemu-iotests/04

Re: [Qemu-devel] [PATCH v8 14/17] Add the vhost-user netdev backend to the command line

2014-02-17 Thread Eric Blake
On 02/13/2014 05:03 AM, Antonios Motakis wrote: > The supplied chardev id will be inspected for supported options. Only > a socket backend, with a set path (i.e. a Unix socket) and optionally > the server parameter set, will be allowed. Other options (nowait, telnet) > will make the chardev unusabl

[Qemu-devel] [PATCH 1/3] include/qemu/crc32c.h: Rename include guards to match filename

2014-02-17 Thread Will Newton
Signed-off-by: Will Newton --- include/qemu/crc32c.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/crc32c.h b/include/qemu/crc32c.h index 56d1c3b..dafb6a1 100644 --- a/include/qemu/crc32c.h +++ b/include/qemu/crc32c.h @@ -25,8 +25,8 @@ * */ -#ifndef QE

[Qemu-devel] [PATCH 3/3] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-17 Thread Will Newton
Add support for AArch32 CRC32 and CRC32C instructions added in ARMv8. Signed-off-by: Will Newton --- target-arm/helper.c| 37 + target-arm/helper.h| 3 +++ target-arm/translate.c | 48 3 files changed,

[Qemu-devel] [PATCH 0/3] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-17 Thread Will Newton
This series adds support for the AArch32 CRC32 instructions added in ARMv8. The CRC-32 algorithm is added alongside the existing CRC-32C implementation which requires a small fix to the crc32c.h header file. Will Newton (3): include/qemu/crc32c.h: Rename include guards to match filename util/c

[Qemu-devel] [PATCH 2/3] util/crc32.c: Add CRC-32 implementation

2014-02-17 Thread Will Newton
Add a table-driven CRC-32 implementation similar in style to the existing CRC-32C implementation. Signed-off-by: Will Newton --- include/qemu/crc32.h | 15 util/Makefile.objs | 1 + util/crc32.c | 98 3 files changed, 114 i

Re: [Qemu-devel] [PATCH 1/3] include/qemu/crc32c.h: Rename include guards to match filename

2014-02-17 Thread Peter Maydell
On 17 February 2014 17:19, Will Newton wrote: > Signed-off-by: Will Newton > --- > include/qemu/crc32c.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/qemu/crc32c.h b/include/qemu/crc32c.h > index 56d1c3b..dafb6a1 100644 > --- a/include/qemu/crc32c.h > +++

Re: [Qemu-devel] [PATCH] Properly check if 'log dirty' flags have changed

2014-02-17 Thread Eric Blake
On 02/17/2014 06:47 AM, Vincent KHERBACHE wrote: > The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is not > good because the condition is valid when enable == 0 and current dirty log > memory flag is set. > As a consequence kvm_log_global_stop() does not stop the KVM dirty log > track

Re: [Qemu-devel] [PATCH] block/iscsi: query for supported VPD pages

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 18:09, Peter Lieven ha scritto: ping ;-) Looks good, but I cannot find the original post. Paolo Am 29.01.2014 12:56, schrieb Peter Lieven: this patch ensures that we only query for block provisioning and block limits vpd pages if they are advertised. It also cleans up the inqu

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-17 Thread Eduardo Habkost
On Mon, Feb 17, 2014 at 05:17:51PM +0100, Andreas Färber wrote: > Am 17.02.2014 14:58, schrieb Michael S. Tsirkin: > > On Tue, Feb 04, 2014 at 03:12:43PM +0100, Andreas Färber wrote: > >> Am 03.02.2014 20:01, schrieb Eduardo Habkost: > >>> On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wro

Re: [Qemu-devel] [PATCH v8 01/17] Convert -mem-path to QemuOpts and add prealloc and share properties

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 14:04, Antonios Motakis ha scritto: Hmm in that case, let's not add prealloc as a property here. Stick to existing flag for that, this way we don't need to support 3 ways to do this. We'll remove the prealloc property then for the next version. Otherwise, I wonder if

Re: [Qemu-devel] [PATCH] block/iscsi: query for supported VPD pages

2014-02-17 Thread Peter Lieven
Am 17.02.2014 18:26, schrieb Paolo Bonzini: > Il 17/02/2014 18:09, Peter Lieven ha scritto: >> ping ;-) > > Looks good, but I cannot find the original post. strange, sent it to qemu-devel on Jan/29. Peter > > Paolo > >> Am 29.01.2014 12:56, schrieb Peter Lieven: >>> this patch ensures that we only

Re: [Qemu-devel] [PATCH 2/3] util/crc32.c: Add CRC-32 implementation

2014-02-17 Thread Peter Maydell
On 17 February 2014 17:19, Will Newton wrote: > Add a table-driven CRC-32 implementation similar in style to the > existing CRC-32C implementation. > +++ b/include/qemu/crc32.h > @@ -0,0 +1,15 @@ > +/* > + * CRC32C Checksum Algorithm > + * > + * Polynomial: 0x04C11DB7 > + * > + */ > + > +#ifnde

[Qemu-devel] [PULL 00/12] Build system changes for 2014-02-17

2014-02-17 Thread Paolo Bonzini
Anthony, Peter, The following changes since commit 89e4a51ca9546a7bbe1998c4e3d4a3ac3a0c19be: Merge remote-tracking branch 'stefanha/tags/tracing-pull-request' into staging (2014-01-31 11:13:08 +) are available in the git repository at: git://github.com/bonzini/qemu.git configure for y

Re: [Qemu-devel] PC-BSD installer does not boot with 1.7.4 (bisected)

2014-02-17 Thread Michael Tokarev
10.02.2014 19:41, Kevin O'Connor wrote: [] > There hasn't been much comment, but I have pushed this patch to the > main seabios repo for now. Xin Li (Cc'ed) replied to this email. Meanwhile I tried your patch, and it indeed fixes the reported issues with FreeBSD and PCBSD. Even if FreeBSD fixes

[Qemu-devel] [PULL 07/12] module: implement module loading

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_sta

[Qemu-devel] [PULL 05/12] darwin: do not use -mdynamic-no-pic

2014-02-17 Thread Paolo Bonzini
While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng Signed-off-b

[Qemu-devel] [PULL 04/12] block: use per-object cflags and libs

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to

Re: [Qemu-devel] [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value

2014-02-17 Thread Eric Blake
On 02/17/2014 04:52 AM, Marcel Apfelbaum wrote: > A NULL value is not added to visitor's stack, but there > is no check for that when the visitor tries to return > that value, leading to Qemu crash. Do you have an easy formula for reproducing the crash? > > Signed-off-by: Marcel Apfelbaum > ---

[Qemu-devel] [PULL 06/12] rules.mak: introduce DSO rules

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng Add necessary rules and flags for shared object generation. The new rules introduced here are: 1) %.o in $(common-obj-m) is compiled to %.o, then linked to %.so. 2) %.mo in $(common-obj-m) is the placeholder for %.so for pattern matching in Makefile. It's linked to "-shared" wit

[Qemu-devel] [PULL 09/12] Makefile: introduce common-obj-m and block-obj-m for DSO

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile|4 +++- Makefile.objs |2 ++ Makefile.target |6 +- 3 files changed, 10 insertions(+), 2 dele

[Qemu-devel] [PULL 11/12] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-17 Thread Paolo Bonzini
From: Don Slutz Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names to be fixed (TMPB). Add new functions do_libtool and libtool_prog. Add check for broken gcc and libtool. Signed-off-by: Don Slutz Signed-off-by: Paolo Bonzini --- configure | 63 ++

[Qemu-devel] [PATCH RESEND] block/iscsi: query for supported VPD pages

2014-02-17 Thread Peter Lieven
this patch ensures that we only query for block provisioning and block limits vpd pages if they are advertised. It also cleans up the inquiry code and eliminates some redundant code. Signed-off-by: Peter Lieven --- block/iscsi.c | 107 + 1

[Qemu-devel] [PULL 08/12] Makefile: install modules with "make install"

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 07d1ed7..57d83a3 100644 --- a/Makefile +++ b/Makefile @@ -368,6 +368

[Qemu-devel] [PULL 01/12] util: Split out exec_dir from os_find_datadir

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng With this change, main() calls qemu_init_exec_dir and uses argv[0] to init exec_dir. The saved value can be retrieved with qemu_get_exec_dir later. It will be reused by module loading. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/qemu-common.h |2 +- i

[Qemu-devel] [PULL 10/12] block: convert block drivers linked with libs to modules

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index bd21db9..639b5c9

[Qemu-devel] [PULL 12/12] build: softmmu targets do not have a "main.o" file

2014-02-17 Thread Paolo Bonzini
Thus this rule is useless. Signed-off-by: Paolo Bonzini --- Makefile.target |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index 3945260..ba12340 100644 --- a/Makefile.target +++ b/Makefile.target @@ -130,8 +130,6 @@ else obj-y += hw/

[Qemu-devel] [PATCH 5/7] allwinner-a10-pit: implement prescaler and source selection

2014-02-17 Thread Beniamino Galvani
This implements the prescaler and source fields of the timer control register as described in the A10 user manual. Signed-off-by: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/timer/allwinner-a10-pi

<    1   2   3   4   >