Hello,
It looks like that commit 56bd9ea1a37395012adecca8b9c4762da15b01e7
(console: reimplement qemu_default_pixelformat) breaks display with
qemu-system-ppc on x86_64 host with SDL. The window just stays black after
this commit (although the machine still runs, it cannot be seen). Can you
How to test send data to VM?
On 2014/7/18 7:44, Michael S. Tsirkin wrote:
From: Nikolay Nikolaev n.nikol...@virtualopensystems.com
A new field mmap_offset was added in the vhost-user message, we need to
reflect
this change in the test too.
Signed-off-by: Nikolay Nikolaev
The S24/TCX framebuffer is a mildly accelerated video card with
blitter, stippler and hardware cursor.
* Solaris and NetBSD 6.x use all the hardware acceleration features
* The Xorg driver (used by Linux) can use the hardware cursor only
This patch implements hardware acceleration in both 8 bit
Il 13/09/2014 04:22, TeLeMan ha scritto:
On Fri, Sep 12, 2014 at 6:05 PM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 12/09/2014 03:39, TeLeMan ha scritto:
On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini pbonz...@redhat.com wrote:
diff --git a/aio-win32.c b/aio-win32.c
index 4542270..61e3d2d
Il 13/09/2014 05:51, John Snow ha scritto:
When the command completion code in IDE and AHCI
was unified to put all command completion inside
of a callback, cmd_done, we neglected to
ensure that all AHCI/ATAPI command paths would
eventually register as finished. for the PCI
interface to IDE
Il 12/09/2014 21:26, Markus Armbruster ha scritto:
Match the bdrv_new() with a bdrv_unref(), just to be tidy.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index
Il 13/09/2014 06:34, John Snow ha scritto:
The prepare_buf callback takes an argument named /is_write/,
however in core.c we are checking to see if this DMA command
is /is_read/. I am adding a small macro to correct this oversight.
Impact: Nothing, yet.
-The prepare_buf callback is only
Il 13/09/2014 06:34, John Snow ha scritto:
Currently, DMA read/write operations neglect to update
the byte count after a successful transfer like ATAPI
DMA read or PIO read/write operations do.
We correct this oversight by adding another callback into
the IDEDMAOps structure. The commit
Il 13/09/2014 06:34, John Snow ha scritto:
This impacts both BMDMA and AHCI HBA interfaces for IDE.
Currently, we confuse the difference between a PRD having
0 bytes and a PRD having 0 complete sectors.
This leads to, in the BMDMA case, leaked memory for short PRDTs,
and infinite loops in
Il 13/09/2014 06:34, John Snow ha scritto:
AHCI devices support a feature where individual entries in the
scatter-gather list may have interrupt request bits set, in order
to receive notification partway through a command that a portion
of a transfer has completed. AHCI specs refer to this as
Il 13/09/2014 06:34, John Snow ha scritto:
Error checking in ahci's handle_cmd is re-ordered so that we
initialize as few things as possible before we've done our
sanity checking. This simplifies returning from this call
in case of an error.
A check to make sure the DMA memory map succeeds
Il 13/09/2014 06:34, John Snow ha scritto:
Instead of checking for a known byte, inspect the
fields of this byte explicitly to produce more meaningful
error messages and improve the readability of this section.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 23
Il 13/09/2014 06:34, John Snow ha scritto:
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 169
++
1 file changed, 86 insertions(+), 83 deletions(-)
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
diff --git
Hi Guys
I am new to this forum and I have joined this forum in order to contribute
to this forum and also get benefit from it.
Actually I have a development board based on ARM9 architecture named as
mini2440.
I want to develop a BSP for this board so that the qemu can support this
board also in
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
No functional change, except:
- naming convention i.e. QemuProcess has been changed to QemuDirtyBitmapUser.
- rectified mistakes in documentation in qapi-schema.json.
- removed acronyms
hmp-commands.hx | 16 ++
hmp.c
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
No functional change, except acronyms have been removed.
Removed acronyms, no functional change.
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 9 +
Hi,
The following patches introduce the support of the dirty bitmap logging and
dumping to a specified file. This patch series addresses the previous issues
raised by David and Eric.
v5 -- v6
* The shared function between migration and log bitmap has been again modified
(David's advice).
*
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
Removed acronyms, no functional change.
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 12
qmp-commands.hx | 24
savevm.c
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
Removed acronyms, no functional change.
hmp-commands.hx | 2 ++
hmp.c| 21 +
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 28
qmp-commands.hx
I have modified the script to support the dump of the images to the file.
Earlier,
everything was saved to the memory and later the processing was taking place.
Now,
I have tried to solve that issue with only using the required memory.
After discussion with David, I have tried to select a base
Now, the counter variable is available to all the functions that will call
qemu_bitmap_sync_range. I have tried to make the function along with the
variables as generic as possible.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
arch_init.c | 19 +++
Make the BlockBackend own the DriveInfo. Change blockdev_init() to
return the BlockBackend instead of the DriveInfo.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 3 --
block/block-backend.c | 38
blockdev.c| 73
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes and the backend as a whole. Drawbacks:
* Its
BlockBackend's name space is separate only to keep the initial patches
simple. Time to merge the two.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 11 +++
block/block-backend.c | 13 ++---
2 files changed, 9 insertions(+), 15 deletions(-)
diff
The pointer from BlockBackend to BlockDriverState is a strong
reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is
a weak one.
Convenience function blk_new_with_bs() creates a BlockBackend with its
BlockDriverState. Callers have to unref both. The commit after next
will
device_name[] can become non-empty only in bdrv_new_root() and
bdrv_move_feature_fields(). The latter is used only to undo damage
done by bdrv_swap(). The former is called only by blk_new_with_bs().
Therefore, when a BlockDriverState's device_name[] is non-empty, then
it's been created with a
This is consistent with how VirtIOFOOConf variables are named
elsewhere, and makes blk available for BlockBackend variables.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/block/dataplane/virtio-blk.c | 33 +-
hw/block/dataplane/virtio-blk.h | 2 +-
Commit 12c5674 turned it into a pointer to member blk.conf.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/block/virtio-blk.c | 28 ++--
include/hw/virtio/virtio-blk.h | 1 -
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git
Creating an anonymous BDS can't fail. Make that obvious.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 28 +++-
block/iscsi.c | 2 +-
block/vvfat.c | 2 +-
blockdev.c| 2 +-
hw/block/xen_disk.c | 2 +-
On BlockBackend destruction, unref its BlockDriverState. Replaces the
callers' unrefs.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 6 ++
blockdev.c| 7 ++-
hw/block/xen_disk.c | 6 +++---
qemu-img.c| 35
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block-migration.c | 30 +++---
block.c | 9 -
blockdev.c| 31 +--
include/block/block.h | 2 --
monitor.c | 32
The patch is big, but all it really does is replacing
dinfo-bdrv
by
blk_bs(blk_legacy_dinfo(dinfo))
The replacement is repetitive, but the conversion of device models to
BlockBackend is imminent, and will shorten it to just
blk_legacy_dinfo(dinfo).
Line wrapping muddies the waters a
My last attempt got bogged down because I tried to do a reasonably
complete job, and the complexity proved more than I could handle with
the limited amount of uninterrupted time available. This time, I'm
cutting BlockBackend off with an axe, leaving most of the work for
later.
Done in this
Signed-off-by: Markus Armbruster arm...@redhat.com
---
include/hw/isa/pc87312.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h
index befc8bd..bf74470 100644
--- a/include/hw/isa/pc87312.h
+++ b/include/hw/isa/pc87312.h
@@ -47,13 +47,10 @@
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 15 +++
blockdev.c| 13 -
include/sysemu/blockdev.h | 1 -
stubs/Makefile.objs | 1 -
stubs/blockdev.c | 12
5 files changed, 15 insertions(+),
Commit 2d246f0 introduced DriveInfo member enable_auto_del to
distinguish DriveInfo created via drive_new() from DriveInfo created
via qmp_blockdev_add(). The latter no longer exist. Drop
enable_auto_del.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c| 11
Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use
blk_aio_discard() instead of bdrv_aio_discard().
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/ide/core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 1 -
blockdev.c| 3 +--
include/sysemu/blockdev.h | 1 -
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 472b545..9b146c8 100644
---
Much more command code needs conversion. I'm converting these now
because they's using bdrv_dev_* functions, which I'm about to lift
into BlockBackend.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
Doesn't make a difference just yet, but it's the right thing to do.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/block-backend.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 9c504f3..17285ba 100644
---
Much more command code needs conversion. I start with this one
because it's using bdrv_dev_* functions, which I'm about to lift into
BlockBackend.
While there, give bdrv_query_info() internal linkage.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/qapi.c | 15
I'll use BlockDriverAIOCB with block backends shortly, and the name is
going to fit badly there. It's a block layer thing anyway, not just a
block driver thing.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block-migration.c | 2 +-
block.c | 151
blockdev_init() always creates a DriveInfo, but only drive_new() fills
it in. qmp_blockdev_add() leaves it blank. This results in a drive
with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c.
Board initialization code looking for IDE drive (0,0) can pick up one
of these bogus
Move device model attachment / detachment and the BlockDevOps device
model callbacks and their wrappers from BlockDriverState to
BlockBackend.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c| 126 --
block/block-backend.c
On 09/12/2014 01:26 PM, Markus Armbruster wrote:
Suggested-by: Benoit Canet benoit.ca...@nodalink.com
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c| 3 ++-
tests/qemu-iotests/087.out | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by:
On Fri, 09/05 16:33, Stefan Hajnoczi wrote:
On Mon, Sep 01, 2014 at 06:52:48PM +0800, Jun Li wrote:
How does this patch handle self-describing refcount blocks? I think
they will keep the refcount block alive forever because your code will
not decide to free them.
Sorry, I have ignored
On 12/09/2014 08:19 μμ, Luiz Capitulino wrote:
On Fri, 12 Sep 2014 20:01:04 +0300
Stratos Psomadakis pso...@grnet.gr wrote:
On 12/09/2014 06:21 μμ, Luiz Capitulino wrote:
On Fri, 12 Sep 2014 17:07:32 +0300
Stratos Psomadakis pso...@grnet.gr wrote:
Commit cdaa86a54 (Add G_IO_HUP handler for
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 13 +
target-m68k/cpu-qom.h | 3 +++
target-m68k/cpu.c | 3 +++
target-m68k/helper.c | 20
4 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 6 --
target-s390x/cpu-qom.h | 1 +
target-s390x/cpu.c | 1 +
target-s390x/helper.c | 13 +
4 files changed, 15 insertions(+), 6 deletions(-)
diff --git
Around the cpu_exec_enter/exit hooks contain many empty
ifdef blocks. Delete all of these to highlight those
targets for which we actually need to do work.
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 32
1 file changed, 32 deletions(-)
In preparation for removing a bunch of ifdefs from cpu_exec.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 9 ++---
include/qom/cpu.h | 5 +
qom/cpu.c | 6 --
3 files changed, 11 insertions(+), 9 deletions(-)
Cc: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 23 ---
target-arm/cpu-qom.h | 1 +
target-arm/cpu.c | 34 ++
target-arm/cpu64.c | 1 +
4 files changed, 36
Prompted by trying to review Martin's ARM exception vs gdb
problems, let's clean up cpu_exec so that it's almost readable.
After the 23 patches, there's one (interesting) ifdef left.
That is, i386 redefining CPU_INTERRUPT_RESET as CPU_INTERRUPT_INIT
for its own purposes. I'm not sure why all
Since do_interrupt_m68k_hardirq is no longer used outside
op_helper.c, make it static.
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 13 -
target-m68k/cpu-qom.h | 1 +
target-m68k/cpu.c | 1 +
target-m68k/cpu.h | 1 -
Cc: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 9 -
target-microblaze/cpu-qom.h | 1 +
target-microblaze/cpu.c | 1 +
target-microblaze/helper.c | 16
4 files changed, 18
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 32
target-alpha/cpu-qom.h | 1 +
target-alpha/cpu.c | 1 +
target-alpha/helper.c | 44
4 files changed, 46 insertions(+), 32
The signal is currently checked by 10 targets, but only actually
raised by Sparc and ARM. For the sake of one test-and-branch,
we can handle this generic bit generically.
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 5 -
1 file changed, 5 deletions(-)
diff --git
Continuing the removal of ifdefs from cpu_exec.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 14 +-
include/qom/cpu.h | 2 ++
qom/cpu.c | 6 ++
3 files changed, 17 insertions(+), 5 deletions(-)
diff --git
Cc: Michael Walle mich...@walle.cc
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 7 ---
target-lm32/cpu-qom.h | 1 +
target-lm32/cpu.c | 1 +
target-lm32/helper.c | 13 +
4 files changed, 15 insertions(+), 7 deletions(-)
diff --git
Cc: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 21 -
target-cris/cpu-qom.h | 1 +
target-cris/cpu.c | 1 +
target-cris/helper.c | 31 +++
4 files changed, 33
Cc: qemu-...@nongnu.org
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 8
target-ppc/cpu-qom.h| 1 +
target-ppc/cpu.h| 1 -
target-ppc/excp_helper.c| 19 +--
target-ppc/translate_init.c | 1 +
5 files
Cc: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 5 -
target-sh4/cpu-qom.h | 1 +
target-sh4/cpu.c | 1 +
target-sh4/helper.c | 9 +
4 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/cpu-exec.c
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 64
target-i386/cpu-qom.h| 1 +
target-i386/cpu.c| 1 +
target-i386/seg_helper.c | 69
4 files changed, 71
Cc: Guan Xuetao g...@mprc.pku.edu.cn
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c | 7 ---
target-unicore32/cpu-qom.h | 1 +
target-unicore32/cpu.c | 1 +
target-unicore32/helper.c | 15 +++
4 files changed, 17 insertions(+), 7
Cc: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Richard Henderson r...@twiddle.net
---
cpu-exec.c| 9 -
target-mips/cpu-qom.h | 1 +
target-mips/cpu.c | 1 +
target-mips/helper.c | 17 +
4 files changed, 19 insertions(+), 9 deletions(-)
diff
On 09/13/2014 08:54 AM, Paolo Bonzini wrote:
Il 13/09/2014 06:34, John Snow ha scritto:
The prepare_buf callback takes an argument named /is_write/,
however in core.c we are checking to see if this DMA command
is /is_read/. I am adding a small macro to correct this oversight.
Impact:
This has been discussed on IRC, but I want it on the list for further
discussion and later reference.
Terminology: BDS = BlockDriverState, BB = BlockBackend
Traditionally, only root BDSes could be named. They're always uniquely
named; if the user doesn't supply a name via -drive parameter id,
On 12.09.2014 14:38, Stefan Hajnoczi wrote:
Max: Unrelated to this performance issue but I notice that the qcow2
metadata overlap check is high in the host CPU profile. Have you had
any thoughts about optimizing the check?
Stefan
In fact, I have done so (albeit only briefly). Instead of
On 12.09.2014 11:51, Fam Zheng wrote:
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk
Signed-off-by: Fam
On 12.09.2014 21:26, Markus Armbruster wrote:
blockdev_init() mixes up BlockDriverState and DriveInfo initialization
Finish the BlockDriverState job before starting to mess with
DriveInfo. Easier on the eyes.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 43
The Friday 12 Sep 2014 à 21:26:24 (+0200), Markus Armbruster wrote :
Suggested-by: Benoit Canet benoit.ca...@nodalink.com
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c| 3 ++-
tests/qemu-iotests/087.out | 2 +-
2 files changed, 3 insertions(+), 2
On 12.09.2014 21:26, Markus Armbruster wrote:
If the BDS's refcnt 0, drive_del() destroys the DriveInfo, but not
the BDS. This can happen in three places:
* Device model destruction during unplug: blockdev_auto_del()
* Xen IDE unplug: pci_piix3_xen_ide_unplug()
* drive_del command when no
Il 13/09/2014 15:26, Paolo Bonzini ha scritto:
+if (ad-dp_intr_req) {
+ahci_trigger_irq(ad-hba, ad, PORT_IRQ_SG_DONE);
+ad-dp_intr_req = 0;
+}
Is it also needed in the error case? Especially the short-PRDT case
that you are adding in the next patch.
...
Il 13/09/2014 18:44, Richard Henderson ha scritto:
After the 23 patches, there's one (interesting) ifdef left.
That is, i386 redefining CPU_INTERRUPT_RESET as CPU_INTERRUPT_INIT
for its own purposes. I'm not sure why all that couldn't be done
under whatever hooks cpu_reset allows.
There
On 13.09.2014 17:00, Markus Armbruster wrote:
Creating an anonymous BDS can't fail. Make that obvious.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 28 +++-
block/iscsi.c | 2 +-
block/vvfat.c | 2 +-
blockdev.c
On 13.09.2014 17:00, Markus Armbruster wrote:
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes
On 13.09.2014 17:00, Markus Armbruster wrote:
The pointer from BlockBackend to BlockDriverState is a strong
reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is
a weak one.
Convenience function blk_new_with_bs() creates a BlockBackend with its
BlockDriverState. Callers have
On Sat, 13 Sep 2014 19:27:46 +0300
Stratos Psomadakis pso...@grnet.gr wrote:
On 12/09/2014 08:19 μμ, Luiz Capitulino wrote:
On Fri, 12 Sep 2014 20:01:04 +0300
Stratos Psomadakis pso...@grnet.gr wrote:
On 12/09/2014 06:21 μμ, Luiz Capitulino wrote:
On Fri, 12 Sep 2014 17:07:32 +0300
Try adding this to the Linux commandline, in your bootloader:
mce=nobootlog
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1307225
Title:
Running a virtual machine on a Haswell system produces
I got a new Haswell based system a few days ago. It has been running
fine without warnings but today I started a VirtualBox VM and got a MCE
soon afterwards. MCA: Internal parity error like everyone else. From
reading this bug and the vmware link in the first post it seems like
this problem occurs
80 matches
Mail list logo
