Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread aurelio remonda
Thank you! Im working on it El 16/6/2015 8:21, Peter Maydell peter.mayd...@linaro.org escribió: On 15 June 2015 at 21:31, Aurelio C. Remonda aurelioremo...@gmail.com wrote: This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP

Re: [Qemu-devel] [PATCH 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used in new code. Hiding them in QERR_ macros makes new uses hard to spot. Fortunately, there's just one such macro left. Eliminate it with

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread aurelio remonda
about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first set_feature, the cortex-m3 initfn does not have it, do you want me to change that one too? Thanks 2015-06-16 9:29 GMT-03:00 Liviu Ionescu i...@livius.net: On 16 Jun 2015, at 14:21, Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH v2 4/6] qapi: AllocVisitor

2015-06-16 Thread Kővágó, Zoltán
Simple visitor that recursively allocates structures with only optional variables. Unions are initialized to the first type specified. Other non optional types are not supported. Signed-off-by: Kővágó, Zoltán dirty.ice...@gmail.com --- include/qapi/alloc-visitor.h | 18 +

Re: [Qemu-devel] [PATCH 11/13] target-mips: microMIPS32 R6 Major instructions

2015-06-16 Thread Leon Alrae
On 12/06/2015 15:02, Yongbok Kim wrote: add new microMIPS32 Release 6 Major opcode instructions Signed-off-by: Yongbok Kim yongbok@imgtec.com --- target-mips/translate.c | 58 -- 1 files changed, 55 insertions(+), 3 deletions(-) diff

Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError

2015-06-16 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 13 Jun 2015 16:20:47 +0200 Markus Armbruster arm...@redhat.com wrote: After a bit over a year and many patches, QError is finally ripe. All that's left of qerror.h after this series is a bunch of QERR_ macros. Killing them is left for

Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError

2015-06-16 Thread Luiz Capitulino
On Tue, 16 Jun 2015 15:08:41 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 13 Jun 2015 16:20:47 +0200 Markus Armbruster arm...@redhat.com wrote: After a bit over a year and many patches, QError is finally ripe. All that's

Re: [Qemu-devel] [PATCH v4 2/2] semihosting: add --semihosting-config arg sub-argument

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 13:32, Liviu Ionescu i...@livius.net wrote: would it be possible to have all the semihosting patches ready for 2.4? Yes, I agree that would be good. Is it just this 2 patch series, or are there others too? thanks -- PMM

[Qemu-devel] [PATCH V16 3/4] i386: add a Virtual Machine Generation ID device

2015-06-16 Thread Gal Hammer
Based on Microsoft's specifications (paper can be downloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is set using a global vmgenid.uuid parameter. Signed-off-by: Gal Hammer gham...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Michael S. Tsirkin
On Tue, Jun 16, 2015 at 09:33:19AM +0800, Shannon Zhao wrote: On 2015/6/16 2:13, Michael S. Tsirkin wrote: On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: On 15 June 2015 at 17:32, Andrew Jones drjo...@redhat.com wrote: On Mon, Jun 15, 2015 at 06:10:25PM +0200, Michael S.

[Qemu-devel] [PATCH v2 05/11] qerror: Clean up QERR_ macros to expand into a single string

2015-06-16 Thread Markus Armbruster
These macros expand into error class enumeration constant, comma, string. Unclean. Has been that way since commit 13f59ae. The error class is always ERROR_CLASS_GENERIC_ERROR since the previous commit. Clean up as follows: * Prepend every use of a QERR_ macro by ERROR_CLASS_GENERIC_ERROR, and

Re: [Qemu-devel] [PATCH 4/6] xen/pass-through: correctly deal with RW1C bits

2015-06-16 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Jan Beulich wrote: Introduce yet another mask for them, so that the generic routine can handle them, at once rendering xen_pt_pmcsr_reg_write() superfluous. Signed-off-by: Jan Beulich jbeul...@suse.com --- a/qemu/upstream/hw/xen/xen_pt.h +++

[Qemu-devel] [PATCH v2 00/11] Sprint to the finish: purge QError

2015-06-16 Thread Markus Armbruster
After a bit over a year and many patches, QError is finally ripe. All that's left of qerror.h after this series is a bunch of QERR_ macros. Killing them is left for another day. The diffstat looks a bit scary, but that's almost entirely due to mechanical changes like PATCH 05. This series

[Qemu-devel] [PATCH v2 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND

2015-06-16 Thread Markus Armbruster
Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used in new code. Hiding them in QERR_ macros makes new uses hard to spot. Fortunately, there's just one such macro left. Eliminate it with this coccinelle semantic patch: @@ expression EP, E; @@ -error_set(EP,

Re: [Qemu-devel] [PATCH v1 4/4] vhost-user: Add new option to specify vhost-user backend features

2015-06-16 Thread Eric Blake
On 05/28/2015 10:42 PM, Tetsuya Mukawa wrote: This patch adds below '-net' options to let QEMU know which features vhost-user backend will support. [meta-comment: when posting a new revision of a series, do it as a new top-level thread rather than buried in-reply-to an earlier version] If

Re: [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: These macros expand into error class enumeration constant, comma, string. Unclean. Has been that way since commit 13f59ae. The error class is always ERROR_CLASS_GENERIC_ERROR since the previous commit.

[Qemu-devel] [PATCH v2 6/6] audio: -audiodev command line option

2015-06-16 Thread Kővágó, Zoltán
This patch adds an -audiodev command line option, and deprecates the QEMU_* environment variables for audio backend configuration. It's syntax is similar to existing options (-netdev, -device, etc): -audiodev driver_name,property=value,... Audio drivers now get an Audiodev * as config paramters,

Re: [Qemu-devel] [PATCH 07/11] qmp: Wean off qerror_report()

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: The traditional QMP command handler interface int qmp_FOO(Monitor *mon, const QDict *params, QObject **ret_data); doesn't provide for returning an Error object. Instead, the handler is expected to

Re: [Qemu-devel] [Qemu-block] [PATCH 3/9] main-loop: Move include of qemu/sockets.h to libslirp.h

2015-06-16 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 04:59:45PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- main-loop.c | 1 - slirp/libslirp.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgp5dY4xapKAB.pgp Description: PGP

[Qemu-devel] [PATCH V16 2/4] acpi: add a vm_generation_id_changed method

2015-06-16 Thread Gal Hammer
Add a new method to the AcpiDeviceIfClass interface. The new method sends an ACPI notfication when the VM generation id is changed. Signed-off-by: Gal Hammer gham...@redhat.com --- hw/acpi/core.c | 8 hw/acpi/ich9.c | 8

[Qemu-devel] [PATCH v2 11/11] Include monitor/monitor.h exactly where needed

2015-06-16 Thread Markus Armbruster
In particular, don't include it into headers. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- balloon.c | 2 +- blockdev-nbd.c

Re: [Qemu-devel] [PATCH V4] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 14:37, Aurelio C. Remonda aurelioremo...@gmail.com wrote: This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. Created an ARM_FEATURE_THUMB_DSP to be added to any non-M

Re: [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: qerror_report() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report() in initial startup helpers parse_sandbox()

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 13:52, aurelio remonda aurelioremo...@gmail.com wrote: about the space between ARMCPU *cpu = ARM_CPU(obj); line and the first set_feature, the cortex-m3 initfn does not have it, do you want me to change that one too? Thanks I would leave that one alone. It's bad style, but

Re: [Qemu-devel] Greate difference of disk I/O performance for guest on Qemu-2.30 of CentOS.

2015-06-16 Thread Stefan Hajnoczi
On Mon, Jun 15, 2015 at 09:14:52PM +0800, cauchy-love wrote: I am running a embedded OS on Qemu-2.3.0. However I found that the I/O performance was quite different for different CentOS release (CentOS 6.5 and CentOS 7.0). The CentOS 6.5 uses linux-2.6.32 while the CentOS 7.0 uses

Re: [Qemu-devel] [PATCH 2/6] xen/MSI-X: drive maskall and enable bits through hypercalls

2015-06-16 Thread Jan Beulich
On 16.06.15 at 16:03, stefano.stabell...@eu.citrix.com wrote: On Fri, 5 Jun 2015, Jan Beulich wrote: +} else if (s-msix-enabled) { +if (!(value PCI_MSIX_FLAGS_ENABLE)) { +xen_pt_msix_disable(s); +s-msix-enabled = false; +} else if

Re: [Qemu-devel] [PATCH v4 2/2] semihosting: add --semihosting-config arg sub-argument

2015-06-16 Thread Leon Alrae
On 16/06/2015 15:03, Peter Maydell wrote: On 16 June 2015 at 13:32, Liviu Ionescu i...@livius.net wrote: would it be possible to have all the semihosting patches ready for 2.4? Yes, I agree that would be good. Is it just this 2 patch series, or are there others too? Just to confirm -- the

[Qemu-devel] [PATCH v2 09/11] qerror: Move #include out of qerror.h

2015-06-16 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- audio/spiceaudio.c | 1 + audio/wavcapture.c | 1 + block.c |

Re: [Qemu-devel] [PATCH v17] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 12:58, Eric Auger eric.au...@linaro.org wrote: This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=device). A specialized device tree node is created for the guest, containing compat, dma-coherent,

Re: [Qemu-devel] [PULL 11/28] target-arm: Use the kernel's idea of MPIDR if we're using KVM

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 13:02, Pavel Fedin p.fe...@samsung.com wrote: Hello! I see only affinity patch went in. What is the status of the rest of GICv3 stuff? Definitely not-for-2.4. It needs review... The affinity patch was a useful standalone fix, which is why I put it in. thanks -- PMM

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-06-16 Thread Stefan Hajnoczi
On Mon, Jun 15, 2015 at 10:07:26AM +0300, Denis V. Lunev wrote: On 08/06/15 09:43, Denis V. Lunev wrote: On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests. Signed-off-by: Olga Krishtal

[Qemu-devel] [PATCH RFC 3/3] block/nfs: switch to error_init_local

2015-06-16 Thread Michael S. Tsirkin
We probably should just switch everyone, this is just to demonstrate the API usage. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index ca9e24e..de4b8c3 100644 --- a/block/nfs.c +++

Re: [Qemu-devel] [PATCH 06/11] tpm: Avoid qerror_report() outside QMP command handlers

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: qerror_report() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [Qemu-block] [PATCH 4/9] slirp: Remove dead code for PROBE_CONN

2015-06-16 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 04:59:46PM +0800, Fam Zheng wrote: It has always been compiled out. Remove it before we refactor the rest part of slirp poll. Signed-off-by: Fam Zheng f...@redhat.com --- slirp/slirp.c| 40 slirp/slirp_config.h | 4

Re: [Qemu-devel] [PATCH 2/6] xen/MSI-X: drive maskall and enable bits through hypercalls

2015-06-16 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Jan Beulich wrote: Particularly the maskall bit has to be under exclusive hypervisor control (and since they live in the same config space field, the enable bit has to follow suit). Use the replacement hypercall interfaces. From this commit message, I expect a patch that

[Qemu-devel] [PATCH v2 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-16 Thread Markus Armbruster
In particular, don't include it into headers. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com --- backends/hostmem.c | 1 - balloon.c

Re: [Qemu-devel] [PULL 11/28] target-arm: Use the kernel's idea of MPIDR if we're using KVM

2015-06-16 Thread Pavel Fedin
Hello! I see only affinity patch went in. What is the status of the rest of GICv3 stuff? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [Qemu-devel] Windows2012R2 virtio-win drivers and IPv6

2015-06-16 Thread Peter Lieven
Hi Yan, thanks for the reply. * When you experience the issues is it between VMs on the same host? I can reproduce it between a Windows VM on Host A and a Linux VM on Host B. Linux and Windows are not on the same host systems due to licensing. Between Linux VMs and/or if I download to the

[Qemu-devel] [PATCH RFC 1/3] error: don't rely on pointer comparisons

2015-06-16 Thread Michael S. Tsirkin
makes it possible to copy error_abort pointers, not just pass them on directly. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- util/error.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/util/error.c b/util/error.c index 14f4351..ccf29ea 100644 ---

[Qemu-devel] [PATCH RFC 2/3] error: allow local errors to trigger abort

2015-06-16 Thread Michael S. Tsirkin
It's a common idiom: Error *local_err = NULL; foo(local_err); ... if (local_err) { error_propagate(errp, local_err); return; } Unfortunately it means that call to foo(local_err) will not abort even if errp is set to error_abort. Instead, we get an

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 14:12, Andrew Jones drjo...@redhat.com wrote: Can we now revert this revert, along with bumping the non-x86 arch atleast-version to v2.2.1 Probably. I suggest you submit a patch and test it on the relevant architectures and seccomp versions. thanks -- PMM

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-16 Thread Igor Mammedov
On Tue, 16 Jun 2015 09:33:19 +0800 Shannon Zhao shannon.z...@linaro.org wrote: On 2015/6/16 2:13, Michael S. Tsirkin wrote: On Mon, Jun 15, 2015 at 05:59:06PM +0100, Peter Maydell wrote: On 15 June 2015 at 17:32, Andrew Jones drjo...@redhat.com wrote: On Mon, Jun 15, 2015 at 06:10:25PM

Re: [Qemu-devel] [Qemu-block] [PATCH 0/9] slirp: iohandler: Rebase onto aio

2015-06-16 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 04:59:42PM +0800, Fam Zheng wrote: Currently iohandler.c and asyn.c has a lot in common, except that iohandler is hooked into main_loop_wait(), with qemu_iohandler_fill(). Likewise for slirp. It is much cleaner to drive slirp fds with iohandler, and implement

[Qemu-devel] [PATCH v2 01/11] QemuOpts: Wean off qerror_report_err()

2015-06-16 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. The only remaining user in qemu-option.c is qemu_opts_parse(). Is it used in QMP context? If not, we can simply replace qerror_report_err() by

[Qemu-devel] [PATCH v2 03/11] vl: Use error_report() for --display errors

2015-06-16 Thread Markus Armbruster
Results in nicer error messages. Before this patch: Invalid GTK option string: gtk,lirum-larum After: qemu-system-x86_64: -display gtk,lirum-larum: Invalid GTK option string Of course, the thing ought to use QemuOpts instead of parsing by hand. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 5/6] xen/pass-through: log errno values rather than function return ones

2015-06-16 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Jan Beulich wrote: Functions setting errno commonly return just -1, which is of no particular use in the log file. Signed-off-by: Jan Beulich jbeul...@suse.com Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- a/qemu/upstream/hw/xen/xen_pt.c +++

Re: [Qemu-devel] [PATCH v17] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-06-16 Thread Eric Auger
Hi Peter, On 06/16/2015 01:59 PM, Peter Maydell wrote: On 16 June 2015 at 12:58, Eric Auger eric.au...@linaro.org wrote: This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=device). A specialized device tree node is

Re: [Qemu-devel] QEMU ARM SMP: IPI delivery delayed until next main loop event // how to improve IPI latency?

2015-06-16 Thread Alex Züpke
Am 16.06.2015 um 13:53 schrieb Peter Maydell: On 16 June 2015 at 12:11, Alex Züpke alexander.zue...@hs-rm.de wrote: But the startup is not my problem, it's the later parts. But it was my problem because it meant your test case wasn't functional :-) I added the WFE to the initial lock.

Re: [Qemu-devel] [PATCH 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/15/2015 09:18 AM, Luiz Capitulino wrote: On Sat, 13 Jun 2015 16:20:51 +0200 Markus Armbruster arm...@redhat.com wrote: Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used in new code. Hiding them in QERR_ macros makes new uses

Re: [Qemu-devel] [PATCH 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND

2015-06-16 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 15 June 2015 at 16:18, Luiz Capitulino lcapitul...@redhat.com wrote: On Sat, 13 Jun 2015 16:20:51 +0200 Markus Armbruster arm...@redhat.com wrote: Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used in new code. Hiding

[Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print

2015-06-16 Thread Kővágó, Zoltán
This allows to print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list. Only block.c depended on the old behavior, but it was also updated. Signed-off-by: Kővágó, Zoltán

[Qemu-devel] [PATCH v2 1/6] qapi: qapi for audio backends

2015-06-16 Thread Kővágó, Zoltán
This patch adds structures into qapi to replace the existing configuration structures used by audio backends currently. This qapi will be the base of the -audiodev command line parameter (that replaces the old environment variables based config). This is not a 1:1 translation of the old options,

[Qemu-devel] [PATCH v2 0/6] -audiodev option

2015-06-16 Thread Kővágó, Zoltán
This series of patches adds a new -audiodev command line option to specify audio subsytem parameters instead of environment variables. This will later allow us to specify multiple audio backends. The syntax is something like this: -audiodev driver_name,property=value,... like: -audiodev

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-06-16 Thread Denis V. Lunev
On 16/06/15 15:48, Stefan Hajnoczi wrote: On Mon, Jun 15, 2015 at 10:07:26AM +0300, Denis V. Lunev wrote: On 08/06/15 09:43, Denis V. Lunev wrote: On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests.

[Qemu-devel] [PATCH RFC 0/3] error: allow local errors to trigger abort

2015-06-16 Thread Michael S. Tsirkin
It's a common idiom: Error *local_err = NULL; foo(local_err); ... if (local_err) { error_propagate(errp, local_err); return; } Unfortunately it means that call to foo(local_err) will not abort

Re: [Qemu-devel] [PATCH 10/13] target-mips: microMIPS32 R6 POOL32{I, C} instructions

2015-06-16 Thread Leon Alrae
On 12/06/2015 15:02, Yongbok Kim wrote: add new microMIPS32 Release 6 POOL32I/POOL32C type instructions Signed-off-by: Yongbok Kim yongbok@imgtec.com --- target-mips/translate.c | 36 1 files changed, 32 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-16 Thread Andrew Jones
On Fri, Apr 10, 2015 at 01:58:01PM +0100, Peter Maydell wrote: Unfortunately it turns out that libseccomp 2.2 still does not work correctly on non-x86 architectures; return to the previous configure setup of insisting on libseccomp 2.1 or better and i386/x86_64 and disabling seccomp support in

Re: [Qemu-devel] About usb passthru and speed mismatch

2015-06-16 Thread Gerd Hoffmann
On Do, 2015-06-11 at 23:47 +0800, Lin Ma wrote: Hi Gerd, Based on the current implementation of 'usb_host_open' in hw/usb/host-libusb.c, When user performs usb_add, The usb device will be detached from kernel first, Then be checked for speed mismatch second. If it found speed mismatch,

Re: [Qemu-devel] [PATCH 1/6] xen/MSI-X: latch MSI-X table writes

2015-06-16 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Jan Beulich wrote: The remaining log message in pci_msix_write() is wrong, as there guest behavior may only appear to be wrong: For one, the old logic didn't take the mask-all bit into account. And then this shouldn't depend on host device state (i.e. the host may have

[Qemu-devel] [PATCH V4] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Aurelio C. Remonda
This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. Created an ARM_FEATURE_THUMB_DSP to be added to any non-M thumb2-compatible CPU that uses DSP instructions, and manually added it to the M4 in its initfn.

Re: [Qemu-devel] [RFC v9 14/18] vfio: improve vfio_pci_hot_reset to support more case

2015-06-16 Thread Alex Williamson
On Tue, 2015-06-16 at 16:10 +0800, Chen Fan wrote: On 06/10/2015 05:24 AM, Alex Williamson wrote: On Tue, 2015-06-09 at 11:37 +0800, Chen Fan wrote: the vfio_pci_hot_reset differentiate the single and multi in-used devices for reset. but sometimes we own the group without any devices,

[Qemu-devel] [RFC] generic-gpio-led stm32-gpio-led

2015-06-16 Thread Liviu Ionescu
# Intro For my multiple Cortex-M boards, I need a LED device that will display a message when a GPIO bit is written. # Goal The goal is to pack the LED into an object that is very easy to instantiate and configure. # Solution My solution is an abstract class generic-gpio-led and derived

[Qemu-devel] [PATCH v2 07/11] qmp: Wean off qerror_report()

2015-06-16 Thread Markus Armbruster
The traditional QMP command handler interface int qmp_FOO(Monitor *mon, const QDict *params, QObject **ret_data); doesn't provide for returning an Error object. Instead, the handler is expected to stash it in the monitor with qerror_report(). When we rebased QMP on top of QAPI, we didn't

[Qemu-devel] [PATCH v17] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-06-16 Thread Eric Auger
This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=device). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts properties. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v2 5/6] audio: use qapi AudioFormat instead of audfmt_e

2015-06-16 Thread Kővágó, Zoltán
I had to include an enum for audio sampling formats into qapi, but that meant duplicating the audfmt_e enum. This patch replaces audfmt_e and associated values with the qapi generated AudioFormat enum. This patch is mostly a search-and-replace, except for switches where the qapi generated

[Qemu-devel] [PATCH v2 2/6] qapi: support nested structs in OptsVisitor

2015-06-16 Thread Kővágó, Zoltán
The current OptsVisitor flattens the whole structure, if there are same named fields under different paths (like `in' and `out' in `Audiodev'), the current visitor can't cope with them (for example setting `frequency=44100' will set the in's frequency to 44100 and leave out's frequency

Re: [Qemu-devel] [PATCH] usb: Use usb_bus_find(-1) instead of usb_enabled() in usb_device_add/usb_device_del

2015-06-16 Thread Gerd Hoffmann
On Do, 2015-06-04 at 15:55 +0800, Lin Ma wrote: Without usb=on machine option, usb_device_add/usb_device_del don't work, Even if there are virtual usb controllers presented. If you use -device to add your usb host controllers, you should likewise use -device (or device_add monitor cmd) to add

Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code

2015-06-16 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 04:59:44PM +0800, Fam Zheng wrote: diff --git a/iohandler.c b/iohandler.c index 826f713..f5d7704 100644 --- a/iohandler.c +++ b/iohandler.c @@ -32,111 +32,39 @@ #include sys/wait.h #endif -typedef struct IOHandlerRecord { -IOHandler *fd_read; -

[Qemu-devel] [PATCH V16 1/4] docs: vm generation id device's description

2015-06-16 Thread Gal Hammer
Signed-off-by: Gal Hammer gham...@redhat.com --- docs/specs/vmgenid.txt | 33 + 1 file changed, 33 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 index 000..d06977a ---

[Qemu-devel] [PATCH V16 0/4] Virtual Machine Generation ID

2015-06-16 Thread Gal Hammer
Hi, Resending after applying changes requested from Paolo, Igor and Michael. Thanks, Gal. V16 - Remove the sysbus device and use directly a DeviceClass. - Device is created with -device command line parameter - Device have uuid and addr parameters. - Support for 64-bit address.

Re: [Qemu-devel] [PATCH 3/6] xen/MSI-X: really enforce alignment

2015-06-16 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Jan Beulich wrote: The way the generic infrastructure works the intention of not allowing unaligned accesses can't be achieved by simply setting .unaligned to false. The benefit is that we can now replace the conditionals in {get,set}_entry_value() by assert()-s.

[Qemu-devel] [PATCH v2 08/11] qerror: Finally unused, clean up

2015-06-16 Thread Markus Armbruster
Remove it except for two things in qerror.h: * Two #include to be cleaned up separately to avoid cluttering this patch. * The QERR_ macros. Mark as obsolete. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH 5/7] userfaultfd: switch to exclusive wakeup for blocking reads

2015-06-16 Thread Andrea Arcangeli
On Mon, Jun 15, 2015 at 08:41:24PM -1000, Linus Torvalds wrote: On Mon, Jun 15, 2015 at 12:19 PM, Andrea Arcangeli aarca...@redhat.com wrote: Yes, it would leave the other blocked, how is it different from having just 1 reader and it gets killed? Either is completely wrong. But the

Re: [Qemu-devel] [PATCH v4 2/2] semihosting: add --semihosting-config arg sub-argument

2015-06-16 Thread Liviu Ionescu
would it be possible to have all the semihosting patches ready for 2.4? regards, Liviu

Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-16 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/13/2015 08:20 AM, Markus Armbruster wrote: In particular, don't include it into headers. Signed-off-by: Markus Armbruster arm...@redhat.com --- 46 files changed, 25 insertions(+), 21 deletions(-) Assuming this was done by deleting from

[Qemu-devel] [PATCH V16 4/4] tests: add a unit test for the vmgenid device

2015-06-16 Thread Gal Hammer
Signed-off-by: Gal Hammer gham...@redhat.com --- tests/Makefile | 2 ++ tests/vmgenid-test.c | 44 2 files changed, 46 insertions(+) create mode 100644 tests/vmgenid-test.c diff --git a/tests/Makefile b/tests/Makefile index c5e4744..3608068

[Qemu-devel] [PATCH v2 02/11] vl: Avoid qerror_report() outside QMP command handlers

2015-06-16 Thread Markus Armbruster
qerror_report() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report() in initial startup helpers parse_sandbox() and parse_add_fd(). Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric

Re: [Qemu-devel] QEMU ARM SMP: IPI delivery delayed until next main loop event // how to improve IPI latency?

2015-06-16 Thread Peter Maydell
On 16 June 2015 at 12:11, Alex Züpke alexander.zue...@hs-rm.de wrote: But the startup is not my problem, it's the later parts. But it was my problem because it meant your test case wasn't functional :-) I added the WFE to the initial lock. Here are two new tests, both are now 3178 bytes in

Re: [Qemu-devel] [PATCH V3] Target-arm: Add the Cortex-M4 CPU

2015-06-16 Thread Liviu Ionescu
On 16 Jun 2015, at 14:21, Peter Maydell peter.mayd...@linaro.org wrote: ... I think we can get this into QEMU for 2.4. that would be really great, I have quite a lot of M4 MCUs in my Cortex-M branch. Liviu

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

2015-06-16 Thread Stefan Hajnoczi
On Sat, Jun 13, 2015 at 04:02:34PM +0100, Mark Cave-Ayland wrote: On 13/06/15 08:53, Aurelien Jarno wrote: As it's freeze coming up, I need to send an OpenBIOS pull request fairly soon. Do you need anything from me to get this done beforehand? For what I can see on the server, I

Re: [Qemu-devel] [PATCH 1/6] xen/MSI-X: latch MSI-X table writes

2015-06-16 Thread Jan Beulich
On 16.06.15 at 15:35, stefano.stabell...@eu.citrix.com wrote: On Fri, 5 Jun 2015, Jan Beulich wrote: @@ -322,6 +323,13 @@ static int xen_pt_msix_update_one(XenPCI pirq = entry-pirq; +if (pirq == XEN_PT_UNASSIGNED_PIRQ || s-msix-maskall || +(entry-latch(VECTOR_CTRL)

Re: [Qemu-devel] [PATCH 9/9] slirp: Remove unused pollfds from the parameter list

2015-06-16 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 04:59:51PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- main-loop.c | 4 ++-- slirp/libslirp.h | 4 ++-- slirp/slirp.c| 4 ++-- stubs/slirp.c| 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/main-loop.c

[Qemu-devel] [PATCH v2 06/11] tpm: Avoid qerror_report() outside QMP command handlers

2015-06-16 Thread Markus Armbruster
qerror_report() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH 4/6] xen/pass-through: correctly deal with RW1C bits

2015-06-16 Thread Jan Beulich
On 16.06.15 at 16:19, stefano.stabell...@eu.citrix.com wrote: On Fri, 5 Jun 2015, Jan Beulich wrote: @@ -1016,11 +1002,12 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] .size = 2, .init_val = 0x0008, .res_mask = 0x00F0, -.ro_mask= 0xE10C, +

[Qemu-devel] [PATCH v2 13/15] qapi-types: Drop unused members parameters

2015-06-16 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 86e5ddc..c408542 100644 ---

Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running help for command errors

2015-06-16 Thread Markus Armbruster
Applied to my (badly named) qapi-next branch, thanks!

Re: [Qemu-devel] [PATCH 08/13] target-mips: microMIPS32 R6 POOL32A{XF} instructions

2015-06-16 Thread Leon Alrae
On 12/06/2015 15:02, Yongbok Kim wrote: +case R6_LWXS: +check_insn(ctx, ISA_MIPS32R6); +gen_ldxs(ctx, rs, rt, rd); +break; According to the manual LWXS is removed, not recoded. Otherwise, Reviewed-by: Leon Alrae

[Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: add missing long option terminator

2015-06-16 Thread Aneesh Kumar K.V
From: Stefan Hajnoczi stefa...@redhat.com The getopt_long(3) long options array must have a zeroed terminator. This patch solves a segmentation fault when an unknown command-line option is encountered: $ fsdev/virtfs-proxy-helper --help Segmentation fault (core dumped) Signed-off-by:

[Qemu-devel] [PATCH 2/2] virtfs-proxy-helper: fail gracefully if socket path is too long

2015-06-16 Thread Aneesh Kumar K.V
From: Stefan Hajnoczi stefa...@redhat.com Replace the assertion check with graceful failure when the socket path is too long. Programs should not crash on invalid input. Print an error message and exit properly. Cc: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v7 17/42] Add migration-capability boolean for postcopy-ram.

2015-06-16 Thread Eric Blake
On 06/16/2015 04:26 AM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The 'postcopy ram' capability allows postcopy migration of RAM; note that the migration starts off in precopy mode until postcopy mode is triggered (see the migrate_start_postcopy

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

2015-06-16 Thread Stefan Hajnoczi
On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote: +/** + * bdrv_lock: + * + * Begin a temporary exclusive accessing by locking the BDS. + */ +void bdrv_lock(BlockDriverState *bs); + +/** + * bdrv_unlock: + * + * End a exclusive accessing. + */ +void

[Qemu-devel] [PATCH v2 2/4] qtest/ahci: add test_max

2015-06-16 Thread John Snow
Test that the FIS delivered after a nondata command has appropriately updated registers, just as we'd expect a data command to do. Signed-off-by: John Snow js...@redhat.com --- tests/ahci-test.c | 50 +- 1 file changed, 45 insertions(+), 5

Re: [Qemu-devel] [PATCH] tcg/s390: fix branch target change during code retranslation

2015-06-16 Thread Alexander Graf
On 06/16/15 07:11, Aurelien Jarno wrote: Make sure to not modify the branch target. This ensure that the branch target is not corrupted during partial retranslation. Cc: Alexander Graf ag...@suse.de Cc: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net This

[Qemu-devel] [PATCH v2 2/2] spapr_iommu: translate sPAPRTCEAccess to IOMMUAccessFlags

2015-06-16 Thread Greg Kurz
The fact that these enums have matching values is pure coincidence. We actually need to translate from the PAPR definition to the QEMU one. This patch doesn't fix any bug, it is only code cleanup. Suggested-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com

[Qemu-devel] [PATCH v2 1/2] spapr_iommu: drop erroneous check in h_put_tce_indirect()

2015-06-16 Thread Greg Kurz
The tce_list variable is not a TCE but the address to a TCE: we shouldn't clear permission bits as we do now. And this is dead code anyway since we check tce_list is 4K aligned a few lines above. This patch doesn't fix any bug, it is only code cleanup. Suggested-by: Alexey Kardashevskiy

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_iommu: fix erroneous sanity check in h_put_tce_indirect()

2015-06-16 Thread Alexey Kardashevskiy
On 06/16/2015 07:24 PM, Greg Kurz wrote: On Tue, 16 Jun 2015 18:53:51 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/16/2015 03:28 AM, Greg Kurz wrote: According to PAPR+ 3.2.2.2, the TCE is implemented as follows: bits 0-51: real page number bits 52-61: reserved for

Re: [Qemu-devel] [PATCH 6/6] xen/pass-through: constify some static data

2015-06-16 Thread Jan Beulich
On 16.06.15 at 16:27, stefano.stabell...@eu.citrix.com wrote: On Fri, 5 Jun 2015, Jan Beulich wrote: This is done indirectly by adjusting two typedefs and helps emphasizing that the respective tables aren't supposed to be modified at runtime (as they may be shared between devices).

[Qemu-devel] [PATCH v2 09/15] qapi: Better separate the different kinds of helpers

2015-06-16 Thread Markus Armbruster
Insert comments to separate sections dealing with parsing, semantic analysis, code generation, and so forth. Move helpers to their proper section. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 128

[Qemu-devel] [PATCH v2 01/15] MAINTAINERS: Fix up QAPI and QAPI schema file patterns

2015-06-16 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba2079..103b91d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -945,7 +945,10 @@ M: Markus

[Qemu-devel] [PATCH v2 07/15] qapi: Fix to reject stray 't', 'f' and 'n'

2015-06-16 Thread Markus Armbruster
Screwed up in commit e53188a. --- scripts/qapi.py | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index a24a7e2..6faa897 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -217,20 +217,18 @@ class QAPISchema:

  1   2   3   4   >