Re: [Qemu-devel] [PATCH COLO-Frame v11 08/39] migration: Rename the'file' member of MigrationState

2015-12-10 Thread Hailiang Zhang
On 2015/12/10 14:41, Wen Congyang wrote: On 11/24/2015 05:25 PM, zhanghailiang wrote: Rename the 'file' member of MigrationState to 'to_dst_file'. Signed-off-by: zhanghailiang Cc: Dr. David Alan Gilbert --- v11: - Only rename 'file' member

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-10 Thread Bharata B Rao
On Thu, Dec 10, 2015 at 01:35:05PM +0100, Igor Mammedov wrote: > On Thu, 10 Dec 2015 11:45:35 +0530 > Bharata B Rao wrote: > > > Hi, > > > > This is an attempt to define a generic CPU device that serves as a > > containing device to underlying arch-specific CPU

Re: [Qemu-devel] [PATCH 11/11] RFC: qemu-img: Use new JSON output formatter

2015-12-10 Thread Fam Zheng
On Thu, 12/10 16:53, Eric Blake wrote: > Now that we can pretty-print straight to JSON from a visitor, > we can eliminate the temporary conversion into QObject inside > qemu-img. > > RFC because at least qemu-iotests 043 has changed output, not > included in this version of the patch. Conflicts

[Qemu-devel] [PATCH for-2.5?] qemu-iotests: Reduce racy output in 028

2015-12-10 Thread Eric Blake
On my machine, './check -qcow2 028' was failing about 80% of the time, due to a race in how many times the repeated attempts to run 'info block-jobs' could occur before the job was done, showing up as a failure of fewer '(qemu) ' prompts than in the expected output. Silence the output during the

[Qemu-devel] [PATCH v5 03/10] ARM: Virt: Add a GPIO controller

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for powerdown, hotplug evnets. Add a GPIO controller in machine virt, to support powerdown, maybe can be used for cpu hotplug. And here we use pl061. Signed-off-by: Shannon Zhao

[Qemu-devel] [PATCH v5 02/10] acpi: extend aml_interrupt() to support multiple irqs

2015-12-10 Thread Shannon Zhao
From: Igor Mammedov ASL Interrupt() macro translates to Extended Interrupt Descriptor which supports variable number of IRQs. It will be used for conversion of ASL code for pc/q35 machines that use it for returning several IRQs in _PSR object. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v5 01/10] acpi: support serialized method

2015-12-10 Thread Shannon Zhao
From: Xiao Guangrong Add serialized method support so that explicit Mutex can be avoided Signed-off-by: Xiao Guangrong Signed-off-by: Igor Mammedov Reviewed-by: Shannon Zhao ---

[Qemu-devel] [PATCH v5 05/10] ARM: ACPI: Add power button device in ACPI DSDT table

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Add power button device in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Wei Huang Tested-by: Wei Huang Reviewed-by: Igor

[Qemu-devel] [PATCH v5 04/10] ARM: ACPI: Add GPIO controller in ACPI DSDT table

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Add GPIO controller in ACPI DSDT table. It can be used for gpio event. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/arm/virt-acpi-build.c |

[Qemu-devel] [PATCH v5 00/10] Add system_powerdown support on ARM for ACPI and DT

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced platforms(like ARM). It uses GPIO pin to trigger an event to the guest. For QEMU, here we add PL061 GPIO controller and use PIN 3 for system_powerdown, reserving PIN 0, 1, 2 for PCI

Re: [Qemu-devel] [PATCH v7 29/31] qapi: Simplify semantics of visit_next_list()

2015-12-10 Thread Eric Blake
On 12/10/2015 10:32 AM, Eric Blake wrote: > On 12/07/2015 08:55 PM, Eric Blake wrote: > >> We can greatly simplify things by hoisting the special case >> into the start() routine, and flipping the order in the loop >> to visit before advance: >> >> start(head) >> element = *head >> while

Re: [Qemu-devel] [PATCH v4 2/8] ARM: ACPI: Add GPIO controller in ACPI DSDT table

2015-12-10 Thread Shannon Zhao
Hi, On 2015/12/11 4:13, Igor Mammedov wrote: > On Thu, 10 Dec 2015 13:16:22 -0600 > Wei Huang wrote: > >> > >> > >> > On 12/10/2015 07:22 AM, Igor Mammedov wrote: >>> > > On Mon, 7 Dec 2015 15:39:46 +0800 >>> > > Shannon Zhao wrote: >>> > > >

Re: [Qemu-devel] [PATCH 07/74] acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern

2015-12-10 Thread Shannon Zhao
On 2015/12/10 7:41, Igor Mammedov wrote: > Currently AML API doesn't compose terms in form of > following pattern: > >Opcode Arg2 Arg2 [Dst] > > but ASL used in piix4/q35 DSDT ACPI tables uses that > form, so for clean conversion of it, AML API should > be able to handle an optional 'Dst'

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Bharata B Rao
On Thu, Dec 10, 2015 at 06:23:49PM +0100, Markus Armbruster wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. > > Cc: Fam Zheng > Cc: Peter Crosthwaite

[Qemu-devel] [PATCH v5 09/10] ARM: Virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Currently mach-virt model doesn't support powerdown request. Guest VM doesn't react to system_powerdown from monitor console (or QMP) because there is no communication mechanism for such requests. This patch registers GPIO Pin 3 with powerdown

[Qemu-devel] [PATCH v5 08/10] ARM: ACPI: Add _E03 for Power Button

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/arm/virt-acpi-build.c |

[Qemu-devel] [PATCH v5 07/10] ACPI: Add aml_gpio_int() wrapper for GPIO Interrupt Connection

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 20

[Qemu-devel] [PATCH v5 06/10] ACPI: Add GPIO Connection Descriptor

2015-12-10 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang Reviewed-by: Igor Mammedov --- hw/acpi/aml-build.c | 68

Re: [Qemu-devel] [RFC PATCH v0 1/9] vl: Don't allow CPU toplogies with partially filled cores

2015-12-10 Thread Bharata B Rao
On Thu, Dec 10, 2015 at 10:25:28AM +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2015 at 11:45:36AM +0530, Bharata B Rao wrote: > > Prevent guests from booting with CPU topologies that have partially > > filled CPU cores or can result in partially filled CPU cores after CPU > > hotplug like >

Re: [Qemu-devel] [PATCH 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 83 +++ hw/i386/acpi-dsdt.dsl | 60 - 2 files changed, 83 insertions(+), 60

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Dr. David Alan Gilbert
* Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: > Hi, > > qemu-img-ev-2.3.0-29.1.el7.x86_64 > libvirt-daemon-driver-qemu-1.2.8-16.el7_1.4.x86_64 > qemu-kvm-ev-2.3.0-29.1.el7.x86_64 > qemu-kvm-common-ev-2.3.0-29.1.el7.x86_64 > ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch >

Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method

2015-12-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 December 2015 at 10:29, Markus Armbruster wrote: >> Device realize() methods aren't supposed to call hw_error(), they >> should set an error and fail cleanly. Do that. >> >> Cc: Peter Maydell

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Victor Kaplansky
On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: > On 12/09/2015 04:59 PM, Victor Kaplansky wrote: > >On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: > >>Hi > >> > >>On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard > >> wrote: >

Re: [Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Jan Kiszka
On 2015-12-10 13:51, Tim Sander wrote: > Hi Jan > > I have seen your patches for AT24Cxx functionality in qemu: > https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html > > As i am interested in this work i am wondering what happend to this effort? Internally in heavy use (not sure

Re: [Qemu-devel] [PATCH 12/74] acpi: extend aml_shiftright() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it allows to express ShiftRight(A,B,C) syntax Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 4 ++-- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 2 +- 3 files changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH v4 2/8] ARM: ACPI: Add GPIO controller in ACPI DSDT table

2015-12-10 Thread Igor Mammedov
On Mon, 7 Dec 2015 15:39:46 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add GPIO controller in ACPI DSDT table. It can be used for gpio event. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao

[Qemu-devel] [PATCH for-2.5] Update language files for QEMU 2.5.0

2015-12-10 Thread Peter Maydell
Update translation files (change created via 'make -C po update'). Signed-off-by: Peter Maydell --- po/de_DE.po| 36 ++-- po/fr_FR.po| 36 ++-- po/hu.po | 36

Re: [Qemu-devel] [PATCH for-2.5] Update language files for QEMU 2.5.0

2015-12-10 Thread Stefan Weil
Am 10.12.2015 um 14:34 schrieb Peter Maydell: > Update translation files (change created via 'make -C po update'). > > Signed-off-by: Peter Maydell > --- > po/de_DE.po| 36 ++-- > po/fr_FR.po| 36

Re: [Qemu-devel] [PATCH 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 14:32:11 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 83 > > +++ > >

Re: [Qemu-devel] qemu 2.2 stuck on condition mutex locks on all threads

2015-12-10 Thread Neil McGill
Thanks Stefan, will check and update neil On 12/10/15, 3:47 AM, Stefan Hajnoczi wrote: On Mon, Dec 07, 2015 at 07:44:24PM -0500, Neil McGill wrote: Has anyone seen anything like this ? all 4 qemu threads are stuck on a pthread condition This is incorrect. Thread 4 is blocked in poll(2).

Re: [Qemu-devel] [PATCH 06/74] acpi: add aml_create_qword_field()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 21 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH 04/74] acpi: add aml_lgreater_equal()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:40 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

Re: [Qemu-devel] [PATCH 08/74] acpi: extend aml_add() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it allows to express following ASL expression: Add(arg1, arg2, result) usecases that do not need to store result should pass NULL as 3rd arg that would express Add(arg1, arg2,) construct. Signed-off-by: Igor Mammedov ---

Re: [Qemu-devel] [PATCH 09/74] acpi: add aml_decrement() and aml_subtract()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 12:29 PM, Markus Armbruster wrote: >> isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when >> passed a null bus. Use of hw_error() has always been questionable, >> because these are used only during machine

Re: [Qemu-devel] [PATCH 13/74] acpi: add aml_alias()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dcaa7e9..6a63477

[Qemu-devel] [PATCH] usb: hcd-ehci: add check to avoid an infinite loop

2015-12-10 Thread P J P
Hello Gerd, An infinite loop issue was reported by Mr Qinghao Tang(CC'd), in the USB EHCI emulator. In that, a malicious isochronous transfer descriptor(iTD) list could unfold an infinite loop in the 'ehci_advance_state' routine, by always setting 'again = 0 or 1'. Please see below a

Re: [Qemu-devel] [PATCH 16/74] acpi: add aml_lor()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 5094826..8cfa65c

Re: [Qemu-devel] [PATCH 20/74] acpi: add aml_to_buffer()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 03:09 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 12/10/2015 12:29 PM, Markus Armbruster wrote: isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable,

Re: [Qemu-devel] [PATCH 10/74] acpi: add aml_call0() helper

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it will help to call a method with 0 arguments Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH 14/74] acpi: add aml_sleep()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

Re: [Qemu-devel] [PATCH 17/74] acpi: add aml_lgreater()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 8cfa65c..b22e7da

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Grundmann, Christian
Sorry as this is my productionsystem i can't > Am 10.12.2015 um 14:18 schrieb Markus Armbruster : > > "Dr. David Alan Gilbert" writes: > >> * Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: >>> Hi, >>> >>>

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> On 10/12/2015 11:19, Markus Armbruster wrote: >>> +object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr", >>> + _fatal);object_property_set_int(OBJECT(cpu), >>> + MPCORE_PERIPHBASE, >>> +

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 02:34 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 12/10/2015 12:19 PM, Markus Armbruster wrote: Done with this admittedly crude Coccinelle semantic patch with manual burial of dead Error * variables squashed in: @@

[Qemu-devel] setting fadt->century

2015-12-10 Thread Laszlo Ersek
Hi, an edk2-devel discussion made me look at how QEMU builds the FADT, in particular the "century" field. The RTC CMOS RAM index to the century of data value (hundred and thousand year decimals). If this field contains a zero, then the RTC centenary feature is not supported. If this

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 11:45:35 +0530 Bharata B Rao wrote: > Hi, > > This is an attempt to define a generic CPU device that serves as a > containing device to underlying arch-specific CPU devices. The > motivation for this is to have an arch-neutral way to specify CPUs

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 12:19 PM, Markus Armbruster wrote: >> Done with this admittedly crude Coccinelle semantic patch with manual >> burial of dead Error * variables squashed in: >> >> @@ >> identifier FUN; >> expression ERR, EC; >>

Re: [Qemu-devel] [PATCH 25/74] pc: acpi: memhp: prepare context in SSDT for moving memhp DSDT code

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs | 2 +- hw/acpi/memory_hotplug_acpi_table.c | 40 + hw/i386/acpi-build.c| 3 +++

Re: [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods

2015-12-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 December 2015 at 10:29, Markus Armbruster wrote: >> Device init() methods aren't supposed to call hw_error(), they should >> report the error and fail cleanly. Do that. >> >> Cc: Peter Maydell

[Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
Hi Jan I have seen your patches for AT24Cxx functionality in qemu: https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html As i am interested in this work i am wondering what happend to this effort? Best regards Tim

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:40 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 6d37332..50678b5 100644 ---

Re: [Qemu-devel] [PATCH 11/74] acpi: add aml_to_integer()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 50587de..1f599e3

Re: [Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
Hi Jan Am Donnerstag, 10. Dezember 2015, 13:57:47 schrieb Jan Kiszka: > > I have seen your patches for AT24Cxx functionality in qemu: > > https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html > > > > As i am interested in this work i am wondering what happend to this > > effort? >

Re: [Qemu-devel] [PATCH 07/74] acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Currently AML API doesn't compose terms in form of following pattern: Opcode Arg2 Arg2 [Dst] but ASL used in piix4/q35 DSDT ACPI tables uses that form, so for clean conversion of it, AML API should be able to handle an optional 'Dst' argumet

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: >> Hi, >> >> qemu-img-ev-2.3.0-29.1.el7.x86_64 >> libvirt-daemon-driver-qemu-1.2.8-16.el7_1.4.x86_64 >> qemu-kvm-ev-2.3.0-29.1.el7.x86_64 >>

Re: [Qemu-devel] [PATCH 19/74] acpi: add aml_to_hexstring()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index

Re: [Qemu-devel] [PATCH 10/74] acpi: add aml_call0() helper

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 15:04:43 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > it will help to call a method with 0 arguments > > > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/aml-build.c | 8

Re: [Qemu-devel] [PATCH 22/74] acpi: extend aml_or() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 4 ++-- hw/arm/virt-acpi-build.c| 6 +++--- hw/i386/acpi-build.c| 3 ++- include/hw/acpi/aml-build.h | 2 +- 4 files changed, 8 insertions(+), 7

Re: [Qemu-devel] [PATCH 25/74] pc: acpi: memhp: prepare context in SSDT for moving memhp DSDT code

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 14:45:32 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/Makefile.objs | 2 +- > > hw/acpi/memory_hotplug_acpi_table.c | 40 >

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 14:58, Marcel Apfelbaum wrote: > My point is, now we *could* have a guarantee that if anyone uses the old > way, we can catch it in time. It can be easily lost in the review process. The right way to do that would be in scripts/checkpatch.pl, by catching error_report_err followed

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Alexander Duyck
On Thu, Dec 10, 2015 at 6:38 AM, Lan, Tianyu wrote: > > > On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: >>> >>> Ideally, it is able to leave guest driver unmodified but it requires the >>> >hypervisor or qemu to aware the device which means we may need a driver >>> >

Re: [Qemu-devel] [PATCH v3 2/4] target-tilegx: Add single floating point implementation

2015-12-10 Thread Richard Henderson
On 12/10/2015 06:15 AM, Chen Gang wrote: > +#define TILEGX_F_CALC_CVT 0 /* convert int to fsingle */ > +#define TILEGX_F_CALC_NCVT 1 /* Not convertion */ > + > +static uint32_t get_f32_exp(float32 f) > +{ > +return extract32(float32_val(f), 23, 8); > +} > + > +static void

Re: [Qemu-devel] [PATCH 2/4] error: Clean up errors with embedded newlines (again), part 1

2015-12-10 Thread Laszlo Ersek
On 12/10/15 18:23, Markus Armbruster wrote: > The arguments of error_report() should yield a short error string > without newlines. > > A few places try to print additional help after the error message by > embedding newlines in the error string. That's nice, but let's do it > the right way.

Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent

2015-12-10 Thread Zhu Lingshan
Yeah, I assume that is an easy and efficient solution Thanks On 12/10/2015 04:57 PM, Peter Lieven wrote: Am 10.12.2015 um 09:55 schrieb Paolo Bonzini: On 10/12/2015 03:59, Zhu Lingshan wrote: -if (task == NULL || task->status != SCSI_STATUS_GOOD) { +if ((rc16 != NULL) && ((task ==

[Qemu-devel] [Bug 1524637] [NEW] system_powerdown/system_reset not working when exec stop on hmp

2015-12-10 Thread Qinghua Jin
Public bug reported: system_powerdown/system_reset stops working in qemu for centos kernels if KVM is enabled. qemu versioin: 2.4 linux kernel versioin: 4.2.5 How to reproduce: 1. qemu-system-x86_64 -enable-kvm -drive if=none,id=drive0,file=/media/sda5/image/fc21/fc21.raw -device

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Yang Zhang
On 2015/12/10 19:41, Dr. David Alan Gilbert wrote: * Yang Zhang (yang.zhang...@gmail.com) wrote: On 2015/12/10 18:18, Dr. David Alan Gilbert wrote: * Lan, Tianyu (tianyu@intel.com) wrote: On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: I thought about what this is doing at the high

[Qemu-devel] [PATCH 06/34] scripts/kvm/kvm_stat: Invert dictionaries

2015-12-10 Thread Janosch Frank
The exit reasons dictionaries were defined number -> value but later on were accessed the other way around. Therefore a invert function inverted them. Defining them the right way removes the need to invert them and therefore also speeds up the script's setup process. --- scripts/kvm/kvm_stat |

[Qemu-devel] [PATCH 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval

2015-12-10 Thread Janosch Frank
Reading /sys/devices/system/cpu/online makes opening the cpu directories unnecessary and works on more/older systems. --- scripts/kvm/kvm_stat | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index

[Qemu-devel] [PATCH 07/34] scripts/kvm/kvm_stat: Cleanup of path variables

2015-12-10 Thread Janosch Frank
Paths to debugfs and trace dirs are now specified globally to remove redundancies in the code. Reviewed-by: Jason J. Herne --- scripts/kvm/kvm_stat | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/kvm/kvm_stat

[Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

2015-12-10 Thread Chen Gang
It passes gcc testsuite. Signed-off-by: Chen Gang --- target-tilegx/helper-fdouble.c | 400 + 1 file changed, 400 insertions(+) create mode 100644 target-tilegx/helper-fdouble.c diff --git a/target-tilegx/helper-fdouble.c

[Qemu-devel] [PATCH v3 4/4] target-tilegx: Integrate floating pointer implementation

2015-12-10 Thread Chen Gang
It passes normal building, and gcc testsuite. Signed-off-by: Chen Gang --- target-tilegx/Makefile.objs | 3 +- target-tilegx/cpu.h | 2 ++ target-tilegx/helper.h | 12 target-tilegx/translate.c | 68

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Cornelia Huck
On Thu, 10 Dec 2015 18:23:49 +0100 Markus Armbruster wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. > > Cc: Fam Zheng > Cc: Peter

[Qemu-devel] vhost_user and VIRTIO_NET_F_GUEST_ANNOUNCE

2015-12-10 Thread Pavel Fedin
Hello! I am currently testing this patchset (http://dpdk.org/ml/archives/dev/2015-December/029193.html), and I've got a question. After the migration the guest has to announce its MAC address for the network to work. Guest OS can do it itself, or qemu can send VHOST_USER_SEND_RARP to the

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Lan, Tianyu
On 12/11/2015 12:11 AM, Michael S. Tsirkin wrote: On Thu, Dec 10, 2015 at 10:38:32PM +0800, Lan, Tianyu wrote: On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: Ideally, it is able to leave guest driver unmodified but it requires the hypervisor or qemu to aware the device which means

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc3 is now available

2015-12-10 Thread Peter Maydell
On 8 December 2015 at 08:26, Peter Maydell wrote: > On 8 December 2015 at 00:16, Michael Roth wrote: >> The release plan for the 2.5 release is available at: >> >> http://wiki.qemu.org/Planning/2.5 > > My plan here is for us to fix only any

Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:40 AM, Igor Mammedov wrote: Due to huge size, CCing only cover letter instead of individual patches. Series consist of 2 parts the 1st part prefixed 'acpi:' adds necessary AML API functions and the second part converts DSDT using existing and new AML API. Series does exact

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

2015-12-10 Thread Fam Zheng
On Thu, 12/10 18:23, Markus Armbruster wrote: > diff --git a/block/vmdk.c b/block/vmdk.c > index 6f819e4..b4a224e 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -1494,8 +1494,8 @@ static int vmdk_write(BlockDriverState *bs, int64_t > sector_num, > > if (sector_num >

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 02:34 PM, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >>> On 12/10/2015 12:19 PM, Markus Armbruster wrote: Done with this admittedly crude Coccinelle semantic patch with manual burial

Re: [Qemu-devel] setting fadt->century

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 15:08, Laszlo Ersek wrote: > > The RTC CMOS RAM index to the century of data value (hundred and > thousand year decimals). If this field contains a zero, then the > RTC centenary feature is not supported. If this field has a > non-zero value, then this field

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Lan, Tianyu
On 12/10/2015 4:38 PM, Michael S. Tsirkin wrote: Let's assume you do save state and do have a way to detect whether state matches a given hardware. For example, driver could store firmware and hardware versions in the state, and then on destination, retrieve them and compare. It will be pretty

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Lan, Tianyu
On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: Ideally, it is able to leave guest driver unmodified but it requires the >hypervisor or qemu to aware the device which means we may need a driver in >hypervisor or qemu to handle the device on behalf of guest driver. Can you answer the

[Qemu-devel] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/550295/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John

Re: [Qemu-devel] [PATCH for-2.5] Update language files for QEMU 2.5.0

2015-12-10 Thread Peter Maydell
On 10 December 2015 at 13:42, Stefan Weil wrote: > Am 10.12.2015 um 14:34 schrieb Peter Maydell: >> Update translation files (change created via 'make -C po update'). >> >> Signed-off-by: Peter Maydell >> --- >> po/de_DE.po| 36

Re: [Qemu-devel] [PATCH 1/1] qcow2: insert assert into qcow2_get_specific_info()

2015-12-10 Thread Kevin Wolf
Am 10.12.2015 um 10:55 hat Denis V. Lunev geschrieben: > s->qcow_version is always set to 2 or 3. Let's assert if this is wrong. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Max Reitz > CC: Kevin Wolf

Re: [Qemu-devel] [PATCH 1/1] qcow2: insert assert into qcow2_get_specific_info()

2015-12-10 Thread Eric Blake
[adding qemu-block in cc, per MAINTAINERS] On 12/10/2015 02:55 AM, Denis V. Lunev wrote: > s->qcow_version is always set to 2 or 3. Let's assert if this is wrong. > > Signed-off-by: Denis V. Lunev > CC: Roman Kagan > CC: Max Reitz >

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Didier Pallard
On 12/10/2015 01:56 PM, Victor Kaplansky wrote: On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard

Re: [Qemu-devel] [PATCH] tcg/arm: improve direct jump

2015-12-10 Thread Richard Henderson
On 12/10/2015 12:02 AM, Aurelien Jarno wrote: Note: I don't really get the reason for the current 16MB limit. With the standard branch instructions the offset is coded on 24 bits, but shifted right by 2, which should give us a +/-32MB jumps, and therefore a 32MB limit. That might be me with

[Qemu-devel] [Patch V1 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-10 Thread Ashok Raj
This patch adds basic enumeration, control msr's required to support Local Machine Check Exception Support (LMCE). - Added Local Machine Check definitions, changed MCG_CAP - Added support for IA32_FEATURE_CONTROL. - When delivering MCE to guest, we deliver to just a single CPU when guest OS has

[Qemu-devel] [Patch V0 2/2] x86, mce: Need to translate GPA to HPA to inject error in guest.

2015-12-10 Thread Ashok Raj
From: root When we need to test error injection to a specific address using EINJ, there needs to be a way to translate GPA to HPA. This will allow host EINJ to inject error to test how guest behavior is when a bad address is consumed. This permits guest OS to perform

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Michael S. Tsirkin
On Thu, Dec 10, 2015 at 10:38:32PM +0800, Lan, Tianyu wrote: > > > On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: > >>Ideally, it is able to leave guest driver unmodified but it requires the > >>>hypervisor or qemu to aware the device which means we may need a driver in > >>>hypervisor or

[Qemu-devel] [PATCH v2 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - adapt build_prt() for using for PCI0._PRT(), reduces code duplication, Suggested-by: Marcel Apfelbaum pc: acpi: piix4: adapt build_prt() for using for PCI0._PRT() Signed-off-by: Igor Mammedov

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Dr. David Alan Gilbert
* Lan, Tianyu (tianyu@intel.com) wrote: > > > On 12/10/2015 7:41 PM, Dr. David Alan Gilbert wrote: > >>Ideally, it is able to leave guest driver unmodified but it requires the > >>>hypervisor or qemu to aware the device which means we may need a driver in > >>>hypervisor or qemu to handle

[Qemu-devel] [PATCH v2 2/2] hw: Inline the qdev_prop_set_drive_nofail() wrapper

2015-12-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/arm/nseries.c | 4 ++-- hw/block/fdc.c | 15 ++- hw/block/nand.c | 2 +- hw/core/qdev-properties-system.c | 6 -- hw/ide/qdev.c| 3 ++-

[Qemu-devel] [PATCH v2 0/2] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
v2: * PATCH 1: Don't mess up formatting of zynq_init() [Paolo] * PATCH 2: New [Paolo] Markus Armbruster (2): Use error_fatal to simplify obvious fatal errors hw: Inline the qdev_prop_set_drive_nofail() wrapper hw/arm/exynos4210.c | 13 ++-- hw/arm/highbank.c

[Qemu-devel] [PATCH v2 1/2] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Done with this admittedly crude Coccinelle semantic patch: @@ identifier FUN; expression ERR, EC; @@ -FUN(); -if (ERR != NULL) { -error_report_err(ERR); -exit(EC); -} +FUN(_fatal); @@ identifier FUN; expression

Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 17:53:31 +0200 Marcel Apfelbaum wrote: [...] > Hi Igor, > Please consider splinting this series... > > Maybe ACPI new constructs first, then memhp/cpu, piix/q35. (only a > suggestion) In this you will have some "sane" 20 something patches > series

[Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

2015-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" My fix (84e7b80a) replaced the last_sent_block update that I'd removed earlier; however it was too aggressive in the xbzrle case. save_xbzrle_page might return '0' to mean that the page didn't need sending since it was the same as the last

<    1   2   3