Re: [Qemu-devel] [PATCH 00/18] virgl: use a seperate rendering thread

2016-09-08 Thread Gerd Hoffmann
Hi, > The benchmarks are quite encouraging, since I get from +-25% for > xonotic up to +-100% for glmark. (fwiw, vhost-user-gpu had similar > results too). Finally, I tried to make it acceptable for upstream. Hmm, I don't feel like adding too many modes to virgl ... With vhost-user-gpu giving

Re: [Qemu-devel] [PATCH 2/3] virtio: add virtqueue_rewind()

2016-09-08 Thread Roman Kagan
On Wed, Sep 07, 2016 at 05:20:48PM +0200, Ladi Prosek wrote: > From: Stefan Hajnoczi > > virtqueue_discard() requires a VirtQueueElement but virtio-balloon does > not migrate its in-use element. Introduce a new function that is > similar to virtqueue_discard() but doesn't

Re: [Qemu-devel] [PATCH 2/3] virtio: add virtqueue_rewind()

2016-09-08 Thread Ladi Prosek
On Thu, Sep 8, 2016 at 8:44 AM, Roman Kagan wrote: > On Wed, Sep 07, 2016 at 05:20:48PM +0200, Ladi Prosek wrote: >> From: Stefan Hajnoczi >> >> virtqueue_discard() requires a VirtQueueElement but virtio-balloon does >> not migrate its in-use element.

Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter

2016-09-08 Thread Daniel P. Berrange
On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote: > Add a parameter to associate an iSCSI block driver instance with an -iscsi > object. This is more powerful than relying on the implicit target IQN naming > convention since that only allows one -iscsi object per target. I'm

Re: [Qemu-devel] [PATCH] ppc: restrict the use of the rfi instruction

2016-09-08 Thread Thomas Huth
On 08.09.2016 09:32, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Power ISA 2.x has deleted the rfi instruction and rfid shoud be used > instead on cpus following this instruction set or later. > > This will raise an invalid exception when rfi is used on

Re: [Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-08 Thread Ladi Prosek
On Wed, Sep 7, 2016 at 5:54 PM, Stefan Hajnoczi wrote: > On Wed, Sep 7, 2016 at 11:51 AM, Stefan Hajnoczi wrote: >> vq->inuse must be zeroed upon device reset like most other virtqueue >> fields. >> >> In theory, virtio_reset() just needs assert(vq->inuse

Re: [Qemu-devel] [PATCH] vhost_net: don't enable vring if backend lack this feature

2016-09-08 Thread Chen Hanxiao
At 2016-09-03 16:44:47, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >If backend(such as dpdk) lack this feature, >don't assume it and mark it in vring_enable. >Or we may fail in vhost_net_start, >then we can't use vhost net. >This will bring compat

Re: [Qemu-devel] [PATCH] virtio: zero vq->inuse in virtio_reset()

2016-09-08 Thread Cornelia Huck
On Wed, 7 Sep 2016 11:51:25 -0400 Stefan Hajnoczi wrote: > vq->inuse must be zeroed upon device reset like most other virtqueue > fields. > > In theory, virtio_reset() just needs assert(vq->inuse == 0) since > devices must clean up in-flight requests during reset (requests

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-08 Thread Gerd Hoffmann
Hi, > I had understood that the xhci could be a legacy PCI device or a PCI > Express device depending on the socket it was plugged into (or was that > possibly just someone doing some hand-waving over the fact that > obscuring the PCI Express capabilities effectively turns it into a >

[Qemu-devel] [PATCH] ppc: restrict the use of the rfi instruction

2016-09-08 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Power ISA 2.x has deleted the rfi instruction and rfid shoud be used instead on cpus following this instruction set or later. This will raise an invalid exception when rfi is used on such processors: Book3S 64-bit processors.

Re: [Qemu-devel] [RFC v2 0/4] adding mdev bus and vfio support

2016-09-08 Thread Jike Song
On 09/08/2016 12:56 AM, Alex Williamson wrote: > On Wed, 07 Sep 2016 14:42:58 +0800 > Jike Song wrote: > >> On 09/07/2016 11:38 AM, Neo Jia wrote: >>> On Wed, Sep 07, 2016 at 10:22:26AM +0800, Jike Song wrote: On 09/02/2016 11:03 PM, Alex Williamson wrote: > On

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Ashijeet Acharya
On Thu, Sep 8, 2016 at 3:33 AM, Eric Blake wrote: > On 09/06/2016 08:39 AM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting maximum migration speed and

Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-08 Thread Laurent Vivier
On 08/09/2016 04:04, David Gibson wrote: > On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote: >> And add support for ppc64. >> >> Signed-off-by: Laurent Vivier > > Some of my coments may be obsoleted by the discussion with Greg. > >> --- >> v2: >> - remove

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-08 Thread Greg Kurz
On Tue, 6 Sep 2016 15:17:55 +0200 Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- FWIW, Reviewed-by: Greg Kurz > v4: > - add this patch in the series to change all strtoXX() in qtest.c > > qtest.c | 49

Re: [Qemu-devel] [PATCH] 9pfs: add support for IO limits to 9p-local driver

2016-09-08 Thread Greg Kurz
On Wed, 7 Sep 2016 16:36:12 -0500 Eric Blake wrote: > On 09/07/2016 07:39 AM, Pradeep wrote: > > Uses throttling APIs to limit I/O bandwidth and number of operations on the > > devices which use 9p-local driver. > > > > Signed-off-by: Pradeep >

Re: [Qemu-devel] [PATCH] virtio-vga: adapt to page-per-vq=off

2016-09-08 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] virtio-vga: adapt to page-per-vq=off Type: series Message-id:

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-09-08 Thread Gerd Hoffmann
Hi, > > Good point, maybe libvirt can avoid adding switches unless the user > > explicitly > > asked for them. I checked and it a actually works fine in QEMU. > So, *is* there any downside to doing this? I don't think so. The only issue I can think of when it comes to multifunction is

Re: [Qemu-devel] KVM Forum 2016 videos now online

2016-09-08 Thread Christian Borntraeger
On 09/08/2016 05:28 AM, Pranith Kumar wrote: > FYI, > > The KVM Forum 2016 videos are now online on youtube. You can find them here: > > https://www.youtube.com/playlist?list=PLW3ep1uCIRfzQoZ0SlniYE8nz1ZRobjH7 The videos are not complete yet, some more still to come as far as I can see.

Re: [Qemu-devel] [PATCH 1/2] SDL2: only show consoles by shortcuts and not hide.

2016-09-08 Thread Gerd Hoffmann
On Mi, 2016-09-07 at 15:24 +0300, Andrei Karas wrote: > >Среда, 7 сентября 2016, 14:27 +03:00 от Gerd Hoffmann : > > > >On Di, 2016-08-23 at 23:36 +0300, Andrei Karas wrote: > >> This fix issue with stuck keys in SDL2 if press one of shortcuts > >> for show/hide consoles. > > >

Re: [Qemu-devel] [PATCH 00/18] virgl: use a seperate rendering thread

2016-09-08 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > > The benchmarks are quite encouraging, since I get from +-25% for > > xonotic up to +-100% for glmark. (fwiw, vhost-user-gpu had similar > > results too). Finally, I tried to make it acceptable for upstream. > > Hmm, I don't feel like adding too many

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-09-08 Thread Kevin Zhao
Hi All, As discussed before, upstream are working about PCIE instead of PCI in AArch64. Thanks for your efforts about this on AArch64 :-) If it convenient, could you tell me when we plan to finish this task ? and which qemu version will support this functions in the future? Big

[Qemu-devel] [PATCH] target-mips: generate fences

2016-09-08 Thread Leon Alrae
Make use of memory barrier TCG opcode in MIPS front end. Signed-off-by: Leon Alrae --- This patch complements the following series: https://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg03283.html --- target-mips/translate.c | 4 ++-- 1 file changed, 2

Re: [Qemu-devel] [virtio-dev][RFC v3] virtio-sdm: new device specification

2016-09-08 Thread Christian Pinto
Hello Edgar, On 07/09/2016 18:02, Edgar E. Iglesias wrote: On Wed, Sep 07, 2016 at 05:39:08PM +0200, Christian Pinto wrote: On 07/09/2016 09:51, Edgar E. Iglesias wrote: On Wed, Sep 07, 2016 at 09:24:39AM +0200, Christian Pinto wrote: Hello Edgar, thanks for your comments. Thanks for the

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-08 Thread Markus Armbruster
Greg Kurz writes: > Calling assert() really makes sense when hitting a genuine bug, which calls > for a fix in QEMU. However, when something goes wrong because the guest > sends a malformed message, it is better to write down a more meaningul > error message and exit. > >

[Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable

2016-09-08 Thread Gerd Hoffmann
We can't hotplug display adapters in qemu, tag virtio-gpu-pci accordingly (virtio-vga already has this). Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: error out when both legacy and modern modes are disabled

2016-09-08 Thread Markus Armbruster
Greg Kurz writes: > From: Greg Kurz > > Without presuming if we got there because of a user mistake or some > more subtle bug in the tooling, it really does not make sense to > implement a non-functional device. > > Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-08 Thread Cédric Le Goater
On 09/07/2016 11:48 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-07 at 14:13 +0200, Cédric Le Goater wrote: >> On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote: >>> >>> On Wed, 2016-09-07 at 12:50 +0200, Cédric Le Goater wrote: This is a bit broader than Ben's patch which used

[Qemu-devel] [PATCH] virtio-vga: adapt to page-per-vq=off

2016-09-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/virtio-vga.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/display/virtio-vga.c b/hw/display/virtio-vga.c index 5b510a1..f77b401 100644 --- a/hw/display/virtio-vga.c +++ b/hw/display/virtio-vga.c @@ -122,6

[Qemu-devel] [PATCH 0/2] vhost-user: set_mem_table updates

2016-09-08 Thread Maxime Coquelin
The series first restore the GET_FEATURES call in vhost_set_mem_table(), as the hang it introduced was due to the use of TCG in the vhost-user-test, mode which is no more used since commit cdafe929 ("vhost-user-test: Use libqos instead of pxe-virtio.rom"). Second patch aims at being as close as

Re: [Qemu-devel] [PATCH v2 07/27] tcg: Add EXCP_ATOMIC

2016-09-08 Thread Alex Bennée
Richard Henderson writes: > When we cannot emulate an atomic operation within a parallel > context, this exception allows us to stop the world and try > again in a serial context. > > Signed-off-by: Richard Henderson > --- > cpu-exec-common.c | 6

[Qemu-devel] [PATCH v5 3/3] tests: add RTAS command in the protocol

2016-09-08 Thread Laurent Vivier
Add a first test to validate the protocol: - rtas/get-time-of-day compares the time from the guest with the time from the host. Signed-off-by: Laurent Vivier --- v5: - use qtest_spapr_boot() instead of machine_alloc_init() v4: - use qemu_strtoXXX() instead strtoXX() v3:

[Qemu-devel] [PATCH v5 0/3] tests: add RTAS protocol

2016-09-08 Thread Laurent Vivier
This series allows to call RTAS commands from the qtest framework, and defines a first test to call RTAS command "get-time-of-day" to validate the protocol and test RTAS. RTAS command parameters are passed to the guest via the guest memory, so we also need to implement the guest memory management

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-08 Thread Jike Song
On 08/25/2016 11:53 AM, Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by different drivers of different > devices. > > This module provides a generic interface to create

Re: [Qemu-devel] [PATCH v2 08/27] HACK: Always enable parallel_cpus

2016-09-08 Thread Alex Bennée
Richard Henderson writes: > This is really just a placeholder for an actual > command-line switch for mttcg. > --- > translate-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/translate-all.c b/translate-all.c > index 99ae7f9..a10fa06 100644 >

[Qemu-devel] [PATCHv5] tests: add qtest_add_data_func_full

2016-09-08 Thread Marc-André Lureau
Allows one to specify a destroy function for the test data. Add a fallback using glib g_test_add_vtable() internal function, whose signature changed over time. Tested with glib 2.22, 2.26 and 2.48, which according to git log should be enough to cover all variations. Signed-off-by: Marc-André

[Qemu-devel] [PATCH v5 2/3] libqos: define SPAPR libqos functions

2016-09-08 Thread Laurent Vivier
Define spapr_alloc_init()/spapr_alloc_init_flags()/spapr_alloc_uninit() to allocate and use SPAPR guest memory Define qtest_spapr_vboot()/qtest_spapr_boot()/qtest_spapr_shutdown() to start SPAPR guest with QOSState initialized for it (memory management) Move qtest_irq_intercept_in() from

[Qemu-devel] [PATCH v5 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-08 Thread Laurent Vivier
Check the result of qemu_strtoXX() and assert if the string cannot be converted. Signed-off-by: Laurent Vivier Reviewed-by: David Gibson --- v5: - update log message about result checking - add David's Rb v4: - add this patch in the series to

[Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Maxime Coquelin
The goal of this patch is to only request a sync (reply_ack, or get_features) in set_mem_table only when necessary. It should not be necessary the first time we set the table, or when we add a new regions which hadn't been merged with an existing ones. Suggested-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure

2016-09-08 Thread Cédric Le Goater
On 09/07/2016 11:53 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-07 at 17:47 +0200, Cédric Le Goater wrote: >> >> +static uint64_t pnv_lpc_xscom_mr_read(void *opaque, hwaddr addr, >> unsigned size) >> +{ >> +XScomDevice *xd = XSCOM_DEVICE(opaque); >> +uint64_t val = 0; >> + >> +

[Qemu-devel] [PATCH 1/2] Revert "Revert "vhost-user: Attempt to fix a race with set_mem_table.""

2016-09-08 Thread Maxime Coquelin
This reverts commit 94c9cb31c04737f86be29afefbff401cd23bc24d. Analysis of the race shows that it would happen only when QEMU relies on TCG. Since commit cdafe929 ("vhost-user-test: Use libqos instead of pxe-virtio.rom"), vhost-user-test don't use TCG, so the race no more appear. Cc: Michael S.

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > >> + > > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > > >> +{ > > >> +VXHSAIOCB *acb = ptr; > > >> + > > >> +acb->buffer = buffer; > > >> +} > > >> + > > > > >

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Kevin Wolf
Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > >> + > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > >> +{ > >> +VXHSAIOCB *acb = ptr; > >> + > >> +acb->buffer = buffer; > >> +} > >> + > > > > Unused function? > > This is called from within libqnio. Wait, you mean the

Re: [Qemu-devel] [PATCH 0/7] MIPS Boston board support

2016-09-08 Thread Leon Alrae
On Fri, Aug 19, 2016 at 08:40:32PM +0100, Paul Burton wrote: > On 19/08/16 20:25, no-re...@patchew.org wrote: > > Hi, > > > > Your series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > > >> + > > > > >> +void

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-08 Thread Greg Kurz
On Thu, 8 Sep 2016 10:59:26 +0200 Cornelia Huck wrote: > On Wed, 07 Sep 2016 19:19:24 +0200 > Greg Kurz wrote: > > > Calling assert() really makes sense when hitting a genuine bug, which calls > > for a fix in QEMU. However, when something goes wrong

Re: [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable

2016-09-08 Thread Marc-André Lureau
On Thu, Sep 8, 2016 at 11:29 AM Gerd Hoffmann wrote: > We can't hotplug display adapters in qemu, tag virtio-gpu-pci > accordingly (virtio-vga already has this). > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-08 Thread Cornelia Huck
On Wed, 07 Sep 2016 19:19:24 +0200 Greg Kurz wrote: > Calling assert() really makes sense when hitting a genuine bug, which calls > for a fix in QEMU. However, when something goes wrong because the guest > sends a malformed message, it is better to write down a more meaningul >

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: print error message and exit instead of BUG_ON()

2016-09-08 Thread Greg Kurz
On Thu, 08 Sep 2016 09:14:05 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > Calling assert() really makes sense when hitting a genuine bug, which calls > > for a fix in QEMU. However, when something goes wrong because the guest > > sends a malformed

[Qemu-devel] [PATCH V14 04/12] Jhash: add linux kernel jhashtable in qemu

2016-09-08 Thread Zhang Chen
Jhash will be used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 59

[Qemu-devel] [PATCH V14 00/12] Introduce COLO-Proxy

2016-09-08 Thread Zhang Chen
COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO-proxy's help, COLO greatly improves the performance. The filter-redirector,

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-08 Thread Peter Xu
On Wed, Sep 07, 2016 at 04:41:54PM +1000, David Gibson wrote: > On Wed, Sep 07, 2016 at 02:34:19PM +0800, Peter Xu wrote: > > On Wed, Sep 07, 2016 at 03:44:19PM +1000, David Gibson wrote: > > > > For "CHANGE", it sounds like a unmap() + a map(). However I'd say > > > > "ADDITION" is nowhere

Re: [Qemu-devel] [PATCH] memory: Use standard log messages for unassigned memory read / write

2016-09-08 Thread Paolo Bonzini
On 08/09/2016 07:43, Stefan Weil wrote: > Am 07.09.2016 um 23:29 schrieb Peter Maydell: >> On 7 September 2016 at 20:13, Stefan Weil wrote: >>> The old log messages are implemented by conditional compilation >>> and not available by default. >>> >>> The new log messages can be

[Qemu-devel] [PATCH V14 10/12] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-09-08 Thread Zhang Chen
We will rewrite tcp packet secondary received and sent. When colo guest is a tcp server. Firstly, client start a tcp handshake. the packet's seq=client_seq, ack=0,flag=SYN. COLO primary guest get this pkt and mirror(filter-mirror) to secondary guest, secondary get it use filter-redirector.

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: error out when both legacy and modern modes are disabled

2016-09-08 Thread Greg Kurz
On Thu, 08 Sep 2016 09:15:28 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > From: Greg Kurz > > > > Without presuming if we got there because of a user mistake or some > > more subtle bug in the tooling, it really does not

[Qemu-devel] [PATCH V14 06/12] colo-compare: introduce packet comparison thread

2016-09-08 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes but secondary packet does not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > > >> + > > > > >> +void

[Qemu-devel] [PATCH V14 07/12] colo-compare: add TCP, UDP, ICMP packet comparison

2016-09-08 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. Less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Kevin Wolf
Am 08.09.2016 um 11:43 hat Daniel P. Berrange geschrieben: > On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > > Am 08.09.2016 um 00:32 hat ashish mittal

[Qemu-devel] [PATCH v9 2/2] virtio-crypto: Add conformance clauses

2016-09-08 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 31 +++ 1 file changed, 31 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..039f44e 100644 ---

[Qemu-devel] [PATCH] docs/xbzrle: correction

2016-09-08 Thread Cao jin
1. Default cache size is 64MB. 2. Semantics correction. Signed-off-by: Cao jin --- docs/xbzrle.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt index 52c8511..c0a7dfd 100644 --- a/docs/xbzrle.txt +++

[Qemu-devel] [PATCH] iothread: Stop threads before main() quits

2016-09-08 Thread Fam Zheng
Right after main_loop ends, we release various things but keep iothread alive. The latter is not prepared to the sudden change of resources. Specifically, after bdrv_close_all(), virtio-scsi dataplane get a surprise at the empty BlockBackend: (gdb) bt at

Re: [Qemu-devel] [PATCH] iothread: Stop threads before main() quits

2016-09-08 Thread Paolo Bonzini
On 08/09/2016 11:28, Fam Zheng wrote: > Right after main_loop ends, we release various things but keep iothread > alive. The latter is not prepared to the sudden change of resources. > > Specifically, after bdrv_close_all(), virtio-scsi dataplane get a > surprise at the empty BlockBackend: > >

[Qemu-devel] [PATCH V14 11/12] MAINTAINERS: add maintainer for COLO-proxy

2016-09-08 Thread Zhang Chen
add Zhang Chen and Li zhijian as co-maintainers of COLO-proxy. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff

[Qemu-devel] [PATCH V14 05/12] colo-compare: track connection and enqueue packet

2016-09-08 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+

Re: [Qemu-devel] [PATCH RESEND v4 1/2] pc: Add 2.8 machine

2016-09-08 Thread Christian Borntraeger
On 09/05/2016 09:53 AM, Longpeng(Mike) wrote: > +++ b/include/hw/compat.h > @@ -1,6 +1,8 @@ > #ifndef HW_COMPAT_H > #define HW_COMPAT_H > > +#define HW_COMPAT_2_7 > + This is already defined (due to the s390 2.8 machine)

[Qemu-devel] [PATCH V14 12/12] docs: Add documentation for COLO-proxy

2016-09-08 Thread Zhang Chen
Introduce the design of COLO-proxy, and how to use it. Signed-off-by: Zhang Chen --- docs/colo-proxy.txt | 188 1 file changed, 188 insertions(+) create mode 100644 docs/colo-proxy.txt diff --git

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Kevin Wolf
Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > >> + > > > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > > > >> +{ > > > >> +VXHSAIOCB *acb = ptr;

Re: [Qemu-devel] [PATCH 0/7] MIPS Boston board support

2016-09-08 Thread Paul Burton
On 08/09/16 09:57, Leon Alrae wrote: > On Fri, Aug 19, 2016 at 08:40:32PM +0100, Paul Burton wrote: >> On 19/08/16 20:25, no-re...@patchew.org wrote: >>> Hi, >>> >>> Your series failed automatic build test. Please find the testing commands >>> and >>> their output below. If you have docker

Re: [Qemu-devel] [PATCH v7 1/4] vfio: Mediated device Core driver

2016-09-08 Thread Neo Jia
On Thu, Sep 08, 2016 at 04:09:39PM +0800, Jike Song wrote: > On 08/25/2016 11:53 AM, Kirti Wankhede wrote: > > + > > +/** > > + * struct parent_ops - Structure to be registered for each parent device to > > + * register the device to mdev module. > > + * > > + * @owner: The module owner. >

[Qemu-devel] [PATCH V14 02/12] colo-compare: introduce colo compare initialization

2016-09-08 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ |

[Qemu-devel] [PATCH] vmsvga: correct bitmap and pixmap size checks

2016-09-08 Thread P J P
From: Prasad J Pandit When processing svga command DEFINE_CURSOR in vmsvga_fifo_run, the computed BITMAP and PIXMAP size are checked against the 'cursor.mask[]' and 'cursor.image[]' array sizes in bytes. Correct these checks to avoid OOB memory access. Reported-by:

Re: [Qemu-devel] [PATCH 02/10] tcg: Pass last_tb by value to tb_find_fast()

2016-09-08 Thread Alex Bennée
Paolo Bonzini writes: > From: Sergey Fedorov > > This is a small clean up. tb_find_fast() is a final consumer of this > variable so no need to pass it by reference. 'last_tb' is always updated > by subsequent cpu_loop_exec_tb() in cpu_exec(). > > @@

Re: [Qemu-devel] KVM Forum 2016 videos now online

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 09:42:33AM +0200, Christian Borntraeger wrote: > On 09/08/2016 05:28 AM, Pranith Kumar wrote: > > FYI, > > > > The KVM Forum 2016 videos are now online on youtube. You can find them here: > > > > https://www.youtube.com/playlist?list=PLW3ep1uCIRfzQoZ0SlniYE8nz1ZRobjH7 >

[Qemu-devel] [PATCH V14 01/12] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-08 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian

[Qemu-devel] [PATCH V14 08/12] filter-rewriter: introduce filter-rewriter initialization

2016-09-08 Thread Zhang Chen
Filter-rewriter is a part of COLO project. It will rewrite some of secondary packet to make secondary guest's tcp connection established successfully. In this module we will rewrite tcp packet's ack to the secondary from primary,and rewrite tcp packet's seq to the primary from secondary. usage:

Re: [Qemu-devel] [PULL v2 0/4] target-arm queue

2016-09-08 Thread Peter Maydell
On 6 September 2016 at 20:03, Peter Maydell wrote: > v2 pull: > * dropped the ast2500 patches > * fix ast2400 memory controller format string bug > > thanks > -- PMM > > > The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39: > > Merge

Re: [Qemu-devel] [PATCHv5] tests: add qtest_add_data_func_full

2016-09-08 Thread Eric Blake
On 09/08/2016 03:40 AM, Marc-André Lureau wrote: > Allows one to specify a destroy function for the test data. > > Add a fallback using glib g_test_add_vtable() internal function, whose > signature changed over time. Tested with glib 2.22, 2.26 and 2.48, which > according to git log should be

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Paolo Bonzini
On 08/09/2016 12:18, Kevin Wolf wrote: > Am 08.09.2016 um 11:43 hat Daniel P. Berrange geschrieben: >> On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: >>> Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: >

[Qemu-devel] [PATCH V14 03/12] net/colo.c: add colo.c to define and handle packet

2016-09-08 Thread Zhang Chen
The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v3 1/3] memory: introduce IOMMUNotifier and its caps

2016-09-08 Thread Peter Xu
On Wed, Sep 07, 2016 at 08:20:35PM +1000, David Gibson wrote: > On Wed, Sep 07, 2016 at 03:09:16PM +0800, Peter Xu wrote: > > On Wed, Sep 07, 2016 at 04:02:39PM +1000, David Gibson wrote: > > > On Wed, Sep 07, 2016 at 01:32:22PM +0800, Peter Xu wrote: > > > > IOMMU Notifier list is used for

Re: [Qemu-devel] [PATCH v3 0/8] docker tests fixes

2016-09-08 Thread Fam Zheng
On Tue, 09/06 22:05, Sascha Silbe wrote: > A couple of fixes for issues encountered while trying out the new > docker test support. > > v2→v3: > - fix non-portable sort -V usage > - send debootstrap.pre error messages to stderr > - whitespace changes > > v1→v2: > - found a good place to

Re: [Qemu-devel] [PULL 35/38] qmp: add QMP interface "query-cpu-model-baseline"

2016-09-08 Thread Eric Blake
On 09/06/2016 02:47 AM, Cornelia Huck wrote: > From: David Hildenbrand > > Let's provide a standardized interface to baseline two CPU models, to > create a third, compatible one. This is especially helpful when two > CPU models are not identical, but a CPU model is

[Qemu-devel] [PATCH V14 09/12] filter-rewriter: track connection and parse packet

2016-09-08 Thread Zhang Chen
We use net/colo.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo.c| 14 ++ net/colo.h| 1 +

Re: [Qemu-devel] [PATCH 3/3] virtio-balloon: fix stats vq migration

2016-09-08 Thread Roman Kagan
On Wed, Sep 07, 2016 at 05:20:49PM +0200, Ladi Prosek wrote: > The statistics virtqueue is not migrated properly because virtio-balloon > does not include s->stats_vq_elem in the migration stream. > > After migration the statistics virtqueue hangs because the host never > completes the last

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > I previously split the global trace-events file up into one file > > per-subdirectory to avoid merge conflict hell. > [...] > > Sorry, I could not find the message where the infrastructure is

Re: [Qemu-devel] [PATCHv5] tests: add qtest_add_data_func_full

2016-09-08 Thread Marc-André Lureau
Hi - Original Message - > On 09/08/2016 03:40 AM, Marc-André Lureau wrote: > > Allows one to specify a destroy function for the test data. > > > > Add a fallback using glib g_test_add_vtable() internal function, whose > > signature changed over time. Tested with glib 2.22, 2.26 and 2.48,

[Qemu-devel] [PULLv2 15/25] acpi-build: fix array leak

2016-09-08 Thread Marc-André Lureau
The free_ranges array is used as a temporary pointer array, the segment should still be freed, however, it shouldn't free the elements themself. Signed-off-by: Marc-André Lureau Tested-by: Marcel Apfelbaum Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PATCH 2/6] crypto: clear out buffer after timing pbkdf algorithm

2016-09-08 Thread Daniel P. Berrange
The 'out' buffer will hold a key derived from master password, so it is best practice to clear this buffer when no longer required. Signed-off-by: Daniel P. Berrange --- crypto/pbkdf.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULLv2 17/25] pc: free i8259

2016-09-08 Thread Marc-André Lureau
Simiarly to 2ba154cf4eb8636cdd3aa90f392ca9e77206ca39 Signed-off-by: Marc-André Lureau Reviewed-by: Marcel Apfelbaum --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index

[Qemu-devel] [PULLv2 22/25] tests: add qtest_add_data_func_full

2016-09-08 Thread Marc-André Lureau
Allows one to specify a destroy function for the test data. Add a fallback using glib g_test_add_vtable() internal function, whose signature changed over time. Tested with glib 2.22, 2.26 and 2.48, which according to git log should be enough to cover all variations. Signed-off-by: Marc-André

[Qemu-devel] [PULLv2 23/25] tests: pc-cpu-test leaks fixes

2016-09-08 Thread Marc-André Lureau
The path is allocated and should be freed. The qmp response should be unref, but then 'machine' must be duplicated. Use a destroy function for the PCTestData. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/pc-cpu-test.c | 24

[Qemu-devel] [PATCH v9 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-08 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH for-2.7] qtest.c: Allow zero size in memset qtest commands

2016-09-08 Thread Eric Blake
On 08/05/2016 05:43 AM, Peter Maydell wrote: > Some tests use the qtest protocol "memset" command with a zero > size, expecting it to do nothing. However in the current code this > will result in calling memset() with a NULL pointer, which is > undefined behaviour. Detect and specially handle zero

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-08 Thread Jeff Cody
On Thu, Sep 08, 2016 at 10:34:24AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > > Am 08.09.2016 um 00:32 hat

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Ashijeet Acharya
On Thu, Sep 8, 2016 at 8:11 PM, Juan Quintela wrote: > Eric Blake wrote: > >>> +if (has_max_bandwidth) { >>> +s->parameters.max_bandwidth = max_bandwidth; >>> +if (s->to_dst_file) { >>> +

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-08 Thread Lluís Vilanova
Daniel P Berrange writes: > I previously split the global trace-events file up into one file > per-subdirectory to avoid merge conflict hell. [...] Sorry, I could not find the message where the infrastructure is modified to provide this. But I think there's a more efficient way to provide

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2016 at 07:56:38AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Regarding Patch 2/2: > > This patch seems to filter responses from set_mem_table only for certain > > updates of memory regions. It violates the definition of the REPLY_ACK > > feature.

Re: [Qemu-devel] [PATCH for-2.8 v1 04/60] trace: move hw/virtio/virtio-balloon.c trace points into correct file

2016-09-08 Thread Eric Blake
On 08/09/2016 10:31 AM, Daniel P. Berrange wrote: > The trace points for hw/virtio/virtio-balloon.c were mistakenly put > in the top level trace-events file, instead of util/trace-events. Is it worth updating the commit messages to commit ids that caused that need for 1-4 in your series? --

Re: [Qemu-devel] [PATCH v2] iscsi: Fix divide-by-zero regression on raw SG devices

2016-09-08 Thread Holger Schranz
Hi Eric, Thanks a lot, it seems the patch works. The VM starting. Unfortunately we run into the next issue. By the accessing the megasas controller we got a SIGSEGV. See the trave below. Best regards Holger === Thread 4

Re: [Qemu-devel] [PATCH RFC v2 09/22] block/pcache: separation AIOCB on requests

2016-09-08 Thread Pavel Butsykin
On 02.09.2016 12:10, Kevin Wolf wrote: Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: for case when the cache partially covers request we are part of the request is filled from the cache, and the other part request from disk. Also add reference counting for nodes, as way to maintain

  1   2   3   >