Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: > On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: > > > > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > > > > > > The flag values are expected to remain same for a machine version for > > > the migration t

Re: [Qemu-devel] [PATCH v4 0/8] replay additions

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 07:41, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 21/09/2016 13:33, Pavel Dovgalyuk wrote: >>> This set of patches includes several fixes for replay and >>> adds network record/replay for network devices. It also makes possible >>> saving/restor

Re: [Qemu-devel] [PATCH] x86: ioapic: boost default version to 0x20

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 10:36, Peter Xu wrote: > It's 2.8 now, and maybe it's time to switch IOAPIC default version to > 0x20. > > Signed-off-by: Peter Xu > --- > hw/intc/ioapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > index 31791b

Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 09:02, Thomas Huth wrote: > On Wed, 21 Sep 2016 22:08:10 +0200 > Paolo Bonzini wrote: > >> On 21/09/2016 21:42, Thomas Huth wrote: >>> Basic idea of this script is to check the git log for URLs >>> to the QEMU bugtracker at launchpad.net and to figure out >>> whether the related b

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: >> > >> > On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: >> > > >> > > The flag values are expected to remain same for a m

[Qemu-devel] [PATCH 02/30] qmp-commands: move 'cont' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 12 qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 5a91d77..c97dcb5 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp-c

[Qemu-devel] [PATCH 03/30] qmp-commands: move 'system_wakeup' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 12 qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index c97dcb5..1c3e69f 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp-c

[Qemu-devel] [PATCH v2] qtest: fix make check complaint in crypto module

2016-09-22 Thread Gonglei
CCtests/test-crypto-tlscredsx509.o CCtests/crypto-tls-x509-helpers.o CCtests/pkix_asn1_tab.o tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory tests/pkix_asn1_tab.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pkix_asn1_tab’ make: **

[Qemu-devel] [PATCH 04/30] qmp-commands: move 'inject-nmi' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 14 -- qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 1c3e69f..c4caf9c 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

[Qemu-devel] [PATCH 05/30] qmp-commands: move 'set_link' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 15 --- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index c4caf9c..18a15dc 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

Re: [Qemu-devel] [PATCH] checkpatch: downgrade "architecture specific defines should be avoided"

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 09:12, Markus Armbruster wrote: > Paolo Bonzini writes: > >> --- >> scripts/checkpatch.pl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index dde3f5f..3afa19a 100755 >> --- a/scripts/checkpatch.pl >> +

[Qemu-devel] [PATCH 09/30] qmp-commands: move 'migrate_cancel' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 12 qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index c3b813f..158dcbd 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp-c

[Qemu-devel] [PATCH 10/30] qmp-commands: move 'migrate_set_downtime' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 15 --- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 158dcbd..b73bcac 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

[Qemu-devel] [PATCH 08/30] qmp-commands: move 'human-monitor-command' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 33 - qapi-schema.json | 17 ++--- 2 files changed, 14 insertions(+), 36 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 6d43415..c3b813f 100644 --- a/docs/

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/09/2016 17:46, Alistair Francis wrote: >>> > I know it's way too late for design questions, but the thought just >>> > occured to me: -device gives you what you need without defining yet >>> > another command line option (good!), but is it appropriate? It's not >>>

[Qemu-devel] [PATCH 11/30] qmp-commands: move 'migrate_set_speed' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 14 -- qapi-schema.json | 8 +++- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index b73bcac..9ef6ce1 100644 --- a/docs/qmp-commands.txt +++ b/docs/q

[Qemu-devel] [PATCH 14/30] qmp-commands: move 'expire_password' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 16 qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 724c3a9..0082101 100644 --- a/docs/qmp-commands.txt +++ b/docs/

[Qemu-devel] [PATCH 21/30] qmp-commands: move 'dump-guest-memory' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 30 -- qapi-schema.json | 8 2 files changed, 8 insertions(+), 30 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 0359516..0fc4cde 100644 --- a/docs/qmp-commands.

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 11:19, Markus Armbruster wrote: >> > I think -device is okay for something that isn't a "backend" but is >> > directly guest-visible. > Well, the contents of a block device is just as guest-visible. We split > the device in a frontend and a backend, and the contents comes from the

[Qemu-devel] [PATCH 19/30] qmp-commands: move 'xen-set-global-dirty-log' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 15 --- qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index cc90d57..dc7c2f11 100644 --- a/docs/qmp-commands.txt +++ b/docs/

[Qemu-devel] [PATCH 12/30] qmp-commands: move 'query-migrate-cache-size' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 13 - qapi-schema.json | 8 +++- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 9ef6ce1..b829dc1 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

[Qemu-devel] [PATCH 28/30] qmp-commands: move 'getfd' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 22 -- qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 03d8c54..37ff37d 100644 --- a/docs/qmp-commands.txt +++ b

[Qemu-devel] [PATCH 00/30] Move qapi documentation to schema (part 2/5)

2016-09-22 Thread Marc-André Lureau
Hi, The QAPI documentation is currently done in two places, the json schema and a more human-friendly text file. The goal is to avoid duplication and to generate friendly versions from the schema (pdf, man etc). Thus, all documentation should be moved to the schema. In order to facilitate the re

[Qemu-devel] [PATCH 22/30] qmp-commands: move 'query-dump-guest-memory-capability' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 11 --- qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 0fc4cde..b84446f 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp-c

[Qemu-devel] [PATCH 13/30] qmp-commands: move 'set_password' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 17 - qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index b829dc1..724c3a9 100644 --- a/docs/qmp-commands.txt +++ b/docs

[Qemu-devel] [PATCH 01/30] qmp-commands: move 'pmemsave' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 19 --- qapi-schema.json | 9 + 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 280e337..5a91d77 100644 --- a/docs/qmp-commands.txt +++ b/

[Qemu-devel] [PATCH 15/30] qmp-commands: move 'change' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 27 --- qapi-schema.json | 17 + 2 files changed, 17 insertions(+), 27 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 0082101..d5ad1de 100644 --- a/docs/qmp-co

[Qemu-devel] [PATCH 23/30] qmp-commands: move 'dump-skeys' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 14 -- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index b84446f..051bbfd 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp

[Qemu-devel] [PATCH 25/30] qmp-commands: move 'netdev_del' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 15 --- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index d41a60a..0bc2b1a 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

[Qemu-devel] [PATCH 06/30] qmp-commands: move 'balloon' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 14 -- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 18a15dc..dadcc20 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp

[Qemu-devel] [PATCH 16/30] qmp-commands: move 'migrate' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 24 qapi-schema.json | 16 2 files changed, 16 insertions(+), 24 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index d5ad1de..799ac72 100644 --- a/docs/qmp-comman

Re: [Qemu-devel] [Qemu-ppc] KVM-PR is broken with current QEMU

2016-09-22 Thread Anton Blanchard
Hi Thomas, > So if you like, I can try to come up with a small patch series that > cleans up this mess - and I could also include an updated versions of > Anton's patch there unless he wants to redo the changes on his own...? Thanks for looking at this. I'm travelling (stuck in an airport at the

[Qemu-devel] [PATCH 07/30] qmp-commands: move 'transaction' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 86 --- qapi-schema.json | 45 +++ 2 files changed, 45 insertions(+), 86 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index dadcc20

[Qemu-devel] [PATCH 18/30] qmp-commands: move 'xen-save-devices-state' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 18 -- qapi-schema.json | 8 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 32e5b0a..cc90d57 100644 --- a/docs/qmp-commands.txt +++ b/do

Re: [Qemu-devel] [RFC/PATCH 2] kvm: x86: handle KVM_SET_VCPU_EVENTS/KVM_VCPUEVENT_VALID_SMM properly

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 09:51, Herongguang (Stephen) wrote: > After making memory consistent between source and destination > (https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03069.html), > there can > still reproduce instruction emulation failure in destination side if > migration when VM’s in gr

[Qemu-devel] [PATCH 17/30] qmp-commands: move 'migrate-incoming' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 20 qapi-schema.json | 20 +--- 2 files changed, 17 insertions(+), 23 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 799ac72..32e5b0a 100644 --- a/docs/qmp-comman

[Qemu-devel] [PATCH 20/30] qmp-commands: move 'device_del' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 19 --- qapi-schema.json | 11 ++- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index dc7c2f11..0359516 100644 --- a/docs/qmp-commands.txt ++

[Qemu-devel] [PATCH 24/30] qmp-commands: move 'netdev_add' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 22 -- qapi-schema.json | 8 2 files changed, 8 insertions(+), 22 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 051bbfd..d41a60a 100644 --- a/docs/qmp-commands.txt +++

[Qemu-devel] [PATCH 30/30] qmp-commands: move 'add-fd' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 28 qapi-schema.json | 8 2 files changed, 8 insertions(+), 28 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 52bec44..93858b2 100644 --- a/docs/qmp-commands.tx

Re: [Qemu-devel] [PATCH] qmp: fix object-add assert() without props

2016-09-22 Thread Markus Armbruster
Marc-André Lureau writes: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.", because the qdict i

[Qemu-devel] [PATCH 26/30] qmp-commands: move 'object-add' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 17 - qapi-schema.json | 7 +++ 2 files changed, 7 insertions(+), 17 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 0bc2b1a..ff83ea2 100644 --- a/docs/qmp-commands.txt +++ b/docs

[Qemu-devel] [PATCH 27/30] qmp-commands: move 'object-del' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 15 --- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index ff83ea2..03d8c54 100644 --- a/docs/qmp-commands.txt +++ b/docs/qm

[Qemu-devel] [PATCH v2 1/9] ui/vnc-enc-tight: remove switch and have single return

2016-09-22 Thread Alex Bennée
When enabling the sanitizer build it will complain about control reaching a non-void function. Normally the compiler should detect that there is only one possible exit given a static VNC_SERVER_FB_BYTES. As we always expect a static VNC_SERVER_FB_BYTES I've added a compile time assert and just cal

[Qemu-devel] [PATCH v2 8/9] qga/command: use QEMU atomic primitives

2016-09-22 Thread Alex Bennée
The guest client's use of the glib's g_atomic primitives causes newer GCC's to barf when built on Travis. As QEMU has its own primitives with well understood semantics we might as well use them. The use of atomics was a little inconsistent so I've also ensure the values are correctly set with atom

[Qemu-devel] [PATCH 29/30] qmp-commands: move 'closefd' doc to schema

2016-09-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/qmp-commands.txt | 14 -- qapi-schema.json | 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt index 37ff37d..52bec44 100644 --- a/docs/qmp-commands.txt +++ b/docs/qmp

[Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?

2016-09-22 Thread Peter Maydell
This is clearly a bug, but your suggested change won't deal with the problem, which is that we're trying to set a bool so the ? 32 : 64 construct is just wrong. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Qemu-devel] [PATCH v2 9/9] .travis.yml: add gcc sanitizer build

2016-09-22 Thread Alex Bennée
As it seems easy to break the ThreadSanitizer build we should defend it to ensure that fixes get applied when it breaks. We use the Ubuntu GCC PPA to get the latest GCC goodness. As we need to use the -fuse-ld=gold work around we have to disable the linux-user targets as these trip up the linker.

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Dr. David Alan Gilbert
* Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > > > Hi, > > > > > > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > > > to newer QEMU-2.7

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: > Something like this works for KVM: > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > index 4820f22..1cf3779 100644 > --- a/target-ppc/machine.c > +++ b/target-ppc/machine.c > @@ -563,8 +563,8 @@ const VMStateDescription vms

Re: [Qemu-devel] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

2016-09-22 Thread Kevin Wolf
Am 21.09.2016 um 00:27 hat Eric Blake geschrieben: > On 09/20/2016 04:08 PM, Kevin Wolf wrote: > > The option whether or not to use a native AIO interface really isn't a > > generic option for all drivers, but only applies to the native file > > protocols. This patch moves the option in blockdev-ad

Re: [Qemu-devel] [Qemu-ppc] KVM-PR is broken with current QEMU

2016-09-22 Thread Cédric Le Goater
On 09/22/2016 09:18 AM, Thomas Huth wrote: > On Thu, 22 Sep 2016 07:30:52 +0200 > Thomas Huth wrote: > >> On Thu, 22 Sep 2016 11:57:15 +1000 >> David Gibson wrote: >> >>> On Wed, Sep 21, 2016 at 10:22:11AM +0200, Thomas Huth wrote: On 20.09.2016 16:39, Cédric Le Goater wrote: > On 09/20

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Nikunj A Dadhania
"Dr. David Alan Gilbert" writes: > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: >> On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: >> > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: >> > > Hi, >> > > >> > > Nikunj and I realized that migrating pseries-2.6 gu

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Dr. David Alan Gilbert
* Nikunj A Dadhania (nik...@linux.vnet.ibm.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > >> On Thu, Sep 22, 2016 at 03:30:08PM +1000, David Gibson wrote: > >> > On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > >> > > Hi,

[Qemu-devel] [PATCH v2 6/9] cpu: atomically modify cpu->exit_request

2016-09-22 Thread Alex Bennée
ThreadSanitizer picks up potential races although we already use barriers to ensure things are in the correct order when processing exit requests. For now we just use the relaxed atomic_set/atomic_read semantics to reassure tsan that we can't tear the value. Signed-off-by: Alex Bennée --- cpu-ex

[Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2016-09-22 Thread P J P
From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in bd.flags. Set an upper lim

[Qemu-devel] [PATCH v2 0/9] A couple of fixes for ThreadSanitizer

2016-09-22 Thread Alex Bennée
Hi, This is v2 of the ThreadSanitizer fixes. Changes from the last version: - added Marc-André's review tags - added qga/command: use QEMU atomic primitives - simplified ui/vnc-enc-tight: remove switch and have single return - fixed the Travis CI build (that was painful) There is sti

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Alexey Kardashevskiy
On 22/09/16 19:04, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > >> On Thu, 2016-09-22 at 11:45 +0530, Bharata B Rao wrote: >>> On Thu, Sep 22, 2016 at 04:07:21PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2016-09-22 at 10:51 +0530, Bharata B Rao wrote: > > The f

Re: [Qemu-devel] [PATCH v2] net: imx: limit buffer descriptor count

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 12:31, P J P wrote: > From: Prasad J Pandit > > i.MX Fast Ethernet Controller uses buffer descriptors to manage > data flow to/fro receive & transmit queues. While transmitting > packets, it could continue to read buffer descriptors if a buffer > descriptor has length of zero and

[Qemu-devel] [PATCH v2 2/9] tcg/optimize: move default return out of if statement

2016-09-22 Thread Alex Bennée
This is to appease sanitizer builds which complain that: "error: control reaches end of non-void function" Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau --- tcg/optimize.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[Qemu-devel] [PATCH v2] net: mcf: limit buffer descriptor count

2016-09-22 Thread P J P
From: Prasad J Pandit ColdFire Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in bd.flags. Set upper li

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 12:04, Benjamin Herrenschmidt wrote: > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >> Something like this works for KVM: >> >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >> index 4820f22..1cf3779 100644 >> --- a/target-ppc/machine.c >> +++ b/target-ppc/

[Qemu-devel] [PATCH v2 3/9] new: blacklist.tsan

2016-09-22 Thread Alex Bennée
A list of blacklists for tsan instrumentation. One hopes more can be removed over time as tsan improves. The path needs to be absolute so it doesn't break when directories change during the build: ./configure --with-coroutine=gthread --disable-pie \ --extra-cflags="-g3 -O0 -fsanitize=thread

[Qemu-devel] [PATCH v2 5/9] qom/object: update class cache atomically

2016-09-22 Thread Alex Bennée
The idiom CPU_GET_CLASS(cpu) is fairly extensively used in various threads and trips of ThreadSanitizer due to the fact it updates obj->class->object_cast_cache behind the scenes. As this is just a fast-path cache there is no need to lock updates just ensure that we don't get torn-updates from two

[Qemu-devel] [PATCH v2 7/9] util/qht: atomically set b->hashes

2016-09-22 Thread Alex Bennée
ThreadSanitizer detects a possible race between reading/writing the hashes. As ordering semantics are already documented for qht we just need to ensure a race can't tear the hash value so we can use the relaxed atomic_set/read functions. Signed-off-by: Alex Bennée --- util/qht.c | 10 +-

[Qemu-devel] [PATCH v2 4/9] seqlock: use atomic writes for the sequence

2016-09-22 Thread Alex Bennée
From: Paolo Bonzini There is a data race if the sequence is written concurrently to the read. In C11 this has undefined behavior. Use atomic_set; the read side is already using atomic_read. Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Alex Bennée --- include/qemu/se

Re: [Qemu-devel] [PATCH v2] net: mcf: limit buffer descriptor count

2016-09-22 Thread Paolo Bonzini
On 22/09/2016 12:32, P J P wrote: > From: Prasad J Pandit > > ColdFire Fast Ethernet Controller uses buffer descriptors to manage > data flow to/fro receive & transmit queues. While transmitting > packets, it could continue to read buffer descriptors if a buffer > descriptor has length of zero

Re: [Qemu-devel] [PATCH 1/3] qapi: return a 'missing parameter' error

2016-09-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Aha, we got a different bug fix! The old code fails to fail when the >> parameter doesn't exist. Instead, it sets *obj = NULL, which seems very >> likely to crash QEMU. Let me try... yup: >> >> { "execute": "object-add", >

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >> Something like this works for KVM: >> >> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >> index 4820f22..1cf3779 100644 >> --- a/target-ppc/machine.c >> +++ b/target-ppc/machine.c >> @@ -56

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 20:34 +1000, Alexey Kardashevskiy wrote: > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > > index 4820f22..1cf3779 100644 > > --- a/target-ppc/machine.c > > +++ b/target-ppc/machine.c > > @@ -563,8 +563,8 @@ const VMStateDescription vmstate_ppc_cpu = { > >   > > 

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: >> Don't make up a description in user_creatable_help_func(), improve the >> description infrastructure and its use so you get more useful ones >> there. >> >> The existing description infrastructur

Re: [Qemu-devel] [PATCH] tcg update

2016-09-22 Thread Peter Maydell
On 20 September 2016 at 19:57, Richard Henderson wrote: > Annoying that a bug that Peter reported for aarch64 is also > visible on x86_64. Reported for a ppc64 target, it takes > a while to trigger the bug. > > > r~ > > > > The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda5

Re: [Qemu-devel] [PATCH] pci-testdev: enhance to support new testcases

2016-09-22 Thread Andrew Jones
On Thu, Sep 22, 2016 at 02:15:08PM +0800, Peter Xu wrote: > pci-testdev is used mostly in kvm-unit-test for some eventfd tests. > However I see it a good framework for other tests as well (e.g., the > IOMMU unit test in the future). So enhanced it to support more > testcases. > > The original memo

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Nikunj A Dadhania
"Dr. David Alan Gilbert" writes: >> > You might find the first two patches in: >> >https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03681.html >> > useful in debugging this; it prints the values when the _EQUAL macros fail >> > and prints >> > the field name that fails. >> >> Thanks,

Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema

2016-09-22 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> On 09/13/2016 08:01 AM, Marc-André Lureau wrote: >> >> > Signed-off-by: Marc-André Lureau >> >> > --- >> >> > docs/qmp-commands.txt | 29 ---

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Cédric Le Goater
On 09/22/2016 01:07 PM, Nikunj A Dadhania wrote: > Benjamin Herrenschmidt writes: > >> On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote: >>> Something like this works for KVM: >>> >>> diff --git a/target-ppc/machine.c b/target-ppc/machine.c >>> index 4820f22..1cf3779 100644 >>> --- a/ta

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 01:12:22PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: > >> Don't make up a description in user_creatable_help_func(), improve the > >> description infrastructure and its use so you

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-22 Thread Pradeep Jagadeesh
Hi Alberto, On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { }, { .name

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 12:32 +0200, Paolo Bonzini wrote: > *However* a better fix would be to preserve the old flags for > pseries-2.6, and only set the newer flags for pseries-2.7.  I'm not > saying you have to do this, but if it's not hard (no idea) why not learn > how to do it right. > > The des

Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken

2016-09-22 Thread Benjamin Herrenschmidt
On Thu, 2016-09-22 at 13:27 +0200, Cédric Le Goater wrote: > > TCG migration succeeds and proceeds ahead. But fails somewhere > > ahead in > > powerpc exception handler: > > > > [qemu]$ ./ppc64-softmmu/qemu-system-ppc64  -machine pseries- > > 2.6,usb=off -vga none -nographic -m 2G   ../../imgs/gu

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-22 Thread Pradeep Jagadeesh
Hi Greg, On Wed, 21 Sep 2016 12:22:25 +0200 Pradeep Jagadeesh wrote: Hi Greg, Thanks for having a look at patchset. See the replies below. On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev device

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/09/2016 11:19, Markus Armbruster wrote: >>> > I think -device is okay for something that isn't a "backend" but is >>> > directly guest-visible. >> Well, the contents of a block device is just as guest-visible. We split >> the device in a frontend and a backend, and

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result

2016-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote: >> On 09/21/2016 10:28 AM, Markus Armbruster wrote: >> >> >> The compiler.h file has no license header, just a comment >> >> saying "public domain", which is obviously not the case >> >> if you add this ma

Re: [Qemu-devel] [PATCH] checkpatch: downgrade "architecture specific defines should be avoided"

2016-09-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/09/2016 09:12, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> --- >>> scripts/checkpatch.pl | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >>> index dde3f5f..3afa19a 100755 >>>

Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema

2016-09-22 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > - Original Message - > >> >> On 09/13/2016 08:01 AM, Marc-André Lureau wrote: > >> >> > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 1/1] qom: fix qdict visit in user_creatable_add_type

2016-09-22 Thread Markus Armbruster
Xiao Long Jiang writes: > This fixes a Qemu crash that introduced by commit ad73970 > ("qom: Wrap prop visit in visit_start_struct"). > > Not all of the callers of user_creatable_add_type always pass qdict, > so we should check qdict against NULL, but not raise an assertion. > > The problem can b

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-09-22 Thread Stefan Hajnoczi
On Sun, Sep 04, 2016 at 11:38:58PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next bo

[Qemu-devel] [PATCH v4] fsdev: add IO throttle support to fsdev devices

2016-09-22 Thread Pradeep Jagadeesh
Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which use 9p-local driver. Signed-off-by: Pradeep Jagadeesh --- fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 +++ fsdev/qemu-fsd

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 22, 2016 at 01:12:22PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: >> >> Don't make up a description in user_creatable_help_func(), improve the >> >> descrip

[Qemu-devel] [PATCH v2] Avoid additional GET_FEATURES call on vhost-user

2016-09-22 Thread Felipe Franciosi
Vhost-user requires an early GET_FEATURES call to determine if the slave supports protocol feature negotiation. An extra GET_FEATURES call is made after vhost_backend_init() to actually set the device features. This patch moves the actual setting of the device features to both implementations (ker

[Qemu-devel] [PULL 03/26] linux-user: Allow bad msg_name for recvfrom on connected socket

2016-09-22 Thread riku . voipio
From: Peter Maydell The POSIX standard mandates that for a connected socket recvfrom() must ignore the msg_name and msg_namelen fields. This is awkward for QEMU because we will attempt to copy them from guest address space. Handle this by not immediately returning a TARGET_EFAULT if the copy fail

[Qemu-devel] [PULL 00/26] linux-user update

2016-09-22 Thread riku . voipio
From: Riku Voipio The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git tags/pull-linux-user-20160915 for you

[Qemu-devel] [PULL 04/26] linux-user: Implement FS_IOC_GETFLAGS and FS_IOC_SETFLAGS ioctls

2016-09-22 Thread riku . voipio
From: Peter Maydell Implement the FS_IOC_GETFLAGS and FS_IOC_SETFLAGS ioctls, as used by chattr. Note that the type information encoded in these ioctl numbers is at odds with the actual type the kernel accesses, as discussed in http://thread.gmane.org/gmane.linux.file-systems/80164. Signed-off-

[Qemu-devel] [PULL 15/26] linux-user: Use correct target SHMLBA in shmat()

2016-09-22 Thread riku . voipio
From: Peter Maydell The shmat() handling needs to do target-specific handling of the attach address for shmat(): * if the SHM_RND flag is passed, the address is rounded down to a SHMLBA boundary * if SHM_RND is not passed, then the call is failed EINVAL if the address is not a multiple of

[Qemu-devel] [PULL 08/26] linux-user: report signals being taken in strace output

2016-09-22 Thread riku . voipio
From: Peter Maydell Native strace reports when the process being traced takes a signal: --- SIGSEGV {si_signo=SIGSEGV, si_code=SI_KERNEL, si_addr=0} --- Report something similar when QEMU is doing its internal strace of the guest process and is about to deliver it a signal. Signed-off-by: Pe

[Qemu-devel] [PULL 05/26] linux-user: Use direct syscall for utimensat

2016-09-22 Thread riku . voipio
From: Peter Maydell The linux utimensat syscall differs in semantics from the libc function because the syscall combines the features of utimensat() and futimens(). Rather than trying to split these apart in order to call the two libc functions which then call the same underlying syscall, just al

[Qemu-devel] [PULL 11/26] linux-user: Fix incorrect use of host errno in do_ioctl_dm()

2016-09-22 Thread riku . voipio
From: Peter Maydell do_ioctl_dm() should return target errno values, not host ones; correct an accidental use of a host errno in an error path. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PULL 02/26] linux-user: Fix errno for sendrecvmsg with large iovec length

2016-09-22 Thread riku . voipio
From: Peter Maydell The sendmsg and recvmsg syscalls use a different errno to indicate an overlarge iovec length from readv and writev. Handle this special case in do_sendrcvmsg_locked() to avoid getting the default errno returned by lock_iovec(). Signed-off-by: Peter Maydell Signed-off-by: Rik

[Qemu-devel] [PULL 06/26] linux-user: Check for bad event numbers in epoll_wait

2016-09-22 Thread riku . voipio
From: Peter Maydell The kernel checks that the maxevents parameter to epoll_wait is non-negative and not larger than EP_MAX_EVENTS. Add this check to our implementation, so that: * we fail these cases EINVAL rather than EFAULT * we don't pass negative or overflowing values to the lock_user()

[Qemu-devel] [PULL 09/26] linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call

2016-09-22 Thread riku . voipio
From: Peter Maydell A target_mmap() call in load_elf_binary() was missing the MAP_ANONYMOUS flag. (Spotted by Coverity, because target_mmap() will try to use -1 as the filedescriptor in this case.) This has never been noticed because the code in question is for handling ancient SVr4 iBCS2 binari

[Qemu-devel] [PULL 01/26] linux-user: Fix handling of iovec counts

2016-09-22 Thread riku . voipio
From: Peter Maydell In the kernel the length of an iovec is generally handled as an unsigned long, not an integer; fix the parameter to lock_iovec() accordingly. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 8 1 file changed, 4 insertions(+), 4 d

<    1   2   3   4   5   6   7   >