[Qemu-devel] [PATCH] MAINTAINERS: Add usermode related config files

2016-09-30 Thread Thomas Huth
The default-configs/*-linux-user.mak belong to Linux usermode emulation, and default-configs/*-bsd-user.mak belong to BSD usermode emulation. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error and fix callers to check it

2016-09-30 Thread Cao jin
On 09/30/2016 03:01 PM, Markus Armbruster wrote: Cao jin writes: On 09/29/2016 10:17 PM, Markus Armbruster wrote: Intentional change? I like the old one better. Oh...it was lost by me. I was planning move these comments into a separate patch, but later feel

Re: [Qemu-devel] [PATCH v3 6/8] megasas: remove unnecessary megasas_use_msix()

2016-09-30 Thread Cao jin
On 09/29/2016 10:35 PM, Markus Armbruster wrote: Cao jin writes: @@ -2349,7 +2342,7 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp) memory_region_init_io(>mmio_io, OBJECT(s), _mmio_ops, s, "megasas-mmio",

Re: [Qemu-devel] [PATCH 2/2] net: pcnet: fix source formatting and indentation

2016-09-30 Thread P J P
+-- On Fri, 30 Sep 2016, Jason Wang wrote --+ | Thanks but there're still several other places that needs to be fixed were | reported by robot. | | Please fix them too. Done. Sent a revised patch v2. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053

Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-09-30 Thread Cao jin
On 09/29/2016 10:42 PM, Markus Armbruster wrote: Cao jin writes: static int vmxnet3_post_load(void *opaque, int version_id) { VMXNET3State *s = opaque; -PCIDevice *d = PCI_DEVICE(s); net_tx_pkt_init(>tx_pkt, PCI_DEVICE(s),

[Qemu-devel] [PATCH] target-arm: kvm: use AddressSpace-specific listener

2016-09-30 Thread Paolo Bonzini
The only address space where the GIC devices are added is address_space_memory. There is no need to use a global MemoryListener. This removes the only user of global MemoryListeners. Signed-off-by: Paolo Bonzini --- target-arm/kvm.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v2] net: pcnet: fix source formatting and indentation

2016-09-30 Thread P J P
From: Prasad J Pandit Fix indentations and source format at few places. Add braces around 'if' and 'while' statements. Signed-off-by: Prasad J Pandit --- hw/net/pcnet.c | 130 + 1 file

Re: [Qemu-devel] [PATCH v4 05/11] target-i386: Remove underscores from property names

2016-09-30 Thread Jiri Denemark
On Thu, Sep 29, 2016 at 18:14:53 -0300, Eduardo Habkost wrote: > Instead of translating the feature name entries when adding > property names, store the actual property names in the feature > name array. > > Signed-off-by: Eduardo Habkost > --- > Changes series v3 -> v4: > *

Re: [Qemu-devel] [PATCH v4 09/11] target-i386: x86_cpu_load_features() function

2016-09-30 Thread Paolo Bonzini
On 29/09/2016 23:14, Eduardo Habkost wrote: > +/* Load CPUID data based on configureured features > + */ Typo ("configureured") and also unnecessarily breaking the comment on two lines. Paolo > +static void x86_cpu_load_features(X86CPU *cpu, Error **errp)

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Laurent Vivier
On 30/09/2016 03:27, David Gibson wrote: > On Thu, Sep 29, 2016 at 07:15:05PM +0200, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier > > This could do with a commit message, even if it's just to say that > this is supposed to be a refactor without behavioural change.

Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices between source and distination at the begining

2016-09-30 Thread Li Zhijian
On 09/30/2016 02:15 PM, Amit Shah wrote: Hi, On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote: Priviously, if the source and distination have different devices, source could goto the status "paused (postmigrate)", and the distination will exit that means no qemu is alive. After this

Re: [Qemu-devel] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-30 Thread Paolo Bonzini
On 29/09/2016 23:14, Eduardo Habkost wrote: > +/* Return the feature property name for a feature flag bit */ > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > +{ > +/* XSAVE components are automatically enabled by other features, > + * so return the original feature

Re: [Qemu-devel] [PATCH v3 3/8] pci: Convert msix_init() to Error and fix callers to check it

2016-09-30 Thread Markus Armbruster
Cao jin writes: > On 09/29/2016 10:17 PM, Markus Armbruster wrote: >> Cao jin writes: >> > >>> >>> -/* Initialize the MSI-X structures */ >>> +/* Make PCI device @dev MSI-X capable >>> + * @nentries is the max number of MSI-X vectors that the

[Qemu-devel] [PATCH] MAINTAINERS: Add some more MIPS related files

2016-09-30 Thread Thomas Huth
The MIPS section is missing some related header files, and files in the hw/misc/, hw/intc/ and hw/timer/ folders. Signed-off-by: Thomas Huth --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 977e96e..4e86539 100644 ---

Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices between source and distination at the begining

2016-09-30 Thread Amit Shah
Hi, On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote: > Priviously, if the source and distination have different devices, source > could goto > the status "paused (postmigrate)", and the distination will exit that means > no qemu > is alive. > > After this patch, at above case, source can

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-09-30 Thread Hailiang Zhang
On 2016/9/30 13:53, Amit Shah wrote: On (Thu) 29 Sep 2016 [16:46:20], zhanghailiang wrote: This is the 20th version of COLO frame series. COLO Block replication and proxy (COLO compare) series are both been merged into upstream already. And further works can be done now to realize the full

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] tests: enable virtio tests on SPAPR

2016-09-30 Thread Laurent Vivier
On 30/09/2016 03:30, David Gibson wrote: > On Thu, Sep 29, 2016 at 07:15:07PM +0200, Laurent Vivier wrote: >> but disable MSI-X tests on SPAPR as we can't check the result >> (the memory region used on PC is not readable on SPAPR). >> >> Signed-off-by: Laurent Vivier >> ---

Re: [Qemu-devel] [PATCH v3 6/8] megasas: remove unnecessary megasas_use_msix()

2016-09-30 Thread Markus Armbruster
Cao jin writes: > On 09/29/2016 10:35 PM, Markus Armbruster wrote: >> Cao jin writes: >> > >>> >>> @@ -2349,7 +2342,7 @@ static void megasas_scsi_realize(PCIDevice *dev, >>> Error **errp) >>> >>> memory_region_init_io(>mmio_io,

Re: [Qemu-devel] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

2016-09-30 Thread Paolo Bonzini
On 29/09/2016 23:14, Eduardo Habkost wrote: > + * "-foo" overrides "+foo" > + * "[+-]foo" overrides "foo=..." Is this something that people are actually using? Can we detect it and deprecate it in 2.8, and drop it in 2.9? Paolo > + * "foo_bar" should be translated to "foo-bar"

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Greg Kurz
On Thu, 29 Sep 2016 19:15:05 +0200 Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > tests/virtio-9p-test.c | 53 > tests/virtio-blk-test.c | 154 > +-- >

Re: [Qemu-devel] [PATCH v2] block: modify top-id's comments

2016-09-30 Thread Kevin Wolf
This is v2, should be included in the subject line. Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben: > Kevin Wolf's advice: > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie

Re: [Qemu-devel] [PATCH v2] block: modify top-id's comments

2016-09-30 Thread wangweiwei
Ok,thanks. On 09/30/2016 05:52 PM, Kevin Wolf wrote: This is v2, should be included in the subject line. Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben: Kevin Wolf's advice: http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH v3 1/3] qapi: add assert about root value

2016-09-30 Thread Marc-André Lureau
qiv->root should not be null, make that clearer with some assert. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qapi/qmp-input-visitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/qmp-input-visitor.c

[Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of iss_sf in disas_ld_lit

2016-09-30 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix the decoding of iss_sf in disas_ld_lit. The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome) is a bit that specifies the width of the register that the instruction loads to. If cleared it specifies 32 bits. If set it

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Laurent Vivier
On 30/09/2016 12:29, Greg Kurz wrote: > On Fri, 30 Sep 2016 11:13:33 +0200 > Laurent Vivier wrote: > >> On 30/09/2016 10:33, Greg Kurz wrote: >>> On Thu, 29 Sep 2016 19:15:05 +0200 >>> Laurent Vivier wrote: >>> [...] static void

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Greg Kurz
On Fri, 30 Sep 2016 11:13:33 +0200 Laurent Vivier wrote: > On 30/09/2016 10:33, Greg Kurz wrote: > > On Thu, 29 Sep 2016 19:15:05 +0200 > > Laurent Vivier wrote: > > > >> [...] > >> static void pci_nop(void) > >> { > >> -qvirtio_9p_start(); > >>

Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of iss_sf in disas_ld_lit

2016-09-30 Thread Edgar E. Iglesias
On Fri, Sep 30, 2016 at 12:42:27PM +0200, Thomas Huth wrote: > On 30.09.2016 12:19, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Fix the decoding of iss_sf in disas_ld_lit. > > The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome) > >

[Qemu-devel] [PATCH v7 00/22] qcow2: persistent dirty bitmaps

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
v7: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7 based on block-next (https://github.com/XanClic/qemu/commits/block-next) - a lot of refactoring and reordering of patches. - dead code removed (bdrv_dirty_bitmap_load, etc.) - do not maintain extra data

[Qemu-devel] [PATCH 15/22] qcow2-bitmap: add autoclear bit

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Add autoclear bit for handling rewriting image by old qemu version. If autoclear bit is not set, but bitmaps extension is found it would not be loaded and warning will be generated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 4

Re: [Qemu-devel] [PATCH 2/2] migration/postcopy: Explicitly disallow huge pages

2016-09-30 Thread Daniel P. Berrange
On Thu, Sep 29, 2016 at 08:09:38PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > At the moment postcopy will fail as soon as qemu tries to register > userfault on the RAMBlock pages that are backed by hugepages. > However, the kernel is

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-30 Thread Peter Lieven
Am 28.09.2016 um 21:52 schrieb Michael Roth: Quoting Peter Lieven (2016-09-27 06:30:27) Am 27.09.2016 um 12:28 schrieb Peter Lieven: Am 16.09.2016 um 15:56 schrieb Peter Lieven: Am 13.09.2016 um 20:04 schrieb Michael Roth: Quoting Peter Lieven (2016-09-13 10:52:04)

[Qemu-devel] [PATCH v3 0/3] qapi: return 'missing parameter' error

2016-09-30 Thread Marc-André Lureau
Hi, 'monitor: use qmp_dispatch()' patch broke some iotests expecting a 'missing parameter' error. This series fixes qapi visitors to return this error for all types. This series should go on top of: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg05949.html v3: - merge patch 4 (iotest

Re: [Qemu-devel] [PATCH 3/3] virtio-serial: add missing virtio_detach_element() call

2016-09-30 Thread Ladi Prosek
On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi wrote: > Ports enter a "throttled" state when writing to the chardev would block. > The current output VirtQueueElement is kept around until the chardev > becomes writable again. > > There are several places in the

Re: [Qemu-devel] [PATCH v4] hw/misc: Add simple measurement hardware

2016-09-30 Thread Dr. David Alan Gilbert
* Matthew Garrett (mj...@coreos.com) wrote: > Trusted Boot is based around having a trusted store of measurement data and > a secure communications channel between that store and an attestation > target. In actual hardware, that's a TPM. Since the TPM can only be accessed > via the host system,

[Qemu-devel] [PATCH 02/22] tests: add hbitmap iter test

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap.c

Re: [Qemu-devel] [PATCH 3/3] tests: enable virtio tests on SPAPR

2016-09-30 Thread Greg Kurz
On Fri, 30 Sep 2016 12:30:08 +0200 Laurent Vivier wrote: > On 30/09/2016 12:18, Greg Kurz wrote: > > On Thu, 29 Sep 2016 19:15:07 +0200 > > Laurent Vivier wrote: > > > >> but disable MSI-X tests on SPAPR as we can't check the result > >> (the memory

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-09-30 Thread Chunguang Li
> -原始邮件- > 发件人: "Amit Shah" > 发送时间: 2016年9月30日 星期五 > 收件人: "Chunguang Li" > 抄送: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, > pbonz...@redhat.com, stefa...@redhat.com, quint...@redhat.com > 主题: Re: Re:

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Laurent Vivier
On 30/09/2016 10:33, Greg Kurz wrote: > On Thu, 29 Sep 2016 19:15:05 +0200 > Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier >> --- >> tests/virtio-9p-test.c | 53 >> tests/virtio-blk-test.c | 154 >>

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread Kashyap Chamarthy
On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote: > Kevin Wolf's advice: > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html IIUC, what Stefan meant is to write a simple descriptive commit message that explains why this change is necessary -- the above URL might have

Re: [Qemu-devel] [PATCH 3/3] tests: enable virtio tests on SPAPR

2016-09-30 Thread Laurent Vivier
On 30/09/2016 12:18, Greg Kurz wrote: > On Thu, 29 Sep 2016 19:15:07 +0200 > Laurent Vivier wrote: > >> but disable MSI-X tests on SPAPR as we can't check the result >> (the memory region used on PC is not readable on SPAPR). >> >> Signed-off-by: Laurent Vivier

[Qemu-devel] [PULL 4/8] s390x/kvm: Fix potential deadlock in sigp handling

2016-09-30 Thread Christian Borntraeger
If two VCPUs exit at the same time and target each other with a sigp, both could run into a deadlock as run_on_cpu on CPU0 will free the BQL when starting the CPU1 target routine. CPU1 will run its sigp initiater for CPU0 before handling the run_on_cpu requests, thus resulting in a dead lock. As

[Qemu-devel] [PATCH 01/22] hbitmap: improve dirty iter

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/hbitmap.h | 24 ++-- util/hbitmap.c | 23 ++- 2 files changed, 24 insertions(+), 23

[Qemu-devel] [PATCH 06/22] qcow2: add dirty bitmaps extension

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Add dirty bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

2016-09-30 Thread Jiri Denemark
On Fri, Sep 30, 2016 at 09:55:33 +0200, Paolo Bonzini wrote: > > > On 29/09/2016 23:14, Eduardo Habkost wrote: > > + * "-foo" overrides "+foo" > > + * "[+-]foo" overrides "foo=..." > > Is this something that people are actually using? Can we detect it and > deprecate it in 2.8, and

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread wangweiwei
Ok, I'wll wrap it. On 09/29/2016 09:35 PM, Eric Blake wrote: On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: Please send a proper commit message and commit description. "modify top-id's comments" says almost nothing and there is no

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-30 Thread Stefan Hajnoczi
On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git The QEMU block driver should deal with

[Qemu-devel] [PATCH] MAINTAINERS: Some updates related to the SH4 machines

2016-09-30 Thread Thomas Huth
hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to the R2D machine, as far as I can see. And concerning the Shix machine, it does not make much sense to have a "M:" entry here and the "S:" set to "Orphan". So I'd like to suggest to use "Odd Fixes" here instead. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH v3 3/3] qapi: return a 'missing parameter' error

2016-09-30 Thread Marc-André Lureau
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing parameters, but the qapi qmp_dispatch() code uses QERR_INVALID_PARAMETER_TYPE. Improve qapi code to return QERR_MISSING_PARAMETER where appropriate. Fix expected error message in iotests. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 3/3] tests: enable virtio tests on SPAPR

2016-09-30 Thread Greg Kurz
On Thu, 29 Sep 2016 19:15:07 +0200 Laurent Vivier wrote: > but disable MSI-X tests on SPAPR as we can't check the result > (the memory region used on PC is not readable on SPAPR). > > Signed-off-by: Laurent Vivier > --- > tests/Makefile.include| 3

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Greg Kurz
On Fri, 30 Sep 2016 11:56:50 +0200 Laurent Vivier wrote: > On 30/09/2016 10:33, Greg Kurz wrote: > > On Thu, 29 Sep 2016 19:15:05 +0200 > > Laurent Vivier wrote: > ... > >> @@ -230,9 +227,6 @@ static void test_unaligned_write_same(void) > >>

[Qemu-devel] [PULL 7/8] s390x/css: {c, h, t, r, x}sch: require enable AND device number valid

2016-09-30 Thread Christian Borntraeger
From: Sascha Silbe According to the PoP, subchannels are only considered operational if they are enabled _and_ the device number is valid. With the current checks being enabled _or_ having a valid device number was sufficient. This caused qemu to allow IO on subchannels

[Qemu-devel] [PULL 6/8] pc-bios/s390-ccw.img: rebuild image

2016-09-30 Thread Christian Borntraeger
Contains: - pc-bios/s390-ccw: enable subchannel for IPL I/O devices Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 26440 -> 26392 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index

[Qemu-devel] [PATCH 21/22] specs/qcow2: fix bitmap granularity qemu-specific note

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0..d3e292f 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt @@

Re: [Qemu-devel] [PULL 0/2] target-mips queue

2016-09-30 Thread Yongbok Kim
> > Your GPG key hasn't been signed by anybody -- are you in a position > to get it signed by somebody else who can in-person verify your identity > (eg Leon)? > > thanks > -- PMM > Hi Peter, We have just arranged the key signing and Leon has signed my key. Thanks, Yongbok

Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices between source and distination at the begining

2016-09-30 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 09/30/2016 02:15 PM, Amit Shah wrote: > > Hi, > > > > On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote: > > > Priviously, if the source and distination have different devices, source > > > could goto > > > the status "paused

[Qemu-devel] [PULL 0/8] next patches for s390x/kvm

2016-09-30 Thread Christian Borntraeger
Peter, The following changes since commit 25930ed60aad49f1fdd7de05272317c86ce1275b: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-09-27 23:10:12 +0100) are available in the git repository at: git://github.com/borntraeger/qemu.git

Re: [Qemu-devel] [RFC 0/4] QOM class properties - do we need them?

2016-09-30 Thread Daniel P. Berrange
On Fri, Sep 30, 2016 at 09:33:20AM +1000, David Gibson wrote: > On Thu, Sep 29, 2016 at 09:14:16AM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 29, 2016 at 10:16:41AM +1000, David Gibson wrote: > > > QOM has the concept of both "object class" properties and "object > > > instance" properties.

[Qemu-devel] [PATCH] block: modify top-id's comments

2016-09-30 Thread Wang WeiWei
Kevin Wolf's advice: http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH 1/3] tests: use qtest_pc_boot()/qtest_pc_shutdown() in virtio tests

2016-09-30 Thread Laurent Vivier
On 30/09/2016 10:33, Greg Kurz wrote: > On Thu, 29 Sep 2016 19:15:05 +0200 > Laurent Vivier wrote: ... >> @@ -230,9 +227,6 @@ static void test_unaligned_write_same(void) >> 0x41, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x33, 0x00, 0x00 >> }; >> >> -

[Qemu-devel] [PATCH v3 2/3] qapi: assert list entry has a value

2016-09-30 Thread Marc-André Lureau
This helps to figure out the expectations. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qapi/qmp-input-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index

Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?

2016-09-30 Thread Edgar E. Iglesias
On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote: > On 22 September 2016 at 02:53, Peter Maydell wrote: > > This is clearly a bug, but your suggested change won't deal with the > > problem, which is that we're trying to set a bool so the ? 32 : 64 > >

[Qemu-devel] [PATCH 1/1] target-i386: Correct family/model/stepping for Opteron_G3 (2350)

2016-09-30 Thread Denis V. Lunev
From: Evgeny Yakovlev Current CPU definition for AMD Opteron third generation includes features like SSE4a and LAHF_LM support in emulated CPUID. These features are present in K8 rev.E or K10 CPUs and later. However, current G3 family and model describe 2nd generation K8

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] tests: enable virtio tests on SPAPR

2016-09-30 Thread David Gibson
On Fri, Sep 30, 2016 at 08:59:39AM +0200, Laurent Vivier wrote: > > > On 30/09/2016 03:30, David Gibson wrote: > > On Thu, Sep 29, 2016 at 07:15:07PM +0200, Laurent Vivier wrote: > >> but disable MSI-X tests on SPAPR as we can't check the result > >> (the memory region used on PC is not readable

Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of iss_sf in disas_ld_lit

2016-09-30 Thread Thomas Huth
On 30.09.2016 12:19, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Fix the decoding of iss_sf in disas_ld_lit. > The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome) > is a bit that specifies the width of the register that the > instruction

[Qemu-devel] [PULL 3/8] s390x/pci: code cleanup

2016-09-30 Thread Christian Borntraeger
From: Yi Min Zhao Now that each S390 PCI device uses an IO region as MSIX region. The code in s390_translate_iommu() will never be triggered. Let's remove it. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel

[Qemu-devel] [PULL 1/8] s390x/pci: re-arrange variable declarations

2016-09-30 Thread Christian Borntraeger
From: Pierre Morel Pull mr variable declarations at the top of the functions instead of mixing them up with the code. This is in preparation for followup patches. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 5/8] pc-bios/s390-ccw: enable subchannel for IPL I/O devices

2016-09-30 Thread Christian Borntraeger
From: Dong Jia Shi IPL should cause the IPL I/O device to become enabled. So when handling the IPL program, we should set the E (Enable) bit. However, virtio-ccw does not know whether it's dealing with an IPL device or not. Since trying to perform I/O on a disabled

[Qemu-devel] [PULL 2/8] s390x/pci: assign msix io region for each pci device

2016-09-30 Thread Christian Borntraeger
From: Yi Min Zhao For efficiency we now assign one msix io region for each pci device and provide it with the pointer to the zPCI device as opaque parameter. In addition, we remove msix address space and add msix io region as a subregion to the root memory region of

[Qemu-devel] [PULL 8/8] s390x/kvm: fix build against qemu_uuid

2016-09-30 Thread Christian Borntraeger
commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most users of qemu_uuid but not all. Fix a build error on s390/kvm. Reviewed-by: Fam Zheng Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 14/22] qcow2: delete bitmaps on truncate

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
This will not touch loaded bitmaps, as they are alredy removed from the image. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 38 ++ block/qcow2.c| 9 ++--- block/qcow2.h| 2 ++ 3 files

[Qemu-devel] [PATCH 16/22] qmp: add persistent flag to block-dirty-bitmap-add

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev --- blockdev.c | 12 +++- qapi/block-core.json | 7 ++-

Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments

2016-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 11:48:44AM +0200, Kashyap Chamarthy wrote: > On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote: > > Kevin Wolf's advice: > > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html > > IIUC, what Stefan meant is to write a simple descriptive commit

[Qemu-devel] [PATCH 19/22] iotests: test qcow2 persistent dirty bitmap

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/165 | 87 ++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 93 insertions(+) create mode 100755

[Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 241 +++ block/qcow2.c| 2 + block/qcow2.h|

[Qemu-devel] [PATCH 10/22] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 0314581..392d660 100644 ---

[Qemu-devel] [Bug 1629282] [NEW] QEMU (still) hangs on Windows 7 install

2016-09-30 Thread Mary Sherman
Public bug reported: I'm trying to install Windows 7 as guest, but the machine still hangs (more precisely, the windows icon keeps flashing, but never goes past this stage). I think this is a different bug from https://bugs.launchpad.net/qemu/+bug/1581936. Specifically, its happens when the

[Qemu-devel] [PATCH v8 21/36] qemu-iotests: 091: Prepare for image lock

2016-09-30 Thread Fam Zheng
We should wait for the QEMU process to terminate and close the image before we check the data. Also use shared lock in migration source and target. Signed-off-by: Fam Zheng --- tests/qemu-iotests/091 | 9 +++-- tests/qemu-iotests/091.out | 1 + 2 files changed, 8

[Qemu-devel] [PATCH v8 22/36] qemu-iotests: 030: Disable image locking when checking test image

2016-09-30 Thread Fam Zheng
The VM is running, qemu-io would fail the lock acquisition. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/030 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index

[Qemu-devel] [PATCH v8 28/36] qemu-iotests: Add test case 153 for image locking

2016-09-30 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/153 | 197 + tests/qemu-iotests/153.out | 426 + tests/qemu-iotests/group | 1 + 3 files changed, 624 insertions(+)

[Qemu-devel] [PATCH v8 27/36] tests: Use null-co:// instead of /dev/null

2016-09-30 Thread Fam Zheng
With image locking, opening /dev/null can fail when multiple tests run in parallel (make -j2, for example). Use null-co:// as the null protocol doesn't do image locking. While it's arguable we could special-case /dev/null, /dev/zero, /dev/urandom etc in raw-posix driver, it is not really

[Qemu-devel] [PATCH v8 34/36] onenand: Add 'lock-mode' property

2016-09-30 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/onenand.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 8d84227..9b058e8 100644 --- a/hw/block/onenand.c +++ b/hw/block/onenand.c @@ -778,6 +778,7 @@ static int

[Qemu-devel] [PATCH v8 36/36] sd: Add 'lock-mode' property

2016-09-30 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/sd/sd.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 8e88e83..6c18fb8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -124,6 +124,7 @@ struct SDState { qemu_irq readonly_cb; qemu_irq inserted_cb;

Re: [Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT

2016-09-30 Thread Igor Mammedov
On Fri, 12 Aug 2016 14:54:05 +0800 Xiao Guangrong wrote: > _FIT is required for hotplug support, guest will inquire the updated > device info from it if a hotplug event is received > > As FIT buffer is not completely mapped into guest address space, so a > new

Re: [Qemu-devel] [PATCH 10/12] virtio: do not export set_host_notifier_internal

2016-09-30 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 03:18:57PM +0200, Paolo Bonzini wrote: > ioeventfd_disabled was the only reason for the default > implementation of virtio_device_start_ioeventfd_impl not to use > virtio_bus_set_host_notifier. This is now fixed, and the sole entry > point to set up ioeventfd can now be

Re: [Qemu-devel] [PATCH v2 09/12] vfio/pci: Conversion to realize

2016-09-30 Thread Auger Eric
Hi, On 22/09/2016 19:24, Markus Armbruster wrote: > Eric Auger writes: > >> This patch converts VFIO PCI to realize function. >> >> Also original initfn errors now are propagated using QEMU >> error objects. All errors are formatted with the same pattern: >> "vfio: %s:

Re: [Qemu-devel] [PATCH v2 04/12] vfio/pci: Pass an error object to vfio_intx_enable

2016-09-30 Thread Auger Eric
Markus, On 22/09/2016 18:27, Markus Armbruster wrote: > Eric Auger writes: > >> Pass an error object to prepare for migration to VFIO-PCI realize. >> >> The error object is propagated downto vfio_intx_enable_kvm > > down to vfio_intx_enable_kvm(). > > (feel free to omit

Re: [Qemu-devel] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

2016-09-30 Thread Eduardo Habkost
On Fri, Sep 30, 2016 at 10:02:49AM +0200, Paolo Bonzini wrote: > On 29/09/2016 23:14, Eduardo Habkost wrote: > > +/* Return the feature property name for a feature flag bit */ > > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > > +{ > > +/* XSAVE components are

Re: [Qemu-devel] [PATCH v2 7/7] intel-iommu: keep buggy EIM enabled in 2.7 machine type

2016-09-30 Thread Radim Krčmář
2016-09-30 13:40+0800, Peter Xu: > On Thu, Sep 29, 2016 at 01:23:29PM +0200, Radim Krčmář wrote: > > [...] > >> @@ -2481,11 +2482,14 @@ static void vtd_realize(DeviceState *dev, Error >> **errp) >> if (s->intr_eim == ON_OFF_AUTO_AUTO && !x86_iommu->intr_supported) { >> s->intr_eim

Re: [Qemu-devel] [PATCH v5 04/20] trace: convert code to use event iterators

2016-09-30 Thread Lluís Vilanova
Daniel P Berrange writes: > This converts the HMP/QMP monitor API implementations > and some internal trace control methods to use the new > trace event iterator APIs. > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Daniel P. Berrange > --- >

Re: [Qemu-devel] [PATCH 08/12] virtio: remove set_handler argument from set_host_notifier_internal

2016-09-30 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 03:18:55PM +0200, Paolo Bonzini wrote: > Make virtio_device_start_ioeventfd_impl use the same logic as > dataplane to set up the host notifier. This removes the need > for the set_handler argument in set_host_notifier_internal. > > This is a first step towards using

Re: [Qemu-devel] [PATCH v2 05/12] vfio/pci: Pass an error object to vfio_add_capabilities

2016-09-30 Thread Auger Eric
Hi Markus, On 22/09/2016 18:52, Markus Armbruster wrote: > Eric Auger writes: > >> Pass an error object to prepare for migration to VFIO-PCI realize. >> The error is cascaded downto vfio_add_std_cap and then vfio_msi(x)_setup, >> vfio_setup_pcie_cap. >> >>

Re: [Qemu-devel] [PATCH 12/12] virtio: inline set_host_notifier_internal

2016-09-30 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 03:18:59PM +0200, Paolo Bonzini wrote: > This is only called from virtio_bus_set_host_notifier. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio-bus.c | 60 > +- > 1 file changed, 25

Re: [Qemu-devel] [PATCH v2 02/12] vfio/pci: Pass an error object to vfio_populate_device

2016-09-30 Thread Auger Eric
Markus, On 22/09/2016 17:49, Markus Armbruster wrote: > Eric Auger writes: > >> Pass an error object to prepare for migration to VFIO-PCI realize. >> The returned value will be removed later on. >> >> The case where error recovery cannot be enabled is not converted into

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-30 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: > Opinions, reviews and bug reports? Looks good in general but I've skipped the tricky parts. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [v19 0/4] AMD IOMMU

2016-09-30 Thread David Kiarie
On Fri, Sep 30, 2016 at 4:55 PM, Paolo Bonzini wrote: > > > On 20/09/2016 17:42, David Kiarie wrote: >> Hi all, >> >> This patchset adds basic AMD IOMMU emulation support to Qemu. >> >> Resent this with some changes suggested by Michael. > > > Hi David, Hi Paolo, > > please

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 10:12:05AM +0800, Fam Zheng wrote: > On Thu, 09/29 13:41, Stefan Hajnoczi wrote: > > On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > > commit', but didn't turn on the "unmap" in the

Re: [Qemu-devel] [v19 0/4] AMD IOMMU

2016-09-30 Thread Paolo Bonzini
On 20/09/2016 17:42, David Kiarie wrote: > Hi all, > > This patchset adds basic AMD IOMMU emulation support to Qemu. > > Resent this with some changes suggested by Michael. Hi David, please fix the problems below, that were reported by Coverity. Paolo ** CID 1363372: Uninitialized

Re: [Qemu-devel] [PATCH v2 5/7] intel-iommu: add OnOffAuto intr_eim as "eim" property

2016-09-30 Thread Radim Krčmář
2016-09-30 13:13+0800, Peter Xu: > On Thu, Sep 29, 2016 at 01:23:27PM +0200, Radim Krčmář wrote: >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c >> @@ -2466,6 +2472,18 @@ static void vtd_realize(DeviceState *dev, Error >> **errp) >> exit(1); >> } >> >> +if

Re: [Qemu-devel] [PATCH v2 8/8] nvdimm docs: add nvdimm Read FIT function

2016-09-30 Thread Igor Mammedov
On Fri, 12 Aug 2016 14:54:10 +0800 Xiao Guangrong wrote: > Add the specification of Read FIT function should be squashed into 3/8 > > Signed-off-by: Xiao Guangrong > --- > docs/specs/acpi_nvdimm.txt | 38

Re: [Qemu-devel] [PATCH V15 00/12] Introduce COLO-Proxy

2016-09-30 Thread Paolo Bonzini
On 27/09/2016 04:22, Zhang Chen wrote: > COLO-proxy is a part of COLO project. COLO project is > composed of COLO-frame, COLO-proxy and block-replication. > It is used to compare the network package to help COLO > decide whether to do checkpoint. With COLO-proxy's help, > COLO greatly improves

  1   2   3   4   >