Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol

On 20.11.2016 09:41, Vincent Bernat wrote: > From: Vincent Bernat > > Some network equipments are requesting a file using the netascii > protocol and this is not configurable. Currently, qemu's tftpd only > supports the octet protocol. This commit makes it accept the netascii

[Qemu-devel] 答复： Re: About vNVDIMM question in TCG

You've been very helpful, haozhong, Thanks for your comments, I appreciate. >>> Haozhong Zhang 2016/11/21 星期一 上午 10:55 >>> On 11/20/16 10:58 -0700, Lin Ma wrote: >Hi Guangrong, > >I'm interested in vNVDIMM on qemu. I'd like to give it a try on my laptop. >Because I dont

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

21 Ноя 2016 г. 4:27 пользователь "Yang Wei" написал: > > In order to preserve sparse disk image, detect_zeroes > should also be enabled when bdrv_get_block_status_above() > returns BDRV_BLOCK_DATA > > Signed-off-by: Yang Wei > --- Hi, does this patch fixes

Re: [Qemu-devel] [PATCH 12/18] migration: add postcopy migration of dirty bitmaps

04.11.2016 16:09, Juan Quintela wrote: Vladimir Sementsov-Ogievskiy wrote: Postcopy migration of dirty bitmaps. Only named dirty bitmaps, associated with root nodes and non-root named nodes are migrated. If destination qemu is already containing a dirty bitmap with

[Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

When I try to use qemu-system-i386, I see this error message: qobject/qjson.c:69: failed assertion `obj != NULL'. This is the function where the assertion fails: /* * IMPORTANT: This function aborts on error, thus it must not * be used with untrusted arguments. */ QObject

Re: [Qemu-devel] [PATCH] vfio: avoid adding same iommu mr for notify

On Thu, Nov 17, 2016 at 02:24:54PM +1100, David Gibson wrote: > On Mon, Nov 14, 2016 at 07:59:28PM -0500, Peter Xu wrote: > > When one IOMMU memory region is splitted into multiple memory sections, > > vfio will register multiple same notifiers to a vIOMMU for the same > > region. That's not

Re: [Qemu-devel] [PATCH v2] docs: add document to explain the usage of vNVDIMM

On 11/09/16 12:35 +, Stefan Hajnoczi wrote: On Wed, Nov 09, 2016 at 09:04:48AM +0800, Haozhong Zhang wrote: Signed-off-by: Haozhong Zhang Reviewed-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi --- Changes

Re: [Qemu-devel] [PATCH 0/5] Last minute ppc migration fixes

On Mon, Nov 21, 2016 at 03:58:31PM +1100, David Gibson wrote: > Unfortunately, a bug already slipped into the qemu-2.7 release which > breaks migration of the pseries-2.6 machine type from qemu v2.6.0 to > qemu v2.7.0. That bug also breaks migration from v2.6.0 to current > master. In addition

[Qemu-devel] [PATCHv2 5/5] spapr: Fix 2.7<->2.8 migration of PCI host bridge

daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration from qemu-2.7 to the current version. It split the device's MMIO window into two pieces for 32-bit and 64-bit MMIO. The patch included backwards compatibility code to convert the old property into the new format. However, the

[Qemu-devel] [PATCHv2 3/5] target-ppc: Allow eventual removal of old migration mistakes

Until very recently, the vmstate for ppc cpus included some poorly thought out VMSTATE_EQUAL() components, that can easily break migration compatibility, and did so between qemu-2.6 and later versions. A hack was recently added which fixes this migration breakage, but it leaves the unhelpful

[Qemu-devel] [PATCHv2 2/5] migration: Add VMSTATE_UINTTL_TEST()

include/migration/cpu.h defines VMSTATE_UINTTL() and several variants for migrating target_ulong fields. It's defined in terms of VMSTATE_UINT32() or VMSTATE_UINT64() as appropriate. It doesn't, however, include a VMSTATE_UINTTL_TEST() variant, which I'm going to need shortly. So, add it.

[Qemu-devel] [PATCHv2 4/5] Revert "spapr: Fix migration of PCI host bridges from qemu-2.7"

This reverts commit 9b54ca0ba781012eeea4237b7c4832ba2ea81d89. The commit above corrected a migration breakage between qemu-2.7 and qemu-2.8. However it did so by advancing the migration version for the PCI host bridge, which obviously breaks migration backwards to earlier qemu versions.

[Qemu-devel] [PATCHv2 1/5] target-ppc: Fix CPU migration from qemu-2.6 <-> later versions

When migration for target-ppc was converted to vmstate, several VMSTATE_EQUAL() checks were foolishly included of things that really should be internal state. Specifically we verified equality of the insns_flags and insns_flags2 fields, which are used within TCG to determine which groups of

[Qemu-devel] [PATCHv2 0/5] Last minute ppc migration fixes

Unfortunately, a bug already slipped into the qemu-2.7 release which breaks migration of the pseries-2.6 machine type from qemu v2.6.0 to qemu v2.7.0. That bug also breaks migration from v2.6.0 to current master. In addition there have been several more changes which have inadvertently broken

Re: [Qemu-devel] [PATCH 10/18] migration/qemu-file: add qemu_put_counted_string()

17.08.2016 12:09, Fam Zheng wrote: On Tue, 08/16 13:26, Vladimir Sementsov-Ogievskiy wrote: Add function opposite to qemu_get_counted_string. qemu_put_counted_string puts one-byte length of the string (string should not be longer than 255 characters), and then it puts the string, without last

[Qemu-devel] [PATCH v2 1/1] hw/net/spapr_llan: 6 byte mac address device tree entry

The spapr-vlan device in QEMU has always presented it's MAC address in the device tree as an 8 byte value, even though PAPR requires it to be 6 bytes. This is because, at the time, AIX required the value to be 8 bytes. However, modern versions of AIX support the (correct) 6 byte value so they no

[Qemu-devel] [PATCH 1/3] Split serial-isa into its own config option

At present, the core device model code for 8250-like serial ports (serial.c) and the code for serial ports attached to ISA-style legacy IO (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. There are lots and lots of embedded platforms that have 8250-like serial ports but have

[Qemu-devel] [PATCH 3/5] target-ppc: Allow eventual removal of old migration mistakes

Until very recently, the vmstate for ppc cpus included some poorly thought out VMSTATE_EQUAL() components, that can easily break migration compatibility, and did so between qemu-2.6 and later versions. A hack was recently added which fixes this migration breakage, but it leaves the unhelpful

[Qemu-devel] [PATCH 2/3] Allow ISA bus to be configured out

Currently, the code to handle the legacy ISA bus is always included in qemu. However there are lots of platforms that don't include ISA legacy devies, and quite a few that have never used ISA legacy devices at all. This patch allows the ISA bus code to be disabled in the configuration for

[Qemu-devel] [PATCH 0/5] Last minute ppc migration fixes

Unfortunately, a bug already slipped into the qemu-2.7 release which breaks migration of the pseries-2.6 machine type from qemu v2.6.0 to qemu v2.7.0. That bug also breaks migration from v2.6.0 to current master. In addition there have been several more changes which have inadvertently broken

[Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device

The m48t59 device supports both ISA and direct sysbus attached versions of the device in the one .c file. This can be awkward for some embedded machine types which need the sysbus M48T59, but don't want to pull in the ISA bus code and its other dependencies. Therefore, this patch splits out the

[Qemu-devel] [PATCH 5/5] spapr: Fix 2.7<->2.8 migration of PCI host bridge

daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration from qemu-2.7 to the current version. It split the device's MMIO window into two pieces for 32-bit and 64-bit MMIO. The patch included backwards compatibility code to convert the old property into the new format. However, the

[Qemu-devel] [PATCH 4/5] Revert "spapr: Fix migration of PCI host bridges from qemu-2.7"

This reverts commit 9b54ca0ba781012eeea4237b7c4832ba2ea81d89. The commit above corrected a migration breakage between qemu-2.7 and qemu-2.8. However it did so by advancing the migration version for the PCI host bridge, which obviously breaks migration backwards to earlier qemu versions.

[Qemu-devel] [PATCH 2/5] migration: Add VMSTATE_UINTTL_TEST()

include/migration/cpu.h defines VMSTATE_UINTTL() and several variants for migrating target_ulong fields. It's defined in terms of VMSTATE_UINT32() or VMSTATE_UINT64() as appropriate. It doesn't, however, include a VMSTATE_UINTTL_TEST() variant, which I'm going to need shortly. So, add it.

[Qemu-devel] [PATCH 1/5] target-ppc: Fix CPU migration from qemu-2.6 <-> later versions

When migration for target-ppc was converted to vmstate, several VMSTATE_EQUAL() checks were foolishly included of things that really should be internal state. Specifically we verified equality of the insns_flags and insns_flags2 fields, which are used within TCG to determine which groups of

Re: [Qemu-devel] [PATCH for-2.8 3/3] spapr: migration support for CAS-negotiated option vectors

On Fri, Nov 18, 2016 at 10:08:59AM -0600, Michael Roth wrote: > Quoting Michael Roth (2016-11-17 19:40:27) > > With the additional of the OV5_HP_EVT option vector, we now have > > certain functionality (namely, memory unplug) that checks at run-time > > for whether or not the guest negotiated the

Re: [Qemu-devel] [PATCH for-2.8] target-*: Fix typos found by codespell

On Sat, Nov 19, 2016 at 08:50:55PM +0100, Stefan Weil wrote: > Signed-off-by: Stefan Weil Low risk, but low priority. Applied to ppc-for-2.9. > --- > target-i386/translate.c | 2 +- > target-m68k/translate.c | 6 +++--- > target-ppc/cpu.h | 2 +- >

Re: [Qemu-devel] [PATCH for-2.8] disas/ppc: Fix indefinite articles in comments

On Sat, Nov 19, 2016 at 08:23:03PM +0100, Stefan Weil wrote: > Signed-off-by: Stefan Weil Low risk, but low priority. Applied to ppc-for-2.9 > --- > disas/ppc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/disas/ppc.c b/disas/ppc.c >

Re: [Qemu-devel] [PATCH for-2.8 0/3] spapr: fix breakage of memory unplug after migration

On Fri, Nov 18, 2016 at 10:39:49AM -0600, Michael Roth wrote: > Quoting David Gibson (2016-11-17 23:45:05) > > On Thu, Nov 17, 2016 at 07:40:24PM -0600, Michael Roth wrote: > > > These patches are based on David's ppc-for-2.8 tree, and are also > > > available from: > > > > > >

Re: [Qemu-devel] [PATCH] hw/char/spapr_vty: Return amount of free buffer entries in vty_can_receive()

On Fri, Nov 18, 2016 at 10:09:37AM +0100, Thomas Huth wrote: > The can_receive() callbacks of the character devices should return > the amount of characters that can be accepted at once, not just a > boolean value (which rather means only one character at a time). > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] About vNVDIMM question in TCG

On 11/20/16 10:58 -0700, Lin Ma wrote: Hi Guangrong, I'm interested in vNVDIMM on qemu. I'd like to give it a try on my laptop. Because I dont have skylake server hardware, So I want to expose cpu flags clflushopt, clwb and pcommit to guest for NVDIMM drivers on TCG. I saw clflushopt and clwb

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On 18/11/16 19:17, Andrea Bolognani wrote: > On Thu, 2016-11-17 at 13:02 +1100, Alexey Kardashevskiy wrote: >>> That said, considering that a big part of the PCI address >>> allocation logic is based off whether the specific machine >>> type exposes a legay PCI Root Bus or a PCI Express Root Bus,

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror Type: series Message-id:

[Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

In order to preserve sparse disk image, detect_zeroes should also be enabled when bdrv_get_block_status_above() returns BDRV_BLOCK_DATA Signed-off-by: Yang Wei --- block/mirror.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index

Re: [Qemu-devel] [Qemu-ppc] Testing PowerPC floating point instructions

On Thu, Nov 17, 2016 at 10:57:41AM -0500, G 3 wrote: > Is there an official way to test any of the PowerPC floating point > instructions in QEMU? > Hello! it's not an "official way" but I've been working on Risu tool for PPC64le (https://wiki.linaro.org/PeterMaydell/Risu). I think the hardest

[Qemu-devel] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

From: Benjamin Herrenschmidt It's currently broken as it uses an incorrect shift, it tries to use the slot number but uses the top bits of the bus number instead. Note: Neither implementation matches what OpenBIOS ends up putting in the device-tree either, which will

[Qemu-devel] About vNVDIMM question in TCG

Hi Guangrong, I'm interested in vNVDIMM on qemu. I'd like to give it a try on my laptop. Because I dont have skylake server hardware, So I want to expose cpu flags clflushopt, clwb and pcommit to guest for NVDIMM drivers on TCG. I saw clflushopt and clwb feature flags in cpuinfo of guest, but

[Qemu-devel] [Bug 1643342] Re: not able to passthrough mouse / keyboard

** Description changed: After upgrading from qemu version 2.6.2 to 2.7.9 I can't boot my vm anymore. I get this error: qemu-system-x86_64: -usbdevice host:046d:c227: could not add USB device 'host:046d:c227' This happens with every usb-device I tried. Works 2.6.2 without any

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL] tftp: fake support for netascii protocol Type: series Message-id: 20161120170517.9181-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PULL] tftp: fake support for netascii protocol

From: Vincent Bernat Some network equipments are requesting a file using the netascii protocol and this is not configurable. Currently, qemu's tftpd only supports the octet protocol. This commit makes it accept the netascii protocol as well but do not perform the requested

[Qemu-devel] [PULL] tftp: fake support for netascii protocol

The following changes since commit b0bcc86d2a87456f5a276f941dc775b265b309cf: Update version for v2.8.0-rc0 release (2016-11-15 20:55:12 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to

[Qemu-devel] [Bug 1643342] [NEW] not able to passthrough mouse / keyboard

Public bug reported: After upgrading from qemu version 2.6.2 to 2.7.9 I can't boot my vm anymore. I get this error: qemu-system-x86_64: -usbdevice host:046d:c227: could not add USB device 'host:046d:c227' This happens with every usb-device I tried. Works 2.6.2 without any errors. (also tried

Re: [Qemu-devel] [Bug?] Guest pause because VMPTRLD failed in KVM

On 2016/11/17 20:39, Paolo Bonzini wrote: > > On 10/11/2016 15:10, gong lei wrote: >> 4) The isssue can't be reporduced. I search the Intel VMX sepc about >> reaseons >> of vmptrld failure: >> The instruction fails if its operand is not properly aligned, sets >> unsupported

Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [v2] tftp: fake support for netascii protocol Type: series Message-id: 20161120084136.721-1-vincent.ber...@exoscale.ch === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v14 1/2] virtio-crypto: Add virtio crypto device specification

On 2016/11/17 2:11, Halil Pasic wrote: > On 11/11/2016 10:23 AM, Gonglei wrote: >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the following crypto services: CIPHER, MAC, HASH, and AEAD. >> >> In

Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [v2] tftp: fake support for netascii protocol Message-id: 20161120084136.721-1-vincent.ber...@exoscale.ch Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

❦ 19 novembre 2016 23:30 +0100, Samuel Thibault  : >> > I think you should at least issue a qemu_log_mask(LOG_UNIMP, "...") >> > call in that case. >> >> I can do that if needed. > > That'd be better indeed. Otherwise people might wonder why things are > not working.

[Qemu-devel] [v2] tftp: fake support for netascii protocol

From: Vincent Bernat Some network equipments are requesting a file using the netascii protocol and this is not configurable. Currently, qemu's tftpd only supports the octet protocol. This commit makes it accept the netascii protocol as well but do not perform the requested