Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 21:34:45 +0200 "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: > > > As long as all users pass in 0 though there's a real possibility guests > > > will implement this incorrectly. > > We are here to ensure that at least Seabios (I

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

2017-02-16 Thread Thomas Huth
On 15.02.2017 19:27, Daniel P. Berrange wrote: > The current impl of seccomp in QEMU is intentionally allowing a huge range > of system calls to be executed. The goal was that running '-sandbox on' > should never break any feature of QEMU, so naturally any syscall that can > executed on any codepat

Re: [Qemu-devel] 答复: Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 08:16, Lin Ma wrote: >> What are the benefits of having FC access from the guest? > > Actually, I havn't dug it too much, Just thought that from virtualization's > perspective, when interact with FC storage, having complete FC access > from the guest is the way it should use. How

[Qemu-devel] [RFC v4] RBD: Add support readv,writev for rbd

2017-02-16 Thread jazeltq
From: tianqing Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing --- block/rbd.c | 47 +-- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/block/rbd.c b/bloc

[Qemu-devel] [RFC v5] RBD: Add support readv,writev for rbd

2017-02-16 Thread jazeltq
From: tianqing Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing --- block/rbd.c | 49 ++--- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/block/rbd.c b/bl

Re: [Qemu-devel] 答复: Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

2017-02-16 Thread Lin Ma
>>> Paolo Bonzini 2/16/2017 4:39 下午 >>> > > >On 16/02/2017 08:16, Lin Ma wrote: >>> What are the benefits of having FC access from the guest? >> >> Actually, I havn't dug it too much, Just thought that from virtualization's >> perspective, when interact with FC storage, having complete FC acces

[Qemu-devel] about translation block

2017-02-16 Thread oussema ben khedher
hi  im using qemu and i run in it a sample application of addition.c that do a+b=c  in order to implement a trace for the code execution od addition.c  i want to get adresses of transaltion block  thank you for the help   

Re: [Qemu-devel] [PATCH 0/2] add writeconfig command on monitor

2017-02-16 Thread Markus Armbruster
Eduardo Otubo writes: > This first patch extends the command line option `-writeconfig ' to a > command on HMP and QMP monitors. This is useful when live migrating after a > series of device hot plug events. One can just generate an updated config file > for the vm, transport it to the target hos

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 09:38:59AM +0100, Thomas Huth wrote: > On 15.02.2017 19:27, Daniel P. Berrange wrote: > > The current impl of seccomp in QEMU is intentionally allowing a huge range > > of system calls to be executed. The goal was that running '-sandbox on' > > should never break any feature

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 12:36:51AM +0100, Eduardo Otubo wrote: > On Wed, Feb 15, 2017 at 06=27=32PM +, Daniel P. Berrange wrote: > > The current impl of seccomp in QEMU is intentionally allowing a huge range > > of system calls to be executed. The goal was that running '-sandbox on' > > should

Re: [Qemu-devel] [PATCH v6 0/7] Add support for VM Generation ID

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:10, Ben Warren wrote: > >> On Feb 15, 2017, at 12:52 PM, Laszlo Ersek wrote: >> >> On 02/15/17 21:09, Michael S. Tsirkin wrote: >>> On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote: >> >> [snip] >> For patches #1, #3, #4 and #5: Tested-by: Laszlo Ersek >

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

2017-02-16 Thread Thomas Huth
On 16.02.2017 10:32, Daniel P. Berrange wrote: > On Thu, Feb 16, 2017 at 09:38:59AM +0100, Thomas Huth wrote: >> On 15.02.2017 19:27, Daniel P. Berrange wrote: >>> The current impl of seccomp in QEMU is intentionally allowing a huge range >>> of system calls to be executed. The goal was that runnin

Re: [Qemu-devel] RFC: How to make seccomp reliable and useful ?

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 10:37:31AM +0100, Thomas Huth wrote: > On 16.02.2017 10:32, Daniel P. Berrange wrote: > > On Thu, Feb 16, 2017 at 09:38:59AM +0100, Thomas Huth wrote: > >> I like your proposal! I just wanted to add an idea for an additional > >> parameter (not sure whether it is feasible, t

Re: [Qemu-devel] [PATCH v7 1/8] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 22:18:11 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This is similar to the existing 'add pointer' functionality, but instead > of instructing the guest (BIOS or UEFI) to patch memory, it instructs > the guest to write the pointer back to QEMU via a writeable

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Laszlo Ersek
On 02/16/17 09:25, Igor Mammedov wrote: > On Wed, 15 Feb 2017 21:34:45 +0200 > "Michael S. Tsirkin" wrote: > >> On Wed, Feb 15, 2017 at 07:24:36PM +0100, Igor Mammedov wrote: As long as all users pass in 0 though there's a real possibility guests will implement this incorrectly. >>> W

Re: [Qemu-devel] [PATCH 0/2] add writeconfig command on monitor

2017-02-16 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Eduardo Otubo writes: > > > This first patch extends the command line option `-writeconfig ' to a > > command on HMP and QMP monitors. This is useful when live migrating after a > > series of device hot plug events. One can just generate an updated

Re: [Qemu-devel] [PATCH v7 RESEND 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-16 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 8:19 PM, Peter Maydell wrote: > On 31 January 2017 at 16:23, wrote: >> From: Vijaya Kumar K >> >> Reset CPU interface registers of GICv3 when CPU is reset. >> For this, ARMCPRegInfo struct is registered with one ICC >> register whose resetfn is called when cpu is reset. >

Re: [Qemu-devel] 答复: Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

2017-02-16 Thread Hannes Reinecke
On 02/16/2017 09:39 AM, Paolo Bonzini wrote: > > > On 16/02/2017 08:16, Lin Ma wrote: >>> What are the benefits of having FC access from the guest? >> >> Actually, I havn't dug it too much, Just thought that from virtualization's >> perspective, when interact with FC storage, having complete FC a

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 22:18:14 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > This implements the VM Generation ID feature by passing a 128-bit > GUID to the guest via a fw_cfg blob. > Any time the GUID changes, an ACPI notify event is sent to the guest > > The user interface is a si

Re: [Qemu-devel] [PATCH v7 RESEND 4/5] target-arm: Add GICv3CPUState in CPUARMState struct

2017-02-16 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 8:12 PM, Peter Maydell wrote: > On 31 January 2017 at 16:23, wrote: >> From: Vijaya Kumar K >> >> Add gicv3state void pointer to CPUARMState struct >> to store GICv3CPUState. >> >> In case of usecase like CPU reset, we need to reset >> GICv3CPUState of the CPU. In such sc

Re: [Qemu-devel] [PATCH v7 RESEND 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 09:54, Vijay Kilari wrote: > On Tue, Feb 7, 2017 at 8:19 PM, Peter Maydell > wrote: >> If you want to do nothing in a read/write function there are >> already arm_cp_read_zero and arm_cp_write_ignore functions for >> this. But using the ARM_CP_NOP flag is better still. > >

Re: [Qemu-devel] [PATCH v3 15/16] target-m68k: add more FPU instructions

2017-02-16 Thread Andreas Schwab
On Feb 16 2017, Richard Henderson wrote: > On 02/07/2017 11:59 AM, Laurent Vivier wrote: >> +static long double floatx80_to_ldouble(floatx80 val) >> +{ >> +if (floatx80_is_infinity(val)) { >> +if (floatx80_is_neg(val)) { >> +return -__builtin_infl(); >> +

Re: [Qemu-devel] [PATCH qemu-web] Add Andrea's virtual memory FOSDEM presentation to blog post

2017-02-16 Thread Stefan Hajnoczi
On Wed, Feb 15, 2017 at 04:00:44PM +0100, Paolo Bonzini wrote: > On 15/02/2017 15:42, Stefan Hajnoczi wrote: > > From: Stefan Hajnoczi > > > > Andrea's presentation touches on Transparent Huge Pages and post-copy > > live migration using userfaultfd for virtualization use cases. > > > > Cc: Thom

[Qemu-devel] Is it safe to replace files under /user/local/share in-flight?

2017-02-16 Thread Bob Chen
Hi, I want to upgrade my qemu, is it safe to replace these ROM and keymap files in-flight while qemu processes are still running?

Re: [Qemu-devel] Emulating a Sun Blade 1500, with a Ultrasparc IIIi 1.5 GHz, 2GB ECC RAM. SunOS 5.10

2017-02-16 Thread Artyom Tarasenko
On Wed, Feb 15, 2017 at 11:37 AM, gozulmeunou vasile wrote: > Hello, > > I have an old Sun Blade 1500, with a Ultrasparc IIIi 1.5 GHz, 2GB ECC RAM. > SunOS 5.10, ufs filesystem. The hardware (MB, HDD and video card) is > failing on me and I'm searching for a way to emulate it on x86 hardware, I >

[Qemu-devel] [PATCH] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marc-André Lureau
This will allow the function to be used outside of QOM properties. Add tests and replace strtoul usage for qemu_strtoul while touching it. Signed-off-by: Marc-André Lureau --- include/hw/pci/pci.h | 12 ++ hw/core/qdev-properties.c | 61 +++--

Re: [Qemu-devel] Is it safe to replace files under /user/local/share in-flight?

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 06:26:05PM +0800, Bob Chen wrote: > I want to upgrade my qemu, is it safe to replace these ROM and keymap files > in-flight while qemu processes are still running? That essentially means the ROMS and the keymaps. The keymaps are safe as those are loaded at initial startup o

Re: [Qemu-devel] about translation block

2017-02-16 Thread Alex Bennée
oussema ben khedher writes: > hi > im using qemu and i run in it a sample application of addition.c that > do a+b=cin order to implement a trace for the code execution od > addition.c i want to get adresses of transaltion block If you run your application with -d in_asm,op,op_opt,out_asm you'll

Re: [Qemu-devel] [PATCH 0/2] add writeconfig command on monitor

2017-02-16 Thread Eduardo Otubo
On Thu, Feb 16, 2017 at 09=53=22AM +, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > Eduardo Otubo writes: > > > > > This first patch extends the command line option `-writeconfig ' to > > > a > > > command on HMP and QMP monitors. This is useful when live

Re: [Qemu-devel] [PATCH v7 7/8] tests: Add unit tests for the VM Generation ID feature

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 22:18:17 -0800 b...@skyportsystems.com wrote: > From: Ben Warren > > The following tests are implemented: > * test that a GUID passed in by command line is propagated to the guest. > Read the GUID both from guest memory and from the monitor > * test that the "auto" argument

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Marc-André Lureau
Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: > We can call qemu_chr_fe_set_handlers() to add/remove fd been watched > in 'context' which can be either default main context or other explicit > context. But the original logic is not correct, we didn't r

Re: [Qemu-devel] [PATCH] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] cutils: factor out pci_host_device_address_parse() Message-id: 20170216103016.6669-

Re: [Qemu-devel] [PATCH v7 8/8] MAINTAINERS: Add VM Generation ID entry

2017-02-16 Thread Laszlo Ersek
On 02/16/17 07:18, b...@skyportsystems.com wrote: > From: Ben Warren > > Also add BIOS tables entry > > Signed-off-by: Ben Warren > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index fb57d8e..e2e4b4f 100644 > --- a/MAINTAINERS

[Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
Hello, I have a short question/observation and a longer story. Short question: Between qemu 2.4.1 and 2.5.0 following snippet of code vanished: --- qemu-2.4.1/target-i386/mem_helper.c +++ qemu-2.5.0/target-i386/mem_helper.c @@ -122,11 +142,7 @@ X86CPU *cpu = X86_CPU(cs); CPUX8

[Qemu-devel] [PATCHv2] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marc-André Lureau
This will allow the function to be used outside of QOM properties. Add tests and replace strtoul usage for qemu_strtoul while touching it. Signed-off-by: Marc-André Lureau --- v2: - fixed incompatible type warning/error include/hw/pci/pci.h | 12 ++ hw/core/qdev-properties.c | 61

Re: [Qemu-devel] [PATCH qemu-web] Add Andrea's virtual memory FOSDEM presentation to blog post

2017-02-16 Thread Paolo Bonzini
- Original Message - > From: "Stefan Hajnoczi" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" , "Thomas > Huth" > Sent: Thursday, February 16, 2017 11:20:42 AM > Subject: Re: [PATCH qemu-web] Add Andrea's virtual memory FOSDEM presentation > to blog post > > On

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 11:19:44 -0800 Ben Warren wrote: > > On Feb 15, 2017, at 11:14 AM, Ben Warren wrote: > > > >> > >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov >> > wrote: > >> > >> On Wed, 15 Feb 2017 20:04:40 +0200 > >> "Michael S. Tsirkin" mailto:m...@redh

Re: [Qemu-devel] [PATCHv2] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 12:58 PM, Marc-André Lureau wrote: This will allow the function to be used outside of QOM properties. Hi Mark-Andre, I am not sure cutil.h is the right header for the function, because is too PCI related for a utility library. Also, maybe we can post the patch together with the

Re: [Qemu-devel] [PATCH v15 07/25] qcow2: add bitmaps extension

2017-02-16 Thread Kevin Wolf
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. > > For now, disable image resize if it has bitmaps. It will be fixed later. > > Sign

Re: [Qemu-devel] [PATCHv2] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marc-André Lureau
Hi - Original Message - > On 02/16/2017 12:58 PM, Marc-André Lureau wrote: > > This will allow the function to be used outside of QOM properties. > > > > Hi Mark-Andre, > > I am not sure cutil.h is the right header for the function, because is too > PCI > related for a utility library.

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-16 Thread Kevin Wolf
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Auto loading bitmaps are bitmaps stored in the disk image, which should > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed

Re: [Qemu-devel] [PATCH v7 RESEND 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-16 Thread Vijay Kilari
On Thu, Feb 16, 2017 at 3:39 PM, Peter Maydell wrote: > On 16 February 2017 at 09:54, Vijay Kilari wrote: >> On Tue, Feb 7, 2017 at 8:19 PM, Peter Maydell >> wrote: >>> If you want to do nothing in a read/write function there are >>> already arm_cp_read_zero and arm_cp_write_ignore functions fo

Re: [Qemu-devel] [PATCHv2] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marcel Apfelbaum
On 02/16/2017 01:19 PM, Marc-André Lureau wrote: Hi - Original Message - On 02/16/2017 12:58 PM, Marc-André Lureau wrote: This will allow the function to be used outside of QOM properties. Hi Mark-Andre, I am not sure cutil.h is the right header for the function, because is too PCI

Re: [Qemu-devel] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-16 Thread Kevin Wolf
Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > > S

Re: [Qemu-devel] [PATCH v15 08/25] block: introduce auto-loading bitmaps

2017-02-16 Thread Kevin Wolf
Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Auto loading bitmaps are bitmaps stored in the disk image, which should > > be loaded when the image is opened and become BdrvDirtyBitmaps for the > > corresponding drive. >

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
> Hello, > > I have a short question/observation and a longer story. > > Short question: > > Between qemu 2.4.1 and 2.5.0 following snippet of code vanished: > > --- qemu-2.4.1/target-i386/mem_helper.c > +++ qemu-2.5.0/target-i386/mem_helper.c > @@ -122,11 +142,7 @@ > X86CPU *cpu = X86

Re: [Qemu-devel] [PATCH v7 RESEND 5/5] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 11:28, Vijay Kilari wrote: > On Thu, Feb 16, 2017 at 3:39 PM, Peter Maydell > wrote: >> On 16 February 2017 at 09:54, Vijay Kilari wrote: >>> On Tue, Feb 7, 2017 at 8:19 PM, Peter Maydell >>> wrote: If you want to do nothing in a read/write function there are

Re: [Qemu-devel] [PATCH v6 0/7] Add support for VM Generation ID

2017-02-16 Thread Igor Mammedov
On Wed, 15 Feb 2017 21:52:55 +0100 Laszlo Ersek wrote: > On 02/15/17 21:09, Michael S. Tsirkin wrote: > > On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote: > > [snip] > > >> For patches #1, #3, #4 and #5: > >> > >> Tested-by: Laszlo Ersek > >> > >> I'll soon post the OVMF patches

Re: [Qemu-devel] [PATCHv2] cutils: factor out pci_host_device_address_parse()

2017-02-16 Thread Marc-André Lureau
Hi - Original Message - > On 02/16/2017 01:19 PM, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> On 02/16/2017 12:58 PM, Marc-André Lureau wrote: > >>> This will allow the function to be used outside of QOM properties. > >>> > >> > >> Hi Mark-Andre, > >> > >> I a

[Qemu-devel] problems with qapi2texi.py (use of @quotation)

2017-02-16 Thread Peter Maydell
When we build qemu-qmp-ref.txt this causes texinfo to complain several times: "Negative repeat count does nothing at /usr/share/texinfo/Texinfo/Convert/Line.pm line 124." I dug into what's happening here a bit, and I think the problem is that we're generating bogus texinfo. In particular I think

[Qemu-devel] [PATCH 1/5] migration/vmstate: renames in (load|save)_state

2017-02-16 Thread Halil Pasic
The vmstate_(load|save)_state start out with an a void *opaque pointing to some struct, and manipulate one or more elements of one field within that struct. First the field within the struct is pinpointed as opaque + offset, then if this is a pointer the pointer is dereferenced to obtain a pointer

[Qemu-devel] [PATCH 0/5] vmstate: handle arrays with null ptrs

2017-02-16 Thread Halil Pasic
This is basically the next iteration of the patch set "[RFC PATCH v2 0/8] VMS_ARRAY_OF_POINTER with null pointers". Mostly a rebase on top of current master. I have kept the r-b's for patches which remained conceptually the same. If someone disagrees please complain. RFC v2 -> v1: * rebase * chan

[Qemu-devel] [PATCH 2/5] migration/vmstate: split up vmstate_base_addr

2017-02-16 Thread Halil Pasic
Currently vmstate_base_addr does several things: it pinpoints the field within the struct, possibly allocates memory and possibly does the first pointer dereference. Obviously allocation is needed only for load. Let us split up the functionality in vmstate_base_addr and move the address manipulati

[Qemu-devel] [PATCH 3/5] migration/vmstate: fix array of ptr with nullptrs

2017-02-16 Thread Halil Pasic
Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the reward for trying to migrate an array with some null pointers in it was an illegal memory access, that is a swift and painless death of the process. Let's make vmstate cope with this scenario. The general approach is, when we encou

[Qemu-devel] [PATCH 4/5] tests/test-vmstate.c: test array of ptr with null

2017-02-16 Thread Halil Pasic
Add test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT with an array containing some null pointer. Signed-off-by: Halil Pasic Reviewed-by: Dr. David Alan Gilbert --- tests/test-vmstate.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/tests/test

[Qemu-devel] [PATCH 5/5] tests/test-vmstate.c: test array of ptr to primitive

2017-02-16 Thread Halil Pasic
Let's have a test for ptr arrays to some primitive type with some not-null and null ptrs intermixed. Signed-off-by: Halil Pasic --- Mainly for the sake of completeness and also to demonstrate that it works since in the previous version I wrongly stated it does not. If guys think we do not need

[Qemu-devel] [PATCH 1/5] eth: Extend vlan stripping functions

2017-02-16 Thread Dmitry Fleytman
Make VLAN stripping functions return number of bytes copied to given Ethernet header buffer. This information should be used to re-compose packet IOV after VLAN stripping. Signed-off-by: Dmitry Fleytman --- include/net/eth.h | 4 ++-- net/eth.c | 25 ++--- 2 files c

[Qemu-devel] [PATCH 3/5] NetRxPkt: Do not try to pull more data than present

2017-02-16 Thread Dmitry Fleytman
In case of VLAN stripping, ETH header put into a separate buffer, therefore amont of data copied from original IOV should be smaller. Signed-off-by: Dmitry Fleytman --- hw/net/net_rx_pkt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_p

[Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Dmitry Fleytman
This series fix a few issues related to processing of RX packets with VLAN headers. See commit messages of specific patches for information regarding affected devices. Dmitry Fleytman (5): eth: Extend vlan stripping functions NetRxPkt: Fix memory corruption on VLAN header stripping NetRxPkt

[Qemu-devel] [PATCH 4/5] NetRxPkt: Account buffer with ETH header in IOV length

2017-02-16 Thread Dmitry Fleytman
In case of VLAN stripping ETH header is stored in a separate chunk and length of IOV should take this into account. This patch fixes checksum validation for RX packets with VLAN header. Devices affected by this problem: e1000e and vmxnet3. Signed-off-by: Dmitry Fleytman --- hw/net/net_rx_pkt.c

[Qemu-devel] [PATCH 2/5] NetRxPkt: Fix memory corruption on VLAN header stripping

2017-02-16 Thread Dmitry Fleytman
This patch fixed a problem that was introduced in commit eb700029. When net_rx_pkt_attach_iovec() calls eth_strip_vlan() this can result in pkt->ehdr_buf being overflowed, because ehdr_buf is only sizeof(struct eth_header) bytes large but eth_strip_vlan() can write sizeof(struct eth_header) + size

[Qemu-devel] [PATCH v4 3/4] .shippable.yml: new CI provider

2017-02-16 Thread Alex Bennée
Ostensibly Shippable offers a similar set of services as Travis. However they are focused on Docker container based work-flows so we can use our existing containers to run a few extra builds - in this case a bunch of cross-compiled targets on a Debian multiarch system. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v4 0/4] Docker cross-compile targets and user build support

2017-02-16 Thread Alex Bennée
Hi Fam, Here is the latest iteration of the docker changes incorporating your suggestions: - -u behaves safely if user already added - cross containers specify QEMU_CONFIGURE_OPTS - merged docker and build automation in MAINTAINERS Regards, Alex Bennée (4): tests/docker: add basic user

[Qemu-devel] [PATCH v4 1/4] tests/docker: add basic user mapping support

2017-02-16 Thread Alex Bennée
Currently all docker builds are done by exporting a tarball to the docker container and running the build as the containers root user. Other use cases are possible however and it is possible to map a part of users file-system to the container. This is useful for example for doing cross-builds of ar

Re: [Qemu-devel] [PATCH 10/18] block/dirty-bitmap: add bdrv_load_dirty_bitmap

2017-02-16 Thread Denis V. Lunev
On 02/03/2017 06:47 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 53 > > include/block/block_int.h| 4 > include/block/dirty-bitmap.h | 3 +++ > 3 files changed

[Qemu-devel] [PATCH 5/5] NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()

2017-02-16 Thread Dmitry Fleytman
This is a refactoring commit that does not change behavior. Signed-off-by: Dmitry Fleytman --- hw/net/net_rx_pkt.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index c7ae33d..3899211 100644 --- a/hw/net/net_rx_pkt.c +++ b/

[Qemu-devel] [PATCH v4 4/4] MAINTAINERS: merge Build and test automation with Docker tests

2017-02-16 Thread Alex Bennée
The docker framework is really just another piece in the build automation puzzle so lets merge it together. For added bonus I've also included the Travis and Patchew status links. The Shippable links will be added later once mainline tests have been configured and setup. Suggested-by: Fam Zheng S

[Qemu-devel] [PATCH v4 2/4] new: debian docker targets for cross-compiling

2017-02-16 Thread Alex Bennée
This provides a basic Debian install with access to the emdebian cross compilers. The debian-armhf-cross and debian-arm64-cross targets build on the basic Debian image to allow cross compiling to those targets. A new environment variable (QEMU_CONFIGURE_OPTS) is set as part of the docker container

Re: [Qemu-devel] [PATCH 0/5] A few VLAN-related bugfixes for RX packet abstraction

2017-02-16 Thread Peter Maydell
On 16 February 2017 at 12:29, Dmitry Fleytman wrote: > This series fix a few issues related > to processing of RX packets with VLAN headers. > > See commit messages of specific patches > for information regarding affected devices. I think at least the "fix buffer overrun" parts of this patchset s

Re: [Qemu-devel] [Qemu-block] [PATCH v15 09/25] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-02-16 Thread Kevin Wolf
Sorry, this was sent too early. Next attempt... Am 16.02.2017 um 12:45 hat Kevin Wolf geschrieben: > Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > > are loaded when the image is opened and become B

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
Hello Paolo, On 16.02.2017 12:53, Paolo Bonzini wrote: > As you noticed, the problem is that now cpu_vmexit is called without a > cpu_restore_state before. > > The right fix is to pass the retaddr to cpu_vmexit (via > cpu_svm_check_intercept_param); something like this untested patch: ... > >

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 13:57, Alexander Boettcher wrote: > Hello Paolo, > > On 16.02.2017 12:53, Paolo Bonzini wrote: >> As you noticed, the problem is that now cpu_vmexit is called without a >> cpu_restore_state before. >> >> The right fix is to pass the retaddr to cpu_vmexit (via >> cpu_svm_check_inter

Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Plenty of code relies on QemuOpt member @str not being null, including >> qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to >> qemu_opt_foreach(). >> > >> >> Assert member @str isn't null, so that misuse is

Re: [Qemu-devel] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

2017-02-16 Thread Fam Zheng
On Mon, 02/13 12:54, Vladimir Sementsov-Ogievskiy wrote: > Postcopy migration of dirty bitmaps. Only named dirty bitmaps, > associated with root nodes and non-root named nodes are migrated. > > If destination qemu is already containing a dirty bitmap with the same name > as a migrated bitmap (for

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Marc-André Lureau
Hi On Thu, Feb 16, 2017 at 4:49 PM Hailiang Zhang < zhang.zhanghaili...@huawei.com> wrote: > Hi, > > On 2017/2/16 18:40, Marc-André Lureau wrote: > > Hi > > > > On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < > > zhang.zhanghaili...@huawei.com> wrote: > > > >> We can call qemu_chr_fe_set_handler

Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Use unsigned comparisons to check the result of qemu_strtoul() and >> strtoull(). >> >> Signed-off-by: Markus Armbruster >> --- >> tests/test-cutils.c | 60 >> ++--- >> 1 f

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
On 2017/2/16 21:04, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 4:49 PM Hailiang Zhang < zhang.zhanghaili...@huawei.com> wrote: Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call q

[Qemu-devel] [PATCH 0/3] usb-ccid: improve sanity checks

2017-02-16 Thread Gerd Hoffmann
Hi, Small ccid series which improves the ccid_handle_bulk_out sanity checks. cheers, Gerd Gerd Hoffmann (3): usb-ccid: better bulk_out error handling usb-ccid: move header size check usb-ccid: add check message size checks hw/usb/dev-smartcard-reader.c | 140 +++--

[Qemu-devel] [PATCH 3/3] usb-ccid: add check message size checks

2017-02-16 Thread Gerd Hoffmann
Check message size too when figuring whenever we should expect more data. Fix debug message to show useful data, p->iov.size is fixed anyway if we land there, print how much we got meanwhile instead. Also check announced message size against actual message size. That is a more general fix for CVE

[Qemu-devel] [PATCH 2/3] usb-ccid: move header size check

2017-02-16 Thread Gerd Hoffmann
Move up header size check, so we can use header fields in sanity checks (in followup patches). Also reword the debug message. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/usb/dev-smartcard-rea

[Qemu-devel] [PATCH 1/3] usb-ccid: better bulk_out error handling

2017-02-16 Thread Gerd Hoffmann
Add err goto label where we can jump to from all error conditions. STALL request on all errors. Reset position on all errors. Normal request processing is not in a else branch any more, so this code is reintended, there are no code changes in that part of the code though. Signed-off-by: Gerd Hof

Re: [Qemu-devel] [PATCH v4 2/4] new: debian docker targets for cross-compiling

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > index 4778b27ca8..84bdcc944a 100644 > --- a/tests/docker/Makefile.include > +++ b/tests/docker/Makefile.include > @@ -54,6 +54,10 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker >

Re: [Qemu-devel] [PATCH v4 1/4] tests/docker: add basic user mapping support

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Currently all docker builds are done by exporting a tarball to the > docker container and running the build as the containers root user. > Other use cases are possible however and it is possible to map a part > of users file-system to the container. This is

Re: [Qemu-devel] problems with qapi2texi.py (use of @quotation)

2017-02-16 Thread Marc-André Lureau
Hi On Thu, Feb 16, 2017 at 4:11 PM Peter Maydell wrote: > When we build qemu-qmp-ref.txt this causes texinfo to complain several > times: > "Negative repeat count does nothing at > /usr/share/texinfo/Texinfo/Convert/Line.pm line 124." > > I dug into what's happening here a bit, and I think the p

Re: [Qemu-devel] [PATCH v4 4/4] MAINTAINERS: merge Build and test automation with Docker tests

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > The docker framework is really just another piece in the build > automation puzzle so lets merge it together. For added bonus I've also > included the Travis and Patchew status links. The Shippable links will > be added later once mainline tests have been c

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
On 16.02.2017 13:57, Paolo Bonzini wrote: > > > On 16/02/2017 13:57, Alexander Boettcher wrote: >> Hello Paolo, >> >> On 16.02.2017 12:53, Paolo Bonzini wrote: >>> As you noticed, the problem is that now cpu_vmexit is called without a >>> cpu_restore_state before. >>> >>> The right fix is to pass

Re: [Qemu-devel] [PATCH v6 0/7] Add support for VM Generation ID

2017-02-16 Thread Laszlo Ersek
On 02/16/17 13:08, Igor Mammedov wrote: > On Wed, 15 Feb 2017 21:52:55 +0100 > Laszlo Ersek wrote: > >> On 02/15/17 21:09, Michael S. Tsirkin wrote: >>> On Wed, Feb 15, 2017 at 08:47:48PM +0100, Laszlo Ersek wrote: >> >> [snip] >> For patches #1, #3, #4 and #5: Tested-by: Laszlo

Re: [Qemu-devel] [PATCH v4 3/4] .shippable.yml: new CI provider

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Ostensibly Shippable offers a similar set of services as Travis. > However they are focused on Docker container based work-flows so we > can use our existing containers to run a few extra builds - in this > case a bunch of cross-compiled targets on a Debian

[Qemu-devel] [Bug 1665344] [NEW] documentation error:404 not found

2017-02-16 Thread Suramya
Public bug reported: In http://wiki.qemu-project.org/Outreachy_2017_MayAugust the urls http://www.qemu-project.org/images/4/4e/Q35.pdf and http://www.qemu-project.org/images/f/f6/PCIvsPCIe.pdf on opening displays: Not Found The requested URL /images/4/4e/Q35.pdf was not found on this server.

Re: [Qemu-devel] [PATCH v4 0/4] Docker cross-compile targets and user build support

2017-02-16 Thread Fam Zheng
On Thu, 02/16 12:34, Alex Bennée wrote: > Hi Fam, > > Here is the latest iteration of the docker changes incorporating your > suggestions: > > - -u behaves safely if user already added > - cross containers specify QEMU_CONFIGURE_OPTS > - merged docker and build automation in MAINTAINERS Th

Re: [Qemu-devel] [PATCH v4 13/18] qcow2: add support for LUKS encryption format

2017-02-16 Thread Alberto Garcia
On Fri 10 Feb 2017 06:09:05 PM CET, Daniel P. Berrange wrote: > @@ -990,12 +1123,6 @@ static int qcow2_open(BlockDriverState *bs, QDict > *options, int flags, > s->refcount_max = UINT64_C(1) << (s->refcount_bits - 1); > s->refcount_max += s->refcount_max - 1; > > -if (header.crypt_

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 14:27, Alexander Boettcher wrote: > On 16.02.2017 13:57, Paolo Bonzini wrote: >> >> >> On 16/02/2017 13:57, Alexander Boettcher wrote: >>> Hello Paolo, >>> >>> On 16.02.2017 12:53, Paolo Bonzini wrote: As you noticed, the problem is that now cpu_vmexit is called without a

[Qemu-devel] [PATCH v2 00/22] ppc/xics: simplify ICS and ICP creation

2017-02-16 Thread Cédric Le Goater
Hello, The goal behind this series is to simplify the XICS interface by moving back in the machine the way the ICS and ICP objects interact together. It's up to the machine to implement this "fabric" logic by providing a set of handlers of a QOM interface. These handlers are used to grab an ICS or

[Qemu-devel] [PATCH v2 01/22] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

2017-02-16 Thread Cédric Le Goater
Today, the ICS (Interrupt Controller Source) object is created and realized by the init and realize routines of the XICS object, but some of the parameters are only known at the machine level. These parameters are passed from the sPAPR machine to the ICS object in a rather convoluted way using pro

[Qemu-devel] [PATCH v2 02/22] ppc/xics: remove set_nr_servers() handler from XICSStateClass

2017-02-16 Thread Cédric Le Goater
Today, the ICP (Interrupt Controller Presenter) objects are created by the 'nr_servers' property handler of the XICS object and a class handler. They are realized in the XICS object realize routine. Let's simplify the process by creating the ICP objects along with the XICS object at the machine le

[Qemu-devel] [PATCH v2 05/22] ppc/xics: introduce a QOM interface to handle ICSs

2017-02-16 Thread Cédric Le Goater
This QOM interface provides two simple handlers. One is to get an ICS object from an irq number and a second to resend the irqs when needed. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 7 +++ include/hw/ppc/xics.h | 18 ++ 2 files changed, 25 insertions(+) d

[Qemu-devel] [PATCH v2 03/22] ppc/xics: store the ICS object under the sPAPR machine

2017-02-16 Thread Cédric Le Goater
A list of ICS objects was introduced under the XICS object for the PowerNV machine, but, for the sPAPR machine, it brings extra complexity as there is only a single ICS. To simplify the code, let's add the ICS pointer under the sPAPR machine and try to reduce the use of this list where possible. A

[Qemu-devel] [PATCH v2 04/22] ppc/xics: add an InterruptStatsProvider interface to ICS and ICP objects

2017-02-16 Thread Cédric Le Goater
This is, again, to reduce the use of the list of ICS objects. Let's make each individual ICS and ICP object an InterruptStatsProvider and remove this same interface from XICSState. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 76 +++---

[Qemu-devel] [PATCH v2 06/22] ppc/xics: use the QOM interface under the sPAPR machine

2017-02-16 Thread Cédric Le Goater
Add 'ics_get' and 'ics_resend' handlers to the sPAPR machine. These are relatively simple for a single ICS. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 2 +- hw/ppc/spapr.c| 18 ++ include/hw/ppc/xics.h | 1 + 3 files changed, 20 insertions(+), 1 deletio

  1   2   3   4   >