Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from Revision 1 to > 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to > make running macOS/OS X guests smoother. With a Rev1 FADT, rebooting

[Qemu-devel] [PATCH v2 5/8] ppc/pnv: create the ICP and ICS objects under the machine

Like this is done for the sPAPR machine, we use a simple array under the PowerNV machine to store the Interrupt Control Presenters (ICP) objects, one for each vCPU. This array is indexed by 'cpu_index' of the CPUState but the users will provide a core PIR number. The mapping is done in the

[Qemu-devel] [PATCH v2 8/8] ppc/pnv: add memory regions for the ICP registers

This provides to a PowerNV chip (POWER8) access to the Interrupt Management area, which contains the registers of the Interrupt Control Presenters of each thread. These are used to accept, return, forward interrupts in the system. This area is modeled with a per-chip container memory region

Re: [Qemu-devel] [PATCH for-2.10 6/8] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

On 03/15/2017 07:16 AM, David Gibson wrote: > On Wed, Mar 08, 2017 at 11:52:49AM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> The PSI (Processor Service Interface) Controller is one of the engines >> of the "Bridge" unit which connects the

[Qemu-devel] Adding our own nic model

We are working on a project in QEMU wherein we want to add our own nic model userio. Can you please tell us how to go about it. Thanking you, Warm regards, Shirley Kotian

Re: [Qemu-devel] [PULL for 2.9 00/49] QAPI patches for 2017-03-16

On 16 March 2017 at 06:27, Markus Armbruster wrote: > Significant improvements to QMP documentation, fixing its regression. > > Note: only QAPI *generator* code changes, except for trailing space > removal in generated qmp-marshal.c and doc comments in QAPI schemas. > > The

[Qemu-devel] [PATCH v2 4/8] ppc/pnv: add a PnvICPState object

This provides a new ICPState object for the PowerNV machine (POWER8). Access to the Interrupt Management area is done though a memory region. It contains the registers of the Interrupt Control Presenters of each thread which are used to accept, return, forward interrupts in the system.

[Qemu-devel] [PATCH v2 3/8] ppc/xics: add a realize() handler to ICPStateClass

It will be used by derived classes in PowerNV for customization. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 5 + include/hw/ppc/xics.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 5cde86ceb3bc..7cd842102265

[Qemu-devel] [PATCH v2 7/8] ppc/pnv: link the CPUs to the machine XICSFabric

This assigns the ICPState object to the CPU using the PIR number for lookups before calling the XICS layer to finish the job. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 2 ++ hw/ppc/pnv_core.c | 20 2 files changed, 18 insertions(+), 4

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

On 23 February 2017 at 12:46, Peter Maydell wrote: > On 22 February 2017 at 00:21, Yongbok Kim wrote: >> This is the v2 of the pull-req for target-mips. >> The warning treated as error has been fixed and the file is now isolated for >> mips64el

Re: [Qemu-devel] [PATCH v2] x86: Allow to set NUMA distance for different NUMA nodes

On Thu, Mar 16, 2017 at 04:38:24PM +0800, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create a guest that has 4

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

On 16.03.2017 15:46, Philippe Mathieu-Daudé wrote: > Hi Stefan, Richard. > > On 03/16/2017 10:28 AM, David Hildenbrand wrote: >> On 02.03.2017 20:56, David Hildenbrand wrote: >>> Am 30.01.2017 um 14:15 schrieb Stefan Weil: Returning NULL from get_max_cpu_model results in a SIGSEGV runtime

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

On 02.03.2017 20:56, David Hildenbrand wrote: > Am 30.01.2017 um 14:15 schrieb Stefan Weil: >> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. >> >> Signed-off-by: Stefan Weil >> --- >> >> v2: Re-sent as v1 was damaged by my mailer. >> >> This is also

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

On 16/03/17 12:54, Igor Druzhinin wrote: > On 16/03/17 12:26, Anthony PERARD wrote: >> On Wed, Mar 15, 2017 at 04:01:19PM +, Igor Druzhinin wrote: >>> Saving/restoring the physmap to/from xenstore was introduced to >>> QEMU majorly in order to cover up the VRAM region restore issue. >>> The

Re: [Qemu-devel] [PULL 0/5] virtio, pci: fixes

On 16 March 2017 at 02:34, Michael S. Tsirkin wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

On 16/03/2017 15:12, Gerd Hoffmann wrote: > Hi, > >>> -#define DEPTH 8 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 16 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 24 >>> -#include "cirrus_vga_rop2.h" >>> - >>> #define DEPTH 32 >>> #include "cirrus_vga_rop2.h" >

[Qemu-devel] [PATCH v2 0/8] ppc/pnv: interrupt controller (POWER8)

Hello, Here is a series adding support for the interrupt controller as found on a POWER8 system. POWER9 uses a different interrupt controller called XIVE, still to be worked on. The initial patches are more cleanups of the XICS layer which move the IRQ 'server' number mapping under the machine

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

On 16/03/2017 08:35, Gerd Hoffmann wrote: > Hi, > Note that KVM has some similar hacks to avoid trapping all writes to video memory with its coalesced mmio mechanism however I'm not familiar with all the details. >>> >>> Normal linear framebuffer access doesn't use this. >> >>

[Qemu-devel] [PATCH 0/2] xen: use pkg-config for configure

This small patch set is to be applied on top of Paul's series for support of libxendevicemodel, or (maybe even better) it should be merged into this series. Juergen Gross (2): xen: use 5 digit xen versions configure: use pkg-config for obtaining xen version configure | 43

[Qemu-devel] [PATCH v2 6/8] ppc/pnv: add a helper to calculate MMIO addresses registers

Some controllers (ICP, PSI) have a base register address which is calculated using the chip id. Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h

[Qemu-devel] [PATCH 1/2] xen: use 5 digit xen versions

Today qemu is using e.g. the value 480 for Xen version 4.8.0. As some Xen version tests are using ">" relations this scheme will lead to problems when Xen version 4.10.0 is being reached. Instead of the 3 digit schem use a 5 digit scheme (e.g. 40800 for version 4.8.0). Signed-off-by: Juergen

[Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

Instead of trying to guess the Xen version to use by compiling various test programs first just ask the system via pkg-config. Only if it can't return the version fall back to the test program scheme. Signed-off-by: Juergen Gross --- configure | 31

Re: [Qemu-devel] [PATCH] Dead Code Removal: removing support for DEPTH != 32.

On 16/03/2017 10:20, iwona260...@gmail.com wrote: > static draw_line_func * draw_line8_funcs[] = { > -draw_line8_8, > -draw_line8_15, > -draw_line8_16, > draw_line8_32, > draw_line8_32bgr, > -draw_line8_15bgr, > -draw_line8_16bgr, > }; > > static draw_line_func

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

On Thu, Mar 16, 2017 at 02:06:21PM +, Igor Druzhinin wrote: > On 16/03/17 12:54, Igor Druzhinin wrote: > > On 16/03/17 12:26, Anthony PERARD wrote: > >> I've tried to migrate a guest with this patch, but once migrated, the > >> screen is black (via VNC, keyboard is working fine). > >> > > Hmm.

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

On Thu, Mar 16, 2017 at 02:46:56PM +, Anthony PERARD wrote: > On Thu, Mar 16, 2017 at 02:06:21PM +, Igor Druzhinin wrote: > > On 16/03/17 12:54, Igor Druzhinin wrote: > > > On 16/03/17 12:26, Anthony PERARD wrote: > > >> I've tried to migrate a guest with this patch, but once migrated, the

Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

Hi, > > +DEFINE_PROP_BOOL("blitter", struct PCICirrusVGAState, > > > + cirrus_vga.enable_blitter, true), > > > The default is 'ENABLE'? Yes. > I think there should be 'false'. Just flipping it to false isn't an option. At minimum we would have to keep it enabled

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

Hi Stefan, Richard. On 03/16/2017 10:28 AM, David Hildenbrand wrote: On 02.03.2017 20:56, David Hildenbrand wrote: Am 30.01.2017 um 14:15 schrieb Stefan Weil: Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. Signed-off-by: Stefan Weil --- v2:

Re: [Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

On Thu, Mar 16, 2017 at 06:55:47PM +0200, Achilles Benetopoulos wrote: > I am interested in working on the BiteSized Task mentioned in the > subject line. However, I have a question: Since the current behaviour > of qemu_thread_create is to fail in the case of an error, then it > seems logical to

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 16 March 2017 at 15:23, Peter Maydell wrote: > (Technically right this instant 'mips' and 's390' would be in the > 'dump' list, since I don't personally have access yet. But we have > a plan for s390, and it turns out there is a mips machine in the > gcc compile farm

Re: [Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

Achilles Benetopoulos writes: > I am interested in working on the BiteSized Task mentioned in the > subject line. However, I have a question: Since the current behaviour > of qemu_thread_create is to fail in the case of an error, then it > seems logical to make the

Re: [Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

On Thu, Mar 16, 2017 at 05:36:40PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process

Re: [Qemu-devel] Benchmarking linux-user performance

On Tue, Mar 14, 2017 at 17:06:57 +, Dr. David Alan Gilbert wrote: > * Emilio G. Cota (c...@braap.org) wrote: > > It seems that a good benchmark to take translation overhead into account > > would be gcc/perlbench from SPEC (see [1]; ~20% of exec time is spent > > on translation).

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

Laurent Vivier writes: > Le 27/02/2017 à 15:38, Alex Bennée a écrit : >> >> Laurent Vivier writes: >> >>> Le 24/02/2017 à 12:20, Alex Bennée a écrit : There are a couple of changes that occur at the same time here: - introduce a single

Re: [Qemu-devel] [RFC patch 3/3] blockjob: add devops to blockjob backends

Am 16.03.2017 um 01:46 hat John Snow geschrieben: > This lets us hook into drained_begin and drained_end requests from the > backend level, which is particularly useful for making sure that all > jobs associated with a particular node (whether the source or the target) > receive a drain request. >

Re: [Qemu-devel] [RFC v2 3/3] hw/intc/arm_gicv3_its: Allow save/restore

Hi Peter, On 13/03/2017 19:03, Peter Maydell wrote: > On 6 March 2017 at 12:48, Eric Auger wrote: >> We change the restoration priority of both the GICv3 and ITS. The >> GICv3 must be restored before the ITS and the ITS needs to be restored >> before PCIe devices since it

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 16 March 2017 at 15:46, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: >> OK, here's a concrete proposal for deprecating/dropping out of >> date host OS and architecture support. >> >> We'll put this in the ChangeLog 'Future

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

On 16/03/2017 16:34, Gerd Hoffmann wrote: > Well, not *that* simple. vga checks the dirty bitmap with scanline > granularity, like that: > > foreach (scanline) { > if (get_dirty(scanline)) > update_scanline() > } > reset_dirty(framebuffer) > > I suspect simply transforming

Re: [Qemu-devel] [PULL for-2.9 0/7] cirrus: more blitter security fixes.

wing changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-cirrus-20170316-1

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On Thu, Mar 16, 2017 at 06:01:35PM +, Peter Maydell wrote: > On 16 March 2017 at 15:23, Peter Maydell wrote: > > (Technically right this instant 'mips' and 's390' would be in the > > 'dump' list, since I don't personally have access yet. But we have > > a plan for

Re: [Qemu-devel] [RFC patch 2/3] block-backend: add drained_begin / drained_end ops

Am 16.03.2017 um 01:46 hat John Snow geschrieben: > Signed-off-by: John Snow > > --- > > RFC questions: > > - Does the presence of blk->quiesce_counter relieve the burden of needing > blk->public.io_limits_disabled? I could probably eliminate this counter > entirely and

Re: [Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Subject has a couple of typos; otherwise; Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 - > migration/ram.c | 5 - > 2

Re: [Qemu-devel] [PATCH 12/31] ram: Move norm_pages to RAMState

* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation Message-id:

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

I updated the section before? Build dependencies QEMU now requires a minimum dtc version of 1.4.2. Do you mean to update it like "dtc (libfdt)"? Regards, Yongbok On 16/03/2017 15:03, Peter Maydell wrote: > On 23 February 2017 at 12:46, Peter Maydell wrote: >>

[Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

I am interested in working on the BiteSized Task mentioned in the subject line. However, I have a question: Since the current behaviour of qemu_thread_create is to fail in the case of an error, then it seems logical to make the caller exit (in the patched version) if the return value of the call

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

On Thu, Mar 16, 2017 at 05:34:30PM +0100, Paolo Bonzini wrote: > > > On 16/03/2017 17:19, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > >> qemu-ga's socket activation support was not obeying the LISTEN_PID > >> environment variable, which avoids

Re: [Qemu-devel] [PULL 0/3] Tracing patches

On 16 March 2017 at 07:04, Stefan Hajnoczi wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > OK, here's a concrete proposal for deprecating/dropping out of > date host OS and architecture support. > > We'll put this in the ChangeLog 'Future incompatible changes' > section: > - > * Removal of support for untested host OS

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On Thu, Mar 16, 2017 at 03:55:13PM +, Peter Maydell wrote: > On 16 March 2017 at 15:46, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > >> OK, here's a concrete proposal for deprecating/dropping out of > >> date host OS and

Re: [Qemu-devel] [PATCH 13/31] ram: Remove norm_mig_bytes_transferred

* Juan Quintela (quint...@redhat.com) wrote: > Its value can be calculated by other exported. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 - > migration/migration.c | 3 ++- >

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 16 March 2017 at 16:16, Daniel P. Berrange wrote: > BTW, by "build & test system available", presumably you mean a system > that someone has committed to actively maintaining, not merely donation > of (or access to) hardware on which to install & run VMs ? My personal

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

On 16 March 2017 at 16:25, Yongbok Kim wrote: > I updated the section before? > > Build dependencies > > QEMU now requires a minimum dtc version of 1.4.2. > > Do you mean to update it like "dtc (libfdt)"? > No, that's fine. Sorry, I must have somehow been looking at a

[Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

qemu-ga's socket activation support was not obeying the LISTEN_PID environment variable, which avoids that a process uses a socket-activation file descriptor meant for its parent. Mess can for example ensue if a process forks a children before consuming the socket-activation file descriptor and

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 16/03/2017 16:55, Peter Maydell wrote: >> IOW, I think there is a reasonable 3 tier set here >> >> 1. Stuff we actively test builds & thus guarantee will work for >> any QEMU release going forward. >> >> 2. Stuff we don't actively test, but generally assume is mostly >> working, and

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process

Re: [Qemu-devel] [RFC v2 2/3] hw/intc/arm_gicv3_its: Implement state save/restore

Hi Peter, On 13/03/2017 18:58, Peter Maydell wrote: > On 6 March 2017 at 12:48, Eric Auger wrote: >> We need to handle both registers and ITS tables. While >> register handling is standard, ITS table handling is more >> challenging since the kernel API is devised so that

Re: [Qemu-devel] [PATCH 11/31] ram: Remove unused pages_skiped variable

* Juan Quintela (quint...@redhat.com) wrote: > For compatibility, we need to still send a value, but just specify it > and comment the fact. > > Signed-off-by: Juan Quintela Note missing p in subject, Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On Thu, Mar 16, 2017 at 04:06:35PM +, Peter Maydell wrote: > On 16 March 2017 at 16:00, Daniel P. Berrange wrote: > > I'm just pretty wary of gratuitously deleting stuff that still > > has a reasonable chance of being functional, simply because > > we lack CI testing. >

[Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

OK, here's a concrete proposal for deprecating/dropping out of date host OS and architecture support. We'll put this in the ChangeLog 'Future incompatible changes' section: - * Removal of support for untested host OS and architectures: The QEMU Project intends to drop support in a future

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

Hi, > >> least cg3.c is doing > >> > >>read dirty bitmap > >>read VRAM > >>clear dirty bitmap > >> > >> which has a race. > It's much simpler than that, just clear the dirty bitmap bit before > reading the memory. Well, not *that* simple. vga checks the dirty bitmap with scanline

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 16 March 2017 at 16:00, Daniel P. Berrange wrote: > I'm just pretty wary of gratuitously deleting stuff that still > has a reasonable chance of being functional, simply because > we lack CI testing. Well, me too, but I think that if nobody turns up to help us or donate a

Re: [Qemu-devel] [PATCH for-2.9] thread-pool: add missing qemu_bh_cancel in completion function

On 16/03/2017 17:02, Peter Lieven wrote: > commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. > > However, the rescheduling of the completion BH introcuded unnecessary spinning > in the main-loop. On very fast file backends this can even lead to the > "WARNING: I/O

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

On 16/03/2017 17:19, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: >> qemu-ga's socket activation support was not obeying the LISTEN_PID >> environment variable, which avoids that a process uses a socket-activation >> file descriptor meant for its

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > OK, here's a concrete proposal for deprecating/dropping out of > date host OS and architecture support. > > We'll put this in the ChangeLog 'Future incompatible changes' > section: > - > * Removal of support for untested host OS

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process

Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

On 03/16/2017 07:04 AM, Alex Bennée wrote: > > Anishka0107 writes: > >> To prevent bitrot of the format string of the debug statement, files with >> conditional debug statements should ensure that printf is compiled always, >> and enclosed within if(0)

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

Hi, > I'm not sure here if we want to just have this as a bald list, > or to have some kind of two tier setup with OSes we expect to > dump in one tier and OSes where we're really trolling for a build > machine in the other tier (the "unlikely to dump" category would > get most of the BSD

[Qemu-devel] [PATCH for-2.9] thread-pool: add missing qemu_bh_cancel in completion function

commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. However, the rescheduling of the completion BH introcuded unnecessary spinning in the main-loop. On very fast file backends this can even lead to the "WARNING: I/O thread spun for 1000 iterations" message popping up.

[Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

qemu-ga's socket activation support was not obeying the LISTEN_PID environment variable, which avoids that a process uses a socket-activation file descriptor meant for its parent. Mess can for example ensue if a process forks a children before consuming the socket-activation file descriptor and

Re: [Qemu-devel] [PATCH v2] x86: Allow to set NUMA distance for different NUMA nodes

On Thu, Mar 16, 2017 at 04:38:24PM +0800, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create a guest that has 4

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation Message-id: 20170316161535.22157-1-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU hang on reset

According to the 9P spec [*], when a client wants to cancel a pending I/O request identified by a given tag (uint16), it must send a Tflush message and wait for the server to respond with a Rflush message before reusing this tag for another I/O. The server may still send a completion message for

Re: [Qemu-devel] [PULL 0/6] Migration fixes

ags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20170316 > > for you to fetch changes up to 8679638b0e231f97ad3456c681bf569ca7f7f6d

[Qemu-devel] [PULL for 2.9 02/49] qmp: allow setting properties to empty string in qmp-shell

From: "Daniel P. Berrange" The qmp-shell property parser currently rejects attempts to set string properties to the empty string eg (QEMU) migrate-set-parameters tls-hostname= Error while parsing command line: Expected a key=value pair, got 'tls-hostname=' command

[Qemu-devel] [PULL for 2.9 03/49] qapi: Factor QAPISchemaParser._include() out of .__init__()

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Message-Id: <1489582656-31133-2-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 45 +++-- 1

[Qemu-devel] [PULL for 2.9 01/49] qapi2texi: change texi formatters

From: Marc-André Lureau STRUCT_FMT is generic enough, rename it to TYPE_FMT, use it for unions. Rename COMMAND_FMT to MSG_FMT, since it applies to both commands and events. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL for 2.9 04/49] qapi: Make doc comments optional where we don't need them

Since we added the documentation generator in commit 3313b61, doc comments are mandatory. That's a very good idea for a schema that needs to be documented, but has proven to be annoying for testing. Make doc comments optional again, but add a new directive { 'pragma': { 'doc-required': true

[Qemu-devel] [PULL for 2.9 17/49] qapi: Conjure up QAPIDoc.ArgSection for undocumented members

qapi2texi.py already conjures up ArgSections for undocumented enumeration values, in texi_enum. Drop that, and conjure them up for all kinds of "arguments" (enumeration values, object and alternate type members) in qapi.py instead. Take care to keep generated documentation exactly the same for

[Qemu-devel] [PULL for 2.9 12/49] qapi2texi: Fix up output around #optional

We use tag #optional to mark optional members, like this: # @name: #optional The name of the guest texi_body() strips #optional, but not whitespace around it. For the above, we get in qemu-qmp-qapi.texi @item @code{'name'} (optional) The name of the guest @end table The extra

[Qemu-devel] [PULL for 2.9 22/49] qapi2texi: Plainer enum value and member name formatting

Use @code{%s} instead of @code{'%s'}. Impact, using @id as example: * Texinfo -@item @code{'id'} +@item @code{id} * HTML -'id' +id * POD (for manual pages): -=item C<'id'> +=item C * Formatted manual pages: -'id' +"id" * Plain text: - ''id'' + 'id' Signed-off-by:

[Qemu-devel] [PULL for 2.9 41/49] qapi: Drop unused variable events

Missed in commit e98859a Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1489582656-31133-40-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py

[Qemu-devel] [PULL for 2.9 43/49] qapi: Factor add_name() calls out of the meta conditional

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1489582656-31133-42-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/scripts/qapi.py

[Qemu-devel] [PULL for 2.9 16/49] qapi: Prepare for requiring more complete documentation

We currently neglect to check all enumeration values, common members of object types and members of alternate types are documented. Unsurprisingly, many aren't. Add the necessary plumbing to find undocumented ones, except for variant members of object types. Don't enforce anything just yet, but

[Qemu-devel] [PULL for 2.9 11/49] qapi: Fix to reject empty union base gracefully

Common Python pitfall: 'assert base_members' fires on [] in addition to None. Correct to 'assert base_members is not None'. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL for 2.9 25/49] qapi2texi: Don't hide undocumented members and arguments

Show undocumented object, alternate type members and command, event arguments exactly like undocumented enumeration type values. Example change (qemu-qmp-ref.txt): -- Command: query-rocker Return rocker switch information. + Arguments: + 'name' + Not documented +

[Qemu-devel] [PULL for 2.9 07/49] qapi: Have each QAPI schema declare its returns white-list

qapi.py has a hardcoded white-list of command names that may violate the rules on permitted return types. Add a new pragma directive 'returns-whitelist', and use it to replace the hard-coded white-list. Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [PULL for 2.9 45/49] qapi: struct_types is a list used like a dict, make it one

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1489582656-31133-44-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/scripts/qapi.py

[Qemu-devel] [PULL for 2.9 24/49] qapi2texi: Explain enum value undocumentedness more clearly

Instead of not saying anything when we have no documentation, say "Not documented". Example change (qemu-qmp-ref.txt): -- Enum: GuestPanicAction An enumeration of the actions taken when guest OS panic is detected Values: 'pause' system pauses 'poweroff' +

[Qemu-devel] [PULL for 2.9 27/49] qapi2texi: Include member type in generated documentation

The recent merge of docs/qmp-commands.txt and docs/qmp-events.txt into the schema lost type information. Fix this documentation regression. Example change (qemu-qmp-ref.txt): -- Struct: InputKeyEvent Keyboard input event. Members: - 'button' + 'button: InputButton'

[Qemu-devel] [PULL for 2.9 29/49] qapi2texi: Generate documentation for variant members

A flat union's branch brings in the members of another type. Generate a suitable reference to that type. Example change (qemu-qmp-ref.txt): -- Flat Union: QCryptoBlockOpenOptions The options that are available for all encryption formats when opening an existing volume

[Qemu-devel] [PULL for 2.9 31/49] qapi2texi: Use category "Object" for all object types

At the protocol level, the distinction between struct, flat union and simple union is meaningless, they are all JSON objects. Document them that way. Example change (qemu-qmp-ref.txt): - -- Simple Union: InputEvent + -- Object: InputEvent Input event union. This also fixes the

Re: [Qemu-devel] COLO failover hang

On 03/15/2017 05:06 PM, wangguang wrote: am testing QEMU COLO feature described here [QEMU Wiki](http://wiki.qemu-project.org/Features/COLO). When the Primary Node panic,the Secondary Node qemu hang. hang at recvmsg in qio_channel_socket_readv. And I run { 'execute': 'nbd-server-stop' }

[Qemu-devel] [PULL for 2.9 40/49] qapi: Eliminate check_docs() and drop QAPIDoc.expr

Move what's left in check_docs() to check_expr(). Delegate the actual checking to new QAPIDoc.check_expr(). QAPIDoc.expr is now unused; drop it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 0/3] Tracing patches

The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you

[Qemu-devel] [PULL 2/3] makefile: generate trace-events-all upfront

From: "Daniel P. Berrange" Files should not be created in the build dir during the 'make install' phase. List 'trace-events-all' as a generated file so that it gets created upfront during build. Signed-off-by: Daniel P. Berrange Reviewed-by: Fam Zheng

[Qemu-devel] [PULL for 2.9 06/49] docs/qapi-code-gen.txt: Drop confusing reference to 'gen'

Section "Commands" qualifies its rules on permitted argument and return types "with one exception noted below when 'gen' is used". The note went away in commit 2d21291. Clean up the dangling references. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake

[Qemu-devel] [PULL for 2.9 08/49] qapi: Have each QAPI schema declare its name rule violations

qapi.py has a hardcoded white-list of type names that may violate the rule on use of upper and lower case. Add a new pragma directive 'name-case-whitelist', and use it to replace the hard-coded white-list. Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [PULL for 2.9 36/49] qapi: Move empty doc section checking to doc parser

Results in a more precise error location, but the real reason is emptying out check_docs() step by step. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1489582656-31133-35-git-send-email-arm...@redhat.com> --- scripts/qapi.py

[Qemu-devel] [PULL for 2.9 00/49] QAPI patches for 2017-03-16

Significant improvements to QMP documentation, fixing its regression. Note: only QAPI *generator* code changes, except for trailing space removal in generated qmp-marshal.c and doc comments in QAPI schemas. The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: Merge

[Qemu-devel] [PULL for 2.9 47/49] qapi: Drop unused .check_clash() parameter schema

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1489582656-31133-46-git-send-email-arm...@redhat.com> --- scripts/qapi.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py

  1   2   3   4   >