Re: [Qemu-devel] [PATCH] qemu-img: simplify img_convert

Am 20.04.2017 um 16:08 hat Peter Lieven geschrieben: > Am 20.04.2017 um 16:05 schrieb Fam Zheng: > >On Tue, 02/28 14:35, Peter Lieven wrote: > >>img_convert has been around before there was an ImgConvertState or > >>a block backend, but it has never been modified to directly use > >>these structs.

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

On Thu, Apr 20, 2017 at 10:32:50PM +0200, Kevin Wolf wrote: > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > > On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > block/sheepdog.c | 1 + > > > 1 file changed, 1

Re: [Qemu-devel] question about block size and virtual disks

On 04/20/2017 04:03 PM, Chris Friesen wrote: > Hi, > > Suppose the host has a physical disk that only supports 4KB access, with > no 512B fallback. > > If we boot a guest with "cache=none", does the guest need to be able to > handle disks with 4KB blocks or is qemu able to handle guests trying

Re: [Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness

On 20 April 2017 at 21:43, BALATON Zoltan wrote: > We only emulate the sysbus device in its default LE mode and PCI is LE > as well so specify this for registers and framebuffer memory. > > Signed-off-by: BALATON Zoltan > --- I think it's worth a comment

[Qemu-devel] [PULL 13/15] hostmem: use host_memory_backend_mr_inited() where proper

From: Peter Xu Use the new interface to boost readability. Signed-off-by: Peter Xu Message-Id: <1489151370-15453-3-git-send-email-pet...@redhat.com> Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH v5 06/13] sm501: Add emulation of chip connected via PCI

Only the display controller part is created automatically on PCI Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off removing dependency on base address to separate patch v3: Added reset function and PCI ID constant

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block/sheepdog.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/block/sheepdog.c b/block/sheepdog.c >

[Qemu-devel] [PATCH v5 09/13] sm501: Misc clean ups

- Rename a variable - Move variable declarations out of loop to the beginning in draw_hwc_line Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 10 +- hw/display/sm501_template.h | 10 -- 2

[Qemu-devel] [PATCH v5 02/13] sm501: Use defined constants instead of literal values where available

Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Fix initial value of misc_control register as Peter Maydell suggested Also use M_BYTE constant from cutils.h hw/display/sm501.c | 29 +++--

[Qemu-devel] [PATCH v5 10/13] sm501: Add support for panel layer

Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off renaming a variable to separate clean up patch hw/display/sm501.c | 63 +++--- 1 file changed, 32 insertions(+), 31

[Qemu-devel] [PATCH v5 04/13] sm501: QOMify

Adding vmstate saving is not in this patch because the state structure will be changed in further patches, then another patch will add vmstate descriptor after those changes. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Add

[Qemu-devel] [PATCH v5 03/13] sm501: Add missing arbitration control register

Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6b72964..6e74200 100644 --- a/hw/display/sm501.c +++

[Qemu-devel] [PATCH v5 05/13] sm501: Get rid of base address in draw_hwc_line

Do not use the base address to access data in local memory. This is in preparation to allow chip connected via PCI where base address depends on where the BAR is mapped so it will be unknown. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On 04/19/2017 05:22 PM, Eric Blake wrote: > Libvirt would like to be able to distinguish between a SHUTDOWN > event triggered solely by guest request and one triggered by a > SIGTERM or other action on the host. qemu_kill_report() is > already able to tell whether a shutdown was triggered by a

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Remove PERL_PROG and BC_PROG

On 04/20/2017 03:15 PM, Kevin Wolf wrote: > We test for the presence of perl and bc and save their path in the > variables PERL_PROG and BC_PROG, but never actually make use of them. > Remove the checks and assignments so qemu-iotests can run even when > bc isn't installed. > > Reported-by: Yash

[Qemu-devel] [PATCH v5 11/13] sm501: Add some more missing registers

This is to allow clients to initialise these without failing as long as no 2D engine function is called that would use the written value. Saved values are not used yet (may get used when more of 2D engine is added sometimes) and clients normally only write to most of these registers, nothing is

[Qemu-devel] [PATCH v5 12/13] sm501: Add vmstate descriptor

Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too hw/display/sm501.c | 100 - 1 file changed, 99

[Qemu-devel] [PATCH v5 01/13] sm501: Fixed code style and a few typos in comments

Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 1132 ++- hw/display/sm501_template.h | 52 +- 2 files changed, 594 insertions(+), 590 deletions(-) diff --git

[Qemu-devel] [PATCH v5 08/13] sm501: Fix hardware cursor

Rework HWC handling to simplify it and fix cursor not updating on screen as needed. Previously cursor was not updated because checking for changes in a line overrode the update flag set for the cursor but fixing this is not enough because the cursor should also be updated if its shape or location

[Qemu-devel] [PULL 15/15] qdev: Constify local variable returned by blk_bs

From: Krzysztof Kozlowski Inside qdev_prop_set_drive() the value returned by blk_bs() is passed only as pointer to const to bdrv_get_node_name() and pointed values is not modified in other places so this can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On 04/20/2017 11:18 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 04/20/2017 06:59 AM, Markus Armbruster wrote: >> >>> >>> No objection to Alistair's idea to turn this into an enumeration. >> >> Question - should the enum be more than just 'guest' and 'host'? For

Re: [Qemu-devel] [RFC PATCH 0/4] nvdimm: enable flush hint address structure

On Tue, Apr 11, 2017 at 7:56 AM, Dan Williams wrote: > [ adding Christoph ] > > On Tue, Apr 11, 2017 at 1:41 AM, Haozhong Zhang > wrote: >> On 04/06/17 20:02 +0800, Xiao Guangrong wrote: >>> >>> >>> On 04/06/2017 05:43 PM, Stefan Hajnoczi

[Qemu-devel] [PATCH] qemu-iotests: Remove PERL_PROG and BC_PROG

We test for the presence of perl and bc and save their path in the variables PERL_PROG and BC_PROG, but never actually make use of them. Remove the checks and assignments so qemu-iotests can run even when bc isn't installed. Reported-by: Yash Mankad Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v5 00/13] Improvements for SM501 display controller emulation

Addressing all last review comments so hopefully this can get merged now that tree is thawed. BALATON Zoltan (13): sm501: Fixed code style and a few typos in comments sm501: Use defined constants instead of literal values where available sm501: Add missing arbitration control register

[Qemu-devel] [PATCH v5 07/13] sm501: Fix device endianness

We only emulate the sysbus device in its default LE mode and PCI is LE as well so specify this for registers and framebuffer memory. Signed-off-by: BALATON Zoltan --- v2: Split off small clean up to other patch v4: Set serial part to little endian as well v5: Make

[Qemu-devel] [PATCH v5 13/13] ppc: Add SM501 device in ppc softmmu targets default configs

This is not used by default on any emulated machine yet but it is still useful to have it compiled so it can be added from the command line for clients that can use it (e.g. MorphOS has no driver for any other emulated video cards but can output via SM501) Signed-off-by: BALATON Zoltan

[Qemu-devel] question about block size and virtual disks

Hi, Suppose the host has a physical disk that only supports 4KB access, with no 512B fallback. If we boot a guest with "cache=none", does the guest need to be able to handle disks with 4KB blocks or is qemu able to handle guests trying to access the disk with 512B granularity? Also, does

[Qemu-devel] [ANNOUNCE] QEMU 2.8.1.1 CVE update released

Hi everyone, A security update to the QEMU 2.8 series is now available at: http://wiki.qemu.org/download/qemu-2.8.1.1.tar.xz http://wiki.qemu.org/download/qemu-2.8.1.1.tar.xz.sig v2.8.1.1 is now tagged in the official qemu.git repository, and the stable-2.8 branch has been updated

[Qemu-devel] [PATCH v14 07/20] iotests: 030: Prepare for image locking

qemu-img and qemu-io commands when guest is running need "-U" option, add it. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index

[Qemu-devel] [PATCH v14 05/20] qemu-img: Update documentation for --share-rw

Signed-off-by: Fam Zheng --- qemu-img-cmds.hx | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 8ac7822..1b00bb8 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@

[Qemu-devel] [PATCH v14 08/20] iotests: 046: Prepare for image locking

The qemu-img info command is executed while VM is running, add -U option to avoid the image locking error. Signed-off-by: Fam Zheng --- tests/qemu-iotests/046 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046

[Qemu-devel] [PATCH v14 03/20] block: Respect "force-shared-write" in perm propagating

Signed-off-by: Fam Zheng --- block.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index f5c4e97..6acf618 100644 --- a/block.c +++ b/block.c @@ -1422,6 +1422,21 @@ static int bdrv_child_check_perm(BdrvChild

[Qemu-devel] [PATCH] Fix wrong length in IP header in tcp_respond.

This bug was introduced by https://github.com/qemu/qemu/commit/98c6305 And then we 'fix' it in https://github.com/qemu/qemu/commit/27d92e Actually I believe the root cause was that we sent out a RST packet with wrong length and then get ignored by OS. Signed-off-by: Tao Wu ---

[Qemu-devel] I sent out some patch this afternoon it seems it doesn't show here.

I sent it several hours ago and they don't show at http://lists.gnu.org/archive/html/qemu-devel/2017-04/index.html Is there some kind of spam filter in this list? I sent those patches with git send-email

[Qemu-devel] [PATCH 1/1] Fix wrong mss bug.

This bug was introduced by https://github.com/qemu/qemu/commit/98c6305 Signed-off-by: Tao Wu --- slirp/tcp_input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c index edb98f06f3..07bcbdb2dd 100644 ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/4] ppc: remove cannot_destroy_with_object_finalize_yet

On Tue, Apr 18, 2017 at 01:09:50PM +1000, David Gibson wrote: > On Fri, Apr 14, 2017 at 10:37:15AM +0200, Laurent Vivier wrote: > > This removes the assert(kvm_enabled()) from kvmppc_host_cpu_initfn() > > > > This assert can never be triggered as the function is only registered > > when KVM is

Re: [Qemu-devel] [PATCH v2 0/4] qdev: remove all remaining cannot_destroy_with_object_finalize_yet

On Thu, Apr 20, 2017 at 05:59:27PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 14 April 2017 at 09:37, Laurent Vivier wrote: > >> This series removes all the remaining uses of > >> cannot_destroy_with_object_finalize_yet to

[Qemu-devel] [PATCH v14 04/20] qemu-img: Add --share-rw option to subcommands

Similar to share-rw qdev property, this will force the opened images to allow shared write permission of other programs. Signed-off-by: Fam Zheng --- qemu-img.c | 155 +++-- 1 file changed, 119 insertions(+), 36

[Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later.

The current code looks buggy, we zero ti_i while we access ti_dst/ti_src later. Signed-off-by: Tao Wu --- slirp/tcp_subr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index dc8b4bbb50..398d6b30d3 100644 --- a/slirp/tcp_subr.c +++

[Qemu-devel] [RESEND PATCH] MAINTAINERS: Remove myself from e500

I recently left Freescale/NXP, and even before that it'd been a few years since I was actively involved in KVM/QEMU work. Signed-off-by: Scott Wood --- Sorry for the resend -- fixed mailing list address. MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git

[Qemu-devel] [PATCH v14 13/20] iotests: 172: Use separate images for multiple devices

To avoid image lock failures. Signed-off-by: Fam Zheng --- tests/qemu-iotests/172 | 55 +- tests/qemu-iotests/172.out | 50 + 2 files changed, 56 insertions(+), 49 deletions(-) diff --git

[Qemu-devel] [PATCH v14 10/20] iotests: 085: Avoid image locking conflict

In the case where we test the expected error when a blockdev-snapshot target already has a backing image, the backing chain is opened multiple times. This will be a problem when we use image locking, so use a different backing file that is not already open. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v14 16/20] tests: Disable image lock in test-replication

The COLO block replication architecture requires one disk to be shared between primary and secondary, in the test both processes use posix file protocol (instead of over NBD) so it is affected by image locking. Disable the lock. Signed-off-by: Fam Zheng ---

Re: [Qemu-devel] [PATCH] Fix wrong length in IP header in tcp_respond.

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170420202745.149601-1-lep...@google.com Subject: [Qemu-devel] [PATCH] Fix wrong length in IP header in tcp_respond. === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v14 11/20] iotests: 087: Don't attach test image twice

The test scenario doesn't require the same image, instead it focuses on the duplicated node-name, so use null-co to avoid locking conflict. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 6 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On Thu, Apr 20, 2017 at 12:05 PM, Eric Blake wrote: > On 04/20/2017 11:18 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 04/20/2017 06:59 AM, Markus Armbruster wrote: >>> No objection to Alistair's idea to turn this into an

Re: [Qemu-devel] [PATCH v5 13/13] ppc: Add SM501 device in ppc softmmu targets default configs

On Thu, Apr 20, 2017 at 10:43:46PM +0200, BALATON Zoltan wrote: > This is not used by default on any emulated machine yet but it is > still useful to have it compiled so it can be added from the command > line for clients that can use it (e.g. MorphOS has no driver for any > other emulated video

[Qemu-devel] [PATCH v14 01/20] block: Add, parse and store "force-shared-write" option

Signed-off-by: Fam Zheng --- block.c | 9 + include/block/block.h | 2 ++ include/block/block_int.h | 1 + 3 files changed, 12 insertions(+) diff --git a/block.c b/block.c index 1e668fb..f5c4e97 100644 --- a/block.c +++ b/block.c @@ -763,6 +763,7

[Qemu-devel] [PATCH v14 00/20] block: Image locking series

v14: - Replace BDRV_ flag with the "force-shared-write" block option. [Kevin] - Add bs->force_shared_write. - Update test case accordingly, back to bash again. :) - A few fixes in the locking code spotted by patchew and the new test, though the long line error is still there

[Qemu-devel] [PATCH v14 06/20] qemu-io: Add --share-rw option

Add --share-rw/-U to program options and -U to open subcommand. Signed-off-by: Fam Zheng --- qemu-io.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 427cbae..c4d824f 100644 --- a/qemu-io.c

[Qemu-devel] [PATCH v14 02/20] qapi: Add 'force-shared-write' to blockdev-add arguments

Signed-off-by: Fam Zheng --- qapi/block-core.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 033457c..b9b8002 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2880,6 +2880,8 @@ #

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

On Thu, 04/20 22:32, Kevin Wolf wrote: > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > > On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > block/sheepdog.c | 1 + > > > 1 file changed, 1 insertion(+) > > > >

Re: [Qemu-devel] [PATCH v2 for-2.10 00/18] crypto: add afalg-backend support

Hi Daniel, 2.9 was released, so...ping Thanks. On 2017/4/17 9:33, Longpeng(Mike) wrote: > The AF_ALG socket family is the userspace interface for linux > crypto API, users can use it to access hardware accelerators. > > This patchset adds a afalg-backend for qemu crypto subsystem. Currently >

[Qemu-devel] AccelClass initialization order question

While debugging an issue, I ran across something in the initialization sequence of hardware accelerators. Being a noobie qemu developer, it's hard to tell if I simply don't understand how AccelClass works or if this is a bug. The init_machine function for hardware accelerators is passed a

Re: [Qemu-devel] [PATCH V2 1/2] COLO-compare: Optimize tcp compare for option field

On 04/20/2017 02:43 PM, Jason Wang wrote: On 2017年04月18日 10:20, Zhang Chen wrote: In this patch we support packet that have tcp options field. Add tcp options field check, If the packet have options field we just skip it and compare tcp payload, Avoid unnecessary checkpoint, optimize

[Qemu-devel] [PATCH v14 19/20] file-posix: Add image locking in perm operations

virtlockd in libvirt locks the first byte, so we start looking at the file bytes from 0x10. The complication is in the transactional interface. To make the reopen logic managable, and allow better reuse, the code is internally organized with a table from old mode to the new one. Signed-off-by:

Re: [Qemu-devel] [PATCH V2 1/2] COLO-compare: Optimize tcp compare for option field

On 2017年04月21日 11:48, Zhang Chen wrote: On 04/20/2017 02:43 PM, Jason Wang wrote: On 2017年04月18日 10:20, Zhang Chen wrote: In this patch we support packet that have tcp options field. Add tcp options field check, If the packet have options field we just skip it and compare tcp payload,

[Qemu-devel] [PATCH v14 20/20] qemu-iotests: Add test case 153 for image locking

Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 219 tests/qemu-iotests/153.out | 627 + tests/qemu-iotests/group | 1 + 3 files changed, 847 insertions(+) create mode 100755 tests/qemu-iotests/153

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

Kevin Wolf writes: > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: >> On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: >> > Signed-off-by: Fam Zheng >> > --- >> > block/sheepdog.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> >

[Qemu-devel] [PATCH v14 09/20] iotests: 055: Don't attach the target image already for drive-backup

Double attach is not a valid usage of the target image, drive-backup will open the blockdev itself so skip the add_drive call in this case. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/055 | 32 ++-- 1

[Qemu-devel] [PATCH v14 18/20] osdep: Add qemu_lock_fd and qemu_unlock_fd

They are wrappers of POSIX fcntl "file private locking", with a convenient "try lock" wrapper implemented with F_OFD_GETLK. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- include/qemu/osdep.h | 3 +++ util/osdep.c | 48

Re: [Qemu-devel] [PATCH] hw: make *_exit functions return void

(I forgot to reply all in last email, so I resend the reply again) I have resubmitted two split-out patches in https://lists.nongnu.org/ archive/html/qemu-devel/2017-04/msg03096.html, which change the exit funtion of sclp and virtio-ccw. But the exit function of DeviceClass still returns int after

[Qemu-devel] [PATCH v14 12/20] iotests: 091: Quit QEMU before checking image

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/091 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..10ac4a8 100755 --- a/tests/qemu-iotests/091 +++

[Qemu-devel] [PULL 2/4] ppc: remove cannot_destroy_with_object_finalize_yet

From: Laurent Vivier This removes the assert(kvm_enabled()) from kvmppc_host_cpu_initfn() This assert can never be triggered as the function is only registered when KVM is available (see also 4c315c2 "qdev: Protect device-list-properties against broken devices"). So we can

[Qemu-devel] [PULL 0/4] qdev patches for 2017-04-21

The following changes since commit 359c41abe32638adad503e386969fa428cecff52: Update version for v2.9.0 release (2017-04-20 15:31:34 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qdev-2017-04-21 for you to fetch changes up to

[Qemu-devel] [PULL 1/4] arm: remove remaining cannot_destroy_with_object_finalize_yet

From: Laurent Vivier With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to realize functions"), we can now remove all the remaining cannot_destroy_with_object_finalize_yet as unsafe references have been moved to cpu_exec_realizefn(). (tested with QOM command provided

[Qemu-devel] [PULL 4/4] qdev: remove cannot_destroy_with_object_finalize_yet

From: Laurent Vivier As all users have been removed, we can remove cannot_destroy_with_object_finalize_yet field from the DeviceClass structure. Signed-off-by: Laurent Vivier Message-Id: <20170414083717.13641-5-lviv...@redhat.com> Reviewed-by: Markus

[Qemu-devel] [PATCH v14 17/20] block: Reuse bs as backing hd for drive-backup sync=none

Signed-off-by: Fam Zheng --- blockdev.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 4927914..4e04dec 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3174,6 +3174,7 @@ static BlockJob *do_drive_backup(DriveBackup

[Qemu-devel] [PATCH v14 14/20] tests: Use null-co:// instead of /dev/null as the dummy image

Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/drive_del-test.c| 2 +- tests/nvme-test.c | 2 +- tests/usb-hcd-uhci-test.c | 2 +- tests/usb-hcd-xhci-test.c | 2 +- tests/virtio-blk-test.c | 2 +- tests/virtio-scsi-test.c | 4 ++-- 6

Re: [Qemu-devel] [PATCH 1/1] Fix wrong mss bug.

Hi Tao, On 04/20/2017 04:36 PM, Tao Wu wrote: This bug was introduced by https://github.com/qemu/qemu/commit/98c6305 Nice catch... In 98c6305 Guillaume probably missed parentheses :S - mss = min(IF_MTU, IF_MRU) - sizeof(struct tcpiphdr); + mss = min(IF_MTU, IF_MRU) - sizeof(struct tcphdr) +

Re: [Qemu-devel] [PATCH] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed

On Fri, Apr 21, 2017 at 10:58 AM, 858585 jemmy wrote: > On Thu, Apr 20, 2017 at 6:00 PM, Kevin Wolf wrote: >> Am 20.04.2017 um 10:38 hat jemmy858...@gmail.com geschrieben: >>> From: Lidong Chen >>> >>> when the buffer is zero,

Re: [Qemu-devel] [PATCH] qemu-iotests: Remove PERL_PROG and BC_PROG

On Thu, 04/20 22:15, Kevin Wolf wrote: > We test for the presence of perl and bc and save their path in the > variables PERL_PROG and BC_PROG, but never actually make use of them. > Remove the checks and assignments so qemu-iotests can run even when > bc isn't installed. > > Reported-by: Yash

Re: [Qemu-devel] [PATCH] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed

On Thu, Apr 20, 2017 at 6:00 PM, Kevin Wolf wrote: > Am 20.04.2017 um 10:38 hat jemmy858...@gmail.com geschrieben: >> From: Lidong Chen >> >> when the buffer is zero, blk_co_pwrite_zeroes is more effectively than >> blk_co_pwritev with

[Qemu-devel] [PATCH v14 15/20] file-posix: Add 'locking' option

Making this option available even before implementing it will let converting tests easier: in coming patches they can specify the option already when necessary, before we actually write code to lock the images. Signed-off-by: Fam Zheng --- block/file-posix.c | 5 + 1 file

[Qemu-devel] [PULL 3/4] versatile: remove cannot_destroy_with_object_finalize_yet

From: Laurent Vivier cannot_destroy_with_object_finalize_yet was added by 4c315c2 ("qdev: Protect device-list-properties against broken devices") because "realview_pci" and "versatile_pci" were hanging during "device-list-properties" cleanup (an infinite loop in

Re: [Qemu-devel] [PATCH v2 0/4] qdev: remove all remaining cannot_destroy_with_object_finalize_yet

Laurent Vivier writes: > This series removes all the remaining uses of > cannot_destroy_with_object_finalize_yet to finally remove > the flag itself. > > The ARM patch has already been sent alone and reviewed by Markus. > I have tested the ppc one on ppc64 machine with KVM

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

On Thu, Apr 20, 2017 at 12:14:18AM -0400, Pranith Kumar wrote: > On Wed, Apr 19, 2017 at 10:26 PM, Eduardo Habkost wrote: > > On Wed, Apr 19, 2017 at 06:03:01PM -0400, Pranith Kumar wrote: > >> On Wed, Apr 19, 2017 at 5:33 PM, Eduardo Habkost > >>

[Qemu-devel] [PULL 04/15] memory: introduce memory_region_notify_one()

From: Peter Xu Generalizing the notify logic in memory_region_notify_iommu() into a single function. This can be further used in customized replay() functions for IOMMUs. Reviewed-by: David Gibson Reviewed-by: Eric Auger

[Qemu-devel] [PULL 01/15] memory: add section range info for IOMMU notifier

From: Peter Xu In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check the notification type (MAP|UNMAP), but also check whether the notified iova range overlaps with the range of

[Qemu-devel] [PULL 00/15] Machine queue for 2.10

This includes a few IOMMU fixes because Michael is away this week. The following changes since commit da92ada855036c55bd08b0b0c64c7551d56f3586: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170420' into staging (2017-04-20 17:41:34 +0100) are available in the git

[Qemu-devel] [PULL 06/15] intel_iommu: use the correct memory region for device IOTLB notification

From: Jason Wang We have a specific memory region for DMAR now, so it's wrong to trigger the notifier with the root region. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PULL 02/15] memory: provide IOMMU_NOTIFIER_FOREACH macro

From: Peter Xu A new macro is provided to iterate all the IOMMU notifiers hooked under specific IOMMU memory region. Reviewed-by: David Gibson Reviewed-by: Eric Auger Reviewed-by: \"Michael S. Tsirkin\"

[Qemu-devel] [PULL 03/15] memory: provide iommu_replay_all()

From: Peter Xu This is an "global" version of existing memory_region_iommu_replay() - we announce the translations to all the registered notifiers, instead of a specific one. Reviewed-by: David Gibson Reviewed-by: \"Michael S. Tsirkin\"

[Qemu-devel] [PULL 08/15] intel_iommu: allow dynamic switch of IOMMU region

From: Peter Xu This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU address space, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region

[Qemu-devel] [PULL 07/15] intel_iommu: provide its own replay() callback

From: Peter Xu The default replay() don't work for VT-d since vt-d will have a huge default memory region which covers address range 0-(2^64-1). This will normally consumes a lot of time (which looks like a dead loop). The solution is simple - we don't walk over all the

[Qemu-devel] [PULL 12/15] hostmem: introduce host_memory_backend_mr_inited()

From: Peter Xu We were checking this against memory region size of host memory backend's mr field to see whether the mr has been inited. This is efficient but less elegant. Let's make a helper for it to avoid confusions, along with some notes. Suggested-by: Peter Maydell

[Qemu-devel] [PULL 09/15] intel_iommu: enable remote IOTLB

From: Peter Xu This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html However I removed/fixed some content, and added my own

[Qemu-devel] [PULL 05/15] memory: add MemoryRegionIOMMUOps.replay() callback

From: Peter Xu Originally we have one memory_region_iommu_replay() function, which is the default behavior to replay the translations of the whole IOMMU region. However, on some platform like x86, we may want our own replay logic for IOMMU regions. This patch adds one more

Re: [Qemu-devel] [PATCH v2 1/2] migration: don't close a file descriptor while it can be in use

* Laurent Vivier (lviv...@redhat.com) wrote: > If we close the QEMUFile descriptor in process_incoming_migration_co() > while it has been stopped by an error, the postcopy_ram_listen_thread() > can try to continue to use it. And as the memory has been freed > it is working with an invalid pointer

[Qemu-devel] [PULL 14/15] qdev: Constify value passed to qdev_prop_set_macaddr

From: Krzysztof Kozlowski The 'value' argument is not modified so this can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski Message-Id: <20170310200550.13313-2-k...@kernel.org> Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL 10/15] qdev: Make "hotplugged" property read-only

The "hotplugged" property is user visible, but it was never meant to be set by the user. There are probably multiple ways to break or crash device code by overriding the property. For example, we recently fixed a crash in rtc_set_memory() related to the property (commit

[Qemu-devel] [PULL 11/15] hw/core/null-machine: Print error message when using the -kernel parameter

From: Thomas Huth If the user currently tries to use the -kernel parameter, simply nothing happens, and the user might get confused that there is nothing loaded to memory, but also no error message has been issued. Since there is no real generic way to load a kernel on all CPU

Re: [Qemu-devel] [PATCH v2] qga: Add support network interface statistics in guest-network-get-interfaces command

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 1492684955-27154-1-git-send-email-lu.zhip...@zte.com.cn Subject: [Qemu-devel] [PATCH v2] qga: Add support network interface statistics in guest-network-get-interfaces command Type: series === TEST

Re: [Qemu-devel] [RFC PATCH 4/4] nvdimm acpi: build flush hint address structure if required

On Fri, 31 Mar 2017 16:41:47 +0800 Haozhong Zhang wrote: > Add an boolean option 'flush-hint' to device 'nvdimm'. If it's on, a > flush hint address structure will be constructed for each nvdimm > device. > > Signed-off-by: Haozhong Zhang >

[Qemu-devel] [PATCH 11/17] block: access write_gen with atomics

Signed-off-by: Paolo Bonzini --- block.c | 2 +- block/io.c| 6 +++--- include/block/block_int.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index a48fdd8..f1aec36 100644 --- a/block.c +++

[Qemu-devel] [PATCH 06/17] block: access io_plugged with atomic ops

Signed-off-by: Paolo Bonzini --- block/io.c| 4 ++-- include/block/block_int.h | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/io.c b/block/io.c index 3b2ede9..3ab9476 100644 --- a/block/io.c +++ b/block/io.c @@ -2653,7

[Qemu-devel] [PATCH 13/17] coroutine-lock: introduce qemu_co_mutex_lock_unlock

This primitive lets you lock/unlock a CoMutex, guaranteeing neither blocking nor cacheline bouncing if there is no qemu_co_mutex_lock critical section. Signed-off-by: Paolo Bonzini --- include/qemu/coroutine.h | 6 ++ util/qemu-coroutine-lock.c | 36

[Qemu-devel] [PATCH 14/17] block: optimize access to reqs_lock

Hot path reqs_lock critical sections are very small; the only large critical sections happen when a request waits for serialising requests, and these should never happen in usual circumstances. We do not want these small critical sections to yield in any case, which calls for using a spinlock

[Qemu-devel] [PATCH 04/17] block: access serialising_in_flight with atomic ops

Signed-off-by: Paolo Bonzini --- block/io.c| 6 +++--- include/block/block_int.h | 10 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/block/io.c b/block/io.c index 3a27fd5..869322a 100644 --- a/block/io.c +++ b/block/io.c @@ -375,7

Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN

On Thu, Apr 20, 2017 at 01:59:29PM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > Libvirt would like to be able to distinguish between a SHUTDOWN > > event triggered solely by guest request and one triggered by a > > SIGTERM or other action on the host.

  1   2   3   >