Re: [Qemu-devel] [PATCH 1/2] block: Fix backing paths for filenames with colons

On 05/22/2017 01:07 PM, Max Reitz wrote: > path_combine() naturally tries to preserve a protocol prefix. However, > it recognizes such a prefix by scanning for the first colon; which is > different from what path_has_protocol() does: There only is a protocol > prefix if there is a colon before the

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target

Re: [Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

On 05/19/2017 04:34 AM, Anton Nefedov wrote: > in such case, bdrv_get_block_status() shall return 0, *nr == 0 Sounds better as s/shall/will/ > > iotest 154 updated accordingly: write-zeroes tail alignment can be detected > as zeroes now, so pwrite_zeroes succeeds > > Signed-off-by: Anton

[Qemu-devel] [PATCH v11 3/5] hw/ppc: migrating the DRC state of hotplugged devices

In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface to manage configuration/removal of the resource associated with it. In other words, DRC is the 'plugged state' of a device.

[Qemu-devel] [PATCH v11 5/5] migration: spapr: migrate ccs_list in spapr state

From: Jianjun Duan ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target

Re: [Qemu-devel] [PATCH 1/4] qobject-input-visitor: Reject non-finite numbers with keyval

On 05/22/2017 11:42 AM, Markus Armbruster wrote: > The QObject input visitor can produce only finite numbers when its > input comes out of the JSON parser, because the the JSON parser > implements RFC 7159, which provides no syntax for infinity and NaN. > > However, it can produce infinity and

[Qemu-devel] [PATCH 1/2] block: Fix backing paths for filenames with colons

path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first slash. A protocol prefix that is not

[Qemu-devel] [PATCH 2/2] iotests: Add test for colon handling

Signed-off-by: Max Reitz --- I apologize for the patch title for sounding a bit squishy. But I like it so I won't change it. --- tests/qemu-iotests/126 | 76 ++ tests/qemu-iotests/126.out | 16 ++ tests/qemu-iotests/group

[Qemu-devel] [PATCH v11 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After each call to this callback, the nr_lmbs is decremented by one and, when it reaches zero, the callback proceeds with the

Re: [Qemu-devel] [PATCH v3 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

On 05/22/2017 08:57 AM, Stefan Hajnoczi wrote: > blk/bdrv_drain_all() only takes effect for a single instant and then > resumes block jobs, guest devices, and other external clients like the > NBD server. This can be handy when performing a synchronous drain > before terminating the program, for

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

On Mon, May 22, 2017 at 02:58:56PM +0200, Igor Mammedov wrote: > On Mon, 22 May 2017 14:01:15 +0300 > Evgeny Yakovlev wrote: > > > On 22.05.2017 13:35, Igor Mammedov wrote: > > > On Mon, 22 May 2017 12:50:30 +0300 > > > Evgeny Yakovlev wrote: >

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

v13: - rebased with dgibson/ppc-for-2.10 - patch 1 removed from the series (already applied at ppc-for-2.10) - data_size is now being calculated by using the extended_length field inside rtas_event_log_queue v12: - patch 2: added a switch statement to get the proper data_size based on the

Re: [Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

On 05/22/2017 02:12 PM, Eric Blake wrote: >> +++ b/block/qcow2.c >> @@ -2482,7 +2482,7 @@ static bool is_zero_sectors(BlockDriverState *bs, >> int64_t start, >> int64_t res; >> >> if (start + count > bs->total_sectors) { >> -count = bs->total_sectors - start; >> +

Re: [Qemu-devel] [PATCH v1 03/13] qcow2: do not COW the empty areas

On 05/19/2017 04:34 AM, Anton Nefedov wrote: > If COW area of the newly allocated cluster is zeroes, there is no reason > to write zero sectors in perform_cow() again now as whole clusters are > zeroed out in single chunks by handle_alloc_space(). But that's only true if you can guarantee that

Re: [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow

On 05/19/2017 04:34 AM, Anton Nefedov wrote: > Avoid complicated nested conditions; return or continue asap instead. > The logic is not changed. > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > --- > block/qcow2-cluster.c | 45

[Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 105 + tests/qemu-iotests/126.out | 23 ++ tests/qemu-iotests/group | 1 + 3 files changed, 129 insertions(+) create mode 100755 tests/qemu-iotests/126 create

[Qemu-devel] [PATCH v2 0/3] block: Fix backing paths for filenames with colons

There are (at least) two issues with filenames that contain colons when trying to use relative backing filenames with them, for each of which there is a patch in this series. The first patch fixes an issue in the general block layer (path_combine() does not have the same opinion on what

[Qemu-devel] [PATCH v2 2/3] block/file-*: *_parse_filename() and colons

The file drivers' *_parse_filename() implementations just strip the optional protocol prefix off the filename. However, for e.g. "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's filename which looks like it should be managed using the "foo" protocol. This is especially

Re: [Qemu-devel] [PATCH 3/3] numa: silence incomplete mapping warning under qtest

On Mon, May 22, 2017 at 09:58:36AM +0200, Igor Mammedov wrote: > On Thu, 18 May 2017 15:20:39 -0300 > Eduardo Habkost wrote: > > > On Thu, May 18, 2017 at 10:09:31AM +0200, Igor Mammedov wrote: > > > Suggested-by: Markus Armbruster > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

On 05/22/2017 11:56 AM, Daniel P. Berrange wrote: > On Mon, May 22, 2017 at 11:00:26AM -0500, Eric Blake wrote: >> On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: >>> The semantics around handling ipv4=on|off & ipv6=on|off are quite >>> subtle to understand in combination with the various

Re: [Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

O Fri, May 19, 2017 at 05:14:19PM -0500, Eric Blake wrote: > On 05/19/2017 02:30 AM, Yang Zhong wrote: > > Move the tcg relative files into tcg directory, which will make > > the code more clean in qemu. > > Titling a patch series v0 is a bit unusual (typically, the first version > is untitled,

Re: [Qemu-devel] [PATCH 2/4] qapi: Document visit_type_any() issues with keyval input

On 05/22/2017 11:42 AM, Markus Armbruster wrote: > It's already documented in keyval.c (commit 0ee9ae7), but visitor.h > can use a note, too. > > Signed-off-by: Markus Armbruster > --- > include/qapi/visitor.h | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for colon handling

On 05/22/2017 01:07 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > I apologize for the patch title for sounding a bit squishy. But I like > it so I won't change it. That was a mental image I did not need. ;) > --- > tests/qemu-iotests/126 | 76 >

Re: [Qemu-devel] [PATCH v2 2/3] block/file-*: *_parse_filename() and colons

On 05/22/2017 02:52 PM, Max Reitz wrote: > The file drivers' *_parse_filename() implementations just strip the > optional protocol prefix off the filename. However, for e.g. > "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's > filename which looks like it should be managed

Re: [Qemu-devel] [PATCH 3/4] tests/qapi-schema: Avoid 'str' in alternate test cases

On 05/22/2017 11:42 AM, Markus Armbruster wrote: > The next commit is going to make alternate members of type 'str' > conflict with other scalar types. Would break a few test cases that > don't actually require 'str'. Flip them from 'str' to 'bool' or > 'EnumOne'. > > Signed-off-by: Markus

[Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling

I had two problems with QEMU on macOS: 1) Sometimes when alt-tabbing to QEMU it would act as if the 'a' key was pressed so I'd get 'a'. 2) Using Sikuli to programatically send keys to the QEMU window text like "foo_bar" would come out as "fooa-bar". They looked similar and

Re: [Qemu-devel] [PATCH v1 01/13] qcow2: alloc space for COW in one chunk

On 05/19/2017 04:34 AM, Anton Nefedov wrote: > From: "Denis V. Lunev" > > Currently each single write operation can result in 3 write operations > if guest offsets are not cluster aligned. One write is performed for the > real payload and two for COW-ed areas. Thus the data

Re: [Qemu-devel] [PATCH v1 04/13] qcow2: preallocation at image expand

On 05/19/2017 04:34 AM, Anton Nefedov wrote: > From: "Denis V. Lunev" > > This patch adds image preallocation at expand to provide better locality > of QCOW2 image file and optimize this procedure for some distributed > storages where this procedure is slow. > > Image expand

[Qemu-devel] [PATCH v11 0/5] migration/ppc: migrating DRC and ccs_list

v11: - rebased with dgibson/ppc-for-2.10 branch - patch 1: * use PCDIMMDevice* as index of pending_dimm_unplugs list instead of using its uint64_t address; * spapr_del_lmbs() function was merged with spapr_memory_unplug_request(); * wherever applicable, retrieve the machine by using

[Qemu-devel] [PATCH v11 2/5] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

The pointer drc->detach_cb is being used as a way of informing the detach() function inside spapr_drc.c which cb to execute. This information can also be retrieved simply by checking drc->type and choosing the right callback based on it. In this context, detach_cb is redundant information that

[Qemu-devel] [PATCH v11 4/5] hw/ppc/spapr.c: recover pending LMB unplug info in spapr_lmb_release

When a LMB hot unplug starts, the current DRC LMB status is stored at spapr->pending_dimm_unplugs QTAILQ. This queue isn't migrated, thus if a migration occurs in the middle of a LMB unplug the spapr_lmb_release callback will lost track of the LMB unplug progress. This patch implements a new

[Qemu-devel] [PATCH v2 1/3] block: Fix backing paths for filenames with colons

path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first slash. A protocol prefix that is not

[Qemu-devel] [PATCH] qemu-doc: Add hyperlinks to further license information

Add a link to the GPLv2 and a link to the LICENSE file in the QEMU repository to fix the two TODO items in this appendix. Signed-off-by: Thomas Huth --- qemu-doc.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi

[Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

- offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Replace first_sectors_number - 1 by offset_to_bootsector. Replace

[Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names

More specifically: - try without numeric-tail only if LFN didn't have invalid short chars - start at ~1 (instead of ~0) - handle case if numeric tail is more than one char (ie > 10) Windows 9x Scandisk doesn't see anymore mismatches between short file names and long file names for non-ASCII

[Qemu-devel] [PATCH v2 06/13] vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors

Specification: "FAT: General overview of on-disk format" v1.03, pages 11-13 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

On 05/22/2017 04:11 PM, Hervé Poussineau wrote: > - bs->total_sectors is the number of sectors of the whole disk > - s->sector_count is the number of sectors of the FAT partition > > This fixes the following assert in qemu-img map: > qemu-img.c:2641: get_block_status: Assertion `nb_sectors'

[Qemu-devel] [PATCH] qapi: Fix some blockdev-add documentation regressions

In the process of getting rid of docs/qmp-commands.txt, we managed to regress on any text that changed after the point where the move was first branched and when the move actually occurred. For example, commit 3282eca for blockdev-snapshot re-added the extra "options" layer which had been cleaned

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

On 2017-05-22 22:06, Eric Blake wrote: > On 05/22/2017 02:52 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/126 | 105 >> + >> tests/qemu-iotests/126.out | 23 ++ >>

[Qemu-devel] [PATCH] qemu-doc: Move the qemu-ga description into a separate chapter

The qemu-ga description is currently a subsection of the Disk Images chapter - which does not make much sense since the qemu-ga is not directly related to disk images. So let's move this information into a separate chapter instead. Signed-off-by: Thomas Huth --- qemu-doc.texi

[Qemu-devel] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames

More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch between SFN and LFN. Specification: "FAT: General

[Qemu-devel] [PATCH v2 12/13] vvfat: handle KANJI lead byte 0xe5

Specification: "FAT: General overview of on-disk format" v1.03, page 23 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 5376659010..53e8faa54c 100644 ---

[Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

Hi, This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 Patch 1 fixes a crash when using 'qemu-img convert'. Patches 2 to 6 are code cleanup. No functionnal changes. Patches 7 to 13 fix problems detected

[Qemu-devel] [PATCH v2 03/13] vvfat: fix typos

Signed-off-by: Hervé Poussineau --- block/vvfat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index d3afb731b6..8b5f53ad26 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -404,9 +404,9 @@ static void

[Qemu-devel] [PATCH v2 08/13] vvfat: correctly create long names for non-ASCII filenames

Assume that input filename is encoded as UTF-8, so correctly create UTF-16 encoding. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/block/vvfat.c

[Qemu-devel] [PATCH v2 04/13] vvfat: rename useless enumeration values

MODE_FAKED and MODE_RENAMED are not and were never used. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 8b5f53ad26..6a36d4f7fa 100644 ---

Re: [Qemu-devel] [PATCH 3/4] block: Simplify use of BDRV_BLOCK_RAW.

On 05/18/2017 09:32 PM, Eric Blake wrote: Not sure why I included a trailing dot in the subject line; a maintainer can remove that if desired. > The lone caller that cares about a return of BDRV_BLOCK_RAW > completely replaces the return value, so there is no point in > passing BDRV_BLOCK_DATA.

[Qemu-devel] [PATCH v2 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16

FAT12/FAT16 root directory is two sectors in size, which allows only 512 directory entries. Prevent QEMU startup if too much files exist, instead of overflowing root directory. Also introduce variable root_entries, which will be required for FAT32. Fixes:

[Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some FAT drivers might not recognize the volume." Specification:

[Qemu-devel] [PATCH v2 02/13] vvfat: replace tabs by 8 spaces

This was a complete mess. On 2299 indented lines: - 1329 were with spaces only - 617 with tabulations only - 353 with spaces and tabulations Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2054 - 1 file changed,

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

On 05/22/2017 02:52 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/126 | 105 > + > tests/qemu-iotests/126.out | 23 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 129

[Qemu-devel] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

- bs->total_sectors is the number of sectors of the whole disk - s->sector_count is the number of sectors of the FAT partition This fixes the following assert in qemu-img map: qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed. This also fixes an infinite loop in qemu-img convert.

[Qemu-devel] [PATCH v2 07/13] vvfat: always create . and .. entries at first and in that order

readdir() doesn't always return . and .. entries at first and in that order. This leads to not creating them at first in the directory, which raises some errors on file system checking utilities like MS-DOS Scandisk. Specification: "FAT: General overview of on-disk format" v1.03, page 25 Fixes:

Re: [Qemu-devel] [PATCH v8 14/21] (SQUASHED) move doc to schema

On 01/13/2017 08:41 AM, Marc-André Lureau wrote: > qmp-commands: move 'add_client' doc to schema > Sadly, the squashed version introduced some documentation regressions. For example, the documentation for blockdev-snapshot (got merged as commit 3282eca4): > @@ -983,9 +1193,31 @@ > # > #

Re: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170522211205.14265-1-hpous...@reactos.org Subject: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

>From 468b7c74d36b1e9d56ca014531301f0485254866 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Fri, 19 May 2017 00:01:07 +0100 Subject: [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. Add inital discussion of protocol version. Add code to connect with

[Qemu-devel] [PATCH V2] Add code to connect to external panel, for ARM

>From 5f5c186162ef5f56872095318106e9fe360ae310 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Tue, 23 May 2017 01:43:32 +0100 Subject: [PATCH] Add code to connect to external panel, for ARM Has no effect if panel not found. GDummyPanel Fix formating issues. Add inital

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

On Mon, May 22, 2017 at 04:33:36PM +0200, Greg Kurz wrote: > On Mon, 22 May 2017 12:12:46 +1000 > David Gibson wrote: > > > On Mon, May 22, 2017 at 12:04:13PM +1000, David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > > For

[Qemu-devel] [PATCH 07/31] target/s390x: Use unwind data for helper_clc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0295485..d04850b 100644 ---

[Qemu-devel] [PATCH 09/31] target/s390x: Use unwind data for helper_srst

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 5f38ac3..3c28f3a 100644 ---

[Qemu-devel] [PATCH 04/31] target/s390x: Use unwind data for helper_xc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 25 - target/s390x/translate.c | 1 - 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1018fe0..e0a6fad 100644

[Qemu-devel] [PATCH 05/31] target/s390x: Use unwind data for helper_oc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e0a6fad..e75c2de0 100644 ---

[Qemu-devel] [PATCH 13/31] target/s390x: Use unwind data for helper_lam

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d1a7bcd..4ecec74 100644 ---

[Qemu-devel] [PATCH 14/31] target/s390x: Use unwind data for helper_stam

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4ecec74..d6d5047 100644 ---

[Qemu-devel] [PATCH 25/31] target/s390x: Use unwind data for helper_stctl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b169e0e..1e31bd3 100644 ---

[Qemu-devel] [PATCH 24/31] target/s390x: Use unwind data for helper_lctl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 26960e4..b169e0e 100644 ---

[Qemu-devel] [PATCH 30/31] target/s390x: Implement CSPG

Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 4c91f30..8604847 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -838,6

[Qemu-devel] [PATCH 29/31] target/s390x: Use atomic operations for COMPARE SWAP PURGE

Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 32 target/s390x/translate.c | 42 ++ 4 files changed, 48

[Qemu-devel] [PATCH 17/31] target/s390x: Use unwind data for helper_clcle

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7a59be0..6e85406 100644 ---

[Qemu-devel] [PATCH 26/31] target/s390x: Use unwind data for helper_testblock

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 +++ target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1e31bd3..a874f8a 100644 ---

[Qemu-devel] [PATCH 16/31] target/s390x: Use unwind data for helper_mvcle

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b764c48..7a59be0 100644 ---

[Qemu-devel] [PATCH 22/31] target/s390x: Use unwind data for helper_trt

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4c6c6ee..902290c 100644 ---

[Qemu-devel] [PATCH 31/31] target/s390x: Use unwind data for helper_mvcs/mvcp

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 ++-- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 4becc80..d8d29bd 100644 ---

[Qemu-devel] [PATCH 21/31] target/s390x: Use unwind data for helper_tre

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 15 --- target/s390x/translate.c | 1 - 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 748a6e8..4c6c6ee 100644 ---

[Qemu-devel] [PATCH 23/31] target/s390x: Use unwind data for helper_lctlg

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 902290c..26960e4 100644 ---

[Qemu-devel] [PATCH v5 3/4] net/rocker: Convert to realize()

The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a

[Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

v5: * Patch 1 removed the dead error handling that was previously missing. * Patch 2 and 3 has not changed. * Patch 4 is a new patch to fix the unusual macro name. v4: * Patch 1 is following Markus's suggestion that remove the dead error handling. * Patch 2 is separate from patch 1 to plug the

[Qemu-devel] [PATCH v5 4/4] net/rocker: Fix the unusual macro name

Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/net/rocker/rocker.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 2764529..f8a32f7

[Qemu-devel] [PATCH v5 2/4] net/rocker: Plug memory leak in pci_rocker_init()

pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Signed-off-by: Mao Zhongyi Reviewed-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

On Mon, May 22, 2017 at 03:40:39PM -0300, Daniel Henrique Barboza wrote: > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started.

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v2 4/4] spapr: Fix migration of Radix guests

On Mon, May 22, 2017 at 04:30:50PM +1000, Suraj Jitindar Singh wrote: > On Fri, 2017-05-19 at 11:10 +0530, Bharata B Rao wrote: > > Fix migration of radix guests by ensuring that we issue > > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > > > Reported-by: Nageswara R Sastry

[Qemu-devel] [PULL 1/9] net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

From: Thomas Huth The files tap-haiku.c and tap-aix.c are identical (except one line of error message). We should avoid such code duplication, so replace these by a generic tap-stub.c file instead. Signed-off-by: Thomas Huth Reviewed-by: Philippe

[Qemu-devel] [PULL 0/9] Net patches

The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you

[Qemu-devel] [PULL 4/9] COLO-compare: Improve tcp compare trace event readability

From: Zhang Chen Because of previous patch's trace arguments over the limit of UST backend, so I rewrite the patch. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 33

[Qemu-devel] [PULL 5/9] hmp / net: Mark host_net_add/remove as deprecated

From: Thomas Huth The netdev_add and netdev_del commands should be used nowadays instead. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- hmp-commands.hx | 8 net/net.c | 13 + 2 files changed, 17

[Qemu-devel] [PULL 2/9] net/dump: Issue a warning for the deprecated "-net dump"

From: Thomas Huth Network dumping should be done with "-object filter-dump" nowadays. Using "-net dump" via the VLAN mechanism is considered as deprecated and might be removed in a future release. So warn the users now to inform them to user the filter-dump method instead.

[Qemu-devel] [PULL 8/9] net/filter-rewriter: Remove unused option in filter-rewriter

From: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index

[Qemu-devel] [PULL 3/9] virtio-net: fix wild pointer when remove virtio-net queues

From: Yunjian Wang The tx_bh or tx_timer will free in virtio_net_del_queue() function, when removing virtio-net queues if the guest doesn't support multiqueue. But it might be still referenced by virtio_net_set_status(), which needs to be set NULL. And also the tx_waiting

[Qemu-devel] [PULL 6/9] net/filter-mirror.c: Remove duplicate check code.

From: Zhang Chen The s->outdev have checked in filter_mirror_set_outdev(). Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/filter-mirror.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[Qemu-devel] [PULL 7/9] net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle

From: Zhang Chen Because filter_mirror_receive_iov() and filter_redirector_receive_iov() both use the filter_mirror_send() to send packet, so I change filter_mirror_send() to filter_send() that looks more common. And fix some codestyle. Signed-off-by: Zhang Chen

[Qemu-devel] [PULL 9/9] e1000e: Fix ICR "Other" causes clear logic

From: Sameeh Jubran This commit fixes a bug which causes the guest to hang. The bug was observed upon a "receive overrun" (bit #6 of the ICR register) interrupt which could be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit (#6)

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

On Mon, May 22, 2017 at 10:59:50AM +0200, Greg Kurz wrote: > On Mon, 22 May 2017 12:04:13 +1000 > David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > For historical reasons, we compute CPU device-tree ids with a non-trivial > >

[Qemu-devel] [PATCH 01/31] target/s390: Use cpu_loop_exit_restore for tlb_fill

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0c6a0d9..e3325a4 100644 --- a/target/s390x/mem_helper.c +++

[Qemu-devel] [PATCH 00/31] target/s390x unwind patches

We can use cpu_restore_state (and via *_ra memory helpers) to avoid storing cpu state in expectation of the unlikely case of page fault or specification error. There are more that can be fixed, but this is all of mem_helper.c, and this patch set is large enough. r~ Richard Henderson (31):

[Qemu-devel] [PATCH 02/31] target/s390x: Implement EXECUTE via new TranslationBlock

Previously, helper_ex would construct the insn and then implement the insn via direct calls other helpers. This was sufficient to boot Linux but that is all. It is easy enough to go the whole nine yards by stashing state for EXECUTE within the cpu, and then relying on a new TB to be created that

[Qemu-devel] [PATCH 03/31] target/s390x: Use unwind data for helper_nc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 18 +- target/s390x/translate.c | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index db80d53..1018fe0 100644 ---

[Qemu-devel] [PATCH 06/31] target/s390x: Use unwind data for helper_mvc

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 19 ++- target/s390x/translate.c | 1 - 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e75c2de0..0295485 100644 ---

[Qemu-devel] [PATCH 08/31] target/s390x: Use unwind data for helper_clm

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d04850b..5f38ac3 100644 ---

[Qemu-devel] [PATCH 15/31] target/s390x: Use unwind data for helper_mvcl

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d6d5047..b764c48 100644 ---

[Qemu-devel] [PATCH 12/31] target/s390x: Use unwind data for helper_mvst

Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 9ef9f4a..d1a7bcd 100644 ---

  1   2   3   >