Re: [Qemu-devel] [PATCH v2] xen-platform: Cleanup network infrastructure when emulated NICs are unplugged

On Fri, Jun 30, 2017 at 01:50:28PM +0100, Ross Lagerwall wrote: > When the guest unplugs the emulated NICs, cleanup the peer for each NIC > as it is not needed anymore. Most importantly, this allows the tap > interfaces which QEMU holds open to be closed and removed. > > Signed-off-by: Ross

[Qemu-devel] [PATCH v3 06/10] nbd/client: refactor TRACE of NBD_MAGIC

We are going to switch from TRACE macro to trace points, this TRACE complicates things, this patch simplifies it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/nbd/client.c

Re: [Qemu-devel] [PATCH v3 07/10] nbd/server: fix TRACE in nbd_negotiate_send_rep_len

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Fix wrong order of TRACE arguments. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v11 24/29] target/arm: [tcg, a64] Port to translate_insn

On Fri, Jul 07, 2017 at 05:46:19 -1000, Richard Henderson wrote: > I do wonder if we should provide a generic empty hook, so that a target that > does not need a particular hook need not define an empty function. It could > just put e.g. "translator_noop" into the structure. Ok, maybe a better

Re: [Qemu-devel] [Qemu devel v6 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block.

On Fri, Jul 7, 2017 at 12:08 AM, sundeep subbaraya wrote: > Hi Alistair, > > On Wed, Jul 5, 2017 at 11:36 PM, Alistair Francis > wrote: >> >> On Sun, Jul 2, 2017 at 9:45 PM, Subbaraya Sundeep >> wrote: >> > Added Sytem

[Qemu-devel] [PULL 027/100] mirror: Switch MirrorBlockJob to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Continue by converting an internal structure (no semantic change), and all references to the buffer size. Add an assertion that our use of

[Qemu-devel] [PULL 013/100] vvfat: correctly create base short names for non-ASCII filenames

From: Hervé Poussineau More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch

[Qemu-devel] [PULL 057/100] block: remove all encryption handling APIs

From: "Daniel P. Berrange" Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the

[Qemu-devel] [PULL 031/100] mirror: Switch mirror_do_read() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function, preserving all existing semantics, and adding one more assertion that things are still sector-aligned (so that

[Qemu-devel] [PULL 032/100] mirror: Switch mirror_iteration() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the internal loop iteration of mirroring to track by bytes instead of sectors (although we are still guaranteed that we iterate by steps that

[Qemu-devel] [PULL 035/100] backup: Switch block_backup.h to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Continue by converting the public interface to backup jobs (no semantic change), including a change to CowRequest to track by bytes instead of cluster

[Qemu-devel] [PULL 047/100] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

From: "Daniel P. Berrange" Historically the qcow & qcow2 image formats supported a property "encryption=on" to enable their built-in AES encryption. We'll soon be supporting LUKS for qcow2, so need a more general purpose way to enable encryption, with a choice of formats.

[Qemu-devel] [PULL 076/100] qcow2: support .bdrv_reopen_bitmaps_rw

From: Vladimir Sementsov-Ogievskiy Realize bdrv_reopen_bitmaps_rw interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz Message-id:

[Qemu-devel] [PULL 066/100] tests: add hbitmap iter test

From: Vladimir Sementsov-Ogievskiy Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by:

[Qemu-devel] [PULL 086/100] qmp: add autoload parameter to block-dirty-bitmap-add

From: Vladimir Sementsov-Ogievskiy Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [PULL 098/100] iotests: Use absolute paths for executables

From: Max Reitz A user may specify a relative path for accessing qemu, qemu-img, etc. through environment variables ($QEMU_PROG and friends) or a symlink. If a test decides to change its working directory, relative paths will cease to work, however. Work around this by making

[Qemu-devel] [PULL 077/100] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

From: Vladimir Sementsov-Ogievskiy Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id:

Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver

On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote: > diff --git a/block/nvme-vfio.c b/block/nvme-vfio.c > new file mode 100644 > index 000..f030a82 > --- /dev/null > +++ b/block/nvme-vfio.c > @@ -0,0 +1,703 @@ > +/* > + * NVMe VFIO interface As far as I can tell nothing in this file

[Qemu-devel] [PULL 089/100] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

From: Vladimir Sementsov-Ogievskiy Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow Message-id:

Re: [Qemu-devel] [PATCH v12 04/27] target: [tcg] Add generic translation framework

On 07/07/2017 01:56 AM, Lluís Vilanova wrote: +void translator_loop(const TranslatorOps *ops, DisasContextBase *db, + CPUState *cpu, TranslationBlock *tb) +{ +int max_insns; + +/* Initialize DisasContext */ +db->tb = tb; +db->pc_first = tb->pc; +

[Qemu-devel] [PATCH] MAINTAINERS: Promote NBD to supported, with new maintainer

We are promising more than just odd fixes, and Paolo is hoping to offload the pull requests to me. Also, enough of NBD is related to the block layer that it is worth including qemu-block on patches. Signed-off-by: Eric Blake --- If there are no objections, I'll include this

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On Fri, Jul 07, 2017 at 08:18:20PM +0200, Igor Mammedov wrote: > On Fri, 7 Jul 2017 12:09:56 -0300 > Eduardo Habkost wrote: > > > On Fri, Jul 07, 2017 at 04:58:17PM +0200, Igor Mammedov wrote: > > > On Fri, 7 Jul 2017 10:13:00 -0300 > > > "Eduardo Habkost"

Re: [Qemu-devel] [PATCH v3 03/10] nbd/server: use errp instead of LOG

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Move to modern errp scheme from just LOGging errors. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 266 > +++ > 1 file

Re: [Qemu-devel] [PATCH v3 06/10] nbd/client: refactor TRACE of NBD_MAGIC

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > We are going to switch from TRACE macro to trace points, > this TRACE complicates things, this patch simplifies it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 11 ++- > 1

Re: [Qemu-devel] [PATCH] hxtool: remove dead -q option

On 07/07/2017 10:46 AM, Paolo Bonzini wrote: > This was used to extract .txt documentation for QMP. This was > changed to use the QAPI schema instead, so zap it. > > Signed-off-by: Paolo Bonzini > --- > scripts/hxtool | 46 +- >

[Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

Previously DISAS_JUMP did ensure this but with the optimisation of 8a6b28c7 (optimize indirect branches) we might not leave the loop. This means if any pending interrupts are cleared by changing IRQ flags we might never get around to servicing them. You usually notice this by seeing the

Re: [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands

Hi Guys, Thank you for the feedback! Unfortunately, I am almost off for vacation and will not be able to provide next patch in the following couple of weeks. Nevertheless, will do so as soon as I return back. I still have a question whether we need to provide NUMA information here? >From my

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On 07/07/17 16:07, Eduardo Habkost wrote: >> looks fine, >> >> so what I'd do is: >> * drop 4/6 Yes. > Agreed on this point. But: > >> * make fw_cfg_find() use ambiguous argument and error_abort if ambiguous == >> true During my latest tests I've found that everything works fine without

[Qemu-devel] [PULL 007/100] vvfat: fix typos

From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- block/vvfat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index e83b8ba..07a111f

[Qemu-devel] [PULL 006/100] vvfat: replace tabs by 8 spaces

From: Hervé Poussineau This was a complete mess. On 2299 indented lines: - 1329 were with spaces only - 617 with tabulations only - 353 with spaces and tabulations Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 026/100] commit: Switch commit_run() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the internal loop iteration of committing to track by bytes instead of sectors (although we are still guaranteed that we iterate by steps that

[Qemu-devel] [PULL 055/100] iotests: enable tests 134 and 158 to work with qcow (v1)

From: "Daniel P. Berrange" The 138 and 158 iotests exercise the legacy qcow2 aes encryption code path and they work fine with qcow v1 too. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL 072/100] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

From: Vladimir Sementsov-Ogievskiy It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only. Signed-off-by: Vladimir

[Qemu-devel] [PULL 085/100] qmp: add persistent flag to block-dirty-bitmap-add

From: Vladimir Sementsov-Ogievskiy Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz

[Qemu-devel] [PULL 060/100] docs: document encryption options for qcow, qcow2 and luks

From: "Daniel P. Berrange" Expand the image format docs to cover the new options for the qcow, qcow2 and luks disk image formats Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL 083/100] block: add bdrv_can_store_new_dirty_bitmap

From: Vladimir Sementsov-Ogievskiy This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 075/100] block: new bdrv_reopen_bitmaps_rw interface

From: Vladimir Sementsov-Ogievskiy Add format driver handler, which should mark loaded read-only bitmaps as 'IN_USE' in the image and unset read_only field in corresponding BdrvDirtyBitmap's. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 096/100] iotests: add more LUKS hash combination tests

From: "Daniel P. Berrange" Add tests for sha224, sha512, sha384 and ripemd160 hash algorithms. Reviewed-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange Message-id:

[Qemu-devel] [PULL 088/100] iotests: test qcow2 persistent dirty bitmap

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20170628120530.31251-27-vsement...@virtuozzo.com Signed-off-by: Max Reitz ---

Re: [Qemu-devel] [RFC 00/29] postcopy+vhost-user/shared ram

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Jul 07, 2017 at 01:01:56PM +0100, Dr. David Alan Gilbert wrote: > > > >Take care of deadlocking; any thread in the client that > > > >accesses a userfault protected page can stall. > > > > > > And it can happen under a lock quite

Re: [Qemu-devel] [PATCH v11 23/29] target/arm: [tcg] Port to translate_insn

On 07/07/2017 07:18 AM, Lluís Vilanova wrote: There was no code being generated after this specific case, but I haven't checked if DISAS_EXC is set in any other place that is not immediately followed by a "goto done_generating". Typically we haven't actually done a goto, but simply exit the

[Qemu-devel] [PULL 093/100] iotests: skip 159 & 170 with luks format

From: "Daniel P. Berrange" While the qemu-img dd command does accept --image-opts this is not sufficient to make it work with the LUKS image yet. This is because bdrv_create() still always requires the non-image-opts syntax. Thus we must skip 159/170 with luks for now

[Qemu-devel] [PULL 0/3] please pull xen-20170707-tag

/xen-20170707-tag for you to fetch changes up to 4daf62594d13dfca2ce3a74dd3bddee5f54d7127: xen/pt: Fixup addr validation in xen_pt_pci_config_access_check (2017-07-07 11:13:10 -0700) Xen 2017/07/07

Re: [Qemu-devel] [RFC 00/29] postcopy+vhost-user/shared ram

On Fri, Jul 07, 2017 at 01:01:56PM +0100, Dr. David Alan Gilbert wrote: > > >Take care of deadlocking; any thread in the client that > > >accesses a userfault protected page can stall. > > > > And it can happen under a lock quite easily. > > What exactly is proposed here? > > Maybe we

Re: [Qemu-devel] [PATCH v3 00/10] nbd refactoring part 2

On 07/07/2017 17:29, Vladimir Sementsov-Ogievskiy wrote: > This is last part of "nbd errors and traces refactoring". > > Patches 01-10 from "nbd errors and traces refactoring" are already merged. > Patches 11-13 from it are rejected - do not regret them. > So, these series is update of 14-19

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On 07/07/17 15:48, Eduardo Habkost wrote: >>> I don't see what needs to be fixed. It is not a bug to leave >>> fw_cfg in /machine/unattached, as long as fw_cfg_find() works >>> properly. >> >> Yeah. I wonder if I've been leading myself astray down the wrong path >> here? Let me do some more

Re: [Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery

On 07/06/2017 10:35 PM, John Paul Adrian Glaubitz wrote: On 07/07/2017 10:30 AM, John Paul Adrian Glaubitz wrote: The scripts which are run here can be found as /var/lib/dpkg/info/tzdata.{config,postinst). I don't know yet which command in particular triggers the crash. Interesting. It

[Qemu-devel] [PULL 014/100] vvfat: correctly generate numeric-tail of short file names

From: Hervé Poussineau More specifically: - try without numeric-tail only if LFN didn't have invalid short chars - start at ~1 (instead of ~0) - handle case if numeric tail is more than one char (ie > 10) Windows 9x Scandisk doesn't see anymore mismatches between short

[Qemu-devel] [PULL 005/100] vvfat: fix qemu-img map and qemu-img convert

From: Hervé Poussineau - bs->total_sectors is the number of sectors of the whole disk - s->sector_count is the number of sectors of the FAT partition This fixes the following assert in qemu-img map: qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed. This

[Qemu-devel] [PULL 029/100] mirror: Update signature of mirror_clip_sectors()

From: Eric Blake Rather than having a void function that modifies its input in-place as the output, change the signature to reduce a layer of indirection and return the result. Suggested-by: John Snow Signed-off-by: Eric Blake

[Qemu-devel] [PULL 036/100] backup: Switch backup_do_cow() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change). Signed-off-by: Eric Blake Reviewed-by: John Snow

[Qemu-devel] [PULL 044/100] qcow: require image size to be > 1 for new images

From: "Daniel P. Berrange" The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia

[Qemu-devel] [PULL 048/100] qcow: make encrypt_sectors encrypt in place

From: "Daniel P. Berrange" Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller uses the same buffer for input/output already and the other two callers are

[Qemu-devel] [PULL 056/100] block: rip out all traces of password prompting

From: "Daniel P. Berrange" Now that qcow & qcow2 are wired up to get encryption keys via the QCryptoSecret object, nothing is relying on the interactive prompting for passwords. All the code related to password prompting can thus be ripped out. Reviewed-by: Alberto Garcia

[Qemu-devel] [PULL 081/100] qcow2: add persistent dirty bitmaps support

From: Vladimir Sementsov-Ogievskiy Store persistent dirty bitmaps in qcow2 image. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20170628120530.31251-20-vsement...@virtuozzo.com

[Qemu-devel] [PULL 099/100] iotests: Add test for colon handling

From: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Max Reitz Message-id: 20170702150510.23276-3-mre...@redhat.com Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 105

[Qemu-devel] [PULL 070/100] qcow2: add bitmaps extension

From: Vladimir Sementsov-Ogievskiy Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. Also, calculate refcounts for qcow2 bitmaps, to not break qemu-img check. For now, disable image

[Qemu-devel] [PULL 097/100] iotests: chown LUKS device before qemu-io launches

From: "Daniel P. Berrange" On some distros, whenever you close a block device file descriptor there is a udev rule that resets the file permissions. This can race with the test script when we run qemu-io multiple times against the same block device. Occasionally the second

[Qemu-devel] [PULL 2/3] xen-platform: Cleanup network infrastructure when emulated NICs are unplugged

From: Ross Lagerwall When the guest unplugs the emulated NICs, cleanup the peer for each NIC as it is not needed anymore. Most importantly, this allows the tap interfaces which QEMU holds open to be closed and removed. Signed-off-by: Ross Lagerwall

[Qemu-devel] [PULL 3/3] xen/pt: Fixup addr validation in xen_pt_pci_config_access_check

From: Anoob Soman xen_pt_pci_config_access_check checks if addr >= 0xFF. 0xFF is a valid address and should not be ignored. Signed-off-by: Anoob Soman Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] Fwd: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery

On 07/07/2017 07:57 AM, Richard Henderson wrote: +/* ??? The SH4 kernel checks for and address above 0xC000. + However, the page mappings in qemu linux-user aren't as restricted + and we wind up with the normal stack mapped above 0xF000. + That said, there is no

[Qemu-devel] [PATCH v3 03/10] nbd/server: use errp instead of LOG

Move to modern errp scheme from just LOGging errors. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 266 +++ 1 file changed, 160 insertions(+), 106 deletions(-) diff --git a/nbd/server.c

[Qemu-devel] [PATCH v3 05/10] nbd/common: nbd_tls_handshake: remove extra TRACE

Error is propagated to the caller, TRACE is not needed. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- nbd/common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/nbd/common.c b/nbd/common.c index

Re: [Qemu-devel] [PATCH v3 08/10] nbd/server: rename clientflags var in nbd_negotiate_options

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename 'clientflags' to just 'option'. This variable has nothing to do > with flags, but is a single integer representing the option requested > by the client. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 00/10] nbd refactoring part 2

On 07/07/2017 11:06 AM, Paolo Bonzini wrote: > > > On 07/07/2017 17:29, Vladimir Sementsov-Ogievskiy wrote: >> This is last part of "nbd errors and traces refactoring". >> >> Patches 01-10 from "nbd errors and traces refactoring" are already merged. >> Patches 11-13 from it are rejected - do not

Re: [Qemu-devel] [PATCH v2] vhost-user: support cross-endianess negatiation

ping. :) F. > On 14 Jun 2017, at 18:44, Felipe Franciosi wrote: > > Currently, vhost-user does not implement any means for notifying the > backend about guest endianess. This commit introduces a new message > called VHOST_USER_SET_VRING_ENDIAN which is analogous to the

[Qemu-devel] [PULL 002/100] block: Guarantee that *file is set on bdrv_get_block_status()

From: Eric Blake We document that *file is valid if the return is not an error and includes BDRV_BLOCK_OFFSET_VALID, but forgot to obey this contract when a driver (such as blkdebug) lacks a callback. Messed up in commit 67a0fd2 (v2.6), when we added the file parameter.

[Qemu-devel] [PULL 008/100] vvfat: rename useless enumeration values

From: Hervé Poussineau MODE_FAKED and MODE_RENAMED are not and were never used. Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- block/vvfat.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PULL 017/100] vvfat: change OEM name to 'MSWIN4.1'

From: Hervé Poussineau According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some FAT drivers

[Qemu-devel] [PULL 023/100] stream: Drop reached_end for stream_complete()

From: Eric Blake stream_complete() skips the work of rewriting the backing file if the job was cancelled, if data->reached_end is false, or if there was an error detected (non-zero data->ret) during the streaming. But note that in stream_run(), data->reached_end is only set if

[Qemu-devel] [PULL 042/100] block: add ability to set a prefix for opt names

From: "Daniel P. Berrange" When integrating the crypto support with qcow/qcow2, we don't want to use the bare LUKS option names "hash-alg", "key-secret", etc. We need to namespace them to match the nested QAPI schema. e.g. "encrypt.hash-alg", "encrypt.key-secret" so that

[Qemu-devel] [PULL 030/100] mirror: Switch mirror_cow_align() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change), and add mirror_clip_bytes() as a counterpart to mirror_clip_sectors(). Some of the conversion

[Qemu-devel] [PULL 049/100] qcow: convert QCow to use QCryptoBlock for encryption

From: "Daniel P. Berrange" This converts the qcow driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead.

Re: [Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages

On Fri, Jul 7, 2017 at 5:59 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> Add warn_report(), warn_vreport() for reporting warnings, and >> info_report(), info_vreport() for informational messages. >> >> These are implemented them

[Qemu-devel] [PULL 065/100] hbitmap: improve dirty iter

From: Vladimir Sementsov-Ogievskiy Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow

[Qemu-devel] [PULL 087/100] qmp: add x-debug-block-dirty-bitmap-sha256

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20170628120530.31251-26-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- block/dirty-bitmap.c | 5 + blockdev.c

[Qemu-devel] [PULL 092/100] block: release persistent bitmaps on inactivate

From: Vladimir Sementsov-Ogievskiy We should release them here to reload on invalidate cache. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20170628120530.31251-31-vsement...@virtuozzo.com

Re: [Qemu-devel] change x86 default machine type to Q35?

On Fri, Jul 07, 2017 at 06:17:57PM +0300, Michael S. Tsirkin wrote: > On Fri, Jul 07, 2017 at 10:39:49AM -0300, Eduardo Habkost wrote: > > On Wed, Jul 05, 2017 at 12:32:10PM +0300, Marcel Apfelbaum wrote: > > > On 05/07/2017 11:14, Thomas Huth wrote: > > > > Hi, > > > > > > > > > > Hi, > > >

[Qemu-devel] Fwd: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery

Bah. Should have gone to the list as well. r~ -- Forwarded message -- From: Richard Henderson Date: Fri, Jul 7, 2017 at 6:38 AM Subject: [PATCH v2.5] fixup! linux-user/sh4: Notice gUSA regions during signal delivery To: glaub...@physik.fu-berlin.de Cc:

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

On Fri, 7 Jul 2017 12:09:56 -0300 Eduardo Habkost wrote: > On Fri, Jul 07, 2017 at 04:58:17PM +0200, Igor Mammedov wrote: > > On Fri, 7 Jul 2017 10:13:00 -0300 > > "Eduardo Habkost" wrote: > [...] > > > I don't disagree with adding the assert(), but it

Re: [Qemu-devel] [PATCH v3 02/10] nbd/server: refactor nbd_negotiate

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Combine two successive "if (oldStyle) {...} else {...}" into one. > > Block "if (client->tlscreds)" under "if (oldStyle)" is unreachable, > as we have "oldStyle = client->exp != NULL && !client->tlscreds;". > So, delete this block. >

[Qemu-devel] [PULL 003/100] block: Simplify use of BDRV_BLOCK_RAW

From: Eric Blake The lone caller that cares about a return of BDRV_BLOCK_RAW (namely, io.c:bdrv_co_get_block_status) completely replaces the return value, so there is no point in passing BDRV_BLOCK_DATA. Signed-off-by: Eric Blake Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 001/100] qemu-io: Don't die on second open

From: Eric Blake Most callback commands in qemu-io return 0 to keep the interpreter loop running, or 1 to quit immediately. However, open_f() just passed through the return value of openfile(), which has different semantics of returning 0 if a file was opened, or 1 on any

[Qemu-devel] [PULL 012/100] vvfat: correctly create long names for non-ASCII filenames

From: Hervé Poussineau Assume that input filename is encoded as UTF-8, so correctly create UTF-16 encoding. Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- block/vvfat.c | 38 ++

[Qemu-devel] [PULL 000/100] Block layer patches

The following changes since commit b11365867568ba954de667a0bfe0945b8f78d6bd: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20170706' into staging (2017-07-06 11:42:59 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-devel] [PULL 016/100] vvfat: handle KANJI lead byte 0xe5

From: Hervé Poussineau Specification: "FAT: General overview of on-disk format" v1.03, page 23 Signed-off-by: Hervé Poussineau Signed-off-by: Kevin Wolf --- block/vvfat.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[Qemu-devel] [PULL 028/100] mirror: Switch mirror_do_zero_or_discard() to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change). Signed-off-by: Eric Blake Reviewed-by: John Snow

[Qemu-devel] [PULL 034/100] backup: Switch BackupBlockJob to byte-based

From: Eric Blake We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Continue by converting an internal structure (no semantic change), and all references to tracking progress. Drop a redundant local variable

[Qemu-devel] [PULL 062/100] mirror: Fix inconsistent backing AioContext for after mirroring

From: "sochin.jiang" mirror_complete opens the backing chain, which should have the same AioContext as the top when using iothreads. Make the code guarantee this, which fixes a failed assertion in bdrv_attach_child. Signed-off-by: sochin.jiang

[Qemu-devel] [PULL 040/100] block: Make bdrv_is_allocated_above() byte-based

From: Eric Blake We are gradually moving away from sector-based interfaces, towards byte-based. In the common case, allocation is unlikely to ever use values that are not naturally sector-aligned, but it is possible that byte-based values will let us be more precise about

[Qemu-devel] [PULL 043/100] qcow: document another weakness of qcow AES encryption

From: "Daniel P. Berrange" Document that use of guest virtual sector numbers as the basis for the initialization vectors is a potential weakness, when combined with internal snapshots or multiple images using the same passphrase. This fixes the formatting of the itemized

[Qemu-devel] [PULL 063/100] specs/qcow2: fix bitmap granularity qemu-specific note

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20170628120530.31251-2-vsement...@virtuozzo.com Signed-off-by: Max Reitz ---

[Qemu-devel] [PULL 078/100] block: bdrv_close: release bitmaps after drv->bdrv_close

From: Vladimir Sementsov-Ogievskiy Release bitmaps after 'if (bs->drv) { ... }' block. This will allow format driver to save persistent bitmaps, which will appear in following commits. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

[Qemu-devel] [PULL 064/100] specs/qcow2: do not use wording 'bitmap header'

From: Vladimir Sementsov-Ogievskiy A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension'

[Qemu-devel] [PULL 090/100] qcow2: add .bdrv_remove_persistent_dirty_bitmap

From: Vladimir Sementsov-Ogievskiy Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow Message-id:

[Qemu-devel] [PULL 095/100] iotests: reduce PBKDF iterations when testing LUKS

From: "Daniel P. Berrange" By default the PBKDF algorithm used with LUKS is tuned based on the number of iterations to produce 1 second of running time. This makes running the I/O test with the LUKS format orders of magnitude slower than with qcow2/raw formats. When

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

On Fri, Jul 7, 2017 at 5:06 AM, Eduardo Habkost wrote: > On Thu, Jul 06, 2017 at 04:49:44PM -0700, Alistair Francis wrote: >> Convert all uses of error_report("[Ww]arning:"... to use warn_report() >> instead. This helps standardise on a single method of printing warnings >>

Re: [Qemu-devel] [RFC PATCH] target/arm: ensure eret exits the run-loop

On 07/07/2017 08:29 AM, Alex Bennée wrote: Naming all of these different exit conditions is certainly non-trivial. Given the variation of usage this is something that should probably be done after Lluís common run loop goes in and we can beef up the semantics of the various exit conditions.

[Qemu-devel] [PATCH v3 00/10] nbd refactoring part 2

This is last part of "nbd errors and traces refactoring". Patches 01-10 from "nbd errors and traces refactoring" are already merged. Patches 11-13 from it are rejected - do not regret them. So, these series is update of 14-19 patches from "nbd errors and traces refactoring" v3: 01: reword commit

[Qemu-devel] [PATCH v3 04/10] nbd/server: add errp to nbd_send_reply()

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- nbd/server.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 00a7c606ae..e3fd0ca8fe 100644 ---

  1   2   3   4   5   >